[GitHub] [arrow] ursabot edited a comment on pull request #12051: MINOR: [CI] Fix AppVeyor setup failure

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12051: URL: https://github.com/apache/arrow/pull/12051#issuecomment-1002689878 Benchmark runs are scheduled for baseline = d69957dee479c5521afe6d51ec873bde8d7b6836 and contender = bf7636e1cbd35fdf4c638776366e113cf82f9081. bf7636e1cbd35fdf4c6387763

[GitHub] [arrow] ursabot edited a comment on pull request #12025: ARROW-15190: [C++] Upgrade bundled zstd version

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12025: URL: https://github.com/apache/arrow/pull/12025#issuecomment-1002769153 Benchmark runs are scheduled for baseline = 5aa3f4b8fc280a58e54aad32a3ac3b6a10b5cd05 and contender = ab9528e7e822454147969459bdf73718bfa89002. ab9528e7e822454147969459b

[GitHub] [arrow] bkmgit commented on a change in pull request #11882: ARROW-9843: [C++] Implement Between ternary kernel

2021-12-29 Thread GitBox
bkmgit commented on a change in pull request #11882: URL: https://github.com/apache/arrow/pull/11882#discussion_r776589669 ## File path: cpp/src/arrow/compute/kernels/scalar_compare.cc ## @@ -68,6 +72,50 @@ struct GreaterEqual { } }; +struct BetweenLessEqualLessEqual { +

[GitHub] [arrow] edponce commented on a change in pull request #12041: ARROW-15203: [GLib] garrow_struct_scalar_get_value() for scalar from C++ returns value

2021-12-29 Thread GitBox
edponce commented on a change in pull request #12041: URL: https://github.com/apache/arrow/pull/12041#discussion_r776588154 ## File path: c_glib/arrow-glib/scalar.cpp ## @@ -2039,6 +2039,16 @@ GList * garrow_struct_scalar_get_value(GArrowStructScalar *scalar) { auto priv =

[GitHub] [arrow] ursabot edited a comment on pull request #12036: ARROW-15194: [C++] Combine ChunkedArray constructors

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12036: URL: https://github.com/apache/arrow/pull/12036#issuecomment-1002733642 Benchmark runs are scheduled for baseline = f5ab8833867cb456190d656300cbbb2f7724563e and contender = 5aa3f4b8fc280a58e54aad32a3ac3b6a10b5cd05. 5aa3f4b8fc280a58e54aad32a

[GitHub] [arrow] ursabot edited a comment on pull request #12050: MINOR: [Archery] Fix Travis-CI build URL template

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12050: URL: https://github.com/apache/arrow/pull/12050#issuecomment-1002685566 Benchmark runs are scheduled for baseline = 4219acc7cdbad9384a03357cdafadad9b5880ec4 and contender = d69957dee479c5521afe6d51ec873bde8d7b6836. d69957dee479c5521afe6d51e

[GitHub] [arrow] ursabot edited a comment on pull request #12001: ARROW-15136: [C++] Make S3FS tests faster

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12001: URL: https://github.com/apache/arrow/pull/12001#issuecomment-1002733635 Benchmark runs are scheduled for baseline = bf7636e1cbd35fdf4c638776366e113cf82f9081 and contender = f5ab8833867cb456190d656300cbbb2f7724563e. f5ab8833867cb456190d65630

[GitHub] [arrow] ursabot edited a comment on pull request #12034: MINOR: [Docs] Indicate that Parquet encoding BIT_PACKED cannot be used for values

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12034: URL: https://github.com/apache/arrow/pull/12034#issuecomment-1002681291 Benchmark runs are scheduled for baseline = 7890a1d19cd7eb03f6c86b68fdae674a08a534e1 and contender = 4219acc7cdbad9384a03357cdafadad9b5880ec4. 4219acc7cdbad9384a03357cd

[GitHub] [arrow-rs] codecov-commenter edited a comment on pull request #1104: fix bug: error type for BufferBuilder

2021-12-29 Thread GitBox
codecov-commenter edited a comment on pull request #1104: URL: https://github.com/apache/arrow-rs/pull/1104#issuecomment-1002621673 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1104?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm

[GitHub] [arrow] ursabot edited a comment on pull request #12051: MINOR: [CI] Fix AppVeyor setup failure

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12051: URL: https://github.com/apache/arrow/pull/12051#issuecomment-1002689878 Benchmark runs are scheduled for baseline = d69957dee479c5521afe6d51ec873bde8d7b6836 and contender = bf7636e1cbd35fdf4c638776366e113cf82f9081. bf7636e1cbd35fdf4c6387763

[GitHub] [arrow] cyb70289 commented on pull request #11864: ARROW-12404: [C++] Implement "random" nullary function that generates uniform random between 0 and 1

2021-12-29 Thread GitBox
cyb70289 commented on pull request #11864: URL: https://github.com/apache/arrow/pull/11864#issuecomment-1002836713 @pitrou, do you have other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] edponce commented on issue #12045: How to use arrow-cpp-compute for less filtering of decimal128

2021-12-29 Thread GitBox
edponce commented on issue #12045: URL: https://github.com/apache/arrow/issues/12045#issuecomment-1002831331 Hi @limstorm! Please expand a bit on the context for the filtering operation you are interested in. Are you referring to "less than" for `DecimalXXXType`? -- This is an automated

[GitHub] [arrow] ursabot edited a comment on pull request #12023: ARROW-15189: [C++] Upgrade bundled utf8proc version

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12023: URL: https://github.com/apache/arrow/pull/12023#issuecomment-1002672533 Benchmark runs are scheduled for baseline = 11040609fc4f6c1e7a2cdbfc8279598a7afccb68 and contender = 7890a1d19cd7eb03f6c86b68fdae674a08a534e1. 7890a1d19cd7eb03f6c86b68f

[GitHub] [arrow] ursabot edited a comment on pull request #12050: MINOR: [Archery] Fix Travis-CI build URL template

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12050: URL: https://github.com/apache/arrow/pull/12050#issuecomment-1002685566 Benchmark runs are scheduled for baseline = 4219acc7cdbad9384a03357cdafadad9b5880ec4 and contender = d69957dee479c5521afe6d51ec873bde8d7b6836. d69957dee479c5521afe6d51e

[GitHub] [arrow] edponce commented on pull request #12043: ARROW-15204: [GLib] Add Arrow::RoundOptions

2021-12-29 Thread GitBox
edponce commented on pull request #12043: URL: https://github.com/apache/arrow/pull/12043#issuecomment-1002816829 @kou I assigned ARROW-15216 to you for the `RoundToMultipleOptions` PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [arrow] edponce commented on a change in pull request #12043: ARROW-15204: [GLib] Add Arrow::RoundOptions

2021-12-29 Thread GitBox
edponce commented on a change in pull request #12043: URL: https://github.com/apache/arrow/pull/12043#discussion_r776527644 ## File path: c_glib/arrow-glib/compute.cpp ## @@ -2902,6 +2902,133 @@ garrow_variance_options_new(void) } +enum { + PROP_ROUND_OPTIONS_N_DIGITS = 1

[GitHub] [arrow-datafusion] brianrackle commented on issue #1458: Registering IPC Source into ExecutionContext or Loading Into DataFrame

2021-12-29 Thread GitBox
brianrackle commented on issue #1458: URL: https://github.com/apache/arrow-datafusion/issues/1458#issuecomment-1002811625 Doing this through MemTable but would like to figure out how to stream from the file since the way I understand is supposed to be one benefit of arrow files over parqu

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1110: Parquet fuzz tests (#1053)

2021-12-29 Thread GitBox
codecov-commenter commented on pull request #1110: URL: https://github.com/apache/arrow-rs/pull/1110#issuecomment-1002803268 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1110?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1082: Optimized ByteArrayReader (#1040)

2021-12-29 Thread GitBox
tustvold commented on a change in pull request #1082: URL: https://github.com/apache/arrow-rs/pull/1082#discussion_r776516142 ## File path: parquet/src/arrow/array_reader.rs ## @@ -1663,69 +1699,58 @@ impl<'a> ArrayReaderBuilder { arrow_type,

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1110: Parquet fuzz tests (#1053)

2021-12-29 Thread GitBox
tustvold commented on a change in pull request #1110: URL: https://github.com/apache/arrow-rs/pull/1110#discussion_r776514988 ## File path: parquet/src/arrow/arrow_reader.rs ## @@ -440,14 +477,16 @@ mod tests { /// Number of row group to write to parquet (row group siz

[GitHub] [arrow] asuhan commented on pull request #11864: ARROW-12404: [C++] Implement "random" nullary function that generates uniform random between 0 and 1

2021-12-29 Thread GitBox
asuhan commented on pull request #11864: URL: https://github.com/apache/arrow/pull/11864#issuecomment-1002800675 Any additional feedback on this? I think I've addressed all comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [arrow] ursabot edited a comment on pull request #12034: MINOR: [Docs] Indicate that Parquet encoding BIT_PACKED cannot be used for values

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12034: URL: https://github.com/apache/arrow/pull/12034#issuecomment-1002681291 Benchmark runs are scheduled for baseline = 7890a1d19cd7eb03f6c86b68fdae674a08a534e1 and contender = 4219acc7cdbad9384a03357cdafadad9b5880ec4. 4219acc7cdbad9384a03357cd

[GitHub] [arrow-datafusion] tustvold commented on issue #1441: Incorrect results in datafusion

2021-12-29 Thread GitBox
tustvold commented on issue #1441: URL: https://github.com/apache/arrow-datafusion/issues/1441#issuecomment-1002798788 FYI https://github.com/apache/arrow-rs/pull/1110 runs into a similar issue, that appears to be fixed by switching to ComplexObjectArrayReader instead of ArrowArrayReader.

[GitHub] [arrow-rs] tustvold opened a new pull request #1110: Parquet fuzz tests (#1053)

2021-12-29 Thread GitBox
tustvold opened a new pull request #1110: URL: https://github.com/apache/arrow-rs/pull/1110 # Which issue does this PR close? Closes #1053. # Rationale for this change See ticket # What changes are included in this PR? This extends the parquet fuzz tests t

[GitHub] [arrow] ursabot edited a comment on pull request #12012: ARROW-15116: [Python] Expose invalid_row_handler for CSV reader

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12012: URL: https://github.com/apache/arrow/pull/12012#issuecomment-1002672524 Benchmark runs are scheduled for baseline = e46b0af6ec62c97dc8aa98d7d5b8468b37269198 and contender = 11040609fc4f6c1e7a2cdbfc8279598a7afccb68. 11040609fc4f6c1e7a2cdbfc8

[GitHub] [arrow] kou commented on a change in pull request #12043: ARROW-15204: [GLib] Add Arrow::RoundOptions

2021-12-29 Thread GitBox
kou commented on a change in pull request #12043: URL: https://github.com/apache/arrow/pull/12043#discussion_r776499329 ## File path: c_glib/arrow-glib/compute.cpp ## @@ -2902,6 +2902,133 @@ garrow_variance_options_new(void) } +enum { + PROP_ROUND_OPTIONS_N_DIGITS = 1, +

[GitHub] [arrow-rs] yordan-pavlov commented on a change in pull request #1082: Optimized ByteArrayReader (#1040)

2021-12-29 Thread GitBox
yordan-pavlov commented on a change in pull request #1082: URL: https://github.com/apache/arrow-rs/pull/1082#discussion_r776499818 ## File path: parquet/src/arrow/array_reader.rs ## @@ -1663,69 +1699,58 @@ impl<'a> ArrayReaderBuilder { arrow_type,

[GitHub] [arrow] tachyonwill commented on a change in pull request #11984: PARQUET-2109: [C++] Check if Parquet page has too few values

2021-12-29 Thread GitBox
tachyonwill commented on a change in pull request #11984: URL: https://github.com/apache/arrow/pull/11984#discussion_r776498284 ## File path: cpp/src/parquet/column_reader.cc ## @@ -940,7 +940,7 @@ int64_t TypedColumnReaderImpl::ReadBatchWithDictionary( int64_t* indices_r

[GitHub] [arrow] wjones127 commented on pull request #12044: ARROW-13294: [C#] Create Flight example server and client

2021-12-29 Thread GitBox
wjones127 commented on pull request #12044: URL: https://github.com/apache/arrow/pull/12044#issuecomment-1002779852 @eerhardt @HashidaTKS Interested in reviewing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [arrow] edponce commented on pull request #10296: ARROW-12724: [C++] Add documentation for authoring compute kernels

2021-12-29 Thread GitBox
edponce commented on pull request #10296: URL: https://github.com/apache/arrow/pull/10296#issuecomment-1002779187 @bkmgit Thanks for your reviews! I will get back to this PR and resolve them. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [arrow] edponce commented on a change in pull request #11882: ARROW-9843: [C++] Implement Between ternary kernel

2021-12-29 Thread GitBox
edponce commented on a change in pull request #11882: URL: https://github.com/apache/arrow/pull/11882#discussion_r776495341 ## File path: cpp/src/arrow/compute/kernels/scalar_compare.cc ## @@ -68,6 +72,50 @@ struct GreaterEqual { } }; +struct BetweenLessEqualLessEqual { +

[GitHub] [arrow] edponce commented on a change in pull request #11882: ARROW-9843: [C++] Implement Between ternary kernel

2021-12-29 Thread GitBox
edponce commented on a change in pull request #11882: URL: https://github.com/apache/arrow/pull/11882#discussion_r776495341 ## File path: cpp/src/arrow/compute/kernels/scalar_compare.cc ## @@ -68,6 +72,50 @@ struct GreaterEqual { } }; +struct BetweenLessEqualLessEqual { +

[GitHub] [arrow] wjones127 commented on a change in pull request #12044: ARROW-13294: [C#] Create Flight example server and client

2021-12-29 Thread GitBox
wjones127 commented on a change in pull request #12044: URL: https://github.com/apache/arrow/pull/12044#discussion_r776494470 ## File path: csharp/src/Apache.Arrow.Flight/Server/FlightServer.cs ## @@ -48,9 +48,10 @@ public virtual Task DoAction(FlightAction request, IAsyncStre

[GitHub] [arrow] wjones127 commented on pull request #12044: ARROW-13294: [C#] Create Flight example server and client

2021-12-29 Thread GitBox
wjones127 commented on pull request #12044: URL: https://github.com/apache/arrow/pull/12044#issuecomment-1002776665 > > Just a thought - but recently some of the other subprojects have been adding examples to a [cookbook](https://github.com/apache/arrow-cookbook/), would it make sense to s

[GitHub] [arrow-julia] kou commented on pull request #274: Send issue comments notification to github@arrow.apache.org

2021-12-29 Thread GitBox
kou commented on pull request #274: URL: https://github.com/apache/arrow-julia/pull/274#issuecomment-1002776199 "close issue" notifications are still sent to `iss...@arrow.apache.org` but it will be acceptable... Should we discuss this on `d...@arrow.apache.org`? -- This is an automat

[GitHub] [arrow] edponce commented on a change in pull request #11886: ARROW-13035: [C++] indices_nonzero compute function

2021-12-29 Thread GitBox
edponce commented on a change in pull request #11886: URL: https://github.com/apache/arrow/pull/11886#discussion_r776493536 ## File path: cpp/src/arrow/compute/kernels/vector_selection.cc ## @@ -2355,6 +2358,76 @@ const FunctionDoc array_take_doc( "given by `indices`. Nu

[GitHub] [arrow-julia] kou opened a new pull request #274: Send issue comments notification to github@arrow.apache.org

2021-12-29 Thread GitBox
kou opened a new pull request #274: URL: https://github.com/apache/arrow-julia/pull/274 #271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github

[GitHub] [arrow-datafusion] matthewmturner opened a new issue #1507: Python bindings create duplicated qualified fields after joining

2021-12-29 Thread GitBox
matthewmturner opened a new issue #1507: URL: https://github.com/apache/arrow-datafusion/issues/1507 **Describe the bug** im working on getting datafusion added to db-benchmark (#147). while putting the benchmarks together i came across an error while doing the join benchmark that i wa

[GitHub] [arrow-julia] kou commented on pull request #272: Configure repository metadata

2021-12-29 Thread GitBox
kou commented on pull request #272: URL: https://github.com/apache/arrow-julia/pull/272#issuecomment-1002772844 Ah, we can't test "Automatically delete head branches" feature with this pull request because I created a branch for this pull request on my fork. -- This is an automated messa

[GitHub] [arrow] ursabot edited a comment on pull request #12023: ARROW-15189: [C++] Upgrade bundled utf8proc version

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12023: URL: https://github.com/apache/arrow/pull/12023#issuecomment-1002672533 Benchmark runs are scheduled for baseline = 11040609fc4f6c1e7a2cdbfc8279598a7afccb68 and contender = 7890a1d19cd7eb03f6c86b68fdae674a08a534e1. 7890a1d19cd7eb03f6c86b68f

[GitHub] [arrow] ursabot edited a comment on pull request #12025: ARROW-15190: [C++] Upgrade bundled zstd version

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12025: URL: https://github.com/apache/arrow/pull/12025#issuecomment-1002769153 Benchmark runs are scheduled for baseline = 5aa3f4b8fc280a58e54aad32a3ac3b6a10b5cd05 and contender = ab9528e7e822454147969459bdf73718bfa89002. ab9528e7e822454147969459b

[GitHub] [arrow] edponce commented on pull request #12004: ARROW-13185: [MATLAB] Create a single MEX gateway function which delegates to specific C++ functions

2021-12-29 Thread GitBox
edponce commented on pull request #12004: URL: https://github.com/apache/arrow/pull/12004#issuecomment-1002771191 Simply out of curiousity, `mexfcn` does not supports C++ functions that take `FunctionOptions` in addition to the function arguments? -- This is an automated message from the

[GitHub] [arrow] ursabot commented on pull request #12025: ARROW-15190: [C++] Upgrade bundled zstd version

2021-12-29 Thread GitBox
ursabot commented on pull request #12025: URL: https://github.com/apache/arrow/pull/12025#issuecomment-1002769153 Benchmark runs are scheduled for baseline = 5aa3f4b8fc280a58e54aad32a3ac3b6a10b5cd05 and contender = ab9528e7e822454147969459bdf73718bfa89002. ab9528e7e822454147969459bdf73718

[GitHub] [arrow] edponce commented on pull request #12014: ARROW-10924: [C++] Validate temporal data in ValidateArrayFull

2021-12-29 Thread GitBox
edponce commented on pull request #12014: URL: https://github.com/apache/arrow/pull/12014#issuecomment-1002768779 @JabariBooker Thanks for working on this! I left some minor comments. Also, we are missing validation for the following temporal types: `Date32Type` and `TimestampType`. --

[GitHub] [arrow] edponce commented on a change in pull request #12014: ARROW-10924: [C++] Validate temporal data in ValidateArrayFull

2021-12-29 Thread GitBox
edponce commented on a change in pull request #12014: URL: https://github.com/apache/arrow/pull/12014#discussion_r776479002 ## File path: cpp/src/arrow/array/validate.cc ## @@ -166,6 +166,80 @@ struct ValidateArrayImpl { return Status::OK(); } + Status Visit(const Da

[GitHub] [arrow] kou closed pull request #12025: ARROW-15190: [C++] Upgrade bundled zstd version

2021-12-29 Thread GitBox
kou closed pull request #12025: URL: https://github.com/apache/arrow/pull/12025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow-datafusion] matthewmturner commented on issue #1493: Implement `power` function

2021-12-29 Thread GitBox
matthewmturner commented on issue #1493: URL: https://github.com/apache/arrow-datafusion/issues/1493#issuecomment-1002767204 ive started looking into this and i think it makes sense to add `power` / `power_scalar` compute kernels to arrow first then expose it in `physical_plan/expressions

[GitHub] [arrow-datafusion] james727 commented on issue #1323: implement `set_agg` aggregation function

2021-12-29 Thread GitBox
james727 commented on issue #1323: URL: https://github.com/apache/arrow-datafusion/issues/1323#issuecomment-1002762768 @Jimexist @liukun4515 is this still wanted? I was looking at this as a potential issue to start learning the codebase, it's unclear if someone's already working on it tho

[GitHub] [arrow-rs] tustvold opened a new issue #1109: Add native comparison kernel support for FixedSizeBinaryArray

2021-12-29 Thread GitBox
tustvold opened a new issue #1109: URL: https://github.com/apache/arrow-rs/issues/1109 Is your feature request related to a problem or challenge? Please describe what you are trying to do. Currently there is no support for comparing FixedSizeBinaryArray Describe the solution y

[GitHub] [arrow-rs] tustvold opened a new issue #1108: Add native comparison kernel support for BinaryArray

2021-12-29 Thread GitBox
tustvold opened a new issue #1108: URL: https://github.com/apache/arrow-rs/issues/1108 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Currently there is no support for comparing `BinaryArray` **Describe the solution yo

[GitHub] [arrow-rs] alamb commented on pull request #885: Update Union Array to add `UnionMode`, match latest Arrow Spec, and rename `new` -> `unsafe new_unchecked()`

2021-12-29 Thread GitBox
alamb commented on pull request #885: URL: https://github.com/apache/arrow-rs/pull/885#issuecomment-1002753930 @Jimexist @paddyhoran @nevi-me -- might one of you have time to review this PR? It revamps how UnionArray is supported to conform to the modern Arrow spec, and adds additional v

[GitHub] [arrow] pitrou commented on pull request #10450: ARROW-9947: [Python] High-level Python API for Parquet encryption of files.

2021-12-29 Thread GitBox
pitrou commented on pull request #10450: URL: https://github.com/apache/arrow/pull/10450#issuecomment-1002753669 Right, can we get a functional PyArrow even without encryption enabled? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] andersonm-ibm commented on pull request #10450: ARROW-9947: [Python] High-level Python API for Parquet encryption of files.

2021-12-29 Thread GitBox
andersonm-ibm commented on pull request #10450: URL: https://github.com/apache/arrow/pull/10450#issuecomment-1002753054 > @andersonm-ibm I don't get a linker error, however the tests fail with: > > ``` > =

[GitHub] [arrow-rs] alamb closed issue #1099: support decimal data type for MutableArrayData

2021-12-29 Thread GitBox
alamb closed issue #1099: URL: https://github.com/apache/arrow-rs/issues/1099 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

[GitHub] [arrow-rs] alamb merged pull request #1100: MutableArrayData support extend decimal data type

2021-12-29 Thread GitBox
alamb merged pull request #1100: URL: https://github.com/apache/arrow-rs/pull/1100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-rs] alamb commented on pull request #1097: Print the 'FixedSizeBinaryArray' like a normal 'BinaryArray'

2021-12-29 Thread GitBox
alamb commented on pull request #1097: URL: https://github.com/apache/arrow-rs/pull/1097#issuecomment-1002752673 Thanks again @GrandChaman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow-rs] alamb closed issue #1096: Pretty printing `FixedSizeBinaryArray`

2021-12-29 Thread GitBox
alamb closed issue #1096: URL: https://github.com/apache/arrow-rs/issues/1096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

[GitHub] [arrow-rs] alamb merged pull request #1097: Print the 'FixedSizeBinaryArray' like a normal 'BinaryArray'

2021-12-29 Thread GitBox
alamb merged pull request #1097: URL: https://github.com/apache/arrow-rs/pull/1097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-datafusion] alamb commented on pull request #1502: add indexed fields support to python api

2021-12-29 Thread GitBox
alamb commented on pull request #1502: URL: https://github.com/apache/arrow-datafusion/pull/1502#issuecomment-1002751556 Thanks @nl5887 -- looks good to me. I kicked off the tests and we can merge this in when they pass 👍 -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow] ursabot edited a comment on pull request #12037: ARROW-15181: [C++][FlightRPC] Fix race between signal handler and shutdown

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12037: URL: https://github.com/apache/arrow/pull/12037#issuecomment-1002608371 Benchmark runs are scheduled for baseline = 0f4d662ae5d5ad71cafcac68d082f0f9ef9763c6 and contender = e46b0af6ec62c97dc8aa98d7d5b8468b37269198. e46b0af6ec62c97dc8aa98d7d

[GitHub] [arrow] ursabot edited a comment on pull request #12036: ARROW-15194: [C++] Combine ChunkedArray constructors

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12036: URL: https://github.com/apache/arrow/pull/12036#issuecomment-1002733642 Benchmark runs are scheduled for baseline = f5ab8833867cb456190d656300cbbb2f7724563e and contender = 5aa3f4b8fc280a58e54aad32a3ac3b6a10b5cd05. 5aa3f4b8fc280a58e54aad32a

[GitHub] [arrow-datafusion] nl5887 commented on pull request #1502: add indexed fields support to python api

2021-12-29 Thread GitBox
nl5887 commented on pull request #1502: URL: https://github.com/apache/arrow-datafusion/pull/1502#issuecomment-1002746210 Totally missed the test. Sorry about that. Added the test @alamb. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [arrow-datafusion] viirya opened a new pull request #1506: Fix ORDER BY on aggregate

2021-12-29 Thread GitBox
viirya opened a new pull request #1506: URL: https://github.com/apache/arrow-datafusion/pull/1506 # Which issue does this PR close? Closes #1479. # Rationale for this change # What changes are included in this PR? # Are there any user-facing chang

[GitHub] [arrow-rs] codecov-commenter commented on pull request #1107: Dyn comparison of interval arrays (#1106)

2021-12-29 Thread GitBox
codecov-commenter commented on pull request #1107: URL: https://github.com/apache/arrow-rs/pull/1107#issuecomment-1002743631 # [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1107?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T

[GitHub] [arrow-rs] tustvold opened a new pull request #1107: Dyn comparison of interval arrays (#1106)

2021-12-29 Thread GitBox
tustvold opened a new pull request #1107: URL: https://github.com/apache/arrow-rs/pull/1107 # Which issue does this PR close? Closes #1106. # Rationale for this change See ticket # What changes are included in this PR? See ticket # Are there any use

[GitHub] [arrow] ursabot edited a comment on pull request #12012: ARROW-15116: [Python] Expose invalid_row_handler for CSV reader

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12012: URL: https://github.com/apache/arrow/pull/12012#issuecomment-1002672524 Benchmark runs are scheduled for baseline = e46b0af6ec62c97dc8aa98d7d5b8468b37269198 and contender = 11040609fc4f6c1e7a2cdbfc8279598a7afccb68. 11040609fc4f6c1e7a2cdbfc8

[GitHub] [arrow] ursabot edited a comment on pull request #12001: ARROW-15136: [C++] Make S3FS tests faster

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12001: URL: https://github.com/apache/arrow/pull/12001#issuecomment-1002733635 Benchmark runs are scheduled for baseline = bf7636e1cbd35fdf4c638776366e113cf82f9081 and contender = f5ab8833867cb456190d656300cbbb2f7724563e. f5ab8833867cb456190d65630

[GitHub] [arrow-rs] tustvold opened a new issue #1106: Interval Support in Dyn Comparison Kernels

2021-12-29 Thread GitBox
tustvold opened a new issue #1106: URL: https://github.com/apache/arrow-rs/issues/1106 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Currently trying to use the `*_dyn` comparison kernels on an interval types results in a n

[GitHub] [arrow] ursabot commented on pull request #12036: ARROW-15194: [C++] Combine ChunkedArray constructors

2021-12-29 Thread GitBox
ursabot commented on pull request #12036: URL: https://github.com/apache/arrow/pull/12036#issuecomment-1002733642 Benchmark runs are scheduled for baseline = f5ab8833867cb456190d656300cbbb2f7724563e and contender = 5aa3f4b8fc280a58e54aad32a3ac3b6a10b5cd05. 5aa3f4b8fc280a58e54aad32a3ac3b6a

[GitHub] [arrow] ursabot commented on pull request #12001: ARROW-15136: [C++] Make S3FS tests faster

2021-12-29 Thread GitBox
ursabot commented on pull request #12001: URL: https://github.com/apache/arrow/pull/12001#issuecomment-1002733635 Benchmark runs are scheduled for baseline = bf7636e1cbd35fdf4c638776366e113cf82f9081 and contender = f5ab8833867cb456190d656300cbbb2f7724563e. f5ab8833867cb456190d656300cbbb2f

[GitHub] [arrow] lidavidm commented on a change in pull request #11982: [JAVA] Implement type info method to flight-sql

2021-12-29 Thread GitBox
lidavidm commented on a change in pull request #11982: URL: https://github.com/apache/arrow/pull/11982#discussion_r776453828 ## File path: format/FlightSql.proto ## @@ -867,6 +867,45 @@ enum SqlSupportsConvert { SQL_CONVERT_VARCHAR = 19; } +/* + * Represents a request to

[GitHub] [arrow] lidavidm closed pull request #12036: ARROW-15194: [C++] Combine ChunkedArray constructors

2021-12-29 Thread GitBox
lidavidm closed pull request #12036: URL: https://github.com/apache/arrow/pull/12036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow-rs] tustvold commented on issue #1053: Parquet Fuzz Tests

2021-12-29 Thread GitBox
tustvold commented on issue #1053: URL: https://github.com/apache/arrow-rs/issues/1053#issuecomment-1002727645 FYI I'm experimenting with extending the [existing fuzz tests](https://github.com/apache/arrow-rs/blob/master/parquet/src/arrow/arrow_reader.rs#L459) to support nulls, dictionarie

[GitHub] [arrow] lidavidm closed pull request #12001: ARROW-15136: [C++] Make S3FS tests faster

2021-12-29 Thread GitBox
lidavidm closed pull request #12001: URL: https://github.com/apache/arrow/pull/12001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [arrow-rs] viirya commented on pull request #1095: implement eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn for timestamp types

2021-12-29 Thread GitBox
viirya commented on pull request #1095: URL: https://github.com/apache/arrow-rs/pull/1095#issuecomment-1002717319 Thanks @alamb @Jimexist @liukun4515 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow-datafusion] hntd187 opened a new issue #1505: Renaming Tests Discussion

2021-12-29 Thread GitBox
hntd187 opened a new issue #1505: URL: https://github.com/apache/arrow-datafusion/issues/1505 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** I am starting the discussion on how we want to rename some of the tests post the re

[GitHub] [arrow] ursabot edited a comment on pull request #12037: ARROW-15181: [C++][FlightRPC] Fix race between signal handler and shutdown

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12037: URL: https://github.com/apache/arrow/pull/12037#issuecomment-1002608371 Benchmark runs are scheduled for baseline = 0f4d662ae5d5ad71cafcac68d082f0f9ef9763c6 and contender = e46b0af6ec62c97dc8aa98d7d5b8468b37269198. e46b0af6ec62c97dc8aa98d7d

[GitHub] [arrow-datafusion] ic4y opened a new issue #1504: The destruction of GroupState in high cardinality aggregation takes a lot of time

2021-12-29 Thread GitBox
ic4y opened a new issue #1504: URL: https://github.com/apache/arrow-datafusion/issues/1504 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** The test is as follows(4core 16G MacOS) ```select count(1) from (select user_id from

[GitHub] [arrow] pitrou commented on a change in pull request #12001: ARROW-15136: [C++] Make S3FS tests faster

2021-12-29 Thread GitBox
pitrou commented on a change in pull request #12001: URL: https://github.com/apache/arrow/pull/12001#discussion_r776427143 ## File path: cpp/src/arrow/filesystem/s3_test_util.cc ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [arrow] pitrou commented on a change in pull request #12001: ARROW-15136: [C++] Make S3FS tests faster

2021-12-29 Thread GitBox
pitrou commented on a change in pull request #12001: URL: https://github.com/apache/arrow/pull/12001#discussion_r776426805 ## File path: cpp/src/arrow/filesystem/s3_test_util.cc ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

[GitHub] [arrow] ursabot edited a comment on pull request #12051: MINOR: [CI] Fix AppVeyor setup failure

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12051: URL: https://github.com/apache/arrow/pull/12051#issuecomment-1002689878 Benchmark runs are scheduled for baseline = d69957dee479c5521afe6d51ec873bde8d7b6836 and contender = bf7636e1cbd35fdf4c638776366e113cf82f9081. bf7636e1cbd35fdf4c6387763

[GitHub] [arrow] edponce commented on a change in pull request #12032: ARROW-15126: [C++] Support Null type as group keys

2021-12-29 Thread GitBox
edponce commented on a change in pull request #12032: URL: https://github.com/apache/arrow/pull/12032#discussion_r776423102 ## File path: cpp/src/arrow/compute/kernels/row_encoder.h ## @@ -231,6 +231,26 @@ struct VarLengthKeyEncoder : KeyEncoder { std::shared_ptr type_; };

[GitHub] [arrow] ursabot edited a comment on pull request #12050: MINOR: [Archery] Fix Travis-CI build URL template

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12050: URL: https://github.com/apache/arrow/pull/12050#issuecomment-1002685566 Benchmark runs are scheduled for baseline = 4219acc7cdbad9384a03357cdafadad9b5880ec4 and contender = d69957dee479c5521afe6d51ec873bde8d7b6836. d69957dee479c5521afe6d51e

[GitHub] [arrow] ursabot edited a comment on pull request #12026: ARROW-12706: [Python] Drop Python 3.6 support

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12026: URL: https://github.com/apache/arrow/pull/12026#issuecomment-1002579422 Benchmark runs are scheduled for baseline = c00767ca7b00e06a21e5c7143feca1d3f9d0a9d7 and contender = 0f4d662ae5d5ad71cafcac68d082f0f9ef9763c6. 0f4d662ae5d5ad71cafcac68d

[GitHub] [arrow] lidavidm commented on a change in pull request #12001: ARROW-15136: [C++] Make S3FS tests faster

2021-12-29 Thread GitBox
lidavidm commented on a change in pull request #12001: URL: https://github.com/apache/arrow/pull/12001#discussion_r776419557 ## File path: cpp/src/arrow/filesystem/s3_test_util.cc ## @@ -0,0 +1,174 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more co

[GitHub] [arrow] pitrou commented on pull request #10450: ARROW-9947: [Python] High-level Python API for Parquet encryption of files.

2021-12-29 Thread GitBox
pitrou commented on pull request #10450: URL: https://github.com/apache/arrow/pull/10450#issuecomment-1002691988 @andersonm-ibm I don't get a linker error, however the tests fail with: ``` === ERRORS ===

[GitHub] [arrow] ursabot edited a comment on pull request #12034: MINOR: [Docs] Indicate that Parquet encoding BIT_PACKED cannot be used for values

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12034: URL: https://github.com/apache/arrow/pull/12034#issuecomment-1002681291 Benchmark runs are scheduled for baseline = 7890a1d19cd7eb03f6c86b68fdae674a08a534e1 and contender = 4219acc7cdbad9384a03357cdafadad9b5880ec4. 4219acc7cdbad9384a03357cd

[GitHub] [arrow] ursabot commented on pull request #12051: MINOR: [CI] Fix AppVeyor setup failure

2021-12-29 Thread GitBox
ursabot commented on pull request #12051: URL: https://github.com/apache/arrow/pull/12051#issuecomment-1002689878 Benchmark runs are scheduled for baseline = d69957dee479c5521afe6d51ec873bde8d7b6836 and contender = bf7636e1cbd35fdf4c638776366e113cf82f9081. bf7636e1cbd35fdf4c638776366e113c

[GitHub] [arrow] edponce commented on a change in pull request #12032: ARROW-15126: [C++] Support Null type as group keys

2021-12-29 Thread GitBox
edponce commented on a change in pull request #12032: URL: https://github.com/apache/arrow/pull/12032#discussion_r776410855 ## File path: cpp/src/arrow/compute/kernels/hash_aggregate.cc ## @@ -147,10 +152,13 @@ struct GrouperImpl : Grouper { if (it_success.second) {

[GitHub] [arrow] pitrou closed pull request #12051: MINOR: [CI] Fix AppVeyor setup failure

2021-12-29 Thread GitBox
pitrou closed pull request #12051: URL: https://github.com/apache/arrow/pull/12051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow] pitrou commented on pull request #12051: MINOR: [CI] Fix AppVeyor setup failure

2021-12-29 Thread GitBox
pitrou commented on pull request #12051: URL: https://github.com/apache/arrow/pull/12051#issuecomment-1002687591 (the crossbow submission above is just to test the link generation fix in https://github.com/apache/arrow/pull/12050 ) -- This is an automated message from the Apache Git Serv

[GitHub] [arrow] pitrou commented on pull request #12048: ARROW-15210: [Python] Pyarrow compute functions convert args with `__arrow_array__`.

2021-12-29 Thread GitBox
pitrou commented on pull request #12048: URL: https://github.com/apache/arrow/pull/12048#issuecomment-1002686240 @coady Can you rebase this on git master to fix CI failures? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #12051: MINOR: [CI] Fix AppVeyor setup failure

2021-12-29 Thread GitBox
github-actions[bot] commented on pull request #12051: URL: https://github.com/apache/arrow/pull/12051#issuecomment-1002685732 Revision: fc5f88b3e9e96fc35cdf1cbb54d800e356beec63 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1353](https://github.com/ursacomputing/crossbo

[GitHub] [arrow] ursabot edited a comment on pull request #12023: ARROW-15189: [C++] Upgrade bundled utf8proc version

2021-12-29 Thread GitBox
ursabot edited a comment on pull request #12023: URL: https://github.com/apache/arrow/pull/12023#issuecomment-1002672533 Benchmark runs are scheduled for baseline = 11040609fc4f6c1e7a2cdbfc8279598a7afccb68 and contender = 7890a1d19cd7eb03f6c86b68fdae674a08a534e1. 7890a1d19cd7eb03f6c86b68f

[GitHub] [arrow] ursabot commented on pull request #12050: MINOR: [Archery] Fix Travis-CI build URL template

2021-12-29 Thread GitBox
ursabot commented on pull request #12050: URL: https://github.com/apache/arrow/pull/12050#issuecomment-1002685566 Benchmark runs are scheduled for baseline = 4219acc7cdbad9384a03357cdafadad9b5880ec4 and contender = d69957dee479c5521afe6d51ec873bde8d7b6836. d69957dee479c5521afe6d51ec873bde

[GitHub] [arrow] pitrou commented on pull request #12051: MINOR: [CI] Fix AppVeyor setup failure

2021-12-29 Thread GitBox
pitrou commented on pull request #12051: URL: https://github.com/apache/arrow/pull/12051#issuecomment-1002685342 @github-actions crossbow submit ubuntu-impish-arm64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] pitrou closed pull request #12050: MINOR: [Archery] Fix Travis-CI build URL template

2021-12-29 Thread GitBox
pitrou closed pull request #12050: URL: https://github.com/apache/arrow/pull/12050 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [arrow-rs] yordan-pavlov commented on a change in pull request #1082: Optimized ByteArrayReader (#1040)

2021-12-29 Thread GitBox
yordan-pavlov commented on a change in pull request #1082: URL: https://github.com/apache/arrow-rs/pull/1082#discussion_r776412307 ## File path: parquet/src/arrow/array_reader/byte_array.rs ## @@ -0,0 +1,639 @@ +use crate::arrow::array_reader::{read_records, ArrayReader}; +use

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1054: Preserve Parquet Bitmask (#1037)

2021-12-29 Thread GitBox
tustvold commented on a change in pull request #1054: URL: https://github.com/apache/arrow-rs/pull/1054#discussion_r776411732 ## File path: parquet/src/arrow/record_reader/definition_levels.rs ## @@ -0,0 +1,379 @@ +use std::ops::Range; + +use arrow::array::BooleanBufferBuilder;

[GitHub] [arrow-rs] tustvold commented on a change in pull request #1054: Preserve Parquet Bitmask (#1037)

2021-12-29 Thread GitBox
tustvold commented on a change in pull request #1054: URL: https://github.com/apache/arrow-rs/pull/1054#discussion_r776411732 ## File path: parquet/src/arrow/record_reader/definition_levels.rs ## @@ -0,0 +1,379 @@ +use std::ops::Range; + +use arrow::array::BooleanBufferBuilder;

  1   2   3   >