rok commented on pull request #11818:
URL: https://github.com/apache/arrow/pull/11818#issuecomment-1003827840
@lidavidm @jorisvandenbossche this now rounds time since epoch in local time
([see
here](https://github.com/apache/arrow/blob/b93f0758cd24f23f20ee7b0939ff409f213a9df7/cpp/src/arrow
rok commented on a change in pull request #11818:
URL: https://github.com/apache/arrow/pull/11818#discussion_r777271809
##
File path: cpp/src/arrow/compute/kernels/scalar_temporal_test.cc
##
@@ -342,6 +342,39 @@ class ScalarTemporalTest : public ::testing::Test {
"[-1998
liukun4515 commented on pull request #1127:
URL: https://github.com/apache/arrow-rs/pull/1127#issuecomment-1003811295
I will review this pr, if it's ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] commented on pull request #12061:
URL: https://github.com/apache/arrow/pull/12061#issuecomment-1003798917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on pull request #12060:
URL: https://github.com/apache/arrow/pull/12060#issuecomment-1003785746
https://issues.apache.org/jira/browse/ARROW-15216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
github-actions[bot] commented on pull request #12058:
URL: https://github.com/apache/arrow/pull/12058#issuecomment-1003780425
Revision: 71a7e8797f1982e560b6a12dd438acada372d0b8
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1361](https://github.com/ursacomputing/crossbo
kou commented on pull request #12058:
URL: https://github.com/apache/arrow/pull/12058#issuecomment-1003780308
@github-actions crossbow submit debian-bullseye-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
justinrmiller commented on issue #1396:
URL:
https://github.com/apache/arrow-datafusion/issues/1396#issuecomment-1003776282
> @justinrmiller I don't know how to do this today -- it may be possible to
register a new memory ObjectStore source and then pass the URL into
`register_csv` but on
codecov-commenter edited a comment on pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#issuecomment-1003762887
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm
codecov-commenter commented on pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130#issuecomment-1003762887
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1130?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
yordan-pavlov opened a new pull request #1130:
URL: https://github.com/apache/arrow-rs/pull/1130
# Which issue does this PR close?
Closes #.
# Rationale for this change
As explained in # `RleDecoder` as used in `VariableLenDictionaryDecoder`
as part of the implement
edponce commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r776864703
##
File path: cpp/src/arrow/compute/kernels/scalar_compare.cc
##
@@ -746,6 +787,155 @@ std::shared_ptr
MakeScalarMinMax(std::string name,
return func;
tustvold edited a comment on issue #1128:
URL: https://github.com/apache/arrow-rs/issues/1128#issuecomment-1003747568
Would it work for the kernels to take `impl AsRef` or similar. I
think implementing `Array` for `ArrayRef` as proposed will otherwise result in
two virtual dispatches inste
jorgecarleitao commented on issue #1091:
URL: https://github.com/apache/arrow-rs/issues/1091#issuecomment-1003747841
I was waiting for another (soon to be PR) before reporting here, but
basically it is possible to remove `Option` and also to replace `HashMap` in
Schema by `BTreeMap`, there
tustvold edited a comment on issue #1128:
URL: https://github.com/apache/arrow-rs/issues/1128#issuecomment-1003747568
Would it work for the kernels to take `impl AsRef` or similar. I
think implementing `Array` for `ArrayRef` as proposed will otherwise result in
two virtual dispatches inste
tustvold edited a comment on issue #1128:
URL: https://github.com/apache/arrow-rs/issues/1128#issuecomment-1003747568
Would it work for the kernels to take `impl AsRef` I think
implementing for ArrayRef as proposed will otherwise result in two virtual
dispatches instead of just one?
--
tustvold commented on issue #1128:
URL: https://github.com/apache/arrow-rs/issues/1128#issuecomment-1003747568
Would it work for the kernels to take `impl AsRef' I think
implementing for ArrayRef as proposed will otherwise result in two virtual
dispatches instead of just one?
--
This is
tfeda commented on issue #1517:
URL:
https://github.com/apache/arrow-datafusion/issues/1517#issuecomment-1003747517
I'm new to the project (and open source in general), so I think this would
be a good exercise for me. Because it's an API addition, I could use some
stylistic input on the s
tfeda opened a new issue #1517:
URL: https://github.com/apache/arrow-datafusion/issues/1517
Is your feature request related to a problem or challenge? Please describe
what you are trying to do.
#1514 points out a secondary goal for the python library to expose the
datafusion and arr
alamb commented on issue #1396:
URL:
https://github.com/apache/arrow-datafusion/issues/1396#issuecomment-1003743867
@justinrmiller I don't know how to do this today -- it may be possible to
register a new memory ObjectStore source and then pass the URL into
`register_csv` but one would
alamb merged pull request #1112:
URL: https://github.com/apache/arrow-rs/pull/1112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
alamb commented on a change in pull request #1112:
URL: https://github.com/apache/arrow-rs/pull/1112#discussion_r777231360
##
File path: arrow/src/csv/reader.rs
##
@@ -161,38 +160,31 @@ pub fn infer_reader_schema(
max_read_records: Option,
has_header: bool,
) -> Resu
alamb commented on issue #1091:
URL: https://github.com/apache/arrow-rs/issues/1091#issuecomment-1003742467
Looks like there is a related PR in arrow2:
https://github.com/jorgecarleitao/arrow2/pull/715
--
This is an automated message from the Apache Git Service.
To respond to the messag
alamb commented on a change in pull request #1112:
URL: https://github.com/apache/arrow-rs/pull/1112#discussion_r777230438
##
File path: arrow/src/csv/reader.rs
##
@@ -696,6 +738,39 @@ impl Parser for Date64Type {
_ => None,
}
}
+
+fn parse_format
codecov-commenter commented on pull request #1127:
URL: https://github.com/apache/arrow-rs/pull/1127#issuecomment-1003741445
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1127?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
codecov-commenter commented on pull request #1129:
URL: https://github.com/apache/arrow-rs/pull/1129#issuecomment-1003737295
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
alamb commented on a change in pull request #1129:
URL: https://github.com/apache/arrow-rs/pull/1129#discussion_r777226273
##
File path: arrow/src/pyarrow.rs
##
@@ -148,16 +148,6 @@ impl PyArrowConvert for ArrayData {
}
}
-impl PyArrowConvert for ArrayRef {
Review comm
alamb commented on a change in pull request #1129:
URL: https://github.com/apache/arrow-rs/pull/1129#discussion_r777225544
##
File path: arrow/src/array/cast.rs
##
@@ -21,7 +21,7 @@ use crate::array::*;
use crate::datatypes::*;
/// Force downcast ArrayRef to PrimitiveArray
alamb opened a new pull request #1129:
URL: https://github.com/apache/arrow-rs/pull/1129
# Which issue does this PR close?
Closes https://github.com/apache/arrow-rs/issues/1128
# Rationale for this change
See ticket
# What changes are included in this PR?
1. `
alamb commented on issue #1128:
URL: https://github.com/apache/arrow-rs/issues/1128#issuecomment-1003731598
I tried a blanket implementation like
```rust
/// Anything that can be retrieved as &dyn Array is also an Array
impl Array for T
where T: AsRef + fmt::Debug + Send + Sy
alamb opened a new issue #1128:
URL: https://github.com/apache/arrow-rs/issues/1128
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
Basically, the issue is that I want to treat `ArrayRef` / `Arc`
directly as `&dyn Array` so they
alamb commented on a change in pull request #1115:
URL: https://github.com/apache/arrow-rs/pull/1115#discussion_r777220989
##
File path: arrow/src/compute/kernels/comparison.rs
##
@@ -888,6 +890,375 @@ pub fn gt_eq_utf8_scalar(
compare_op_scalar!(left, right, |a, b| a >= b
alamb opened a new pull request #1127:
URL: https://github.com/apache/arrow-rs/pull/1127
Draft. Items left to do:
- [ ] PR for `impl Array` for `ArrayRef`, ete (and maybe remove
`downcast_array!`)
- [ ] Complete writing tests for Float arrays for comparison kernels
# Which i
alamb closed issue #814:
URL: https://github.com/apache/arrow-rs/issues/814
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arr
alamb closed issue #85:
URL: https://github.com/apache/arrow-rs/issues/85
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow
alamb merged pull request #885:
URL: https://github.com/apache/arrow-rs/pull/885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr..
alamb merged pull request #1125:
URL: https://github.com/apache/arrow-rs/pull/1125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
alamb merged pull request #1123:
URL: https://github.com/apache/arrow-rs/pull/1123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
alamb commented on a change in pull request #1123:
URL: https://github.com/apache/arrow-rs/pull/1123#discussion_r777216807
##
File path: arrow/src/compute/kernels/comparison.rs
##
@@ -1393,6 +1393,29 @@ pub fn lt_eq_dyn_utf8_scalar(left: Arc,
right: &str) -> Result right` oper
codecov-commenter edited a comment on pull request #1123:
URL: https://github.com/apache/arrow-rs/pull/1123#issuecomment-1003582193
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1123?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm
alamb merged pull request #1122:
URL: https://github.com/apache/arrow-rs/pull/1122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
yordan-pavlov commented on issue #:
URL: https://github.com/apache/arrow-rs/issues/#issuecomment-1003718555
UPDATE: performance degradation after the fix is actually not so bad - only
between 3% and 8%
```
arrow_array_reader/read StringArray, plain encoded, optional, half NUL
matthewmturner edited a comment on issue #1515:
URL:
https://github.com/apache/arrow-datafusion/issues/1515#issuecomment-1003717106
> Make sense to me.
>
> BTW, I don't have edit permission in
https://docs.google.com/document/d/1t64vZwZnXm9MyFj2qz3xcAkSxK3Wu12giS3KrS4nDE0/edit
matthewmturner commented on issue #1515:
URL:
https://github.com/apache/arrow-datafusion/issues/1515#issuecomment-1003717106
> Make sense to me.
>
> BTW, I don't have edit permission in
https://docs.google.com/document/d/1t64vZwZnXm9MyFj2qz3xcAkSxK3Wu12giS3KrS4nDE0/edit
Can
codecov-commenter edited a comment on pull request #1122:
URL: https://github.com/apache/arrow-rs/pull/1122#issuecomment-1003581567
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1122?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm
alamb merged pull request #1118:
URL: https://github.com/apache/arrow-rs/pull/1118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
xudong963 commented on issue #1515:
URL:
https://github.com/apache/arrow-datafusion/issues/1515#issuecomment-1003712427
Make sense to me.
BTW, I don't have edit permission in
https://docs.google.com/document/d/1t64vZwZnXm9MyFj2qz3xcAkSxK3Wu12giS3KrS4nDE0/edit
--
This is an automate
liukun4515 commented on issue #1516:
URL:
https://github.com/apache/arrow-datafusion/issues/1516#issuecomment-1003710969
The DF doesn't support hash for the `FixedSizedBinary` type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
codecov-commenter edited a comment on pull request #1118:
URL: https://github.com/apache/arrow-rs/pull/1118#issuecomment-1003508691
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1118?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm
FauxFaux opened a new issue #1516:
URL: https://github.com/apache/arrow-datafusion/issues/1516
**Describe the bug**
An aggregation query against a `FixedSizeBinary` column returns an internal
error:
`Error: Arrow error: External error: Execution error: Arrow error: External
error
alamb merged pull request #1117:
URL: https://github.com/apache/arrow-rs/pull/1117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
codecov-commenter edited a comment on pull request #1117:
URL: https://github.com/apache/arrow-rs/pull/1117#issuecomment-1003507705
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1117?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm
codecov-commenter edited a comment on pull request #885:
URL: https://github.com/apache/arrow-rs/pull/885#issuecomment-955237493
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/885?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_ter
alamb merged pull request #1116:
URL: https://github.com/apache/arrow-rs/pull/1116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
alamb commented on a change in pull request #885:
URL: https://github.com/apache/arrow-rs/pull/885#discussion_r777199560
##
File path: arrow/src/array/array_union.rs
##
@@ -48,15 +48,15 @@ impl UnionArray {
/// caller and assumes that each of the components are correct and
alamb commented on a change in pull request #885:
URL: https://github.com/apache/arrow-rs/pull/885#discussion_r777199264
##
File path: arrow/src/array/array_union.rs
##
@@ -48,15 +48,15 @@ impl UnionArray {
/// caller and assumes that each of the components are correct and
alamb merged pull request #1115:
URL: https://github.com/apache/arrow-rs/pull/1115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
alamb commented on a change in pull request #1115:
URL: https://github.com/apache/arrow-rs/pull/1115#discussion_r777198799
##
File path: arrow/src/compute/kernels/comparison.rs
##
@@ -888,6 +890,375 @@ pub fn gt_eq_utf8_scalar(
compare_op_scalar!(left, right, |a, b| a >= b
alamb commented on pull request #1115:
URL: https://github.com/apache/arrow-rs/pull/1115#issuecomment-1003701060
I think the "multiple PR idea" may not have been ideal here as they ended up
conflicting with each other :) -- I'll tend to these PRs and get them merged in
--
This is an auto
alamb merged pull request #1121:
URL: https://github.com/apache/arrow-rs/pull/1121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
alamb commented on pull request #1115:
URL: https://github.com/apache/arrow-rs/pull/1115#issuecomment-1003700558
I merged from master and will merge this PR after a clean CI run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
alamb commented on a change in pull request #1124:
URL: https://github.com/apache/arrow-rs/pull/1124#discussion_r777196426
##
File path: arrow/src/compute/kernels/comparison.rs
##
@@ -1144,6 +1144,29 @@ pub fn eq_dyn_utf8_scalar(left: Arc, right:
&str) -> Result= right` operat
alamb commented on issue #1515:
URL:
https://github.com/apache/arrow-datafusion/issues/1515#issuecomment-1003700035
Previous attempt at the same type of exercise from a year ago:
https://docs.google.com/document/d/1qspsOM_dknOxJKdGvKbC1aoVoO0M3i6x1CIo58mmN2Y
--
This is an automa
alamb opened a new issue #1515:
URL: https://github.com/apache/arrow-datafusion/issues/1515
@matthewmturner and I we think it would be valuable to try making a high
level roadmap for Arrow / Datafusion. Specifically, and how this differs from
the existing roadmap, we are looking for a ro
alamb commented on a change in pull request #1115:
URL: https://github.com/apache/arrow-rs/pull/1115#discussion_r777196959
##
File path: arrow/src/compute/kernels/comparison.rs
##
@@ -888,6 +890,375 @@ pub fn gt_eq_utf8_scalar(
compare_op_scalar!(left, right, |a, b| a >= b
liukun4515 commented on pull request #1104:
URL: https://github.com/apache/arrow-rs/pull/1104#issuecomment-1003699406
Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on pull request #1124:
URL: https://github.com/apache/arrow-rs/pull/1124#issuecomment-1003699021
Thanks @matthewmturner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
alamb merged pull request #1124:
URL: https://github.com/apache/arrow-rs/pull/1124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
alamb commented on a change in pull request #1124:
URL: https://github.com/apache/arrow-rs/pull/1124#discussion_r777196323
##
File path: arrow/src/compute/kernels/comparison.rs
##
@@ -1144,6 +1144,29 @@ pub fn eq_dyn_utf8_scalar(left: Arc, right:
&str) -> Result= right` operat
alamb closed issue #1113:
URL: https://github.com/apache/arrow-rs/issues/1113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@a
alamb merged pull request #1114:
URL: https://github.com/apache/arrow-rs/pull/1114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
alamb commented on a change in pull request #1114:
URL: https://github.com/apache/arrow-rs/pull/1114#discussion_r777196071
##
File path: arrow/src/compute/kernels/comparison.rs
##
@@ -1116,7 +1116,43 @@ where
dyn_compare_scalar!(&left, right, eq_scalar)
}
alamb closed issue #1103:
URL: https://github.com/apache/arrow-rs/issues/1103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@a
alamb merged pull request #1104:
URL: https://github.com/apache/arrow-rs/pull/1104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
HashidaTKS commented on a change in pull request #12044:
URL: https://github.com/apache/arrow/pull/12044#discussion_r777178819
##
File path: csharp/examples/FlightAspServerExample/FlightAspServerExample.csproj
##
@@ -0,0 +1,39 @@
+
+
+
+
+
+net6.0
Review comment:
HashidaTKS commented on a change in pull request #12044:
URL: https://github.com/apache/arrow/pull/12044#discussion_r777178819
##
File path: csharp/examples/FlightAspServerExample/FlightAspServerExample.csproj
##
@@ -0,0 +1,39 @@
+
+
+
+
+
+net6.0
Review comment:
76 matches
Mail list logo
