[GitHub] [arrow-rs] Ted-Jiang opened a new pull request, #2511: Avoid large over allocate buffer in sync reader

2022-08-18 Thread GitBox
Ted-Jiang opened a new pull request, #2511: URL: https://github.com/apache/arrow-rs/pull/2511 # Which issue does this PR close? Closes #2321 # Rationale for this change # What changes are included in this PR? # Are there any user-facing ch

[GitHub] [arrow-rs] psvri commented on pull request #2501: refactoring boolean builder apis

2022-08-18 Thread GitBox
psvri commented on PR #2501: URL: https://github.com/apache/arrow-rs/pull/2501#issuecomment-1220303656 Closing it temporarily. I will create a new PR for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [arrow] buttertoast123 closed issue #13919: [Go] String Binary Builder Leaks Memory When Writing to Parquet

2022-08-18 Thread GitBox
buttertoast123 closed issue #13919: [Go] String Binary Builder Leaks Memory When Writing to Parquet URL: https://github.com/apache/arrow/issues/13919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow-rs] psvri closed pull request #2501: refactoring boolean builder apis

2022-08-18 Thread GitBox
psvri closed pull request #2501: refactoring boolean builder apis URL: https://github.com/apache/arrow-rs/pull/2501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [arrow] buttertoast123 opened a new issue, #13919: [Go] String Binary Builder Leaks Memory When Writing to Parquet

2022-08-18 Thread GitBox
buttertoast123 opened a new issue, #13919: URL: https://github.com/apache/arrow/issues/13919 I'm running into memory leaks when using the string binary builder and writing parquet. I've also included a sample program illustrating the issue below. Unfortunately I haven't had much look root c

[GitHub] [arrow] ursabot commented on pull request #13907: MINOR: Fix docstrings for kleene boolean scalar funcs

2022-08-18 Thread GitBox
ursabot commented on PR #13907: URL: https://github.com/apache/arrow/pull/13907#issuecomment-1220270009 ['Python', 'R'] benchmarks have high level of regressions. [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/edab4877b3334cb7903754f0efccb049...1dfcd406e29e4d4f857770b91d5a24f4/)

[GitHub] [arrow] ursabot commented on pull request #13907: MINOR: Fix docstrings for kleene boolean scalar funcs

2022-08-18 Thread GitBox
ursabot commented on PR #13907: URL: https://github.com/apache/arrow/pull/13907#issuecomment-1220269901 Benchmark runs are scheduled for baseline = a1c3d57af514d4a84e753ff51df8e563135ee55e and contender = 1a34a078b29c3f119c93de10631d26fc0d52739a. 1a34a078b29c3f119c93de10631d26fc0d52739a is

[GitHub] [arrow-ballista] dependabot[bot] closed pull request #118: Update sqlparser requirement from 0.18 to 0.20

2022-08-18 Thread GitBox
dependabot[bot] closed pull request #118: Update sqlparser requirement from 0.18 to 0.20 URL: https://github.com/apache/arrow-ballista/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow-ballista] dependabot[bot] commented on pull request #118: Update sqlparser requirement from 0.18 to 0.20

2022-08-18 Thread GitBox
dependabot[bot] commented on PR #118: URL: https://github.com/apache/arrow-ballista/pull/118#issuecomment-1220240430 Superseded by #152. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [arrow-ballista] dependabot[bot] commented on pull request #152: Update sqlparser requirement from 0.18 to 0.21

2022-08-18 Thread GitBox
dependabot[bot] commented on PR #152: URL: https://github.com/apache/arrow-ballista/pull/152#issuecomment-1220240416 The following labels could not be found: `auto-dependencies`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-ballista] dependabot[bot] opened a new pull request, #152: Update sqlparser requirement from 0.18 to 0.21

2022-08-18 Thread GitBox
dependabot[bot] opened a new pull request, #152: URL: https://github.com/apache/arrow-ballista/pull/152 Updates the requirements on [sqlparser](https://github.com/sqlparser-rs/sqlparser-rs) to permit the latest version. Changelog Sourced from https://github.com/sqlparser-rs/sqlpar

[GitHub] [arrow-datafusion] hrh007 commented on issue #3177: ObjectStore cannot support hdfs

2022-08-18 Thread GitBox
hrh007 commented on issue #3177: URL: https://github.com/apache/arrow-datafusion/issues/3177#issuecomment-1220234436 Thanks@dmetasoul01 , I have implement one but not good; this will hlep -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] ZMZ91 commented on pull request #13838: ARROW-17382: [C++] open_dataset doesn't ignore BOM in csv file when header's with quotes

2022-08-18 Thread GitBox
ZMZ91 commented on PR #13838: URL: https://github.com/apache/arrow/pull/13838#issuecomment-1220231016 Thanks @pitrou. I've pushed a new commit and still got 2 ci failures. I'm not sure it's related with my change. Could you help check? -- This is an automated message from the Apache Git S

[GitHub] [arrow-ballista] mingmwang commented on a diff in pull request #151: Stop Executor Impl, Executor Graceful Shutdown

2022-08-18 Thread GitBox
mingmwang commented on code in PR #151: URL: https://github.com/apache/arrow-ballista/pull/151#discussion_r949776805 ## ballista/rust/executor/src/executor_server.rs: ## @@ -289,18 +317,34 @@ impl Heartbeater Self { executor_server } } -async fn start(&self)

[GitHub] [arrow-datafusion] dmetasoul01 commented on issue #3177: ObjectStore cannot support hdfs

2022-08-18 Thread GitBox
dmetasoul01 commented on issue #3177: URL: https://github.com/apache/arrow-datafusion/issues/3177#issuecomment-1220218640 There's an hdfs object store implementation in the blaze project: https://github.com/blaze-init/blaze/blob/master/native-engine/datafusion-ext/src/hdfs_object_store.rs

[GitHub] [arrow-rs] HaoYang670 commented on a diff in pull request #2510: Avoid useless memory copies in IPC reader.

2022-08-18 Thread GitBox
HaoYang670 commented on code in PR #2510: URL: https://github.com/apache/arrow-rs/pull/2510#discussion_r949774397 ## arrow/src/ipc/reader.rs: ## @@ -53,14 +53,11 @@ fn read_buffer( ) -> Result { let start_offset = buf.offset() as usize; let end_offset = start_offset +

[GitHub] [arrow-rs] HaoYang670 opened a new pull request, #2510: Avoid useless memory copies in IPC reader.

2022-08-18 Thread GitBox
HaoYang670 opened a new pull request, #2510: URL: https://github.com/apache/arrow-rs/pull/2510 Signed-off-by: remzi <1371656737...@gmail.com> # Which issue does this PR close? Closes #2437. # Rationale for this change # What changes are included in

[GitHub] [arrow] cyb70289 commented on pull request #13907: MINOR: Fix docstrings for kleene boolean scalar funcs

2022-08-18 Thread GitBox
cyb70289 commented on PR #13907: URL: https://github.com/apache/arrow/pull/13907#issuecomment-1220199446 Thanks @gforsyth ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] cyb70289 merged pull request #13907: MINOR: Fix docstrings for kleene boolean scalar funcs

2022-08-18 Thread GitBox
cyb70289 merged PR #13907: URL: https://github.com/apache/arrow/pull/13907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

[GitHub] [arrow-datafusion-python] francis-du opened a new issue, #38: Rust Release 1.63.0 add a new lint `borrow_deref_ref` causing Cargo Clippy error

2022-08-18 Thread GitBox
francis-du opened a new issue, #38: URL: https://github.com/apache/arrow-datafusion-python/issues/38 https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref ![image](https://user-images.githubusercontent.com/25944814/185534765-f6893d3b-e064-4450-a3c3-6a52309857f8.pn

[GitHub] [arrow-datafusion-python] francis-du commented on pull request #34: [DataFrame] - Add DataFrame::distinct binding

2022-08-18 Thread GitBox
francis-du commented on PR #34: URL: https://github.com/apache/arrow-datafusion-python/pull/34#issuecomment-1220191308 This is a new lint in release `1.63.0` https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref -- This is an automated message from the Apache Git S

[GitHub] [arrow-ballista] mingmwang commented on a diff in pull request #151: Stop Executor Impl, Executor Graceful Shutdown

2022-08-18 Thread GitBox
mingmwang commented on code in PR #151: URL: https://github.com/apache/arrow-ballista/pull/151#discussion_r949759864 ## ballista/rust/executor/src/executor_server.rs: ## @@ -368,16 +425,31 @@ impl TaskRunnerPool

[GitHub] [arrow-datafusion-python] andygrove commented on pull request #34: [DataFrame] - Add DataFrame::distinct binding

2022-08-18 Thread GitBox
andygrove commented on PR #34: URL: https://github.com/apache/arrow-datafusion-python/pull/34#issuecomment-1220190061 There are clippy failures like this - not related to your changes: ``` 4 | default_catalog: &str, | ^ help: if you would like

[GitHub] [arrow-datafusion] ShaoDaTao opened a new issue, #3203: datafusion cannot recognize chinese charactors.

2022-08-18 Thread GitBox
ShaoDaTao opened a new issue, #3203: URL: https://github.com/apache/arrow-datafusion/issues/3203 **Describe the bug** datafusion cannot recognize chinese charactors. **To Reproduce** 1. simply create a csv file, put the title as name in chinese charactor: 扫描人 2. run the rust c

[GitHub] [arrow-ballista] mingmwang commented on a diff in pull request #151: Stop Executor Impl, Executor Graceful Shutdown

2022-08-18 Thread GitBox
mingmwang commented on code in PR #151: URL: https://github.com/apache/arrow-ballista/pull/151#discussion_r949756356 ## ballista/rust/executor/src/main.rs: ## @@ -154,57 +162,156 @@ async fn main() -> Result<()> { let scheduler_policy = opt.task_scheduling_policy; let

[GitHub] [arrow-rs] liukun4515 commented on issue #2496: Use u8 for Decimal Precision and Scale

2022-08-18 Thread GitBox
liukun4515 commented on issue #2496: URL: https://github.com/apache/arrow-rs/issues/2496#issuecomment-1220181887 It's reasonable for me. I think the data type of `Decimal128(usize, usize),` should be changed too -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] zhztheplayer commented on pull request #13321: ARROW-16754: [Java] StructVector's child vectors get unexpectedly reordered after adding duplicated fields

2022-08-18 Thread GitBox
zhztheplayer commented on PR #13321: URL: https://github.com/apache/arrow/pull/13321#issuecomment-1220177096 I've addressed the last comment @pitrou @lidavidm please let me know if other changes are needed. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [arrow] zhztheplayer commented on a diff in pull request #13321: ARROW-16754: [Java] StructVector's child vectors get unexpectedly reordered after adding duplicated fields

2022-08-18 Thread GitBox
zhztheplayer commented on code in PR #13321: URL: https://github.com/apache/arrow/pull/13321#discussion_r949746761 ## java/vector/src/test/java/org/apache/arrow/vector/TestStructVector.java: ## @@ -171,13 +174,102 @@ public void testAddOrGetComplexChildVectors() { vector.

[GitHub] [arrow-ballista] mingmwang commented on a diff in pull request #151: Stop Executor Impl, Executor Graceful Shutdown

2022-08-18 Thread GitBox
mingmwang commented on code in PR #151: URL: https://github.com/apache/arrow-ballista/pull/151#discussion_r949746027 ## ballista/rust/executor/src/main.rs: ## @@ -154,57 +162,156 @@ async fn main() -> Result<()> { let scheduler_policy = opt.task_scheduling_policy; let

[GitHub] [arrow-ballista] mingmwang commented on a diff in pull request #151: Stop Executor Impl, Executor Graceful Shutdown

2022-08-18 Thread GitBox
mingmwang commented on code in PR #151: URL: https://github.com/apache/arrow-ballista/pull/151#discussion_r949744647 ## ballista/rust/executor/src/main.rs: ## @@ -154,57 +162,156 @@ async fn main() -> Result<()> { let scheduler_policy = opt.task_scheduling_policy; let

[GitHub] [arrow-ballista] mingmwang commented on a diff in pull request #151: Stop Executor Impl, Executor Graceful Shutdown

2022-08-18 Thread GitBox
mingmwang commented on code in PR #151: URL: https://github.com/apache/arrow-ballista/pull/151#discussion_r949743190 ## ballista/rust/executor/src/execution_loop.rs: ## @@ -108,7 +107,7 @@ pub async fn poll_loop } } Err(error) => { -

[GitHub] [arrow-datafusion-python] francis-du commented on a diff in pull request #35: [DataFrame] - Add union and union_distinct bindings for DataFrame

2022-08-18 Thread GitBox
francis-du commented on code in PR #35: URL: https://github.com/apache/arrow-datafusion-python/pull/35#discussion_r949742906 ## src/dataframe.rs: ## @@ -164,4 +164,24 @@ impl PyDataFrame { let batches = wait_for_future(py, df.collect())?; Ok(pretty::print_batc

[GitHub] [arrow-datafusion-python] andygrove commented on a diff in pull request #35: [DataFrame] - Add union and union_distinct bindings for DataFrame

2022-08-18 Thread GitBox
andygrove commented on code in PR #35: URL: https://github.com/apache/arrow-datafusion-python/pull/35#discussion_r949736490 ## src/dataframe.rs: ## @@ -164,4 +164,24 @@ impl PyDataFrame { let batches = wait_for_future(py, df.collect())?; Ok(pretty::print_batch

[GitHub] [arrow-datafusion] andygrove closed pull request #3126: [WIP] Changes needed to support recent sqlparser handling of LIKE

2022-08-18 Thread GitBox
andygrove closed pull request #3126: [WIP] Changes needed to support recent sqlparser handling of LIKE URL: https://github.com/apache/arrow-datafusion/pull/3126 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [arrow-datafusion] andygrove opened a new pull request, #3202: Sqlparser patches

2022-08-18 Thread GitBox
andygrove opened a new pull request, #3202: URL: https://github.com/apache/arrow-datafusion/pull/3202 # Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/3192 # Rationale for this change # What changes are included in th

[GitHub] [arrow-rs] jiacai2050 commented on pull request #2498: Add API to Retrieve Finished Writer from Parquet Writer

2022-08-18 Thread GitBox
jiacai2050 commented on PR #2498: URL: https://github.com/apache/arrow-rs/pull/2498#issuecomment-1220137697 Thanks for quick response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-datafusion] jklamer opened a new pull request, #3201: Use .get() to avoid panic

2022-08-18 Thread GitBox
jklamer opened a new pull request, #3201: URL: https://github.com/apache/arrow-datafusion/pull/3201 # Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/3190 by avoiding panic # Rationale for this change good first issue # What chang

[GitHub] [arrow-datafusion] andygrove commented on pull request #3181: [sqlparser-0.21] Update trimExpr members during planning

2022-08-18 Thread GitBox
andygrove commented on PR #3181: URL: https://github.com/apache/arrow-datafusion/pull/3181#issuecomment-1220131372 It would be good to add some tests as well either in this PR or as a follow on PR. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [arrow] github-actions[bot] commented on pull request #13918: ARROW-17434: [Java][CI] Add Windows support for Java JDK8

2022-08-18 Thread GitBox
github-actions[bot] commented on PR #13918: URL: https://github.com/apache/arrow/pull/13918#issuecomment-1220130462 :warning: Ticket **has no components in JIRA**, make sure you assign one. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [arrow] github-actions[bot] commented on pull request #13918: ARROW-17434: [Java][CI] Add Windows support for Java JDK8

2022-08-18 Thread GitBox
github-actions[bot] commented on PR #13918: URL: https://github.com/apache/arrow/pull/13918#issuecomment-1220130451 https://issues.apache.org/jira/browse/ARROW-17434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3181: [sqlparser-0.21] Update trimExpr members during planning

2022-08-18 Thread GitBox
codecov-commenter commented on PR #3181: URL: https://github.com/apache/arrow-datafusion/pull/3181#issuecomment-1220123278 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3181?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow] github-actions[bot] commented on pull request #13917: ARROW-17470: [CI][GLib] Add more system packages to sync the upstream PKGBUILD

2022-08-18 Thread GitBox
github-actions[bot] commented on PR #13917: URL: https://github.com/apache/arrow/pull/13917#issuecomment-1220121254 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] github-actions[bot] commented on pull request #13917: ARROW-17470: [CI][GLib] Add more system packages to sync the upstream PKGBUILD

2022-08-18 Thread GitBox
github-actions[bot] commented on PR #13917: URL: https://github.com/apache/arrow/pull/13917#issuecomment-1220121237 https://issues.apache.org/jira/browse/ARROW-17470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] zagto commented on a diff in pull request #13330: ARROW-16772: [C++] Implement encode and decode functions for Run-Length encoding

2022-08-18 Thread GitBox
zagto commented on code in PR #13330: URL: https://github.com/apache/arrow/pull/13330#discussion_r949708426 ## cpp/src/arrow/util/rle_util.cc: ## @@ -0,0 +1,32 @@ +#include "arrow/util/rle_util.h" +#include +#include "arrow/builder.h" + +namespace arrow { +namespace rle_util {

[GitHub] [arrow] zagto commented on a diff in pull request #13330: ARROW-16772: [C++] Implement encode and decode functions for Run-Length encoding

2022-08-18 Thread GitBox
zagto commented on code in PR #13330: URL: https://github.com/apache/arrow/pull/13330#discussion_r949705105 ## cpp/src/arrow/compute/api_vector.h: ## @@ -580,6 +587,26 @@ Result DictionaryEncode( const DictionaryEncodeOptions& options = DictionaryEncodeOptions::Defaults(),

[GitHub] [arrow] kou commented on pull request #13903: ARROW-17433: [C++] Make Boost's include directory a system include directory

2022-08-18 Thread GitBox
kou commented on PR #13903: URL: https://github.com/apache/arrow/pull/13903#issuecomment-122072 No. It's unexpected. I just tried to use Visual Studio 2019 on AppVeyer but it shows that we need to update our AppVeyor related scripts. So I stopped the work. And I found that

[GitHub] [arrow] zagto commented on pull request #13330: ARROW-16772: [C++] Implement encode and decode functions for Run-Length encoding

2022-08-18 Thread GitBox
zagto commented on PR #13330: URL: https://github.com/apache/arrow/pull/13330#issuecomment-1220094793 @drin I hope this is not too confusing, but I did a lot of work on the rle-util branch in the recent time, which was not merged/pushed here yet, sorry for that. I'm going to push that, so t

[GitHub] [arrow-rs] roeap opened a new pull request, #2509: Replace azure sdk with custom implementation

2022-08-18 Thread GitBox
roeap opened a new pull request, #2509: URL: https://github.com/apache/arrow-rs/pull/2509 # Which issue does this PR close? closes #2176 # Rationale for this change See https://github.com/apache/arrow-rs/issues/2176 # What changes are included in this PR? R

[GitHub] [arrow] rok commented on pull request #13501: ARROW-16695: [R][Python][C++] Extension types are not supported in joins

2022-08-18 Thread GitBox
rok commented on PR #13501: URL: https://github.com/apache/arrow/pull/13501#issuecomment-1220091865 Got it! I'll adopt HashJoin as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [arrow] westonpace commented on pull request #13501: ARROW-16695: [R][Python][C++] Extension types are not supported in joins

2022-08-18 Thread GitBox
westonpace commented on PR #13501: URL: https://github.com/apache/arrow/pull/13501#issuecomment-1220088290 > Huh, [python and C++ on s390x get the physical type instead of extension](https://app.travis-ci.com/github/apache/arrow/jobs/580252967#L3789). Probably because we fall back to

[GitHub] [arrow-datafusion] sarahyurick commented on pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-18 Thread GitBox
sarahyurick commented on PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#issuecomment-1220080662 Should I also add tests in `proto/src/lib.rs`? I'm not quite sure what those would look like. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [arrow] rok commented on pull request #13501: ARROW-16695: [R][Python][C++] Extension types are not supported in joins

2022-08-18 Thread GitBox
rok commented on PR #13501: URL: https://github.com/apache/arrow/pull/13501#issuecomment-1220076972 Huh, [python and C++ on s390x get the physical type instead of extension](https://app.travis-ci.com/github/apache/arrow/jobs/580252967#L3789). -- This is an automated message from the Apach

[GitHub] [arrow-rs] viirya commented on pull request #2508: Refactor boolean kernels to use same codebase

2022-08-18 Thread GitBox
viirya commented on PR #2508: URL: https://github.com/apache/arrow-rs/pull/2508#issuecomment-1220074666 ``` and time: [227.53 ns 227.66 ns 227.86 ns] change: [-0.2805% -0.1608% -0.0286%] (p = 0.01 < 0.05)

[GitHub] [arrow] drin commented on a diff in pull request #13330: ARROW-16772: [C++] Implement encode and decode functions for Run-Length encoding

2022-08-18 Thread GitBox
drin commented on code in PR #13330: URL: https://github.com/apache/arrow/pull/13330#discussion_r949678389 ## cpp/src/arrow/compute/kernels/vector_run_length_encode_test.cc: ## @@ -0,0 +1,192 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

[GitHub] [arrow] github-actions[bot] commented on pull request #13916: ARROW-17468: [C++] Validation for RLE arrays

2022-08-18 Thread GitBox
github-actions[bot] commented on PR #13916: URL: https://github.com/apache/arrow/pull/13916#issuecomment-1220073212 https://issues.apache.org/jira/browse/ARROW-17468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow-cookbook] mystic-lama commented on pull request #247: [WIP] Added license to r module

2022-08-18 Thread GitBox
mystic-lama commented on PR #247: URL: https://github.com/apache/arrow-cookbook/pull/247#issuecomment-1220073122 @lidavidm @thisisnic Please look at it when you get time :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow-datafusion] ayushdg commented on pull request #3181: [sqlparser-0.21] Update trimExpr members during planning

2022-08-18 Thread GitBox
ayushdg commented on PR #3181: URL: https://github.com/apache/arrow-datafusion/pull/3181#issuecomment-1220069267 > @ayushdg Could you please rebase against sqlparser-0.21 branch and change the sqlparser rev to 42c5d43b45d3e7a573ac24dd5c927c43bbd3768c. This is the next one to go in.

[GitHub] [arrow-rs] viirya opened a new issue, #2507: Use same codebase for boolean kernels

2022-08-18 Thread GitBox
viirya opened a new issue, #2507: URL: https://github.com/apache/arrow-rs/issues/2507 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Currently `and`/`or` and `and_kleene`/`or_kleene` have different codebase (`binary_boole

[GitHub] [arrow-rs] viirya opened a new pull request, #2508: Refactor boolean kernels to use same codebase

2022-08-18 Thread GitBox
viirya opened a new pull request, #2508: URL: https://github.com/apache/arrow-rs/pull/2508 # Which issue does this PR close? Closes #2507. # Rationale for this change # What changes are included in this PR? # Are there any user-facing chang

[GitHub] [arrow-datafusion] andygrove commented on pull request #3181: [sqlparser-0.21] Update trimExpr members during planning

2022-08-18 Thread GitBox
andygrove commented on PR #3181: URL: https://github.com/apache/arrow-datafusion/pull/3181#issuecomment-1220059257 @ayushdg Could you please rebase against `sqlparser-0.21` branch and change the sqlparser rev to `42c5d43b45d3e7a573ac24dd5c927c43bbd3768c`. This is the next one to go in.

[GitHub] [arrow-datafusion] andygrove merged pull request #3199: [sqlparser-0.21] Rename function `array` to `make_array`

2022-08-18 Thread GitBox
andygrove merged PR #3199: URL: https://github.com/apache/arrow-datafusion/pull/3199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow-rs] HaoYang670 closed pull request #2439: Seal the decimal type.

2022-08-18 Thread GitBox
HaoYang670 closed pull request #2439: Seal the decimal type. URL: https://github.com/apache/arrow-rs/pull/2439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [arrow-rs] HaoYang670 closed issue #2274: Use more `const` functions.

2022-08-18 Thread GitBox
HaoYang670 closed issue #2274: Use more `const` functions. URL: https://github.com/apache/arrow-rs/issues/2274 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [arrow-rs] HaoYang670 closed issue #2384: Rewrite Decimal Array using `const_generic`

2022-08-18 Thread GitBox
HaoYang670 closed issue #2384: Rewrite Decimal Array using `const_generic` URL: https://github.com/apache/arrow-rs/issues/2384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [arrow-rs] HaoYang670 closed issue #2390: Rewriting Decimal Builders using `const_generic`.

2022-08-18 Thread GitBox
HaoYang670 closed issue #2390: Rewriting Decimal Builders using `const_generic`. URL: https://github.com/apache/arrow-rs/issues/2390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [arrow] zagto commented on a diff in pull request #13330: ARROW-16772: [C++] Implement encode and decode functions for Run-Length encoding

2022-08-18 Thread GitBox
zagto commented on code in PR #13330: URL: https://github.com/apache/arrow/pull/13330#discussion_r949662682 ## cpp/src/arrow/compute/kernels/vector_run_length_encode_test.cc: ## @@ -0,0 +1,192 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribu

[GitHub] [arrow] zagto commented on a diff in pull request #13848: ARROW-17381: [C++][Acero] Centralize error handling in ExecPlan

2022-08-18 Thread GitBox
zagto commented on code in PR #13848: URL: https://github.com/apache/arrow/pull/13848#discussion_r949366764 ## cpp/src/arrow/compute/exec/asof_join_node.cc: ## @@ -584,17 +574,20 @@ class AsofJoinNode : public ExecNode { // It may happen here in cases where InputFinished wa

[GitHub] [arrow-datafusion] tustvold commented on pull request #3191: MINOR: Add branching model to contrib guide

2022-08-18 Thread GitBox
tustvold commented on PR #3191: URL: https://github.com/apache/arrow-datafusion/pull/3191#issuecomment-1220041869 > There might be multiple dependency upgrades (arrow-rs, sqlparser, chrono) and we wouldn't want branches for each one. So long as they're independent I see no reason not

[GitHub] [arrow-datafusion] avantgardnerio commented on pull request #3191: MINOR: Add branching model to contrib guide

2022-08-18 Thread GitBox
avantgardnerio commented on PR #3191: URL: https://github.com/apache/arrow-datafusion/pull/3191#issuecomment-1220038887 > name of the dependency I was thinking the reverse - if datafusion pre-25-release wants sqlparser 57, the datafusion branch name is `v25`. There might be mu

[GitHub] [arrow-datafusion] tustvold commented on pull request #3191: MINOR: Add branching model to contrib guide

2022-08-18 Thread GitBox
tustvold commented on PR #3191: URL: https://github.com/apache/arrow-datafusion/pull/3191#issuecomment-1220036940 > PR to non-master branch v[next version here] Probably want the name of the dependency in there somewhere -- This is an automated message from the Apache Git Service.

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3197: [Minor] Reduce code duplication creating ScalarValue::List

2022-08-18 Thread GitBox
codecov-commenter commented on PR #3197: URL: https://github.com/apache/arrow-datafusion/pull/3197#issuecomment-1220028807 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3197?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow-datafusion] andygrove opened a new pull request, #3200: [WIP] Upgrade to sqlparser 0.21

2022-08-18 Thread GitBox
andygrove opened a new pull request, #3200: URL: https://github.com/apache/arrow-datafusion/pull/3200 # Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/3192 # Rationale for this change # What changes are included in th

[GitHub] [arrow-datafusion] andygrove commented on pull request #3122: 'Rename `array()` function to `make_array()`, extend `array[]`

2022-08-18 Thread GitBox
andygrove commented on PR #3122: URL: https://github.com/apache/arrow-datafusion/pull/3122#issuecomment-1220021860 > Update on this PR: I think I may have gotten too ambitious in this PR: `array()` somewhat confusingly returns a `FixedSizedList` and `array[]` returns a List. > > May

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3196: Clean up CI workflows by removing "matrix" strategy, simplifying names

2022-08-18 Thread GitBox
codecov-commenter commented on PR #3196: URL: https://github.com/apache/arrow-datafusion/pull/3196#issuecomment-1220021406 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3196?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow-datafusion] andygrove commented on pull request #3199: [sqlparser-0.21] Rename function `array` to `make_array`

2022-08-18 Thread GitBox
andygrove commented on PR #3199: URL: https://github.com/apache/arrow-datafusion/pull/3199#issuecomment-1220016521 @alamb @tustvold This is the next sqlparser upgrade PR to go into the feature branch -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow-datafusion] andygrove opened a new pull request, #3199: [sqlparser-0.21] Rename function `array` to `make_array`

2022-08-18 Thread GitBox
andygrove opened a new pull request, #3199: URL: https://github.com/apache/arrow-datafusion/pull/3199 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing change

[GitHub] [arrow-datafusion] alamb commented on pull request #3122: 'Rename `array()` function to `make_array()`, extend `array[]`

2022-08-18 Thread GitBox
alamb commented on PR #3122: URL: https://github.com/apache/arrow-datafusion/pull/3122#issuecomment-1220003379 Update on this PR: I think I may have gotten too ambitious in this PR: `array()` somewhat confusingly returns a `FixedSizedList` and `array[]` returns a List. Maybe we can

[GitHub] [arrow-datafusion] alamb opened a new pull request, #3198: Remove old ci directory

2022-08-18 Thread GitBox
alamb opened a new pull request, #3198: URL: https://github.com/apache/arrow-datafusion/pull/3198 # Which issue does this PR close? re #3045 # Rationale for this change These scripts are for the arrow repo and got copied to datafusion when we split it out of the main repo.

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #3197: [Minor] Reduce code duplication creating ScalarValue::List

2022-08-18 Thread GitBox
alamb commented on code in PR #3197: URL: https://github.com/apache/arrow-datafusion/pull/3197#discussion_r949628370 ## datafusion/common/src/scalar.rs: ## @@ -1506,10 +1511,7 @@ impl ScalarValue { Some(scalar_vec) }

[GitHub] [arrow] zeroshade commented on pull request #13909: ARROW-17455: [Go] Initial Compute Framework [WIP]

2022-08-18 Thread GitBox
zeroshade commented on PR #13909: URL: https://github.com/apache/arrow/pull/13909#issuecomment-1219997039 Now that I have this in a stable place with >70% test coverage and tests passing, I'm going to keep this as a WIP and see what pieces I can easily pull out into smaller PRs that can be

[GitHub] [arrow] github-actions[bot] commented on pull request #13915: ARROW-17467: [Go] Aligned Bitmap Ops mess up the final byte when no t…

2022-08-18 Thread GitBox
github-actions[bot] commented on PR #13915: URL: https://github.com/apache/arrow/pull/13915#issuecomment-1219995644 https://issues.apache.org/jira/browse/ARROW-17467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] zeroshade opened a new pull request, #13915: ARROW-17467: [Go] Aligned Bitmap Ops mess up the final byte when no t…

2022-08-18 Thread GitBox
zeroshade opened a new pull request, #13915: URL: https://github.com/apache/arrow/pull/13915 …railing bits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [arrow-datafusion] avantgardnerio commented on pull request #3191: MINOR: Add branching model to contrib guide

2022-08-18 Thread GitBox
avantgardnerio commented on PR #3191: URL: https://github.com/apache/arrow-datafusion/pull/3191#issuecomment-1219995074 1. Who: the first person who needs it? 2. When: when they need it? 3. PR to non-master branch `v[next version here]` ? -- This is an automated message from

[GitHub] [arrow-datafusion] andygrove commented on pull request #3122: 'Rename `array()` function to `make_array()`, extend `array[]`

2022-08-18 Thread GitBox
andygrove commented on PR #3122: URL: https://github.com/apache/arrow-datafusion/pull/3122#issuecomment-1219991244 > @alamb I believe this is the next PR in line to be merged into `sqlparser-0.21` Never mind. These changes are not required in order to upgrade. -- This is an automa

[GitHub] [arrow-cookbook] thisisnic merged pull request #248: [R] Remove no-longer-true content on calling functions

2022-08-18 Thread GitBox
thisisnic merged PR #248: URL: https://github.com/apache/arrow-cookbook/pull/248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow-cookbook] thisisnic commented on pull request #248: [R] Remove no-longer-true content on calling functions

2022-08-18 Thread GitBox
thisisnic commented on PR #248: URL: https://github.com/apache/arrow-cookbook/pull/248#issuecomment-1219990979 Merging it now so it unblocks others' work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [arrow-datafusion] sarahyurick commented on a diff in pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-18 Thread GitBox
sarahyurick commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r949623739 ## datafusion/physical-expr/src/expressions/is_false.rs: ## @@ -0,0 +1,110 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more con

[GitHub] [arrow-datafusion] alamb opened a new pull request, #3197: [Minor] Reduce code duplication creating ScalarValue::List

2022-08-18 Thread GitBox
alamb opened a new pull request, #3197: URL: https://github.com/apache/arrow-datafusion/pull/3197 # Which issue does this PR close? N/A # Rationale for this change While working on https://github.com/apache/arrow-datafusion/pull/3122 I found it quite painful to make `Scalar

[GitHub] [arrow-datafusion] sarahyurick commented on a diff in pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-18 Thread GitBox
sarahyurick commented on code in PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#discussion_r949622961 ## datafusion/common/src/scalar.rs: ## @@ -726,6 +726,24 @@ impl ScalarValue { } } +/// whether this value is true or not. +pub fn i

[GitHub] [arrow-rs] alamb commented on issue #2382: Release Arrow `21.0.0` (next release after `20.0.0`)

2022-08-18 Thread GitBox
alamb commented on issue #2382: URL: https://github.com/apache/arrow-rs/issues/2382#issuecomment-1219988389 RC is out for approval: https://lists.apache.org/thread/g4nzgd57w6rbt7o4tkqpbdmrqg8tqrxz -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [arrow] ursabot commented on pull request #13796: ARROW-17306: [C++] Provide an optimized `GetFileInfoGenerator` specialization for `LocalFileSystem`

2022-08-18 Thread GitBox
ursabot commented on PR #13796: URL: https://github.com/apache/arrow/pull/13796#issuecomment-1219986548 ['Python', 'R'] benchmarks have high level of regressions. [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bcf8cc829bba490eb93a3de0a5c4ede1...edab4877b3334cb7903754f0efccb049/)

[GitHub] [arrow] ursabot commented on pull request #13796: ARROW-17306: [C++] Provide an optimized `GetFileInfoGenerator` specialization for `LocalFileSystem`

2022-08-18 Thread GitBox
ursabot commented on PR #13796: URL: https://github.com/apache/arrow/pull/13796#issuecomment-1219986350 Benchmark runs are scheduled for baseline = bc52f9f0e582474501e92e6a281f0110754a8af1 and contender = a1c3d57af514d4a84e753ff51df8e563135ee55e. a1c3d57af514d4a84e753ff51df8e563135ee55e is

[GitHub] [arrow-datafusion] tustvold commented on pull request #3191: MINOR: Add branching model to contrib guide

2022-08-18 Thread GitBox
tustvold commented on PR #3191: URL: https://github.com/apache/arrow-datafusion/pull/3191#issuecomment-1219976829 Very good questions, I guess the first person creates a draft PR and if another person wants to collaborate on the work they flag it and a maintainer can create the branch?? Al

[GitHub] [arrow-rs] ursabot commented on pull request #2506: Fix verify_release.sh script to run rustfmt in each crate individually

2022-08-18 Thread GitBox
ursabot commented on PR #2506: URL: https://github.com/apache/arrow-rs/pull/2506#issuecomment-1219969525 Benchmark runs are scheduled for baseline = 7ce6ba4b184fae19ca20ade5e9e712a435a8153b and contender = 68934f0fa5da62ae9fcbb753d1dfd8f672a4eb1e. 68934f0fa5da62ae9fcbb753d1dfd8f672a4eb1e i

[GitHub] [arrow-rs] alamb merged pull request #2506: Fix verify_release.sh script to run rustfmt in each crate individually

2022-08-18 Thread GitBox
alamb merged PR #2506: URL: https://github.com/apache/arrow-rs/pull/2506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

[GitHub] [arrow-datafusion] avantgardnerio commented on pull request #3191: MINOR: Add branching model to contrib guide

2022-08-18 Thread GitBox
avantgardnerio commented on PR #3191: URL: https://github.com/apache/arrow-datafusion/pull/3191#issuecomment-1219963805 > a reasonable evolution of the process we've effectively adopted thus far I like evolution. 1. Who does it? 2. When do they do it? 3. What's the naming

[GitHub] [arrow-datafusion] tustvold commented on pull request #3191: MINOR: Add branching model to contrib guide

2022-08-18 Thread GitBox
tustvold commented on PR #3191: URL: https://github.com/apache/arrow-datafusion/pull/3191#issuecomment-1219960771 > next_release I think the intention is not to have a single next_release branch, but a staging point for the features that require the upstream change. Changes that don

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3189: Support "IS TRUE/FALSE" syntax

2022-08-18 Thread GitBox
codecov-commenter commented on PR #3189: URL: https://github.com/apache/arrow-datafusion/pull/3189#issuecomment-1219958251 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3189?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow-rs] alamb opened a new pull request, #2506: Fix verify_release.sh script to run rustfmt in each crate individually

2022-08-18 Thread GitBox
alamb opened a new pull request, #2506: URL: https://github.com/apache/arrow-rs/pull/2506 # Which issue does this PR close? re # Rationale for this change https://github.com/apache/arrow-rs/pull/2339 changes the release candidates so there is no workspace (Cargo.toml)

[GitHub] [arrow-rs] ursabot commented on pull request #2339: Update create-tarball.sh and verify_release.sh script to skip `object_store`

2022-08-18 Thread GitBox
ursabot commented on PR #2339: URL: https://github.com/apache/arrow-rs/pull/2339#issuecomment-1219950187 Benchmark runs are scheduled for baseline = dacd35410f3a9cee3d6103b9b0f71e8669e7a430 and contender = 7ce6ba4b184fae19ca20ade5e9e712a435a8153b. 7ce6ba4b184fae19ca20ade5e9e712a435a8153b i

  1   2   3   4   >