[GitHub] [arrow-datafusion] HaoYang670 closed issue #3368: Avoid coping in `LogicalPlan::expressions`

2022-09-05 Thread GitBox
HaoYang670 closed issue #3368: Avoid coping in `LogicalPlan::expressions` URL: https://github.com/apache/arrow-datafusion/issues/3368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [arrow-datafusion] HaoYang670 commented on issue #3368: Avoid coping in `LogicalPlan::expressions`

2022-09-05 Thread GitBox
HaoYang670 commented on issue #3368: URL: https://github.com/apache/arrow-datafusion/issues/3368#issuecomment-1237733738 Sorry, I notice there are local values generated in this function, so that returning a reference is not reasonable here. -- This is an automated message from the Apach

[GitHub] [arrow] github-actions[bot] commented on pull request #14049: ARROW-17623: [C++][Acero] Helper classes for ranking in window functions

2022-09-05 Thread GitBox
github-actions[bot] commented on PR #14049: URL: https://github.com/apache/arrow/pull/14049#issuecomment-1237732537 https://issues.apache.org/jira/browse/ARROW-17623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #14049: ARROW-17623: [C++][Acero] Helper classes for ranking in window functions

2022-09-05 Thread GitBox
github-actions[bot] commented on PR #14049: URL: https://github.com/apache/arrow/pull/14049#issuecomment-1237732552 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow-datafusion] HaoYang670 opened a new issue, #3368: Avoid coping in `LogicalPlan::expressions`

2022-09-05 Thread GitBox
HaoYang670 opened a new issue, #3368: URL: https://github.com/apache/arrow-datafusion/issues/3368 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** ```rust /// returns all expressions (non-recursively) in the current //

[GitHub] [arrow] michalursa opened a new pull request, #14049: ARROW-17623: [C++][Acero] Helper classes for ranking in window functions

2022-09-05 Thread GitBox
michalursa opened a new pull request, #14049: URL: https://github.com/apache/arrow/pull/14049 Adding helper classes for computing ranking in window functions exec node -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow-datafusion] HaoYang670 closed issue #3355: Eliminate `OFFSET 0` in the logical plan optimization

2022-09-05 Thread GitBox
HaoYang670 closed issue #3355: Eliminate `OFFSET 0` in the logical plan optimization URL: https://github.com/apache/arrow-datafusion/issues/3355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow-datafusion] HaoYang670 commented on issue #3355: Eliminate `OFFSET 0` in the logical plan optimization

2022-09-05 Thread GitBox
HaoYang670 commented on issue #3355: URL: https://github.com/apache/arrow-datafusion/issues/3355#issuecomment-1237716883 Oh, I would close this issue as skip = 0 and skip = None are equivalent. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] kou commented on a diff in pull request #14046: MINOR: [ruby/README.md] Update readme with correct wording.

2022-09-05 Thread GitBox
kou commented on code in PR #14046: URL: https://github.com/apache/arrow/pull/14046#discussion_r963303574 ## ruby/README.md: ## @@ -19,7 +19,7 @@ # Apache Arrow Ruby -There are the official Ruby bindings for Apache Arrow. +These are the official Ruby bindings for Apache Arr

[GitHub] [arrow] kou merged pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-09-05 Thread GitBox
kou merged PR #13911: URL: https://github.com/apache/arrow/pull/13911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow] kou commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-09-05 Thread GitBox
kou commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1237688067 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [arrow] kou commented on a diff in pull request #14045: ARROW-17615: [C++][Packaging] Remove check_required_components from configure_package_config_file

2022-09-05 Thread GitBox
kou commented on code in PR #14045: URL: https://github.com/apache/arrow/pull/14045#discussion_r963277187 ## docs/source/cpp/build_system.rst: ## @@ -51,7 +51,7 @@ file into an executable linked with the Arrow C++ shared library: find_package(Arrow REQUIRED) add_execu

[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #3363: Upgrade to arrow 22

2022-09-05 Thread GitBox
yjshen commented on code in PR #3363: URL: https://github.com/apache/arrow-datafusion/pull/3363#discussion_r963266214 ## datafusion-examples/examples/custom_datasource.rs: ## @@ -243,8 +243,8 @@ impl ExecutionPlan for CustomExec { db.data.values().cloned().collect()

[GitHub] [arrow-datafusion-python] francis-du opened a new pull request, #44: [Doc] - Fix readme git repo url

2022-09-05 Thread GitBox
francis-du opened a new pull request, #44: URL: https://github.com/apache/arrow-datafusion-python/pull/44 Close #41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [arrow-datafusion-python] francis-du commented on pull request #34: [DataFrame] - Add DataFrame::distinct binding

2022-09-05 Thread GitBox
francis-du commented on PR #34: URL: https://github.com/apache/arrow-datafusion-python/pull/34#issuecomment-1237671519 > Looks like a linting issue It has been fixed, please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
viirya commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963262773 ## arrow/src/compute/kernels/arity.rs: ## @@ -83,6 +84,41 @@ where PrimitiveArrayfrom(data) } +/// A overflow-checking variant of `unary`. +pub(crate) fn una

[GitHub] [arrow-datafusion] yjshen commented on pull request #3354: Replace panic with Result in reader.rs

2022-09-05 Thread GitBox
yjshen commented on PR #3354: URL: https://github.com/apache/arrow-datafusion/pull/3354#issuecomment-1237671011 Currently, the use of external `read_field_x` functions is implemented as `b.call_stmt`s, which are executed for side effects. You need to create a local variable and assign the

[GitHub] [arrow-ballista] dependabot[bot] commented on pull request #193: Update arrow-flight requirement from 21.0.0 to 22.0.0

2022-09-05 Thread GitBox
dependabot[bot] commented on PR #193: URL: https://github.com/apache/arrow-ballista/pull/193#issuecomment-1237649124 The following labels could not be found: `auto-dependencies`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-ballista] dependabot[bot] opened a new pull request, #193: Update arrow-flight requirement from 21.0.0 to 22.0.0

2022-09-05 Thread GitBox
dependabot[bot] opened a new pull request, #193: URL: https://github.com/apache/arrow-ballista/pull/193 Updates the requirements on [arrow-flight](https://github.com/apache/arrow-rs) to permit the latest version. Changelog Sourced from https://github.com/apache/arrow-rs/blob/master

[GitHub] [arrow-ballista] dependabot[bot] commented on pull request #192: Update arrow requirement from 21.0.0 to 22.0.0

2022-09-05 Thread GitBox
dependabot[bot] commented on PR #192: URL: https://github.com/apache/arrow-ballista/pull/192#issuecomment-1237648869 The following labels could not be found: `auto-dependencies`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-ballista] dependabot[bot] opened a new pull request, #192: Update arrow requirement from 21.0.0 to 22.0.0

2022-09-05 Thread GitBox
dependabot[bot] opened a new pull request, #192: URL: https://github.com/apache/arrow-ballista/pull/192 Updates the requirements on [arrow](https://github.com/apache/arrow-rs) to permit the latest version. Changelog Sourced from https://github.com/apache/arrow-rs/blob/master/CHANGE

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963231823 ## arrow/src/compute/kernels/arithmetic.rs: ## @@ -895,15 +895,34 @@ pub fn add_dyn(left: &dyn Array, right: &dyn Array) -> Result { /// Add every value in an ar

[GitHub] [arrow-datafusion] avantgardnerio commented on a diff in pull request #3363: Upgrade to arrow 22

2022-09-05 Thread GitBox
avantgardnerio commented on code in PR #3363: URL: https://github.com/apache/arrow-datafusion/pull/3363#discussion_r963230854 ## datafusion/core/src/physical_plan/explain.rs: ## @@ -121,8 +121,8 @@ impl ExecutionPlan for ExplainExec { ))); } -let

[GitHub] [arrow-datafusion] avantgardnerio commented on a diff in pull request #3363: Upgrade to arrow 22

2022-09-05 Thread GitBox
avantgardnerio commented on code in PR #3363: URL: https://github.com/apache/arrow-datafusion/pull/3363#discussion_r963230596 ## datafusion/common/Cargo.toml: ## @@ -39,12 +39,12 @@ pyarrow = ["pyo3"] [dependencies] apache-avro = { version = "0.14", features = ["snappy"], op

[GitHub] [arrow-datafusion] avantgardnerio commented on a diff in pull request #3363: Upgrade to arrow 22

2022-09-05 Thread GitBox
avantgardnerio commented on code in PR #3363: URL: https://github.com/apache/arrow-datafusion/pull/3363#discussion_r963230434 ## datafusion-examples/examples/custom_datasource.rs: ## @@ -243,8 +243,8 @@ impl ExecutionPlan for CustomExec { db.data.values().cloned().c

[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #3363: Upgrade to arrow 22

2022-09-05 Thread GitBox
yjshen commented on code in PR #3363: URL: https://github.com/apache/arrow-datafusion/pull/3363#discussion_r963217863 ## datafusion/common/Cargo.toml: ## @@ -39,12 +39,12 @@ pyarrow = ["pyo3"] [dependencies] apache-avro = { version = "0.14", features = ["snappy"], optional =

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963227230 ## arrow/src/compute/kernels/arity.rs: ## @@ -83,6 +84,41 @@ where PrimitiveArrayfrom(data) } +/// A overflow-checking variant of `unary`. +pub(crate) fn

[GitHub] [arrow-ballista] avantgardnerio commented on pull request #187: [MINOR] Add log info in stdout

2022-09-05 Thread GitBox
avantgardnerio commented on PR #187: URL: https://github.com/apache/arrow-ballista/pull/187#issuecomment-1237628586 > Default , it will print the log in the console Excellent, this is definitely what every modern container environment will expect and is in line with the [12 factors](h

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963227831 ## arrow/src/compute/kernels/arity.rs: ## @@ -83,6 +84,41 @@ where PrimitiveArrayfrom(data) } +/// A overflow-checking variant of `unary`. +pub(crate) fn

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963227230 ## arrow/src/compute/kernels/arity.rs: ## @@ -83,6 +84,41 @@ where PrimitiveArrayfrom(data) } +/// A overflow-checking variant of `unary`. +pub(crate) fn

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963225816 ## arrow/src/compute/kernels/arity.rs: ## @@ -83,6 +84,41 @@ where PrimitiveArrayfrom(data) } +/// A overflow-checking variant of `unary`. +pub(crate) fn

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
viirya commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963225528 ## arrow/src/compute/kernels/arity.rs: ## @@ -83,6 +84,41 @@ where PrimitiveArrayfrom(data) } +/// A overflow-checking variant of `unary`. +pub(crate) fn una

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
viirya commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963225163 ## arrow/src/compute/kernels/arity.rs: ## @@ -83,6 +84,41 @@ where PrimitiveArrayfrom(data) } +/// A overflow-checking variant of `unary`. +pub(crate) fn una

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2661: optimize the `numeric_cast_with_error`

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2661: URL: https://github.com/apache/arrow-rs/pull/2661#discussion_r963224097 ## arrow/src/compute/kernels/cast.rs: ## @@ -1657,22 +1657,21 @@ where T::Native: num::NumCast, R::Native: num::NumCast, { -let iter = from -.

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2649: support `CastOption` for casting numeric

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2649: URL: https://github.com/apache/arrow-rs/pull/2649#discussion_r963223663 ## arrow/src/compute/kernels/cast.rs: ## @@ -1456,21 +1621,62 @@ where } /// Convert Array into a PrimitiveArray of type, and apply numeric cast -fn cast_numeric

[GitHub] [arrow-rs] liukun4515 opened a new pull request, #2661: optimize the `numeric_cast_with_error`

2022-09-05 Thread GitBox
liukun4515 opened a new pull request, #2661: URL: https://github.com/apache/arrow-rs/pull/2661 # Which issue does this PR close? follow up of https://github.com/apache/arrow-rs/pull/2649 from the comment: https://github.com/apache/arrow-rs/pull/2649#discussion_r962789336

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963221429 ## arrow/src/compute/kernels/arity.rs: ## @@ -83,6 +84,41 @@ where PrimitiveArrayfrom(data) } +/// A overflow-checking variant of `unary`. +pub(crate) fn

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963215619 ## arrow/src/compute/kernels/arity.rs: ## @@ -83,6 +84,41 @@ where PrimitiveArrayfrom(data) } +/// A overflow-checking variant of `unary`. +pub(crate) fn

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963215619 ## arrow/src/compute/kernels/arity.rs: ## @@ -83,6 +84,41 @@ where PrimitiveArrayfrom(data) } +/// A overflow-checking variant of `unary`. +pub(crate) fn

[GitHub] [arrow-datafusion] HaoYang670 commented on issue #3248: Remove redundant projection when querying a view

2022-09-05 Thread GitBox
HaoYang670 commented on issue #3248: URL: https://github.com/apache/arrow-datafusion/issues/3248#issuecomment-1237604498 > Can we close this issue in favor of https://github.com/apache/arrow-datafusion/issues/3249 ? We should file a PR to close both this issue and 3249. -- This is

[GitHub] [arrow-rs] viirya commented on pull request #2660: ffi feature also requires layout

2022-09-05 Thread GitBox
viirya commented on PR #2660: URL: https://github.com/apache/arrow-rs/pull/2660#issuecomment-1237602223 cc @tustvold @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-rs] ursabot commented on pull request #2649: support `CastOption` for casting numeric

2022-09-05 Thread GitBox
ursabot commented on PR #2649: URL: https://github.com/apache/arrow-rs/pull/2649#issuecomment-1237601660 Benchmark runs are scheduled for baseline = 773f1b9d49d11a71129aaaebc9884559b7690cd3 and contender = 8ea6ca1cb8bba3e9293cc5c35f08f25c5b1e8336. 8ea6ca1cb8bba3e9293cc5c35f08f25c5b1e8336 i

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2649: support `CastOption` for casting numeric

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2649: URL: https://github.com/apache/arrow-rs/pull/2649#discussion_r963206083 ## arrow/src/compute/kernels/cast.rs: ## @@ -1456,21 +1621,62 @@ where } /// Convert Array into a PrimitiveArray of type, and apply numeric cast -fn cast_numeric

[GitHub] [arrow-rs] liukun4515 closed issue #2648: Cast the numeric without the `CastOptions`

2022-09-05 Thread GitBox
liukun4515 closed issue #2648: Cast the numeric without the `CastOptions` URL: https://github.com/apache/arrow-rs/issues/2648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [arrow-rs] liukun4515 merged pull request #2649: support `CastOption` for casting numeric

2022-09-05 Thread GitBox
liukun4515 merged PR #2649: URL: https://github.com/apache/arrow-rs/pull/2649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

[GitHub] [arrow-rs] viirya opened a new pull request, #2660: ffi feature also requires layout

2022-09-05 Thread GitBox
viirya opened a new pull request, #2660: URL: https://github.com/apache/arrow-rs/pull/2660 # Which issue does this PR close? Closes #2659. # Rationale for this change # What changes are included in this PR? # Are there any user-facing chang

[GitHub] [arrow-rs] viirya commented on issue #2659: clippy error: unresolved import `crate::array::layout`

2022-09-05 Thread GitBox
viirya commented on issue #2659: URL: https://github.com/apache/arrow-rs/issues/2659#issuecomment-1237598333 It is not due to #1960 which was merged since 18.0.0. `layout` was only exported if the `ipc` feature is enabled since #2601. But it is also required by `ffi` feature. -- Th

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2649: support `CastOption` for casting numeric

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2649: URL: https://github.com/apache/arrow-rs/pull/2649#discussion_r963202658 ## arrow/src/compute/kernels/cast.rs: ## @@ -1456,21 +1621,62 @@ where } /// Convert Array into a PrimitiveArray of type, and apply numeric cast -fn cast_numeric

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2649: support `CastOption` for casting numeric

2022-09-05 Thread GitBox
liukun4515 commented on code in PR #2649: URL: https://github.com/apache/arrow-rs/pull/2649#discussion_r963202388 ## arrow/src/compute/kernels/cast.rs: ## @@ -1456,21 +1621,62 @@ where } /// Convert Array into a PrimitiveArray of type, and apply numeric cast -fn cast_numeric

[GitHub] [arrow-rs] wangfenjin opened a new issue, #2659: clippy error: unresolved import `crate::array::layout`

2022-09-05 Thread GitBox
wangfenjin opened a new issue, #2659: URL: https://github.com/apache/arrow-rs/issues/2659 Version 22.0.0 will report clippy error: https://github.com/wangfenjin/duckdb-rs/runs/8198338828?check_suite_focus=true Seems related to this commit: https://github.com/apache/arrow-rs/pull/1960

[GitHub] [arrow-ballista] yahoNanJing commented on pull request #187: [MINOR] Add log info in stdout

2022-09-05 Thread GitBox
yahoNanJing commented on PR #187: URL: https://github.com/apache/arrow-ballista/pull/187#issuecomment-1237584020 It's better to make the writers configurable. If multiple writers, we can separate them by comma. And by default, just set it to be console. -- This is an automated message fro

[GitHub] [arrow-ballista] yahoNanJing commented on pull request #191: Fix CI to prevent future breaking of FlightSql

2022-09-05 Thread GitBox
yahoNanJing commented on PR #191: URL: https://github.com/apache/arrow-ballista/pull/191#issuecomment-1237582440 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [arrow] vibhatha commented on pull request #13700: ARROW-17190: [C++] Create a Fetch Node

2022-09-05 Thread GitBox
vibhatha commented on PR #13700: URL: https://github.com/apache/arrow/pull/13700#issuecomment-1237567614 > order-aware non-sink fetch node. Once Created the JIRA here: https://issues.apache.org/jira/browse/ARROW-17622 -- This is an automated message from the Apache Git Service. To r

[GitHub] [arrow] pcmoritz commented on pull request #14019: ARROW-17079: Show http status code for S3 errors

2022-09-05 Thread GitBox
pcmoritz commented on PR #14019: URL: https://github.com/apache/arrow/pull/14019#issuecomment-1237562396 @pitrou This should be ready now :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2656: Fix flaky test `test_fuzz_async_reader_selection`

2022-09-05 Thread GitBox
viirya commented on code in PR #2656: URL: https://github.com/apache/arrow-rs/pull/2656#discussion_r963163796 ## parquet/src/arrow/async_reader.rs: ## @@ -1015,7 +1014,7 @@ mod tests { let mut selectors = vec![]; while total_rows < 7300 { -

[GitHub] [arrow-rs] viirya opened a new pull request, #2658: Change macro to generic helper function

2022-09-05 Thread GitBox
viirya opened a new pull request, #2658: URL: https://github.com/apache/arrow-rs/pull/2658 # Which issue does this PR close? Closes #2657. # Rationale for this change # What changes are included in this PR? # Are there any user-facing chang

[GitHub] [arrow-rs] viirya opened a new issue, #2657: Change max/min string macro to generic helper function `min_max_helper`

2022-09-05 Thread GitBox
viirya opened a new issue, #2657: URL: https://github.com/apache/arrow-rs/issues/2657 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** The max/min binary and string kernels use a macro `min_max_binary_string` and max/min pr

[GitHub] [arrow-rs] thinkharderdev commented on pull request #2656: Fix flaky test `test_fuzz_async_reader_selection`

2022-09-05 Thread GitBox
thinkharderdev commented on PR #2656: URL: https://github.com/apache/arrow-rs/pull/2656#issuecomment-1237529407 @tustvold FYI. This should fix the flaky test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [arrow-rs] thinkharderdev opened a new pull request, #2656: Fix flaky test `test_fuzz_async_reader_selection`

2022-09-05 Thread GitBox
thinkharderdev opened a new pull request, #2656: URL: https://github.com/apache/arrow-rs/pull/2656 # Which issue does this PR close? Closes #. # Rationale for this change Fixes flaky fuzz test for row selection. Was generating random row selections with `row

[GitHub] [arrow-rs] thinkharderdev commented on pull request #2552: Fix bug in page skipping

2022-09-05 Thread GitBox
thinkharderdev commented on PR #2552: URL: https://github.com/apache/arrow-rs/pull/2552#issuecomment-1237526155 > This appears to be failing on master - https://github.com/apache/arrow-rs/runs/8193393646?check_suite_focus=true could you possibly take a look? Will do -- This is an

[GitHub] [arrow-ballista] avantgardnerio opened a new pull request, #191: Fix CI to prevent future breaking of FlightSql

2022-09-05 Thread GitBox
avantgardnerio opened a new pull request, #191: URL: https://github.com/apache/arrow-ballista/pull/191 # Which issue does this PR close? Closes #190. # Rationale for this change It would be good if CI could prevent features from breaking in the future. # What chan

[GitHub] [arrow-ballista] avantgardnerio opened a new issue, #190: FlightSQL is broken and CI isn't catching it

2022-09-05 Thread GitBox
avantgardnerio opened a new issue, #190: URL: https://github.com/apache/arrow-ballista/issues/190 **Describe the bug** PR #175 introduced a new feature flag for FlightSql support. Unfortunately CI was not updated to run build or tests for this feature, so it has been silently broken

[GitHub] [arrow-datafusion] avantgardnerio commented on pull request #3367: Fix code generation for json feature

2022-09-05 Thread GitBox
avantgardnerio commented on PR #3367: URL: https://github.com/apache/arrow-datafusion/pull/3367#issuecomment-1237489587 > Is this something that we should have caught in CI? Each CI job builds for a given feature set, then vaporizes the docker container. This is only something real u

[GitHub] [arrow-datafusion] ursabot commented on pull request #3367: Fix code generation for json feature

2022-09-05 Thread GitBox
ursabot commented on PR #3367: URL: https://github.com/apache/arrow-datafusion/pull/3367#issuecomment-1237482644 Benchmark runs are scheduled for baseline = ede82fb5a88859b77b7939e4b58c174c8285216d and contender = 827cab9219f90679c5616ebf73779cefe7186d4c. 827cab9219f90679c5616ebf73779cefe

[GitHub] [arrow-datafusion] andygrove commented on pull request #3367: Fix code generation for json feature

2022-09-05 Thread GitBox
andygrove commented on PR #3367: URL: https://github.com/apache/arrow-datafusion/pull/3367#issuecomment-1237480837 Is this something that we should have caught in CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow-datafusion] andygrove commented on pull request #3367: Fix code generation for json feature

2022-09-05 Thread GitBox
andygrove commented on PR #3367: URL: https://github.com/apache/arrow-datafusion/pull/3367#issuecomment-1237480178 Thanks @avantgardnerio -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [arrow-datafusion] andygrove closed issue #3366: Intermittent build error when changing selected features

2022-09-05 Thread GitBox
andygrove closed issue #3366: Intermittent build error when changing selected features URL: https://github.com/apache/arrow-datafusion/issues/3366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion] andygrove merged pull request #3367: Fix code generation for json feature

2022-09-05 Thread GitBox
andygrove merged PR #3367: URL: https://github.com/apache/arrow-datafusion/pull/3367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow-datafusion] avantgardnerio commented on pull request #3363: Upgrade to arrow 22

2022-09-05 Thread GitBox
avantgardnerio commented on PR #3363: URL: https://github.com/apache/arrow-datafusion/pull/3363#issuecomment-1237451108 @alamb thanks for releasing arrow 22! Hopefully this helps release the next version of DataFusion :) -- This is an automated message from the Apache Git Service. To res

[GitHub] [arrow-rs] tustvold commented on pull request #2593: Comparable Row Format

2022-09-05 Thread GitBox
tustvold commented on PR #2593: URL: https://github.com/apache/arrow-rs/pull/2593#issuecomment-1237446061 I think this is now ready for review, I intend to experiment with integration in DataFusion's SortPreservingMerge in the coming days and report back -- This is an automated message f

[GitHub] [arrow-datafusion] Dandandan commented on issue #3248: Remove redundant projection when querying a view

2022-09-05 Thread GitBox
Dandandan commented on issue #3248: URL: https://github.com/apache/arrow-datafusion/issues/3248#issuecomment-1237439664 Can we close this issue in favor of https://github.com/apache/arrow-datafusion/issues/3249 ? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] rok commented on a diff in pull request #13516: ARROW-16981: [C++] Expose jemalloc statistics for logging

2022-09-05 Thread GitBox
rok commented on code in PR #13516: URL: https://github.com/apache/arrow/pull/13516#discussion_r963108380 ## cpp/src/arrow/memory_pool.h: ## @@ -180,6 +180,12 @@ Status jemalloc_set_decay_ms(int ms); /// May return NotImplemented if mimalloc is not available. ARROW_EXPORT Stat

[GitHub] [arrow] rok commented on a diff in pull request #13516: ARROW-16981: [C++] Expose jemalloc statistics for logging

2022-09-05 Thread GitBox
rok commented on code in PR #13516: URL: https://github.com/apache/arrow/pull/13516#discussion_r963108068 ## cpp/src/arrow/memory_pool_jemalloc.cc: ## @@ -151,6 +151,26 @@ Status jemalloc_set_decay_ms(int ms) { return Status::OK(); } +Status jemalloc_mallctl(const char* na

[GitHub] [arrow-rs] jhorstmann commented on issue #2647: Divide By Zero Panics in Unchecked Arithmetic Kernels

2022-09-05 Thread GitBox
jhorstmann commented on issue #2647: URL: https://github.com/apache/arrow-rs/issues/2647#issuecomment-1237421931 I might be misremembering this, but I think `divide_unchecked` is only implemented for floating point types (which have a defined value for division by zero: positive or negative

[GitHub] [arrow-rs] ursabot commented on pull request #2655: MINOR: Ignore flaky test test_fuzz_async_reader_selection

2022-09-05 Thread GitBox
ursabot commented on PR #2655: URL: https://github.com/apache/arrow-rs/pull/2655#issuecomment-1237421358 Benchmark runs are scheduled for baseline = 7429b5cf99c025d170afc26e9a821baff6ebf36a and contender = 773f1b9d49d11a71129aaaebc9884559b7690cd3. 773f1b9d49d11a71129aaaebc9884559b7690cd3 i

[GitHub] [arrow-rs] viirya commented on pull request #2655: MINOR: Ignore flaky test test_fuzz_async_reader_selection

2022-09-05 Thread GitBox
viirya commented on PR #2655: URL: https://github.com/apache/arrow-rs/pull/2655#issuecomment-1237418201 Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [arrow-rs] viirya merged pull request #2655: MINOR: Ignore flaky test test_fuzz_async_reader_selection

2022-09-05 Thread GitBox
viirya merged PR #2655: URL: https://github.com/apache/arrow-rs/pull/2655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apach

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3363: Upgrade to arrow 22

2022-09-05 Thread GitBox
codecov-commenter commented on PR #3363: URL: https://github.com/apache/arrow-datafusion/pull/3363#issuecomment-1237411697 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow-rs] viirya commented on pull request #2655: MINOR: Ignore flaky test test_fuzz_async_reader_selection

2022-09-05 Thread GitBox
viirya commented on PR #2655: URL: https://github.com/apache/arrow-rs/pull/2655#issuecomment-1237411282 cc @tustvold -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [arrow-datafusion] avantgardnerio commented on pull request #3367: Fix code generation for json feature

2022-09-05 Thread GitBox
avantgardnerio commented on PR #3367: URL: https://github.com/apache/arrow-datafusion/pull/3367#issuecomment-1237410582 @alamb and @andygrove let's get this in before users start seeing random build issues. Sorry I didn't catch this with the initial PR. -- This is an automated message fr

[GitHub] [arrow-rs] viirya opened a new pull request, #2655: MINOR: Ignore flaky test test_fuzz_async_reader_selection

2022-09-05 Thread GitBox
viirya opened a new pull request, #2655: URL: https://github.com/apache/arrow-rs/pull/2655 # Which issue does this PR close? Closes #. # Rationale for this change The test `test_fuzz_async_reader_selection` added by #2552 is flaky as observed in CI and l

[GitHub] [arrow-datafusion] avantgardnerio opened a new pull request, #3367: Fix code generation for json feature

2022-09-05 Thread GitBox
avantgardnerio opened a new pull request, #3367: URL: https://github.com/apache/arrow-datafusion/pull/3367 # Which issue does this PR close? Closes #3366. # Rationale for this change We want stable builds, and I broke that. # What changes are included in this PR?

[GitHub] [arrow-datafusion] avantgardnerio opened a new issue, #3366: Intermittent build error when changing selected features

2022-09-05 Thread GitBox
avantgardnerio opened a new issue, #3366: URL: https://github.com/apache/arrow-datafusion/issues/3366 **Describe the bug** Now that codegen has been moved into the `proto/src/datafusion.rs` file, that file can have two different sets of contents depending on whether or not the `json`

[GitHub] [arrow] kshitij12345 commented on pull request #14048: ARROW-16651 : [Python] Casting Table to new schema ignores nullability of fields

2022-09-05 Thread GitBox
kshitij12345 commented on PR #14048: URL: https://github.com/apache/arrow/pull/14048#issuecomment-1237391936 cc: @AlenkaF @jorisvandenbossche -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion] Dandandan commented on issue #166: TPC-H Query 15

2022-09-05 Thread GitBox
Dandandan commented on issue #166: URL: https://github.com/apache/arrow-datafusion/issues/166#issuecomment-1237391552 I think for this to be correct we should switch to using a `decimal` type, as using floating point will result in small rounding errors, because parallel execution does not

[GitHub] [arrow] github-actions[bot] commented on pull request #14048: ARROW-16651 : [Python] Casting Table to new schema ignores nullability of fields

2022-09-05 Thread GitBox
github-actions[bot] commented on PR #14048: URL: https://github.com/apache/arrow/pull/14048#issuecomment-1237389760 https://issues.apache.org/jira/browse/ARROW-16651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow-datafusion] ursabot commented on pull request #3361: return empty dataframe on create table, remove a duplicate optimize call

2022-09-05 Thread GitBox
ursabot commented on PR #3361: URL: https://github.com/apache/arrow-datafusion/pull/3361#issuecomment-1237389780 Benchmark runs are scheduled for baseline = 4c948a3b3d11137bddb78bdfaa62abe98bd14b68 and contender = ede82fb5a88859b77b7939e4b58c174c8285216d. ede82fb5a88859b77b7939e4b58c174c8

[GitHub] [arrow] github-actions[bot] commented on pull request #14048: ARROW-16651 : [Python] Casting Table to new schema ignores nullability of fields

2022-09-05 Thread GitBox
github-actions[bot] commented on PR #14048: URL: https://github.com/apache/arrow/pull/14048#issuecomment-1237389776 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] kshitij12345 opened a new pull request, #14048: ARROW-16651 : [Python] Casting Table to new schema ignores nullability of fields

2022-09-05 Thread GitBox
kshitij12345 opened a new pull request, #14048: URL: https://github.com/apache/arrow/pull/14048 ```python table = pa.table({'a': [None, 1], 'b': [None, True]}) new_schema = pa.schema([pa.field("a", "int64", nullable=True), pa.field("b", "bool", nullable=False)]) casted = table.cast(

[GitHub] [arrow-datafusion] Dandandan commented on pull request #3361: return empty dataframe on create table, remove a duplicate optimize call

2022-09-05 Thread GitBox
Dandandan commented on PR #3361: URL: https://github.com/apache/arrow-datafusion/pull/3361#issuecomment-1237389200 Thanks @kmitchener -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [arrow-datafusion] Dandandan closed issue #3265: `CREATE TABLE` should return empty DataFrame

2022-09-05 Thread GitBox
Dandandan closed issue #3265: `CREATE TABLE` should return empty DataFrame URL: https://github.com/apache/arrow-datafusion/issues/3265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [arrow-datafusion] Dandandan merged pull request #3361: return empty dataframe on create table, remove a duplicate optimize call

2022-09-05 Thread GitBox
Dandandan merged PR #3361: URL: https://github.com/apache/arrow-datafusion/pull/3361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3365: Review use of panic in datafusion-proto crate

2022-09-05 Thread GitBox
codecov-commenter commented on PR #3365: URL: https://github.com/apache/arrow-datafusion/pull/3365#issuecomment-1237387715 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3365?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow] kshitij12345 commented on pull request #14044: ARROW-16652: [Python] Cast compute kernel segfaults when called with a Table

2022-09-05 Thread GitBox
kshitij12345 commented on PR #14044: URL: https://github.com/apache/arrow/pull/14044#issuecomment-1237385195 cc: @AlenkaF -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [arrow-datafusion] comphead opened a new pull request, #3365: Proto no panic

2022-09-05 Thread GitBox
comphead opened a new pull request, #3365: URL: https://github.com/apache/arrow-datafusion/pull/3365 # Which issue does this PR close? Closes #3318. # Rationale for this change Refactor to get rid of explicit panics # What changes are included in this PR?

[GitHub] [arrow] pcmoritz commented on a diff in pull request #14019: ARROW-17079: Show http status code for S3 errors

2022-09-05 Thread GitBox
pcmoritz commented on code in PR #14019: URL: https://github.com/apache/arrow/pull/14019#discussion_r963081229 ## cpp/src/arrow/filesystem/s3_internal.h: ## @@ -154,8 +154,9 @@ Status ErrorToStatus(const std::string& prefix, const std::string& operation, // https://sdk.amaz

[GitHub] [arrow-datafusion] waitingkuo opened a new issue, #3364: support `Statement::ShowVariable` to show session configs

2022-09-05 Thread GitBox
waitingkuo opened a new issue, #3364: URL: https://github.com/apache/arrow-datafusion/issues/3364 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** A clear and concise description of what the problem is. Ex. I'm always frustrated wh

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

2022-09-05 Thread GitBox
viirya commented on code in PR #2650: URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963067814 ## arrow/src/compute/kernels/arithmetic.rs: ## @@ -1236,21 +1283,41 @@ where Ok(unary(array, |a| a % modulo)) } +/// Divide every value in an array by a scalar.

[GitHub] [arrow-datafusion] avantgardnerio opened a new pull request, #3363: Upgrade to arrow 22

2022-09-05 Thread GitBox
avantgardnerio opened a new pull request, #3363: URL: https://github.com/apache/arrow-datafusion/pull/3363 # Which issue does this PR close? Closes #3362. # Rationale for this change We should keep DataFusion up to date with Arrow. # What changes are included in t

[GitHub] [arrow-datafusion] avantgardnerio opened a new issue, #3362: Upgrade to Arrow 22

2022-09-05 Thread GitBox
avantgardnerio opened a new issue, #3362: URL: https://github.com/apache/arrow-datafusion/issues/3362 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** I would like DataFusion to use Arrow 22 so that I can proxy Flights in Balli

  1   2   3   >