[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3458: add FixedSizeBinary support to create_hashes

2022-09-12 Thread GitBox
codecov-commenter commented on PR #3458: URL: https://github.com/apache/arrow-datafusion/pull/3458#issuecomment-1244979519 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow] ZhangChaoming opened a new issue, #14104: Why IpcReadOptions has no member named `codec`, but IpcWriteOptions has?

2022-09-12 Thread GitBox
ZhangChaoming opened a new issue, #14104: URL: https://github.com/apache/arrow/issues/14104 I wanna used ZSDT compression to encode my data, my code as below: ```C++ arrow::ipc::IpcWriteOptions options = arrow::ipc::IpcWriteOptions::Defaults(); auto codecRet = arrow::util::Codec::C

[GitHub] [arrow] pitrou commented on pull request #14102: ARROW-17635: [Python][CI] Sync conda recipe with the arrow-cpp feedstock

2022-09-12 Thread GitBox
pitrou commented on PR #14102: URL: https://github.com/apache/arrow/pull/14102#issuecomment-1244967910 Hmm, you might want to rebase and fix conflicts now that the C++17 PR was merged :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow-datafusion] liukun4515 closed issue #3414: pruning support cast/try_cast expr

2022-09-12 Thread GitBox
liukun4515 closed issue #3414: pruning support cast/try_cast expr URL: https://github.com/apache/arrow-datafusion/issues/3414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [arrow-datafusion] liukun4515 commented on issue #3414: pruning support cast/try_cast expr

2022-09-12 Thread GitBox
liukun4515 commented on issue #3414: URL: https://github.com/apache/arrow-datafusion/issues/3414#issuecomment-1244967553 > in order to make the correctness described in #3377, we should make the sure the type of value has order. > > Now we will have the plan to support them: >

[GitHub] [arrow] github-actions[bot] commented on pull request #14102: ARROW-17635: [Python][CI] Sync conda recipe with the arrow-cpp feedstock

2022-09-12 Thread GitBox
github-actions[bot] commented on PR #14102: URL: https://github.com/apache/arrow/pull/14102#issuecomment-1244967349 Revision: 4d94128d84ffd37c0ed561c71f6f1cee9f92ff7b Submitted crossbow builds: [ursacomputing/crossbow @ actions-07b5c91c58](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] pitrou merged pull request #13991: ARROW-17545: [C++][CI] Mandate C++17 instead of C++11

2022-09-12 Thread GitBox
pitrou merged PR #13991: URL: https://github.com/apache/arrow/pull/13991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

[GitHub] [arrow] pitrou commented on pull request #14102: ARROW-17635: [Python][CI] Sync conda recipe with the arrow-cpp feedstock

2022-09-12 Thread GitBox
pitrou commented on PR #14102: URL: https://github.com/apache/arrow/pull/14102#issuecomment-1244965901 @github-actions crossbow submit -g conda -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-rs] ursabot commented on pull request #2661: optimize the `numeric_cast_with_error`

2022-09-12 Thread GitBox
ursabot commented on PR #2661: URL: https://github.com/apache/arrow-rs/pull/2661#issuecomment-1244945912 Benchmark runs are scheduled for baseline = 259a3028b22f47d788b5e32b4651731206b1b4b6 and contender = f56b5733bc18688a938158529a0d138c7b2e1b47. f56b5733bc18688a938158529a0d138c7b2e1b47 i

[GitHub] [arrow-rs] liukun4515 merged pull request #2661: optimize the `numeric_cast_with_error`

2022-09-12 Thread GitBox
liukun4515 merged PR #2661: URL: https://github.com/apache/arrow-rs/pull/2661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

[GitHub] [arrow] kou merged pull request #14095: ARROW-17681: [CI][Packaging] Update brew dependency glib-utils with glib

2022-09-12 Thread GitBox
kou merged PR #14095: URL: https://github.com/apache/arrow/pull/14095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow-rs] liukun4515 opened a new pull request, #2718: benchmark: bitwise operation

2022-09-12 Thread GitBox
liukun4515 opened a new pull request, #2718: URL: https://github.com/apache/arrow-rs/pull/2718 # Which issue does this PR close? Closes #2714 # Rationale for this change # What changes are included in this PR? # Are there any user-facing c

[GitHub] [arrow] kou commented on a diff in pull request #13881: ARROW-17405: [Doc][Java] C Data Interface library able to compile with mvn command

2022-09-12 Thread GitBox
kou commented on code in PR #13881: URL: https://github.com/apache/arrow/pull/13881#discussion_r969172707 ## docs/source/developers/java/building.rst: ## @@ -47,25 +47,156 @@ repository: $ cd arrow $ git submodule update --init --recursive -Basic Installation ---

[GitHub] [arrow-datafusion] liukun4515 commented on issue #3421: Can't get the right logical plan after optimizer

2022-09-12 Thread GitBox
liukun4515 commented on issue #3421: URL: https://github.com/apache/arrow-datafusion/issues/3421#issuecomment-1244926854 > If there is no regression I agree this issue shouldn't hold up the release (we can fix it as part of the next release) Because in the 11.0.0, the type coercion i

[GitHub] [arrow] kou commented on a diff in pull request #13889: ARROW-17418: [Doc][Java] Dataset library able to compile with mvn command

2022-09-12 Thread GitBox
kou commented on code in PR #13889: URL: https://github.com/apache/arrow/pull/13889#discussion_r969171455 ## java/pom.xml: ## @@ -905,6 +905,69 @@ + + generate-jnicpp-dylib_so + +OFF +OFF +OFF +../java-dist + +

[GitHub] [arrow] ursabot commented on pull request #13854: ARROW-17386: [R] strptime tests not robust across platforms

2022-09-12 Thread GitBox
ursabot commented on PR #13854: URL: https://github.com/apache/arrow/pull/13854#issuecomment-1244926504 ['Python', 'R'] benchmarks have high level of regressions. [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/7d7ed41bda194ef8ae20b8e92b20406a...fbfca02de0fa4ccc87ef1c5363985943/)

[GitHub] [arrow] ursabot commented on pull request #13854: ARROW-17386: [R] strptime tests not robust across platforms

2022-09-12 Thread GitBox
ursabot commented on PR #13854: URL: https://github.com/apache/arrow/pull/13854#issuecomment-1244926389 Benchmark runs are scheduled for baseline = 6c675c35349a066c52758dac09e7b08fd990d239 and contender = 4ae26d1bb7537ca19d3b925cf4e7bf5f6a1c0d07. 4ae26d1bb7537ca19d3b925cf4e7bf5f6a1c0d07 is

[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #3444: Evaluate expressions after type coercion

2022-09-12 Thread GitBox
liukun4515 commented on code in PR #3444: URL: https://github.com/apache/arrow-datafusion/pull/3444#discussion_r969160573 ## datafusion/core/tests/sql/aggregates.rs: ## @@ -1834,11 +1834,11 @@ async fn aggregate_avg_add() -> Result<()> { assert_eq!(results.len(), 1);

[GitHub] [arrow-datafusion] liukun4515 commented on pull request #3422: support cast/try_cast in prune with signed integer and decimal

2022-09-12 Thread GitBox
liukun4515 commented on PR #3422: URL: https://github.com/apache/arrow-datafusion/pull/3422#issuecomment-1244905928 Thanks for your careful review. @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-rs] HaoYang670 commented on pull request #2717: Update `try_binary` and `checked_ops`, and remove `math_checked_op`

2022-09-12 Thread GitBox
HaoYang670 commented on PR #2717: URL: https://github.com/apache/arrow-rs/pull/2717#issuecomment-1244895448 Mark this as a draft now because I also need to update the `math_checked_divide_op` -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [arrow-rs] HaoYang670 opened a new pull request, #2717: Update `try_binary` and `checked_ops`, and remove `math_checked_op`

2022-09-12 Thread GitBox
HaoYang670 opened a new pull request, #2717: URL: https://github.com/apache/arrow-rs/pull/2717 Signed-off-by: remzi <1371656737...@gmail.com> # Which issue does this PR close? Closes #2715. # Rationale for this change 1. `try_binary` should not panic on unequal

[GitHub] [arrow] cyb70289 commented on a diff in pull request #14098: ARROW-17671: [Go] Filter kernels for Binary/String

2022-09-12 Thread GitBox
cyb70289 commented on code in PR #14098: URL: https://github.com/apache/arrow/pull/14098#discussion_r969107632 ## go/arrow/compute/internal/kernels/helpers.go: ## @@ -513,3 +514,134 @@ func (v *validityBuilder) Finish() (buf *memory.Buffer) { v.buffer = nil retur

[GitHub] [arrow] ursabot commented on pull request #13925: ARROW-15481: [R] [CI] Add a crossbow job that mimics CRAN's old macOS

2022-09-12 Thread GitBox
ursabot commented on PR #13925: URL: https://github.com/apache/arrow/pull/13925#issuecomment-1244852927 Benchmark runs are scheduled for baseline = 05b7fe35cf7c0dbba4d3c86882bb93560e606a13 and contender = 6c675c35349a066c52758dac09e7b08fd990d239. 6c675c35349a066c52758dac09e7b08fd990d239 is

[GitHub] [arrow-rs] ursabot commented on pull request #2703: Support bitwise and operation in the kernel

2022-09-12 Thread GitBox
ursabot commented on PR #2703: URL: https://github.com/apache/arrow-rs/pull/2703#issuecomment-1244847547 Benchmark runs are scheduled for baseline = 0ba5c5bf47941d0aa407b592ad594d902979ce50 and contender = 259a3028b22f47d788b5e32b4651731206b1b4b6. 259a3028b22f47d788b5e32b4651731206b1b4b6 i

[GitHub] [arrow-rs] liukun4515 opened a new pull request, #2716: Support bitwise op in kernel: or,xor,not

2022-09-12 Thread GitBox
liukun4515 opened a new pull request, #2716: URL: https://github.com/apache/arrow-rs/pull/2716 # Which issue does this PR close? part of #2702 # Rationale for this change # What changes are included in this PR? # Are there any user-facing

[GitHub] [arrow] github-actions[bot] commented on pull request #14103: ARROW-4740: [Java] [flight] Update to Junit 5

2022-09-12 Thread GitBox
github-actions[bot] commented on PR #14103: URL: https://github.com/apache/arrow/pull/14103#issuecomment-1244845139 https://issues.apache.org/jira/browse/ARROW-4740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [arrow-rs] HaoYang670 opened a new issue, #2715: `try_binary` should not panic on unequaled array length.

2022-09-12 Thread GitBox
HaoYang670 opened a new issue, #2715: URL: https://github.com/apache/arrow-rs/issues/2715 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** The function `try_binary` currently panic on `a.len() != b.len()`: ```rust pub fn try_b

[GitHub] [arrow-rs] liukun4515 merged pull request #2703: Support bitwise and operation in the kernel

2022-09-12 Thread GitBox
liukun4515 merged PR #2703: URL: https://github.com/apache/arrow-rs/pull/2703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

[GitHub] [arrow] jinchengchenghh commented on pull request #13969: ARROW-17523: [C++] Add support to substrait function is_null, is_not_null and count

2022-09-12 Thread GitBox
jinchengchenghh commented on PR #13969: URL: https://github.com/apache/arrow/pull/13969#issuecomment-1244840476 Thanks! It's ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [arrow-rs] liukun4515 commented on issue #2714: Add benchmark for bitwise operation

2022-09-12 Thread GitBox
liukun4515 commented on issue #2714: URL: https://github.com/apache/arrow-rs/issues/2714#issuecomment-1244839932 related https://github.com/apache/arrow-rs/issues/2702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow-rs] liukun4515 opened a new issue, #2714: Add benchmark for bitwise operation

2022-09-12 Thread GitBox
liukun4515 opened a new issue, #2714: URL: https://github.com/apache/arrow-rs/issues/2714 Agreed @liukun4515. And we should add some benchmarks to see whether we ccoul get performance improvement by doing this. _Originally posted by @HaoYang670 in https://github.com/apache/arrow-rs/p

[GitHub] [arrow] andreoss opened a new pull request, #14103: ARROW-4740: [Java] [flight] Update to Junit 5

2022-09-12 Thread GitBox
andreoss opened a new pull request, #14103: URL: https://github.com/apache/arrow/pull/14103 Update flight module to Junit 5 Relevant issue: https://issues.apache.org/jira/browse/ARROW-4740 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [arrow] ZMZ91 commented on a diff in pull request #13838: ARROW-17382: [C++] open_dataset doesn't ignore BOM in csv file when header's with quotes

2022-09-12 Thread GitBox
ZMZ91 commented on code in PR #13838: URL: https://github.com/apache/arrow/pull/13838#discussion_r969085775 ## cpp/src/arrow/dataset/file_csv.cc: ## @@ -196,6 +196,11 @@ static inline Future> OpenReaderAsync( auto reader_fut = DeferNotOk(input->io_context().executor()->Submi

[GitHub] [arrow] davisusanibar commented on a diff in pull request #13889: ARROW-17418: [Doc][Java] Dataset library able to compile with mvn command

2022-09-12 Thread GitBox
davisusanibar commented on code in PR #13889: URL: https://github.com/apache/arrow/pull/13889#discussion_r969081326 ## java/pom.xml: ## @@ -905,6 +905,69 @@ + + generate-jnicpp-dylib_so + +OFF +OFF +OFF +../java-dist

[GitHub] [arrow] lidavidm commented on pull request #14069: ARROW-17645: [CI] Get conda-integration building again

2022-09-12 Thread GitBox
lidavidm commented on PR #14069: URL: https://github.com/apache/arrow/pull/14069#issuecomment-1244808589 Thanks! Reverted the last commit, let's see how the build goes now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow-datafusion] mingmwang commented on issue #3410: Enhance TaskContext and add task failure root cause

2022-09-12 Thread GitBox
mingmwang commented on issue #3410: URL: https://github.com/apache/arrow-datafusion/issues/3410#issuecomment-1244808041 @alamb @yahoNanJing This would help. But it still depends on the programer to propagate the errors correctly in the execution path. And there is another case that we sti

[GitHub] [arrow] vibhatha commented on pull request #13452: ARROW-16856: [C++] Adding Filter Relation ToProto

2022-09-12 Thread GitBox
vibhatha commented on PR #13452: URL: https://github.com/apache/arrow/pull/13452#issuecomment-1244802228 https://github.com/apache/arrow/pull/13401 PR covered this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [arrow] kou commented on pull request #14069: ARROW-17645: [CI] Get conda-integration building again

2022-09-12 Thread GitBox
kou commented on PR #14069: URL: https://github.com/apache/arrow/pull/14069#issuecomment-1244800888 I've removed `amd64-conda` and `amd64-conda-cpp`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] vibhatha closed pull request #13452: ARROW-16856: [C++] Adding Filter Relation ToProto

2022-09-12 Thread GitBox
vibhatha closed pull request #13452: ARROW-16856: [C++] Adding Filter Relation ToProto URL: https://github.com/apache/arrow/pull/13452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [arrow] vibhatha commented on pull request #13452: ARROW-16856: [C++] Adding Filter Relation ToProto

2022-09-12 Thread GitBox
vibhatha commented on PR #13452: URL: https://github.com/apache/arrow/pull/13452#issuecomment-1244800385 Closing this PR, the feature was also included in https://github.com/apache/arrow/pull/13401 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] kou commented on pull request #14069: ARROW-17645: [CI] Get conda-integration building again

2022-09-12 Thread GitBox
kou commented on PR #14069: URL: https://github.com/apache/arrow/pull/14069#issuecomment-1244800357 I'll remove the cached images listed at https://hub.docker.com/r/apache/arrow-dev/tags (admin page: https://hub.docker.com/repository/docker/apache/arrow-dev/tags ). -- This is an automate

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2703: Support bitwise and operation in the kernel

2022-09-12 Thread GitBox
liukun4515 commented on code in PR #2703: URL: https://github.com/apache/arrow-rs/pull/2703#discussion_r969067446 ## arrow/src/compute/kernels/bitwise.rs: ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2703: Support bitwise and operation in the kernel

2022-09-12 Thread GitBox
liukun4515 commented on code in PR #2703: URL: https://github.com/apache/arrow-rs/pull/2703#discussion_r969066328 ## arrow/src/compute/kernels/bitwise.rs: ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [arrow-datafusion] mcassels opened a new pull request, #3458: add FixedSizeBinary support to create_hashes

2022-09-12 Thread GitBox
mcassels opened a new pull request, #3458: URL: https://github.com/apache/arrow-datafusion/pull/3458 # Which issue does this PR close? Closes #1516. # Rationale for this change Allows aggregation queries on FixedSizeBinary columns. # What changes are included in this

[GitHub] [arrow] ursabot commented on pull request #14092: ARROW-17674: [R] Implement dplyr::across() inside arrange()

2022-09-12 Thread GitBox
ursabot commented on PR #14092: URL: https://github.com/apache/arrow/pull/14092#issuecomment-1244784566 Benchmark runs are scheduled for baseline = ea382af7a996672305bde12a8b875741df6075f1 and contender = 05b7fe35cf7c0dbba4d3c86882bb93560e606a13. 05b7fe35cf7c0dbba4d3c86882bb93560e606a13 is

[GitHub] [arrow-nanoarrow] paleolimbot commented on a diff in pull request #44: [C] Fix some compiler warnings

2022-09-12 Thread GitBox
paleolimbot commented on code in PR #44: URL: https://github.com/apache/arrow-nanoarrow/pull/44#discussion_r969052992 ## src/nanoarrow/schema.c: ## @@ -1026,7 +1032,7 @@ ArrowErrorCode ArrowSchemaViewInit(struct ArrowSchemaView* schema_view, return EINVAL; } - int fo

[GitHub] [arrow-rs] HaoYang670 commented on a diff in pull request #2703: Support bitwise and operation in the kernel

2022-09-12 Thread GitBox
HaoYang670 commented on code in PR #2703: URL: https://github.com/apache/arrow-rs/pull/2703#discussion_r969048993 ## arrow/src/compute/kernels/bitwise.rs: ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [arrow-rs] HaoYang670 commented on a diff in pull request #2703: Support bitwise and operation in the kernel

2022-09-12 Thread GitBox
HaoYang670 commented on code in PR #2703: URL: https://github.com/apache/arrow-rs/pull/2703#discussion_r969046414 ## arrow/src/compute/kernels/bitwise.rs: ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [arrow] rok commented on pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-09-12 Thread GitBox
rok commented on PR #13873: URL: https://github.com/apache/arrow/pull/13873#issuecomment-1244751139 No hurry on my end @lidavidm! Sorry for the slow iterations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [arrow] lidavidm commented on pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-09-12 Thread GitBox
lidavidm commented on PR #13873: URL: https://github.com/apache/arrow/pull/13873#issuecomment-1244746093 sorry, I'm fairly backed up, I'll try to get to this sometime this week -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [arrow] rok commented on pull request #13873: ARROW-17407: [Doc][FlightRPC] Flight/gRPC best practices

2022-09-12 Thread GitBox
rok commented on PR #13873: URL: https://github.com/apache/arrow/pull/13873#issuecomment-1244745546 https://crossbow.voltrondata.com/pr_docs/13873/cpp/flight.html#best-practices -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2710: Add divide_opt kernel which produce null values on division by zero error

2022-09-12 Thread GitBox
viirya commented on code in PR #2710: URL: https://github.com/apache/arrow-rs/pull/2710#discussion_r969037946 ## arrow/src/compute/kernels/arity.rs: ## @@ -257,6 +257,50 @@ where Ok(unsafe { build_primitive_array(len, buffer.finish(), null_count, null_buffer) }) } +///

[GitHub] [arrow-rs] sunchao commented on a diff in pull request #2710: Add divide_opt kernel which produce null values on division by zero error

2022-09-12 Thread GitBox
sunchao commented on code in PR #2710: URL: https://github.com/apache/arrow-rs/pull/2710#discussion_r969032401 ## arrow/src/compute/kernels/arity.rs: ## @@ -257,6 +257,50 @@ where Ok(unsafe { build_primitive_array(len, buffer.finish(), null_count, null_buffer) }) } +///

[GitHub] [arrow] rok merged pull request #13854: ARROW-17386: [R] strptime tests not robust across platforms

2022-09-12 Thread GitBox
rok merged PR #13854: URL: https://github.com/apache/arrow/pull/13854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2703: Support bitwise and operation in the kernel

2022-09-12 Thread GitBox
liukun4515 commented on code in PR #2703: URL: https://github.com/apache/arrow-rs/pull/2703#discussion_r969029051 ## arrow/src/compute/kernels/bitwise.rs: ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2703: Support bitwise and operation in the kernel

2022-09-12 Thread GitBox
liukun4515 commented on code in PR #2703: URL: https://github.com/apache/arrow-rs/pull/2703#discussion_r969026323 ## arrow/src/compute/kernels/bitwise.rs: ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2703: Support bitwise and operation in the kernel

2022-09-12 Thread GitBox
liukun4515 commented on code in PR #2703: URL: https://github.com/apache/arrow-rs/pull/2703#discussion_r969025476 ## arrow/src/compute/kernels/bitwise.rs: ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [arrow-datafusion] thinkharderdev commented on pull request #3380: Pushdown `RowFilter` in `ParquetExec`

2022-09-12 Thread GitBox
thinkharderdev commented on PR #3380: URL: https://github.com/apache/arrow-datafusion/pull/3380#issuecomment-1244722059 I'm not sure what's going on with the checks. The errors look like it is building a different version of the code -- This is an automated message from the Apache Gi

[GitHub] [arrow-datafusion] thinkharderdev commented on pull request #3380: Pushdown `RowFilter` in `ParquetExec`

2022-09-12 Thread GitBox
thinkharderdev commented on PR #3380: URL: https://github.com/apache/arrow-datafusion/pull/3380#issuecomment-1244720348 Created issues for follow-up work: https://github.com/apache/arrow-datafusion/issues/3456 https://github.com/apache/arrow-datafusion/issues/3457 -- This is

[GitHub] [arrow-datafusion] thinkharderdev opened a new issue, #3457: Add benchmarks for parquet queries with filter pushdown enabled

2022-09-12 Thread GitBox
thinkharderdev opened a new issue, #3457: URL: https://github.com/apache/arrow-datafusion/issues/3457 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** A clear and concise description of what the problem is. Ex. I'm always frustrate

[GitHub] [arrow-datafusion] thinkharderdev opened a new issue, #3456: Support using offset index in `ParquetRecordBatchStream` when pushing down `RowFilter`

2022-09-12 Thread GitBox
thinkharderdev opened a new issue, #3456: URL: https://github.com/apache/arrow-datafusion/issues/3456 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** A clear and concise description of what the problem is. Ex. I'm always frustrate

[GitHub] [arrow-datafusion] thinkharderdev commented on a diff in pull request #3380: Pushdown `RowFilter` in `ParquetExec`

2022-09-12 Thread GitBox
thinkharderdev commented on code in PR #3380: URL: https://github.com/apache/arrow-datafusion/pull/3380#discussion_r969013867 ## datafusion/core/src/physical_plan/file_format/row_filter.rs: ## @@ -0,0 +1,367 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow-datafusion] thinkharderdev commented on a diff in pull request #3380: Pushdown `RowFilter` in `ParquetExec`

2022-09-12 Thread GitBox
thinkharderdev commented on code in PR #3380: URL: https://github.com/apache/arrow-datafusion/pull/3380#discussion_r969013277 ## datafusion/core/src/physical_plan/file_format/parquet.rs: ## @@ -1139,14 +1246,53 @@ mod tests { "+-++", "| c1 | c2

[GitHub] [arrow-datafusion] thinkharderdev commented on a diff in pull request #3380: Pushdown `RowFilter` in `ParquetExec`

2022-09-12 Thread GitBox
thinkharderdev commented on code in PR #3380: URL: https://github.com/apache/arrow-datafusion/pull/3380#discussion_r969012984 ## datafusion/core/src/physical_plan/file_format/row_filter.rs: ## @@ -0,0 +1,398 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// o

[GitHub] [arrow] ursabot commented on pull request #14088: ARROW-17670: [Go] Implement Filter function for Primitive and FixedSize types

2022-09-12 Thread GitBox
ursabot commented on PR #14088: URL: https://github.com/apache/arrow/pull/14088#issuecomment-1244695244 Benchmark runs are scheduled for baseline = 3ddf69e1453c837a99d5a7fc2db043433b9c8016 and contender = ea382af7a996672305bde12a8b875741df6075f1. ea382af7a996672305bde12a8b875741df6075f1 is

[GitHub] [arrow-datafusion-python] andygrove closed issue #45: Add Python binding for DataFrame::collect_partitioned

2022-09-12 Thread GitBox
andygrove closed issue #45: Add Python binding for DataFrame::collect_partitioned URL: https://github.com/apache/arrow-datafusion-python/issues/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion-python] andygrove merged pull request #46: [DataFrame] - Add collect_partitioned funcation for dataframe

2022-09-12 Thread GitBox
andygrove merged PR #46: URL: https://github.com/apache/arrow-datafusion-python/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [arrow-rs] viirya commented on pull request #2713: Add overflow-checking variants of arithmetic scalar dyn kernels

2022-09-12 Thread GitBox
viirya commented on PR #2713: URL: https://github.com/apache/arrow-rs/pull/2713#issuecomment-1244579644 cc @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [arrow] shollyman closed pull request #10603: ARROW-13191: [Go] allow external schema in ipc readers

2022-09-12 Thread GitBox
shollyman closed pull request #10603: ARROW-13191: [Go] allow external schema in ipc readers URL: https://github.com/apache/arrow/pull/10603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [arrow] shollyman commented on pull request #10603: ARROW-13191: [Go] allow external schema in ipc readers

2022-09-12 Thread GitBox
shollyman commented on PR #10603: URL: https://github.com/apache/arrow/pull/10603#issuecomment-1244575253 Closing this very old PR, seems like the flight changes made the necessary augmentations to process. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [arrow-ballista] dependabot[bot] commented on pull request #206: Update object_store requirement from 0.4.0 to 0.5.0

2022-09-12 Thread GitBox
dependabot[bot] commented on PR #206: URL: https://github.com/apache/arrow-ballista/pull/206#issuecomment-1244547807 Looks like object_store is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow-ballista] dependabot[bot] closed pull request #206: Update object_store requirement from 0.4.0 to 0.5.0

2022-09-12 Thread GitBox
dependabot[bot] closed pull request #206: Update object_store requirement from 0.4.0 to 0.5.0 URL: https://github.com/apache/arrow-ballista/pull/206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3455: Support ShowVariable Statement

2022-09-12 Thread GitBox
codecov-commenter commented on PR #3455: URL: https://github.com/apache/arrow-datafusion/pull/3455#issuecomment-1244528766 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3455?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow-ballista] andygrove closed issue #201: Unsupported binary operator `StringConcat`

2022-09-12 Thread GitBox
andygrove closed issue #201: Unsupported binary operator `StringConcat` URL: https://github.com/apache/arrow-ballista/issues/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-ballista] andygrove merged pull request #200: Use DataFusion 12.0.0-rc1 (and add support for DateTimeIntervalExpr and more binary operators)

2022-09-12 Thread GitBox
andygrove merged PR #200: URL: https://github.com/apache/arrow-ballista/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow] h-vetinari commented on pull request #13991: ARROW-17545: [C++][CI] Mandate C++17 instead of C++11

2022-09-12 Thread GitBox
h-vetinari commented on PR #13991: URL: https://github.com/apache/arrow/pull/13991#issuecomment-1244504568 @pitrou, just FYI, you might be interested in https://github.com/apache/arrow/pull/14102 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [arrow] github-actions[bot] commented on pull request #14102: ARROW-17635: [Python][CI] Sync conda recipe with the arrow-cpp feedstock

2022-09-12 Thread GitBox
github-actions[bot] commented on PR #14102: URL: https://github.com/apache/arrow/pull/14102#issuecomment-1244501588 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] github-actions[bot] commented on pull request #14102: ARROW-17635: [Python][CI] Sync conda recipe with the arrow-cpp feedstock

2022-09-12 Thread GitBox
github-actions[bot] commented on PR #14102: URL: https://github.com/apache/arrow/pull/14102#issuecomment-1244501497 https://issues.apache.org/jira/browse/ARROW-17635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] h-vetinari opened a new pull request, #14102: ARROW-17635: [Python][CI] Sync conda recipe with the arrow-cpp feedstock

2022-09-12 Thread GitBox
h-vetinari opened a new pull request, #14102: URL: https://github.com/apache/arrow/pull/14102 Corresponds to status of feedstock as of https://github.com/conda-forge/arrow-cpp-feedstock/pull/853, minus obvious & intentional divergences in the setup here (with the exception of unpinning xsi

[GitHub] [arrow] kou commented on a diff in pull request #14097: ARROW-17575: [Docs][C++] Update build document to follow new CMake package

2022-09-12 Thread GitBox
kou commented on code in PR #14097: URL: https://github.com/apache/arrow/pull/14097#discussion_r968928276 ## docs/source/cpp/build_system.rst: ## @@ -67,11 +67,55 @@ CMake variables: In addition, it will have created some targets that you can link against (note these are plain

[GitHub] [arrow] raulcd commented on a diff in pull request #14095: ARROW-17681: [CI][Packaging] Update brew dependency glib-utils with glib

2022-09-12 Thread GitBox
raulcd commented on code in PR #14095: URL: https://github.com/apache/arrow/pull/14095#discussion_r968942118 ## c_glib/Brewfile: ## @@ -16,7 +16,7 @@ # under the License. brew "autoconf-archive" -brew "glib-utils" +brew "glib" Review Comment: Done! Thanks @kou ! -- T

[GitHub] [arrow] lidavidm commented on pull request #14069: ARROW-17645: [CI] Get conda-integration building again

2022-09-12 Thread GitBox
lidavidm commented on PR #14069: URL: https://github.com/apache/arrow/pull/14069#issuecomment-1244487355 Looks like a dummy change to bump the cache did the trick - what's the 'right' way to accomplish that? -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [arrow-nanoarrow] lidavidm commented on pull request #44: [C] Fix some compiler warnings

2022-09-12 Thread GitBox
lidavidm commented on PR #44: URL: https://github.com/apache/arrow-nanoarrow/pull/44#issuecomment-1244474741 Updated, though maybe we should consider whether some of these casts should bounds-check instead -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow] ursabot commented on pull request #14047: ARROW-17620: [R] as_arrow_array() ignores type for StructArrays

2022-09-12 Thread GitBox
ursabot commented on PR #14047: URL: https://github.com/apache/arrow/pull/14047#issuecomment-124447 Benchmark runs are scheduled for baseline = 8c76855b17471ac7194c1bba630091e0d181 and contender = 3ddf69e1453c837a99d5a7fc2db043433b9c8016. 3ddf69e1453c837a99d5a7fc2db043433b9c8016 is

[GitHub] [arrow] kou commented on a diff in pull request #14095: ARROW-17681: [CI][Packaging] Update brew dependency glib-utils with glib

2022-09-12 Thread GitBox
kou commented on code in PR #14095: URL: https://github.com/apache/arrow/pull/14095#discussion_r968921440 ## c_glib/Brewfile: ## @@ -16,7 +16,7 @@ # under the License. brew "autoconf-archive" -brew "glib-utils" +brew "glib" Review Comment: Can we remove this line too? I

[GitHub] [arrow-datafusion] waitingkuo commented on a diff in pull request #3455: Support ShowVariable Statement

2022-09-12 Thread GitBox
waitingkuo commented on code in PR #3455: URL: https://github.com/apache/arrow-datafusion/pull/3455#discussion_r968911696 ## datafusion/sql/src/planner.rs: ## @@ -2378,10 +2378,27 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { fn show_variable_to_plan(&self, variable:

[GitHub] [arrow-datafusion] waitingkuo commented on a diff in pull request #3455: Support ShowVariable Statement

2022-09-12 Thread GitBox
waitingkuo commented on code in PR #3455: URL: https://github.com/apache/arrow-datafusion/pull/3455#discussion_r968910885 ## datafusion/core/tests/sql/information_schema.rs: ## @@ -436,15 +444,40 @@ async fn information_schema_show_table_table_names() { ); } +//#[tokio::

[GitHub] [arrow-datafusion] waitingkuo commented on a diff in pull request #3455: Support ShowVariable Statement

2022-09-12 Thread GitBox
waitingkuo commented on code in PR #3455: URL: https://github.com/apache/arrow-datafusion/pull/3455#discussion_r968907557 ## datafusion/core/src/execution/context.rs: ## @@ -1166,14 +1167,14 @@ impl SessionConfig { /// Create an execution config with config options read fro

[GitHub] [arrow-datafusion] waitingkuo commented on a diff in pull request #3455: Support ShowVariable Statement

2022-09-12 Thread GitBox
waitingkuo commented on code in PR #3455: URL: https://github.com/apache/arrow-datafusion/pull/3455#discussion_r968907557 ## datafusion/core/src/execution/context.rs: ## @@ -1166,14 +1167,14 @@ impl SessionConfig { /// Create an execution config with config options read fro

[GitHub] [arrow-datafusion] waitingkuo commented on a diff in pull request #3455: Support ShowVariable Statement

2022-09-12 Thread GitBox
waitingkuo commented on code in PR #3455: URL: https://github.com/apache/arrow-datafusion/pull/3455#discussion_r968906952 ## datafusion/core/src/execution/context.rs: ## @@ -1130,7 +1131,7 @@ pub struct SessionConfig { /// Should DataFusion parquet reader using the predicat

[GitHub] [arrow-datafusion] waitingkuo commented on a diff in pull request #3455: Support ShowVariable Statement

2022-09-12 Thread GitBox
waitingkuo commented on code in PR #3455: URL: https://github.com/apache/arrow-datafusion/pull/3455#discussion_r968905053 ## datafusion/core/src/catalog/information_schema.rs: ## @@ -579,3 +613,45 @@ impl From for MemTable { MemTable::try_new(schema, vec![vec![batch]]).

[GitHub] [arrow-datafusion] waitingkuo commented on a diff in pull request #3455: Support ShowVariable Statement

2022-09-12 Thread GitBox
waitingkuo commented on code in PR #3455: URL: https://github.com/apache/arrow-datafusion/pull/3455#discussion_r968901165 ## datafusion/core/src/catalog/information_schema.rs: ## @@ -141,6 +154,12 @@ impl InformationSchemaProvider { COLUMNS, Tab

[GitHub] [arrow-datafusion] waitingkuo opened a new pull request, #3455: Support ShowVariable Statement

2022-09-12 Thread GitBox
waitingkuo opened a new pull request, #3455: URL: https://github.com/apache/arrow-datafusion/pull/3455 # Which issue does this PR close? Closes #3364 # Rationale for this change To Support ShowVariable # What changes are included in this PR?

[GitHub] [arrow-datafusion] ursabot commented on pull request #3450: Add `InList` support for timestamp type. (#3449)

2022-09-12 Thread GitBox
ursabot commented on PR #3450: URL: https://github.com/apache/arrow-datafusion/pull/3450#issuecomment-1244356615 Benchmark runs are scheduled for baseline = f48a9971bb4822427395d641c071b7ea825ec496 and contender = 17f069df4227b837cf2741a545c39a8b68d5fd76. 17f069df4227b837cf2741a545c39a8b6

[GitHub] [arrow] lidavidm commented on pull request #13800: ARROW-7744: [Java][FlightRPC] JDBC Driver for Arrow Flight SQL

2022-09-12 Thread GitBox
lidavidm commented on PR #13800: URL: https://github.com/apache/arrow/pull/13800#issuecomment-1244350837 Great, CI looks good now (minus known extant issues). I'll give this a final review soon -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow-datafusion] alamb merged pull request #3450: Add `InList` support for timestamp type. (#3449)

2022-09-12 Thread GitBox
alamb merged PR #3450: URL: https://github.com/apache/arrow-datafusion/pull/3450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow-datafusion] alamb closed issue #3449: Support timestamp data type in In_list node

2022-09-12 Thread GitBox
alamb closed issue #3449: Support timestamp data type in In_list node URL: https://github.com/apache/arrow-datafusion/issues/3449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow] lidavidm commented on pull request #14069: ARROW-17645: [CI] Get conda-integration building again

2022-09-12 Thread GitBox
lidavidm commented on PR #14069: URL: https://github.com/apache/arrow/pull/14069#issuecomment-1244344740 Hmm, it failed, but I see it didn't install the most updated zlib…trying again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] ksuarez1423 commented on a diff in pull request #13859: ARROW-17377: [C++][Docs] Adds tutorial for basic Arrow, file access, compute, and datasets

2022-09-12 Thread GitBox
ksuarez1423 commented on code in PR #13859: URL: https://github.com/apache/arrow/pull/13859#discussion_r968883053 ## docs/source/cpp/tutorials/io_tutorial.rst: ## @@ -0,0 +1,404 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor license agr

[GitHub] [arrow] save-buffer commented on a diff in pull request #13669: ARROW-16389: [C++][Acero] Add spilling for hash join

2022-09-12 Thread GitBox
save-buffer commented on code in PR #13669: URL: https://github.com/apache/arrow/pull/13669#discussion_r968875073 ## cpp/src/arrow/compute/exec/spilling_join.cc: ## @@ -0,0 +1,351 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

  1   2   3   4   >