jayzhan211 commented on code in PR #8849:
URL: https://github.com/apache/arrow-datafusion/pull/8849#discussion_r1451371442
##
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##
@@ -438,6 +443,207 @@ where
}
}
+#[derive(Debug)]
+struct StringDistinctCountAccumul
jayzhan211 commented on code in PR #8849:
URL: https://github.com/apache/arrow-datafusion/pull/8849#discussion_r1451371442
##
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##
@@ -438,6 +443,207 @@ where
}
}
+#[derive(Debug)]
+struct StringDistinctCountAccumul
jayzhan211 commented on code in PR #8849:
URL: https://github.com/apache/arrow-datafusion/pull/8849#discussion_r1451368176
##
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##
@@ -438,6 +443,207 @@ where
}
}
+#[derive(Debug)]
+struct StringDistinctCountAccumul
jayzhan211 commented on code in PR #8849:
URL: https://github.com/apache/arrow-datafusion/pull/8849#discussion_r1451367123
##
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##
@@ -152,6 +155,8 @@ impl AggregateExpr for DistinctCount {
Float32 => float_dis
jayzhan211 commented on code in PR #8849:
URL: https://github.com/apache/arrow-datafusion/pull/8849#discussion_r1451362513
##
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##
@@ -438,6 +443,207 @@ where
}
}
+#[derive(Debug)]
+struct StringDistinctCountAccumul
jayzhan211 commented on code in PR #8849:
URL: https://github.com/apache/arrow-datafusion/pull/8849#discussion_r1451362225
##
datafusion/physical-expr/src/aggregate/count_distinct.rs:
##
@@ -438,6 +443,207 @@ where
}
}
+#[derive(Debug)]
+struct StringDistinctCountAccumul
caicancai commented on PR #8818:
URL:
https://github.com/apache/arrow-datafusion/pull/8818#issuecomment-1890353048
> Thanks for double checking `now()` is in `timestamp.slt`, I also verified
that and looks like test in slt for now is enough, and now I'm wondering if we
still need `timestam
conbench-apache-arrow[bot] commented on PR #39502:
URL: https://github.com/apache/arrow/pull/39502#issuecomment-1890351297
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit c78a1aeb2e328cfee713f615a5e52784866725a5.
There was 1 b
github-actions[bot] commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890350887
Revision: 12c7b481e9f0a6ef32c863f0b4a701f3ff446540
Submitted crossbow builds: [ursacomputing/crossbow @
actions-c4cfb415d6](https://github.com/ursacomputing/crossbow/bra
conbench-apache-arrow[bot] commented on PR #38995:
URL: https://github.com/apache/arrow/pull/38995#issuecomment-1890350779
After merging your PR, Conbench analyzed the 5 benchmarking runs that have
been run so far on merge-commit 1a622ec18c154157341ae2562dda3b0df26550f8.
There were no
jduo commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890350424
@github-actions crossbow submit *java-jars*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jayzhan211 opened a new pull request, #8849:
URL: https://github.com/apache/arrow-datafusion/pull/8849
## Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/issues/5472
Follow up on https://github.com/apache/arrow-datafusion/pull/8721
#
matthewgapp commented on PR #8828:
URL:
https://github.com/apache/arrow-datafusion/pull/8828#issuecomment-1890341147
> > I think some tests need updating to get the CI run clean here
>
>
>
> Yeah, this is still a draft, so not quite ready for CI. I'm going to be
readying thes
manoj-inukolunu commented on issue #8456:
URL:
https://github.com/apache/arrow-datafusion/issues/8456#issuecomment-1890338100
Hello @alamb , I attempted a fix for this . `row_group_metadata.columns()`
is returning the fields in structs as top level columns but with an additional
path . So
manoj-inukolunu opened a new pull request, #8848:
URL: https://github.com/apache/arrow-datafusion/pull/8848
## Which issue does this PR close?
Closes #8456
## Rationale for this change
## What changes are included in this PR?
The issue is in thi
Weijun-H commented on PR #8829:
URL:
https://github.com/apache/arrow-datafusion/pull/8829#issuecomment-1890335568
stalled until #8847 fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Weijun-H opened a new pull request, #8847:
URL: https://github.com/apache/arrow-datafusion/pull/8847
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes test
conbench-apache-arrow[bot] commented on PR #39570:
URL: https://github.com/apache/arrow/pull/39570#issuecomment-1890291248
After merging your PR, Conbench analyzed the 6 benchmarking runs that have
been run so far on merge-commit 8149c390276c2f4d4e0031cd162b4498825f9062.
There was 1 b
jayzhan211 opened a new issue, #8846:
URL: https://github.com/apache/arrow-datafusion/issues/8846
I know I'm coming in a little late, but have we considered
instead making the type `Scalar>`? ([Scalar being the
one in arrow-rs](https://docs.rs/arrow/latest/arrow/array/struct.S
github-actions[bot] commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890282915
Revision: 89d20725f91308ae5e0974c4ab17f6ece05b11a6
Submitted crossbow builds: [ursacomputing/crossbow @
actions-51fc5aeb1e](https://github.com/ursacomputing/crossbow/bra
jduo commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890281690
@github-actions crossbow submit *java-jars*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
waynexia merged PR #8843:
URL: https://github.com/apache/arrow-datafusion/pull/8843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@a
waynexia commented on PR #8843:
URL:
https://github.com/apache/arrow-datafusion/pull/8843#issuecomment-1890274529
Thanks for your review @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jayzhan211 commented on code in PR #8827:
URL: https://github.com/apache/arrow-datafusion/pull/8827#discussion_r1451121291
##
datafusion/physical-plan/src/aggregates/group_values/binary.rs:
##
@@ -0,0 +1,258 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// o
jayzhan211 commented on code in PR #8829:
URL: https://github.com/apache/arrow-datafusion/pull/8829#discussion_r1451077923
##
datafusion/physical-expr/src/array_expressions.rs:
##
@@ -702,15 +721,75 @@ where
if let (Some(from), Some(to)) = (from_index, to_index) {
jayzhan211 commented on code in PR #8829:
URL: https://github.com/apache/arrow-datafusion/pull/8829#discussion_r1451077923
##
datafusion/physical-expr/src/array_expressions.rs:
##
@@ -702,15 +721,75 @@ where
if let (Some(from), Some(to)) = (from_index, to_index) {
matthewgapp commented on code in PR #8840:
URL: https://github.com/apache/arrow-datafusion/pull/8840#discussion_r1451077021
##
datafusion/sqllogictest/test_files/cte.slt:
##
@@ -19,3 +19,221 @@ query II
select * from (WITH source AS (select 1 as e) SELECT * FROM source) t1,
matthewgapp commented on code in PR #8840:
URL: https://github.com/apache/arrow-datafusion/pull/8840#discussion_r1451077021
##
datafusion/sqllogictest/test_files/cte.slt:
##
@@ -19,3 +19,221 @@ query II
select * from (WITH source AS (select 1 as e) SELECT * FROM source) t1,
github-actions[bot] commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890240046
Revision: 89d20725f91308ae5e0974c4ab17f6ece05b11a6
Submitted crossbow builds: [ursacomputing/crossbow @
actions-282b011acc](https://github.com/ursacomputing/crossbow/bra
jduo commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890239116
@github-actions crossbow submit *java-jars*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
matthewgapp commented on code in PR #8840:
URL: https://github.com/apache/arrow-datafusion/pull/8840#discussion_r1451075785
##
datafusion/sqllogictest/test_files/cte.slt:
##
@@ -19,3 +19,221 @@ query II
select * from (WITH source AS (select 1 as e) SELECT * FROM source) t1,
jayzhan211 commented on code in PR #8829:
URL: https://github.com/apache/arrow-datafusion/pull/8829#discussion_r1451073585
##
datafusion/expr/src/expr_fn.rs:
##
@@ -731,7 +731,7 @@ scalar_expr!(
scalar_expr!(
ArraySlice,
array_slice,
-array offset length,
+arr
jayzhan211 commented on code in PR #8829:
URL: https://github.com/apache/arrow-datafusion/pull/8829#discussion_r1451073585
##
datafusion/expr/src/expr_fn.rs:
##
@@ -731,7 +731,7 @@ scalar_expr!(
scalar_expr!(
ArraySlice,
array_slice,
-array offset length,
+arr
paleolimbot merged PR #363:
URL: https://github.com/apache/arrow-nanoarrow/pull/363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@a
paleolimbot closed issue #362: [r] Compiler nag on 'pessimizing move' from
`nanoarrow_testing.hpp`
URL: https://github.com/apache/arrow-nanoarrow/issues/362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
paleolimbot commented on PR #363:
URL: https://github.com/apache/arrow-nanoarrow/pull/363#issuecomment-1890233667
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
yyy1000 commented on PR #8780:
URL:
https://github.com/apache/arrow-datafusion/pull/8780#issuecomment-1890224140
Well, I tried to fix the CI-error, but it's harder than I thought. :(
Now the problem is `on`, the two columns in Join, would change but some
functions still pass left and rig
conbench-apache-arrow[bot] commented on PR #39380:
URL: https://github.com/apache/arrow/pull/39380#issuecomment-1890189969
After merging your PR, Conbench analyzed the 6 benchmarking runs that have
been run so far on merge-commit 6fe7480125b7fdb3a000a27fcc9cf464697b8a60.
There were no
sam-goodwin commented on issue #37880:
URL: https://github.com/apache/arrow/issues/37880#issuecomment-1890183194
I am still experiencing problems trying to install pyarrow in a python 3.12
environment:
```Dockerfile
FROM python:3.12.1-alpine3.19
RUN apk update && apk upgrade
github-actions[bot] commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890183155
Revision: 15a79e6b28624b0349a615c26ebc7b6dd8f66927
Submitted crossbow builds: [ursacomputing/crossbow @
actions-65584ca260](https://github.com/ursacomputing/crossbow/bra
jduo commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890182032
@github-actions crossbow submit *java-jars*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
github-actions[bot] commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890144820
Revision: 06b30a3d2c5acd4a35e4430a305199865241ef4a
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1ce5fd1bb0](https://github.com/ursacomputing/crossbow/bra
jduo commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890143548
@github-actions crossbow submit *java-jars*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
assignUser commented on code in PR #39587:
URL: https://github.com/apache/arrow/pull/39587#discussion_r1451025943
##
r/tools/nixlibs.R:
##
@@ -96,53 +96,76 @@ try_download <- function(from_url, to_file, hush = quietly)
{
!inherits(status, "try-error") && status == 0
}
-do
matthewgapp commented on code in PR #8840:
URL: https://github.com/apache/arrow-datafusion/pull/8840#discussion_r1451015265
##
datafusion/sqllogictest/test_files/cte.slt:
##
@@ -19,3 +19,221 @@ query II
select * from (WITH source AS (select 1 as e) SELECT * FROM source) t1,
matthewgapp commented on code in PR #8840:
URL: https://github.com/apache/arrow-datafusion/pull/8840#discussion_r1451015265
##
datafusion/sqllogictest/test_files/cte.slt:
##
@@ -19,3 +19,221 @@ query II
select * from (WITH source AS (select 1 as e) SELECT * FROM source) t1,
github-actions[bot] commented on PR #39587:
URL: https://github.com/apache/arrow/pull/39587#issuecomment-1890114034
Revision: bacfdbe193eb3a1c10ab0076a4532b693cedeedf
Submitted crossbow builds: [ursacomputing/crossbow @
actions-f46bb07c50](https://github.com/ursacomputing/crossbow/bra
assignUser commented on code in PR #39587:
URL: https://github.com/apache/arrow/pull/39587#discussion_r1451000629
##
r/tools/nixlibs.R:
##
@@ -539,10 +562,25 @@ build_libarrow <- function(src_dir, dst_dir) {
env_var_list <- c(env_var_list, ARROW_DEPENDENCY_SOURCE = "BUNDLED
assignUser commented on PR #39587:
URL: https://github.com/apache/arrow/pull/39587#issuecomment-1890109540
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jonkeane opened a new pull request, #39591:
URL: https://github.com/apache/arrow/pull/39591
I noticed a few docs that needed cleaning up when running make commands
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
assignUser commented on issue #39590:
URL: https://github.com/apache/arrow/issues/39590#issuecomment-1890089688
cc @kou
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890086233
Revision: 06b30a3d2c5acd4a35e4430a305199865241ef4a
Submitted crossbow builds: [ursacomputing/crossbow @
actions-96a5ed055f](https://github.com/ursacomputing/crossbow/bra
drin commented on PR #13487:
URL: https://github.com/apache/arrow/pull/13487#issuecomment-1890084716
I may have to do a new PR; it seems that manually cherry picking changes
(but not the commits themselves) perhaps resolves to the same commit hashes and
git thinks the branches are the same
jduo commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890084159
@github-actions crossbow submit *java-jars*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
comphead commented on code in PR #8829:
URL: https://github.com/apache/arrow-datafusion/pull/8829#discussion_r1450989851
##
datafusion/physical-expr/src/array_expressions.rs:
##
@@ -702,15 +721,75 @@ where
if let (Some(from), Some(to)) = (from_index, to_index) {
alamb commented on code in PR #8842:
URL: https://github.com/apache/arrow-datafusion/pull/8842#discussion_r1450985891
##
datafusion/expr/src/window_frame.rs:
##
@@ -30,21 +30,24 @@ use sqlparser::ast;
use sqlparser::parser::ParserError::ParserError;
use std::convert::{From, Tr
comphead commented on code in PR #8829:
URL: https://github.com/apache/arrow-datafusion/pull/8829#discussion_r1450989061
##
datafusion/physical-expr/src/array_expressions.rs:
##
@@ -680,6 +689,16 @@ where
let end = offset_window[1];
let len = end - start;
+
matthewgapp commented on code in PR #8840:
URL: https://github.com/apache/arrow-datafusion/pull/8840#discussion_r1450987751
##
datafusion/sqllogictest/test_files/cte.slt:
##
@@ -19,3 +19,221 @@ query II
select * from (WITH source AS (select 1 as e) SELECT * FROM source) t1,
github-actions[bot] commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890075062
Revision: 28a4068e865dad5deef37028c39b32758723f6f5
Submitted crossbow builds: [ursacomputing/crossbow @
actions-354d5182de](https://github.com/ursacomputing/crossbow/bra
jduo commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890071459
@github-actions crossbow submit *java-jars*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
alamb commented on code in PR #8843:
URL: https://github.com/apache/arrow-datafusion/pull/8843#discussion_r1450983565
##
datafusion/wasmtest/Cargo.toml:
##
@@ -37,11 +37,14 @@ crate-type = ["cdylib", "rlib",]
# all the `std::fmt` and `std::panicking` infrastructure, so isn't gr
comphead merged PR #8823:
URL: https://github.com/apache/arrow-datafusion/pull/8823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@a
kou commented on code in PR #39587:
URL: https://github.com/apache/arrow/pull/39587#discussion_r1450981390
##
r/inst/build_arrow_static.sh:
##
@@ -74,6 +74,8 @@ ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-DARROW_DATASET=${ARROW_DATASET:-ON} \
-DARROW_DEPENDENCY_SOURCE=${A
alamb merged PR #8834:
URL: https://github.com/apache/arrow-datafusion/pull/8834
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
alamb closed issue #8202: Port tests in `group_by.rs` to sqllogictest
URL: https://github.com/apache/arrow-datafusion/issues/8202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alamb merged PR #8802:
URL: https://github.com/apache/arrow-datafusion/pull/8802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
matthewgapp commented on code in PR #8840:
URL: https://github.com/apache/arrow-datafusion/pull/8840#discussion_r1450974585
##
datafusion/sqllogictest/test_files/cte.slt:
##
@@ -19,3 +19,221 @@ query II
select * from (WITH source AS (select 1 as e) SELECT * FROM source) t1,
github-actions[bot] commented on PR #39589:
URL: https://github.com/apache/arrow/pull/39589#issuecomment-1890049915
Revision: 502f666f0829f9cc195cf5f94ec439accb2fa8d4
Submitted crossbow builds: [ursacomputing/crossbow @
actions-a83fa6958a](https://github.com/ursacomputing/crossbow/bra
github-actions[bot] commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890046981
Revision: b1da94f6ffb9c5e24ac84a6302c0bb7a9d59d02c
Submitted crossbow builds: [ursacomputing/crossbow @
actions-9ed9447345](https://github.com/ursacomputing/crossbow/bra
github-actions[bot] commented on PR #39589:
URL: https://github.com/apache/arrow/pull/39589#issuecomment-1890046210
:warning: GitHub issue #39588 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
raulcd commented on PR #39589:
URL: https://github.com/apache/arrow/pull/39589#issuecomment-1890047172
@github-actions crossbow submit verify-rc-source-integration-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450967434
##
datafusion/physical-plan/src/aggregates/mod.rs:
##
@@ -1746,6 +1746,7 @@ mod tests {
}
#[tokio::test]
+#[ignore]
Review Comment:
I don't t
jduo commented on PR #39221:
URL: https://github.com/apache/arrow/pull/39221#issuecomment-1890044412
@github-actions crossbow submit *java-jars*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
alamb commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450967210
##
datafusion/sqllogictest/test_files/repartition_scan.slt:
##
@@ -138,7 +138,7 @@ physical_plan
SortPreservingMergeExec: [column1@0 ASC NULLS LAST]
--Coalesce
raulcd commented on issue #39588:
URL: https://github.com/apache/arrow/issues/39588#issuecomment-1890028147
This is affecting the maintenance branch for 15.0.0 but it does seem to be
an issue with the verification script and doesn't seem to be a blocker for the
release in my opinion.
--
github-actions[bot] commented on PR #39589:
URL: https://github.com/apache/arrow/pull/39589#issuecomment-1890023953
Revision: 502f666f0829f9cc195cf5f94ec439accb2fa8d4
Submitted crossbow builds: [ursacomputing/crossbow @
actions-3e60a461c3](https://github.com/ursacomputing/crossbow/bra
raulcd opened a new pull request, #39589:
URL: https://github.com/apache/arrow/pull/39589
DO NOT MERGE
### Rationale for this change
### What changes are included in this PR?
### Are these changes tested?
### Are there any user-facing ch
raulcd commented on PR #39589:
URL: https://github.com/apache/arrow/pull/39589#issuecomment-1890013778
@github-actions crossbow submit
verify-rc-source-integration-macos-conda-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
alamb commented on issue #8786:
URL:
https://github.com/apache/arrow-datafusion/issues/8786#issuecomment-1889995563
Review Queue:
DataFusion
- [ ] https://github.com/apache/arrow-datafusion/pull/8835
- [ ] https://github.com/apache/arrow-datafusion/pull/8780
- [ ] https://git
tustvold commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450949881
##
datafusion/physical-plan/src/aggregates/mod.rs:
##
@@ -1746,6 +1746,7 @@ mod tests {
}
#[tokio::test]
+#[ignore]
Review Comment:
We cha
tustvold commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450949881
##
datafusion/physical-plan/src/aggregates/mod.rs:
##
@@ -1746,6 +1746,7 @@ mod tests {
}
#[tokio::test]
+#[ignore]
Review Comment:
We cha
tustvold commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450949881
##
datafusion/physical-plan/src/aggregates/mod.rs:
##
@@ -1746,6 +1746,7 @@ mod tests {
}
#[tokio::test]
+#[ignore]
Review Comment:
We cha
tustvold commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450947672
##
datafusion/sqllogictest/test_files/repartition_scan.slt:
##
@@ -138,7 +138,7 @@ physical_plan
SortPreservingMergeExec: [column1@0 ASC NULLS LAST]
--Coale
alamb opened a new issue, #8845:
URL: https://github.com/apache/arrow-datafusion/issues/8845
### Describe the bug
sqllogic
```
External error: query result mismatch:
[SQL] select trace_id, other, MIN(timestamp) from traces group by trace_id,
other order by MIN(timestamp) asc
alamb commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450946231
##
datafusion-cli/src/exec.rs:
##
@@ -340,13 +340,10 @@ mod tests {
let session_token = "fake_session_token";
let location = "s3://bucket/path/
thisisnic commented on code in PR #39587:
URL: https://github.com/apache/arrow/pull/39587#discussion_r1450946941
##
r/tools/nixlibs.R:
##
@@ -539,10 +562,25 @@ build_libarrow <- function(src_dir, dst_dir) {
env_var_list <- c(env_var_list, ARROW_DEPENDENCY_SOURCE = "BUNDLED"
alamb commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450942251
##
benchmarks/Cargo.toml:
##
@@ -29,7 +29,6 @@ rust-version = "1.70"
[features]
ci = []
default = ["mimalloc"]
-simd = ["datafusion/simd"]
Review Comment:
raulcd commented on PR #39545:
URL: https://github.com/apache/arrow/pull/39545#issuecomment-1889979579
Revision: 69174f873b4ff66c9e36d1622d45809531b12c33
Submitted crossbow builds: [ursacomputing/crossbow @
maint-15-nightly-verification-0](https://github.com/ursacomputing/crossbow/bra
conbench-apache-arrow[bot] commented on PR #39245:
URL: https://github.com/apache/arrow/pull/39245#issuecomment-1889978799
After merging your PR, Conbench analyzed the 6 benchmarking runs that have
been run so far on merge-commit 2b4a70320232647f730b19d2fea5746c3baec752.
There were no
codecov-commenter commented on PR #363:
URL: https://github.com/apache/arrow-nanoarrow/pull/363#issuecomment-1889975718
##
[Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/363?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_t
raulcd commented on PR #39545:
URL: https://github.com/apache/arrow/pull/39545#issuecomment-1889975601
Revision: 69174f873b4ff66c9e36d1622d45809531b12c33
Submitted crossbow builds: [ursacomputing/crossbow @
maint-15.0.0-nightly-packaging-1](https://github.com/ursacomputing/crossbow/br
alamb commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450941776
##
datafusion/physical-plan/src/aggregates/mod.rs:
##
@@ -1746,6 +1746,7 @@ mod tests {
}
#[tokio::test]
+#[ignore]
Review Comment:
I adjuste
raulcd commented on PR #39545:
URL: https://github.com/apache/arrow/pull/39545#issuecomment-1889973645
Revision: 69174f873b4ff66c9e36d1622d45809531b12c33
Submitted crossbow builds: [ursacomputing/crossbow @
maint-15.0.0-nightly-tests-1](https://github.com/ursacomputing/crossbow/branch
eddelbuettel opened a new pull request, #363:
URL: https://github.com/apache/arrow-nanoarrow/pull/363
As discussed in #362, we see a nag from `g++` 13.2.0 about a 'pessimizing
move' from this `std::move` and the compiler itself suggests removing it. Did
so, and did not tickle a valgrind is
raulcd merged PR #39580:
URL: https://github.com/apache/arrow/pull/39580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
paleolimbot commented on code in PR #39455:
URL: https://github.com/apache/arrow/pull/39455#discussion_r1450935696
##
cpp/src/arrow/c/bridge.cc:
##
@@ -2152,6 +2211,27 @@ class ArrayStreamBatchReader : public RecordBatchReader {
}
private:
+ template
Review Comment:
eddelbuettel commented on issue #362:
URL:
https://github.com/apache/arrow-nanoarrow/issues/362#issuecomment-1889966373
Will do -- and would have done immediately but wasn't sure if the
`std::move()` there was on purpose (hence my quick attempt at `valgrind` and I
_think_ that is in the co
alamb commented on code in PR #8758:
URL: https://github.com/apache/arrow-datafusion/pull/8758#discussion_r1450934801
##
datafusion/core/Cargo.toml:
##
@@ -47,7 +47,6 @@ parquet = ["datafusion-common/parquet", "dep:parquet"]
pyarrow = ["datafusion-common/pyarrow", "parquet"]
r
paleolimbot commented on issue #362:
URL:
https://github.com/apache/arrow-nanoarrow/issues/362#issuecomment-1889963400
Thanks for reporting! A PR would be great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
yyy1000 commented on PR #8780:
URL:
https://github.com/apache/arrow-datafusion/pull/8780#issuecomment-1889945163
Ah, I believe the CI fails just because the test cases need to be changed
due to `bigger names would be in the front`, I could do that then.
--
This is an automated message fr
1 - 100 of 247 matches
Mail list logo
