qifanzhang-ms commented on PR #2698:
URL: https://github.com/apache/arrow-adbc/pull/2698#issuecomment-2814654287
> I feel like I don't entirely understand this change, so it would be nice
to get a little more explanation.
>
> Today, there's a limitation in ADBC which prevents a single
wgtmac commented on code in PR #45459:
URL: https://github.com/apache/arrow/pull/45459#discussion_r2050086670
##
cpp/src/parquet/geospatial/statistics.h:
##
@@ -0,0 +1,165 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
alamb commented on issue #7415:
URL: https://github.com/apache/arrow-rs/issues/7415#issuecomment-2814012589
Thank you @zhuqi-lucas -- I also added this to the ticket where we are
organizing the work:
- https://github.com/apache/arrow-rs/issues/7363
--
This is an automated message from
alamb commented on PR #329:
URL:
https://github.com/apache/arrow-rs-object-store/pull/329#issuecomment-2813970378
Thanks again everyone. From my perspective this PR is ready to merge but I
want to leave it open for another day or two to allow more time for comments.
I'll be away next week
alamb commented on code in PR #7404:
URL: https://github.com/apache/arrow-rs/pull/7404#discussion_r2049641522
##
arrow-array/src/array/variant_array.rs:
##
@@ -0,0 +1,628 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
conbench-apache-arrow[bot] commented on PR #46176:
URL: https://github.com/apache/arrow/pull/46176#issuecomment-2814504960
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit c2ec1cda88918a3920b7b29eca8d2e3ca7a49fb2.
There were no
alamb commented on PR #322:
URL:
https://github.com/apache/arrow-rs-object-store/pull/322#issuecomment-2813971929
Thanks @tustvold and @kylebarron
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
zanmato1984 commented on code in PR #46124:
URL: https://github.com/apache/arrow/pull/46124#discussion_r2049948899
##
cpp/src/arrow/compute/row/compare_internal.cc:
##
@@ -276,7 +276,8 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper(
int32_t tail_length = length - j
zanmato1984 commented on PR #46124:
URL: https://github.com/apache/arrow/pull/46124#issuecomment-2814416656
OK, I did some [experiments](https://godbolt.org/z/vhcGY3xhd) that can
further justify this fix. This experiment proves that merely changing the
pointer type passed into `std::memcpy`
alamb closed issue #302: Enable anonymous access to GCS buckets
URL: https://github.com/apache/arrow-rs-object-store/issues/302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
zeroshade commented on code in PR #357:
URL: https://github.com/apache/arrow-go/pull/357#discussion_r2049733390
##
parquet/compress/compress_test.go:
##
@@ -138,3 +138,23 @@ func TestCompressReaderWriter(t *testing.T) {
})
}
}
+
+func TestMarshalText(t *
etseidl commented on code in PR #7404:
URL: https://github.com/apache/arrow-rs/pull/7404#discussion_r2049744027
##
arrow-array/src/array/variant_array.rs:
##
@@ -0,0 +1,628 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreemen
github-actions[bot] commented on PR #46124:
URL: https://github.com/apache/arrow/pull/46124#issuecomment-2814172114
Revision: 07d758253c472f5b6d080a41b01bb7576296dc8e
Submitted crossbow builds: [ursacomputing/crossbow @
actions-bccc2b44c0](https://github.com/ursacomputing/crossbow/bra
alexguo-db commented on PR #2692:
URL: https://github.com/apache/arrow-adbc/pull/2692#issuecomment-2814170286
> Thanks! Out of curiosity, would we still need this feature if it were
possible to reliably execute multiple statements in a single batch?
Yes, because we still need the abil
jonkeane commented on PR #46124:
URL: https://github.com/apache/arrow/pull/46124#issuecomment-2814169343
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
alexguo-db commented on code in PR #2692:
URL: https://github.com/apache/arrow-adbc/pull/2692#discussion_r2049734661
##
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##
@@ -86,9 +100,70 @@ protected override TOpenSessionReq CreateSessionRequest()
Client
zanmato1984 commented on code in PR #46124:
URL: https://github.com/apache/arrow/pull/46124#discussion_r2049712392
##
cpp/src/arrow/compute/row/compare_internal.cc:
##
@@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper(
int32_t tail_length = length -
kou commented on code in PR #46176:
URL: https://github.com/apache/arrow/pull/46176#discussion_r2049676468
##
.github/CODEOWNERS:
##
@@ -38,6 +38,7 @@
/java/ @lidavidm
/js/ @domoritz @trxcllnt
/matlab/ @kevingurney @kou @sgilmore10
+/python/ @raulcd @rok @AlenkaF
Review Com
kou merged PR #46176:
URL: https://github.com/apache/arrow/pull/46176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
alamb merged PR #322:
URL: https://github.com/apache/arrow-rs-object-store/pull/322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@a
jonkeane commented on code in PR #46124:
URL: https://github.com/apache/arrow/pull/46124#discussion_r2049633851
##
cpp/src/arrow/compute/row/compare_internal.cc:
##
@@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper(
int32_t tail_length = length - j
alamb commented on issue #14:
URL:
https://github.com/apache/arrow-rs-object-store/issues/14#issuecomment-2813996094
Chunked Reads as requested in this ticket is similar
- https://github.com/apache/arrow-rs-object-store/issues/274
--
This is an automated message from the Apache Git Ser
zanmato1984 commented on code in PR #46124:
URL: https://github.com/apache/arrow/pull/46124#discussion_r2049626926
##
cpp/src/arrow/compute/row/compare_internal.cc:
##
@@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper(
int32_t tail_length = length -
alamb commented on PR #332:
URL:
https://github.com/apache/arrow-rs-object-store/pull/332#issuecomment-2813974107
I am out starting tomorrow for a week, so if another committer doesn't merge
this before I will do so when I get back
Thanks again @ion-elgreco
--
This is an automate
github-actions[bot] commented on PR #46124:
URL: https://github.com/apache/arrow/pull/46124#issuecomment-2813939255
Revision: 07d758253c472f5b6d080a41b01bb7576296dc8e
Submitted crossbow builds: [ursacomputing/crossbow @
actions-798e0f8cd9](https://github.com/ursacomputing/crossbow/bra
alamb merged PR #7418:
URL: https://github.com/apache/arrow-rs/pull/7418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
alamb closed issue #7417: Implement `Eq` and `Default` for `OffsetBuffer`
URL: https://github.com/apache/arrow-rs/issues/7417
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
alamb commented on PR #7418:
URL: https://github.com/apache/arrow-rs/pull/7418#issuecomment-2813924273
Looks good to me too -- thanks @kylebarron and @mbrobbel ❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
zanmato1984 commented on code in PR #46124:
URL: https://github.com/apache/arrow/pull/46124#discussion_r2049525910
##
cpp/src/arrow/compute/row/compare_internal.cc:
##
@@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper(
int32_t tail_length = length -
zanmato1984 commented on code in PR #46124:
URL: https://github.com/apache/arrow/pull/46124#discussion_r2049525910
##
cpp/src/arrow/compute/row/compare_internal.cc:
##
@@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper(
int32_t tail_length = length -
thisisnic commented on code in PR #45818:
URL: https://github.com/apache/arrow/pull/45818#discussion_r2049405787
##
python/pyarrow/tests/test_scalars.py:
##
@@ -555,17 +560,23 @@ def test_binary(value, ty, scalar_typ):
assert str(s) == str(value)
assert repr(value) in
himadripal commented on PR #7179:
URL: https://github.com/apache/arrow-rs/pull/7179#issuecomment-2812785023
An update on this issue, its taking longer than I expected,
after I replace `base.pow_wrapping()` calls with POW10[...], many of the
conversion used in benchmark improved by 45
zeroshade merged PR #2712:
URL: https://github.com/apache/arrow-adbc/pull/2712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.
rok commented on issue #45531:
URL: https://github.com/apache/arrow/issues/45531#issuecomment-2813706373
Issue resolved by pull request 46170
https://github.com/apache/arrow/pull/46170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rok merged PR #46170:
URL: https://github.com/apache/arrow/pull/46170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
sfc-gh-jmichalak commented on issue #32:
URL: https://github.com/apache/arrow-go/issues/32#issuecomment-2813203376
Hi,
Such errors can still happen on 32-bit platforms
([reference](https://github.com/snowflakedb/terraform-provider-snowflake/issues/3474#issuecomment-2803412001)),
eve
thisisnic commented on PR #45818:
URL: https://github.com/apache/arrow/pull/45818#issuecomment-2813650208
OK, still got unpacking to implement, but this is getting there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kylebarron opened a new pull request, #7418:
URL: https://github.com/apache/arrow-rs/pull/7418
# Which issue does this PR close?
Closes #7417.
# Rationale for this change
Follow up after https://github.com/apache/arrow-rs/issues/7411.
# What changes are included i
conbench-apache-arrow[bot] commented on PR #46175:
URL: https://github.com/apache/arrow/pull/46175#issuecomment-2813508281
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 06b693defcd9edfd005fcc4abb20f3cb93ad0e73.
There were no
PinkCrow007 commented on code in PR #7404:
URL: https://github.com/apache/arrow-rs/pull/7404#discussion_r2049303185
##
arrow-array/src/array/variant_array.rs:
##
@@ -0,0 +1,628 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
yyossy5 commented on PR #46170:
URL: https://github.com/apache/arrow/pull/46170#issuecomment-2813471967
Thank you @rok !
> A minor ask: could we add a check like:
>
> ```python
> tensor_array_from_numpy = pa.FixedShapeTensorArray.from_numpy_ndarray(arr)
> assert tensor_ar
jonkeane commented on code in PR #46124:
URL: https://github.com/apache/arrow/pull/46124#discussion_r2048857300
##
cpp/src/arrow/compute/light_array_internal.cc:
##
@@ -615,7 +615,9 @@ Status ExecBatchBuilder::AppendSelected(const
std::shared_ptr& source
target
thomascjohnson commented on issue #282:
URL:
https://github.com/apache/arrow-rs-object-store/issues/282#issuecomment-2813466311
@andreasbros you saved me a lot of effort! I've been stuck on some other
problems the past few months but wanted to get back around to this when I
started scaling
zeroshade commented on issue #32:
URL: https://github.com/apache/arrow-go/issues/32#issuecomment-2813222819
That would likely be fixed by https://github.com/apache/arrow-go/pull/326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
andreasbros commented on issue #282:
URL:
https://github.com/apache/arrow-rs-object-store/issues/282#issuecomment-2813453385
@thomascjohnson @tustvold I have tested this change in real k8s environment
and can confirm that credential retrieval using EKS Pod Identity is working.
#333 is read
conbench-apache-arrow[bot] commented on PR #46171:
URL: https://github.com/apache/arrow/pull/46171#issuecomment-2813401454
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 831b5f034422f01aef3396bc77b1718fc48d2de6.
There were no
rok commented on PR #46170:
URL: https://github.com/apache/arrow/pull/46170#issuecomment-2813377286
Thanks for working on this @yyossy5!
This looks good. A minor ask: could we add a check like:
```python
tensor_array_from_numpy = pa.FixedShapeTensorArray.from_numpy_ndarray(arr)
github-actions[bot] commented on PR #45854:
URL: https://github.com/apache/arrow/pull/45854#issuecomment-2813378287
Revision: 71d36133dcb2000dc7b01b5d687dd7bb1f395e72
Submitted crossbow builds: [ursacomputing/crossbow @
actions-9556f9e16c](https://github.com/ursacomputing/crossbow/bra
WillAyd commented on PR #45854:
URL: https://github.com/apache/arrow/pull/45854#issuecomment-2813371134
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
H-Plus-Time commented on code in PR #329:
URL:
https://github.com/apache/arrow-rs-object-store/pull/329#discussion_r2049147577
##
src/client/connection.rs:
##
@@ -224,6 +224,60 @@ impl HttpService for reqwest::Client {
}
}
+#[async_trait]
+#[cfg(all(target_arch = "wasm3
zeroshade commented on issue #38:
URL: https://github.com/apache/arrow-go/issues/38#issuecomment-2813237723
Hey @jo-me, apologies that this slipped through the cracks.
You should be able to reduce the memory usage by using the read properties
to set `BufferedStreamEnabled` to `true`,
yyossy5 commented on code in PR #46170:
URL: https://github.com/apache/arrow/pull/46170#discussion_r2049144944
##
python/pyarrow/array.pxi:
##
@@ -4655,6 +4657,17 @@ cdef class FixedShapeTensorArray(ExtensionArray):
"Cannot convert 1D array or scalar to fixed sh
kylebarron commented on code in PR #329:
URL:
https://github.com/apache/arrow-rs-object-store/pull/329#discussion_r2049125832
##
src/client/connection.rs:
##
@@ -224,6 +224,60 @@ impl HttpService for reqwest::Client {
}
}
+#[async_trait]
+#[cfg(all(target_arch = "wasm32
paleolimbot commented on PR #2713:
URL: https://github.com/apache/arrow-adbc/pull/2713#issuecomment-2813193986
This definitely seems correct in the sense that it is statically
communicating the constraints of the ADBC object lifetimes as written in the
spec correctly. It is also true that s
kylebarron commented on issue #290:
URL:
https://github.com/apache/arrow-rs-object-store/issues/290#issuecomment-2813180557
> Hmm... I guess the subsequent creation of the `TokenCredentialProvider`
succeeds too?
Yes, that will never fail.
`ImdsManagedIdentityProvider` can't be
nathaniel-elastiflow commented on PR #6965:
URL: https://github.com/apache/arrow-rs/pull/6965#issuecomment-2813175131
@klion26 I've pushed a fix for this case. It seems Arrow applies an implicit
valid field for the non-nullable `partition`, which has no explicit fields.
--
This is an auto
zeroshade merged PR #2651:
URL: https://github.com/apache/arrow-adbc/pull/2651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.
AlenkaF commented on code in PR #46176:
URL: https://github.com/apache/arrow/pull/46176#discussion_r2049076939
##
.github/CODEOWNERS:
##
@@ -38,6 +38,7 @@
/java/ @lidavidm
/js/ @domoritz @trxcllnt
/matlab/ @kevingurney @kou @sgilmore10
+/python/ @raulcd
Review Comment:
Ye
rok commented on code in PR #46176:
URL: https://github.com/apache/arrow/pull/46176#discussion_r2049061882
##
.github/CODEOWNERS:
##
@@ -38,6 +38,7 @@
/java/ @lidavidm
/js/ @domoritz @trxcllnt
/matlab/ @kevingurney @kou @sgilmore10
+/python/ @raulcd
Review Comment:
Sure!
raulcd commented on code in PR #46176:
URL: https://github.com/apache/arrow/pull/46176#discussion_r2049026976
##
.github/CODEOWNERS:
##
@@ -38,6 +38,7 @@
/java/ @lidavidm
/js/ @domoritz @trxcllnt
/matlab/ @kevingurney @kou @sgilmore10
+/python/ @raulcd
Review Comment:
@ro
raulcd opened a new pull request, #46176:
URL: https://github.com/apache/arrow/pull/46176
### Rationale for this change
Sometimes I miss some Python PRs I could potentially review.
### What changes are included in this PR?
Add myself to codeowners Python to get pinged on
raulcd commented on code in PR #46170:
URL: https://github.com/apache/arrow/pull/46170#discussion_r2048956956
##
python/pyarrow/array.pxi:
##
@@ -4655,6 +4657,17 @@ cdef class FixedShapeTensorArray(ExtensionArray):
"Cannot convert 1D array or scalar to fixed sha
xborder commented on code in PR #2651:
URL: https://github.com/apache/arrow-adbc/pull/2651#discussion_r2048981799
##
docs/source/driver/flight_sql.rst:
##
@@ -159,6 +159,12 @@ few optional authentication schemes:
header will then be sent back as the ``authorization`` header o
alamb commented on PR #7179:
URL: https://github.com/apache/arrow-rs/pull/7179#issuecomment-2812839133
> @alamb would you please share, how did you get the result in tabular
format above?
I am using the `critcmp` tool here: https://github.com/BurntSushi/critcmp
My entire script
alamb commented on PR #7399:
URL: https://github.com/apache/arrow-rs/pull/7399#issuecomment-2812899501
🚀 -- thanks @adamreeve @corwinjoy and @etseidl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
alamb closed issue #7390: Add decryption support for column index and offset
index
URL: https://github.com/apache/arrow-rs/issues/7390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
alamb commented on issue #7227:
URL: https://github.com/apache/arrow-rs/issues/7227#issuecomment-2812872795
There is a nice PR from @H-Plus-Time here:
- https://github.com/apache/arrow-rs-object-store/pull/329
--
This is an automated message from the Apache Git Service.
To respond to t
alamb commented on PR #329:
URL:
https://github.com/apache/arrow-rs-object-store/pull/329#issuecomment-2812870336
FYI @kylebarron could you perhaps take a look at this?
Also, FYI @XiangpengHao
--
This is an automated message from the Apache Git Service.
To respond to the message
alamb commented on code in PR #329:
URL:
https://github.com/apache/arrow-rs-object-store/pull/329#discussion_r2048922084
##
tests/http.rs:
##
@@ -41,3 +44,23 @@ async fn test_http_store_gzip() {
.await
.unwrap();
}
+
+#[cfg(all(feature = "http", target_arch =
zeroshade commented on PR #2712:
URL: https://github.com/apache/arrow-adbc/pull/2712#issuecomment-2812861460
@felipecrv does the existing generated code use the correct path? (Did we
update that without updating the template?)
--
This is an automated message from the Apache Git Service.
T
raulcd commented on PR #46171:
URL: https://github.com/apache/arrow/pull/46171#issuecomment-2810176693
@github-actions crossbow submit ubuntu-r-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jonkeane commented on code in PR #46124:
URL: https://github.com/apache/arrow/pull/46124#discussion_r2048861485
##
cpp/src/arrow/compute/row/compare_internal.cc:
##
@@ -276,12 +276,13 @@ void KeyCompare::CompareVarBinaryColumnToRowHelper(
int32_t tail_length = length - j
schaffman5 commented on issue #29664:
URL: https://github.com/apache/arrow/issues/29664#issuecomment-2812663350
Following up on this issue, it would be great if dictionaries created from
factors could be handled natively with dplyr functions without casting to a
character vector where level
assignUser commented on code in PR #45854:
URL: https://github.com/apache/arrow/pull/45854#discussion_r2048809749
##
ci/scripts/python_sdist_build.sh:
##
@@ -23,5 +23,5 @@ source_dir=${1}/python
pushd ${source_dir}
export SETUPTOOLS_SCM_PRETEND_VERSION=${PYARROW_VERSION:-}
-
WillAyd commented on PR #46175:
URL: https://github.com/apache/arrow/pull/46175#issuecomment-2812617648
Wow nice work @AlenkaF !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
yyossy5 commented on PR #46170:
URL: https://github.com/apache/arrow/pull/46170#issuecomment-2812525229
Thank you for reviewing! @AlenkaF
> The document you linked will be updated automatically by the changes in
this PR, since that section is generated from the docstrings.
Oh,
eitsupi commented on issue #743:
URL:
https://github.com/apache/arrow-nanoarrow/issues/743#issuecomment-2812518381
Thanks for letting me know about that!
I will point it out to the Polars folks.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
CurtHagenlocher merged PR #2710:
URL: https://github.com/apache/arrow-adbc/pull/2710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
emilk closed issue #7411: Implement `Eq` and `Default` for `ScalarBuffer`
URL: https://github.com/apache/arrow-rs/issues/7411
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
assignUser commented on issue #46159:
URL: https://github.com/apache/arrow/issues/46159#issuecomment-2812398850
Issue resolved by pull request 46160
https://github.com/apache/arrow/pull/46160
--
This is an automated message from the Apache Git Service.
To respond to the message, please
assignUser merged PR #46160:
URL: https://github.com/apache/arrow/pull/46160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.ap
CurtHagenlocher opened a new pull request, #2710:
URL: https://github.com/apache/arrow-adbc/pull/2710
The Thrift classes in the HiveServer2-based drivers are intended to be
internal implementation details and not exposed publicly. This PR changes their
visibility from public to internal.
wgtmac merged PR #46158:
URL: https://github.com/apache/arrow/pull/46158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
raulcd commented on issue #46174:
URL: https://github.com/apache/arrow/issues/46174#issuecomment-2812341826
Issue resolved by pull request 46175
https://github.com/apache/arrow/pull/46175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
raulcd merged PR #46175:
URL: https://github.com/apache/arrow/pull/46175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
mbrobbel commented on issue #2694:
URL: https://github.com/apache/arrow-adbc/issues/2694#issuecomment-2812307191
Ok it sounds like we should just use associated types then:
https://github.com/apache/arrow-adbc/pull/2713
--
This is an automated message from the Apache Git Service.
To respo
mbrobbel opened a new pull request, #2713:
URL: https://github.com/apache/arrow-adbc/pull/2713
Following the discussion in #2694 - this changes the `impl Trait` return
types to use generic associated types. This is a breaking change.
--
This is an automated message from the Apache Git Ser
AlenkaF commented on PR #46170:
URL: https://github.com/apache/arrow/pull/46170#issuecomment-2812296116
> Should the document be revised as well?
Thanks for the contribution, @yyossy5! The document you linked will be
updated automatically by the changes in this PR, since that section
raulcd commented on PR #46009:
URL: https://github.com/apache/arrow/pull/46009#issuecomment-2812270343
@github-actions crossbow submit wheel-manylinux-2014-cp39-cp39-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
AlenkaF commented on code in PR #42118:
URL: https://github.com/apache/arrow/pull/42118#discussion_r2048535783
##
cpp/src/arrow/c/dlpack.cc:
##
@@ -66,15 +67,15 @@ struct ManagerCtx {
} // namespace
Result ExportArray(const std::shared_ptr& arr) {
- // Define DLDevice stru
AlenkaF commented on PR #46175:
URL: https://github.com/apache/arrow/pull/46175#issuecomment-2812268782
@raulcd the builds are green. I am totally ok with adding a mark, if you
prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
AlenkaF commented on code in PR #42118:
URL: https://github.com/apache/arrow/pull/42118#discussion_r2048558050
##
cpp/src/arrow/c/dlpack.cc:
##
@@ -130,4 +131,71 @@ Result ExportDevice(const
std::shared_ptr& arr) {
}
}
+struct TensorManagerCtx {
+ std::shared_ptr t;
+ s
github-actions[bot] commented on PR #46175:
URL: https://github.com/apache/arrow/pull/46175#issuecomment-2812231791
Revision: 27bb51a9b72065c4083d1f2d069ae642b50b0be5
Submitted crossbow builds: [ursacomputing/crossbow @
actions-b4609db978](https://github.com/ursacomputing/crossbow/bra
AlenkaF commented on PR #46175:
URL: https://github.com/apache/arrow/pull/46175#issuecomment-2812225949
@github-actions crossbow submit example-python-minimal-build-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
raulcd merged PR #46171:
URL: https://github.com/apache/arrow/pull/46171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
raulcd commented on issue #46169:
URL: https://github.com/apache/arrow/issues/46169#issuecomment-281952
Issue resolved by pull request 46171
https://github.com/apache/arrow/pull/46171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
AlenkaF commented on PR #46057:
URL: https://github.com/apache/arrow/pull/46057#issuecomment-281345
> or mark them as `@pytest.mark.acero`
True! I already opened a PR: https://github.com/apache/arrow/pull/46175. Can
change to adding a mark if there will be a preference for it.
-
raulcd commented on PR #46057:
URL: https://github.com/apache/arrow/pull/46057#issuecomment-2812212645
or mark them as `@pytest.mark.acero`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
alexdegroot commented on issue #45559:
URL: https://github.com/apache/arrow/issues/45559#issuecomment-2812206263
@CurtHagenlocher I meant the proposed alternative.
I can understand your reasoning about backwards compatibility.
I'll clean up my PRs and leave the Gists in place for the d
alexdegroot closed pull request #45609: GH-45559: [C#] Increasing performance
by avoiding array allocation everytime method gets used
URL: https://github.com/apache/arrow/pull/45609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
1 - 100 of 104 matches
Mail list logo
