Re: [I] [Docs] Dev version of docs is not updating [arrow]

raulcd commented on issue #46712: URL: https://github.com/apache/arrow/issues/46712#issuecomment-2942983473 Thanks for the ping @ianmcook . I initially thought it could be related but after I did some investigation it is not the case. The issue is that the [test-debian-12-docs](https://g

Re: [PR] feat(c/driver/postgresql): add read support for int2vector [arrow-adbc]

lidavidm commented on PR #2919: URL: https://github.com/apache/arrow-adbc/pull/2919#issuecomment-2942981216 I did manually test with Python that the query actually works but I'll add and commit a test in C++ -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] feat(c/driver/postgresql): add read support for int2vector [arrow-adbc]

lidavidm commented on code in PR #2919: URL: https://github.com/apache/arrow-adbc/pull/2919#discussion_r2128082704 ## c/driver/postgresql/postgres_type_test.cc: ## @@ -441,4 +441,20 @@ TEST(PostgresTypeTest, PostgresTypeResolveRecord) { EXPECT_EQ(type.child(1).type_id(), Post

Re: [PR] feat(csharp/src/Drivers/Databricks): Multiple catalogs with default database [arrow-adbc]

eric-wang-1990 commented on code in PR #2921: URL: https://github.com/apache/arrow-adbc/pull/2921#discussion_r2128073383 ## csharp/src/Drivers/Databricks/DatabricksConnection.cs: ## @@ -168,6 +168,12 @@ private void ValidateProperties() Properties.TryGetValue(AdbcOp

Re: [PR] Initial API for reading Variant data and metadata [arrow-rs]

mkarbo commented on PR #7535: URL: https://github.com/apache/arrow-rs/pull/7535#issuecomment-2942956866 Yes @alamb I will continue when I have time on my hand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Update integration test to avoid long format strings [arrow-rs-object-store]

zensh commented on PR #359: URL: https://github.com/apache/arrow-rs-object-store/pull/359#issuecomment-2942932530 I am facing the same issue. May I ask when a new version will be released to fix this problem? https://github.com/ldclabs/ic-oss/actions/runs/15457272105/job/43511721430

Re: [PR] Add `coalesce` kernel and`BatchCoalescer` for statefully combining selected b…atches: [arrow-rs]

zhuqi-lucas commented on code in PR #7597: URL: https://github.com/apache/arrow-rs/pull/7597#discussion_r2127998724 ## arrow-select/src/coalesce.rs: ## @@ -0,0 +1,629 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. S

Re: [PR] Add `coalesce` kernel and`BatchCoalescer` for statefully combining selected b…atches: [arrow-rs]

Dandandan commented on code in PR #7597: URL: https://github.com/apache/arrow-rs/pull/7597#discussion_r2127979151 ## arrow-select/src/coalesce.rs: ## @@ -0,0 +1,629 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

davidhcoe commented on PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#issuecomment-2942785526 > So I think we agree then: there are only 3 possibilities, but it's being modeled with two booleans (4 possibilities) ok. I will rework it to an enum -- This is an automate

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

lidavidm commented on PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#issuecomment-2942766032 So I think we agree then: there are only 3 possibilities, but it's being modeled with two booleans (4 possibilities) -- This is an automated message from the Apache Git Service. To

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

davidhcoe commented on code in PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#discussion_r2127958852 ## go/adbc/driver/snowflake/statement.go: ## @@ -647,7 +667,7 @@ func (st *statement) ExecuteSchema(ctx context.Context) (*arrow.Schema, error) {

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

davidhcoe commented on PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#issuecomment-2942749437 > So again, this is why I keep asking if the option should really be a boolean :) > > Since the new option is only effective when we are asking for nanoseconds, it's effective

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

lidavidm commented on PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#issuecomment-2942734201 So again, this is why I keep asking if the option should really be a boolean :) Since the new option is only effective when we are asking for nanoseconds, it's effectively 3 po

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

davidhcoe commented on PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#issuecomment-2942729540 > If that's not possible that's not possible - but if we could do that that would be a better experience than silent corruption, IMO. (Or again, this is why I ask if the option shoul

Re: [PR] GH-46652: [Python][Docs] Update language for row_group_size parameter [arrow]

conbench-apache-arrow[bot] commented on PR #46653: URL: https://github.com/apache/arrow/pull/46653#issuecomment-2942717562 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 832bfa1ec67c3a6d43dab5abe7d84271680fee9c. There were 72

Re: [PR] Add `coalesce` kernel and`BatchCoalescer` for statefully combining selected b…atches: [arrow-rs]

zhuqi-lucas commented on code in PR #7597: URL: https://github.com/apache/arrow-rs/pull/7597#discussion_r2127875685 ## arrow-select/src/coalesce.rs: ## @@ -0,0 +1,629 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. S

Re: [PR] Add `coalesce` kernel and`BatchCoalescer` for statefully combining selected b…atches: [arrow-rs]

zhuqi-lucas commented on code in PR #7597: URL: https://github.com/apache/arrow-rs/pull/7597#discussion_r2127875685 ## arrow-select/src/coalesce.rs: ## @@ -0,0 +1,629 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. S

Re: [PR] feat(c/driver/postgresql): add read support for int2vector [arrow-adbc]

paleolimbot commented on code in PR #2919: URL: https://github.com/apache/arrow-adbc/pull/2919#discussion_r2127873308 ## c/driver/postgresql/copy/postgres_copy_reader_test.cc: ## @@ -797,6 +797,88 @@ TEST(PostgresCopyUtilsTest, PostgresCopyReadArray) { ASSERT_EQ(data_buffer[4

Re: [PR] Add `coalesce` kernel and`BatchCoalescer` for statefully combining selected b…atches: [arrow-rs]

zhuqi-lucas commented on code in PR #7597: URL: https://github.com/apache/arrow-rs/pull/7597#discussion_r2127866840 ## arrow-select/src/coalesce.rs: ## @@ -0,0 +1,629 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. S

Re: [PR] Add `coalesce` kernel and`BatchCoalescer` for statefully combining selected b…atches: [arrow-rs]

zhuqi-lucas commented on code in PR #7597: URL: https://github.com/apache/arrow-rs/pull/7597#discussion_r2127866840 ## arrow-select/src/coalesce.rs: ## @@ -0,0 +1,629 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. S

Re: [PR] fix(c/driver/postgresql): ingest zoned timestamp as WITH TIME ZONE [arrow-adbc]

lidavidm merged PR #2904: URL: https://github.com/apache/arrow-adbc/pull/2904 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] GH-79: Move `splitAndTransferValidityBuffer` to `BaseValueVector` [arrow-java]

lidavidm merged PR #777: URL: https://github.com/apache/arrow-java/pull/777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[PR] fix(python/adbc_driver_manager): don't leak array streams [arrow-adbc]

lidavidm opened a new pull request, #2922: URL: https://github.com/apache/arrow-adbc/pull/2922 The driver manager was leaking array streams in the case that you executed a query, *did not fetch the result*, then did another operation. In this case, because the stream was never imported, it

Re: [PR] Add a lint CI [arrow-swift]

kou merged PR #21: URL: https://github.com/apache/arrow-swift/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] Add top level Package.swift file [arrow-swift]

abandy commented on PR #24: URL: https://github.com/apache/arrow-swift/pull/24#issuecomment-2942555412 @kou Thanks for adding the issue! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Add top level Package.swift file [arrow-swift]

kou commented on PR #24: URL: https://github.com/apache/arrow-swift/pull/24#issuecomment-2942552402 We can register this to the Swift Package Index by this, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] Add top level Package.swift file [arrow-swift]

abandy opened a new pull request, #24: URL: https://github.com/apache/arrow-swift/pull/24 ## What's Changed Adding top level Package.swift file. Arrow and ArrowFlight are included in the top level build. -- This is an automated message from the Apache Git Service. To resp

[PR] GH-155: Delegate opening mTLS cert files to `build()` [arrow-java]

rtadepalli opened a new pull request, #783: URL: https://github.com/apache/arrow-java/pull/783 ## What's Changed Make `FlightServer.Builder` store `File` and delegate opening the file to the actual `build()` method. Closes #155. -- This is an automated message from the Apach

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

birschick-bq commented on code in PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2127807259 ## go/adbc/driver/snowflake/snowflake_database.go: ## @@ -58,7 +60,7 @@ type databaseImpl struct { } func (d *databaseImpl) GetOption(key string) (string, e

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

lidavidm commented on PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#issuecomment-2942497813 If that's not possible that's not possible - but if we could do that that would be a better experience than silent corruption, IMO. (Or again, this is why I ask if the option should b

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

lidavidm commented on code in PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#discussion_r2127796405 ## docs/source/driver/snowflake.rst: ## @@ -469,6 +469,10 @@ These options map 1:1 with the Snowflake `Config object

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

lidavidm commented on PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#issuecomment-2942496053 > I started down this path. The challenge is you specify the schema details before you know the values that would cause the overflow, and I wasn’t finding a good way to go back and ch

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

lidavidm commented on code in PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#discussion_r2127796659 ## docs/source/driver/snowflake.rst: ## @@ -469,6 +469,10 @@ These options map 1:1 with the Snowflake `Config object

Re: [PR] Initial API for reading Variant data and metadata [arrow-rs]

PinkCrow007 commented on PR #7535: URL: https://github.com/apache/arrow-rs/pull/7535#issuecomment-2942484216 So glad to see the initial API merged! I'd be happy to contribute. @alamb About the builder APIs — one question I’ve been thinking about: in the Go version, the single-buffer build

Re: [PR] GH-46702: [JS] Remove js/ [arrow]

conbench-apache-arrow[bot] commented on PR #46703: URL: https://github.com/apache/arrow/pull/46703#issuecomment-2942478006 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 76bd3262df04f9dc72e49f31e0139627f3274d88. There were 71

Re: [I] [Java][FlightRPC] FlightServer builder should store File, not InputStream [arrow-java]

rtadepalli commented on issue #155: URL: https://github.com/apache/arrow-java/issues/155#issuecomment-2942412022 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] feat(c/driver_manager): add new function to allow loading by manifest [arrow-adbc]

felipecrv commented on code in PR #2918: URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2127760378 ## go/adbc/drivermgr/adbc_driver_manager.cc: ## @@ -114,7 +125,187 @@ struct OwnedError { } }; +std::filesystem::path UserConfigDir() { + std::filesystem::p

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

davidhcoe commented on code in PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#discussion_r2127776277 ## docs/source/driver/snowflake.rst: ## @@ -469,6 +469,10 @@ These options map 1:1 with the Snowflake `Config object

Re: [PR] Add a lint CI [arrow-swift]

abandy commented on PR #21: URL: https://github.com/apache/arrow-swift/pull/21#issuecomment-2942408103 Lgtm! I tried it locally on my mac and it works as expected. (swiftlint has worked since we setup the linting when swift was in the main arrow repo so I probably am benefitting from prio

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

davidhcoe commented on PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#issuecomment-2942402458 > Is it correct to summarize this issue as "Snowflake returns nanosecond-precision timestamps, but in a representation with a range beyond that of Arrow timestamp[ns]"? > > Is

Re: [PR] GH-46714: [C++] Use hidden symbol visibility in Meson configuration [arrow]

kou commented on code in PR #46715: URL: https://github.com/apache/arrow/pull/46715#discussion_r2127732056 ## cpp/src/arrow/compute/expression.cc: ## @@ -260,7 +260,9 @@ bool Expression::Equals(const Expression& other) const { return false; } -bool Identical(const Expressi

Re: [I] [Benchmarking][R] conbench is failing [arrow]

kou commented on issue #46716: URL: https://github.com/apache/arrow/issues/46716#issuecomment-2942277058 @jonkeane @thisisnic @amoeba This may be related to only R. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [I] [R][Docs] pkgdown generation is failing [arrow]

kou commented on issue #46717: URL: https://github.com/apache/arrow/issues/46717#issuecomment-2942372539 @jonkeane @thisisnic @amoeba We may need to update `_pkgdown.yml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] GH-46714: [C++] Use hidden symbol visibility in Meson configuration [arrow]

WillAyd commented on code in PR #46715: URL: https://github.com/apache/arrow/pull/46715#discussion_r2127743602 ## cpp/src/arrow/compute/expression.cc: ## @@ -260,7 +260,9 @@ bool Expression::Equals(const Expression& other) const { return false; } -bool Identical(const Expr

Re: [I] [C++] 32 bit MSVC doesn't build [arrow]

kou commented on issue #32111: URL: https://github.com/apache/arrow/issues/32111#issuecomment-2942205033 (Unfortunately, I don't have enough bandwidth for it.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] GH-45908: [C++][Docs] Rename and expose basic {Array,...}FromJSON helpers as public APIs [arrow]

amoeba commented on PR #46180: URL: https://github.com/apache/arrow/pull/46180#issuecomment-2942261756 The post-merge comments were all resolved in https://github.com/apache/arrow/issues/46439. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] GH-45908: [C++][Docs] Rename and expose basic {Array,...}FromJSON helpers as public APIs [arrow]

amoeba commented on code in PR #46180: URL: https://github.com/apache/arrow/pull/46180#discussion_r2127739796 ## cpp/src/arrow/json/from_string.h: ## @@ -0,0 +1,121 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See

Re: [PR] GH-45908: [C++][Docs] Rename and expose basic {Array,...}FromJSON helpers as public APIs [arrow]

amoeba commented on code in PR #46180: URL: https://github.com/apache/arrow/pull/46180#discussion_r2127739377 ## cpp/src/arrow/json/from_string.cc: ## @@ -55,14 +55,12 @@ namespace arrow { using internal::ParseValue; using util::Float16; -namespace ipc { -namespace internal

Re: [PR] GH-45908: [C++][Docs] Rename and expose basic {Array,...}FromJSON helpers as public APIs [arrow]

amoeba commented on code in PR #46180: URL: https://github.com/apache/arrow/pull/46180#discussion_r2127739169 ## cpp/src/arrow/dataset/test_util_internal.h: ## @@ -2140,8 +2140,8 @@ class WriteFileSystemDatasetMixin : public MakeFileSystemDatasetMixin { actual_struct =

Re: [PR] GH-46708: [C++][Gandiva] Added zero return values for castDECIMAL_utf8 [arrow]

kou commented on code in PR #46709: URL: https://github.com/apache/arrow/pull/46709#discussion_r2127733596 ## cpp/src/gandiva/tests/decimal_test.cc: ## @@ -1237,4 +1237,42 @@ TEST_F(TestDecimal, TestSha) { EXPECT_NE(value_at_position, response->GetScalar(i - 1).ValueOrDie(

Re: [I] [Python] Missing `utf8_zfill` in pyarrow.compute to support `str.zfill` behavior [arrow]

iabhi4 commented on issue #46683: URL: https://github.com/apache/arrow/issues/46683#issuecomment-2942256709 @pitrou That makes sense, `utf8_lpad` does match Python’s `zfill` behavior but we are still missing an edge case here. If the string has signs like` '-1'` or `'+1'` and we do `pc.utf

Re: [PR] GH-46699: [CI][Dev] fix shellcheck errors in the ci/scripts/cpp_test.sh [arrow]

kou merged PR #46700: URL: https://github.com/apache/arrow/pull/46700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [I] [C++] 32 bit MSVC doesn't build [arrow]

amoeba commented on issue #32111: URL: https://github.com/apache/arrow/issues/32111#issuecomment-2942246531 I think once we tackle https://github.com/apache/arrow/issues/46002, whether we support 32-bit MSVC will be much more clear and so will how to bring it into support. It looks like get

[PR] Fix multiple catalogs with default database [arrow-adbc]

toddmeng-db opened a new pull request, #2921: URL: https://github.com/apache/arrow-adbc/pull/2921 When using `EnableMultipleCatalogs` with new dbr, `InitialNamespace` still returns a catalog value in `TOpenSessionResp`. In Databricks Statement, we check to see if catalog is set; if `EnableM

Re: [I] [C++] 32 bit MSVC doesn't build [arrow]

kou commented on issue #32111: URL: https://github.com/apache/arrow/issues/32111#issuecomment-2942198015 If we support 32bit Windows, I think that we need at least one active maintainer for 32bit Windows. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] GH-46439: [C++] Use result pattern for all FromJSONString Helpers [arrow]

amoeba commented on PR #46696: URL: https://github.com/apache/arrow/pull/46696#issuecomment-2942194532 Thank you as always @kou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [Parquet] Add BooleanArray based row selection [arrow-rs]

alamb commented on code in PR #6624: URL: https://github.com/apache/arrow-rs/pull/6624#discussion_r2127725282 ## parquet/src/arrow/arrow_reader/boolean_selection.rs: ## @@ -0,0 +1,546 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

Re: [I] [CI][Dev] fix shellcheck errors in the ci/scripts/cpp_test.sh [arrow]

kou commented on issue #46699: URL: https://github.com/apache/arrow/issues/46699#issuecomment-2942185014 Issue resolved by pull request 46700 https://github.com/apache/arrow/pull/46700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Add `coalesce` kernel and`BatchCoalescer` for statefully combining selected b…atches: [arrow-rs]

alamb commented on PR #7597: URL: https://github.com/apache/arrow-rs/pull/7597#issuecomment-2942182812 Thank you for the review @Dandandan I'll plan to merge this tomorrow so we can begin iterating. cc @zhuqi-lucas and @tustvold -- This is an automated message from the Apa

Re: [PR] feat(csharp/src/Drivers/Databricks): Multiple catalogs with default database [arrow-adbc]

toddmeng-db commented on code in PR #2921: URL: https://github.com/apache/arrow-adbc/pull/2921#discussion_r2127722162 ## csharp/src/Drivers/Databricks/DatabricksStatement.cs: ## @@ -46,7 +46,7 @@ public DatabricksStatement(DatabricksConnection connection) var defaul

Re: [PR] feat(go/adbc/driver/snowflake): New setting to set the maximum timestamp precision to microseconds [arrow-adbc]

lidavidm commented on code in PR #2917: URL: https://github.com/apache/arrow-adbc/pull/2917#discussion_r2127671967 ## docs/source/driver/snowflake.rst: ## @@ -469,6 +469,10 @@ These options map 1:1 with the Snowflake `Config object

Re: [PR] GH-46439: [C++] Use result pattern for all FromJSONString Helpers [arrow]

kou merged PR #46696: URL: https://github.com/apache/arrow/pull/46696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [I] [C++] 32 bit MSVC doesn't build [arrow]

jmckenna commented on issue #32111: URL: https://github.com/apache/arrow/issues/32111#issuecomment-2942087562 Sorry to not be specific: I should have written "I do know how to configure Meson for MSVC Windows builds at the project level". It is great to read here that the Arrow proje

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

lidavidm commented on code in PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2127618564 ## go/adbc/driver/snowflake/snowflake_database.go: ## @@ -58,7 +60,7 @@ type databaseImpl struct { } func (d *databaseImpl) GetOption(key string) (string, error

Re: [I] [C++] 32 bit MSVC doesn't build [arrow]

WillAyd commented on issue #32111: URL: https://github.com/apache/arrow/issues/32111#issuecomment-2941911934 Meson as a tool definitely supports MSVC. Our current configuration is likely missing things to make that work, so I think patches are welcome to fix any issues you encounter there.

Re: [PR] GH-46611: [Python][C++] Allow building float16 arrays without numpy [arrow]

conbench-apache-arrow[bot] commented on PR #46618: URL: https://github.com/apache/arrow/pull/46618#issuecomment-2941906017 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 55628cd5fed83187d65b8860c3edfc70e09f9a57. There were 68

Re: [PR] GH-79: Move `splitAndTransferValidityBuffer` to `BaseValueVector` [arrow-java]

rtadepalli commented on PR #777: URL: https://github.com/apache/arrow-java/pull/777#issuecomment-2941878478 Resolved all conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] GH-46659: [C++] Fix export of extension arrays with binary view/string view storage [arrow]

paleolimbot commented on PR #46660: URL: https://github.com/apache/arrow/pull/46660#issuecomment-2941729030 Thank you for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [C++] Exporting an ExtensionType with BinaryView or StringView storage to C does not export extra buffer sizes array [arrow]

paleolimbot commented on issue #46659: URL: https://github.com/apache/arrow/issues/46659#issuecomment-2941732305 Issue resolved by pull request 46660 https://github.com/apache/arrow/pull/46660 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] GH-46659: [C++] Fix export of extension arrays with binary view/string view storage [arrow]

paleolimbot merged PR #46660: URL: https://github.com/apache/arrow/pull/46660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] GH-46714: [C++] Use hidden symbol visibility in Meson configuration [arrow]

WillAyd commented on PR #46715: URL: https://github.com/apache/arrow/pull/46715#issuecomment-2941712635 FWIW the hidden symbol visibility appears to shave a couple MB off of the libarrow release size (43MB -> 41 MB locally) -- This is an automated message from the Apache Git Service. To r

Re: [PR] feat(c/driver_manager): add new function to allow loading by manifest [arrow-adbc]

paleolimbot commented on code in PR #2918: URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2127436917 ## c/vendor/toml++/toml.hpp: ## Review Comment: Just pointing out the change in scope introduced here (the current driver manager is ~2000 lines, and this

Re: [PR] GH-46704: [C++] Fix OSS-Fuzz build failure [arrow]

kou commented on code in PR #46706: URL: https://github.com/apache/arrow/pull/46706#discussion_r2127490089 ## cpp/src/arrow/ipc/writer.cc: ## @@ -329,15 +329,24 @@ class RecordBatchSerializer { return Status::OK(); } -int64_t required_bytes = sizeof(offset_type

Re: [PR] GH-46714: [C++] Use hidden symbol visibility in Meson configuration [arrow]

github-actions[bot] commented on PR #46715: URL: https://github.com/apache/arrow/pull/46715#issuecomment-2941580598 :warning: GitHub issue #46714 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-46714: [C++] Use hidden symbol visibility in Meson configuration [arrow]

WillAyd opened a new pull request, #46715: URL: https://github.com/apache/arrow/pull/46715 ### Rationale for this change This will eventually make it easier to support Windows through the Meson configuration, while also providing the documented benefits of hidden symbol visibility

Re: [PR] GH-46704: [C++] Fix OSS-Fuzz build failure [arrow]

pitrou commented on code in PR #46706: URL: https://github.com/apache/arrow/pull/46706#discussion_r2127440364 ## cpp/src/arrow/ipc/writer.cc: ## @@ -329,15 +329,24 @@ class RecordBatchSerializer { return Status::OK(); } -int64_t required_bytes = sizeof(offset_t

Re: [PR] GH-46395: [C++][Statistics] Correct the Equal method for min and max in arrow::ArrayStatistics [arrow]

kou commented on code in PR #46422: URL: https://github.com/apache/arrow/pull/46422#discussion_r2127470369 ## cpp/src/arrow/array/statistics_test.cc: ## @@ -15,9 +15,12 @@ // specific language governing permissions and limitations // under the License. +#include + #include

Re: [PR] GH-46395: [C++][Statistics] Correct the Equal method for min and max in arrow::ArrayStatistics [arrow]

kou commented on code in PR #46422: URL: https://github.com/apache/arrow/pull/46422#discussion_r2127470672 ## cpp/src/arrow/array/statistics_test.cc: ## @@ -15,9 +15,12 @@ // specific language governing permissions and limitations // under the License. +#include + #include

Re: [PR] feat(go/adbc/driver): initial tracing instrumentation for Snowflake driver [arrow-adbc]

birschick-bq commented on code in PR #2825: URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2127464276 ## go/adbc/driver/internal/driverbase/connection.go: ## @@ -183,28 +188,34 @@ func (base *ConnectionImplBase) GetInfo(ctx context.Context, infoCodes []adbc.In

[PR] feat: support on additional builders [arrow-rs]

albertlockett opened a new pull request, #7606: URL: https://github.com/apache/arrow-rs/pull/7606 # Which issue does this PR close? We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link

[I] Support `add_nulls` on additional builder types [arrow-rs]

albertlockett opened a new issue, #7605: URL: https://github.com/apache/arrow-rs/issues/7605 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** I have a need to create array builders for many different types and then add some number

Re: [I] [C++] 32 bit MSVC doesn't build [arrow]

jmckenna commented on issue #32111: URL: https://github.com/apache/arrow/issues/32111#issuecomment-2941484738 @WillAyd Sorry to not be specific: I do know how to configure Meson for Windows builds at the project level (using the setting I mentioned), however my question is what you hinted a

Re: [PR] GH-46704: [C++] Fix OSS-Fuzz build failure [arrow]

kou commented on code in PR #46706: URL: https://github.com/apache/arrow/pull/46706#discussion_r2127436148 ## cpp/src/arrow/ipc/writer.cc: ## @@ -329,15 +329,24 @@ class RecordBatchSerializer { return Status::OK(); } -int64_t required_bytes = sizeof(offset_type

Re: [I] [C++] 32 bit MSVC doesn't build [arrow]

WillAyd commented on issue #32111: URL: https://github.com/apache/arrow/issues/32111#issuecomment-2941446698 I doubt in its current state that the Meson configuration supports Windows - we don't test for it in CI and I have not done anything to appease the Windows requirements for symbol vi

Re: [PR] GH-46691: [CI][Packaging] Make order of platform tag on generated wheel name not relevant for uploaded artifact validation [arrow]

kou commented on code in PR #46705: URL: https://github.com/apache/arrow/pull/46705#discussion_r2127422952 ## dev/release/verify-release-candidate.sh: ## @@ -902,7 +902,8 @@ test_linux_wheels() { if ! VENV_ENV=wheel-${pyver}-${platform} PYTHON_VERSION=${pyver} maybe_setu

Re: [I] [C++][Acero] Apparent deadlock in Table.join_asof [arrow]

erikhansenwong commented on issue #46224: URL: https://github.com/apache/arrow/issues/46224#issuecomment-2941440113 Thank you @zanmato1984 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add a lint CI [arrow-swift]

amoeba commented on PR #21: URL: https://github.com/apache/arrow-swift/pull/21#issuecomment-2941430751 I think the above are related and makes sense. The ubuntu runner must ship with a standard Swift toolchain so this works on CI. On a Mac, you can't just use the CommandLineTools to run run

Re: [PR] Add a lint CI [arrow-swift]

amoeba commented on PR #21: URL: https://github.com/apache/arrow-swift/pull/21#issuecomment-2941405031 On macOS, I get a very cryptic, ``` ❯ nice pre-commit run --show-diff-on-failure --color=always --all-files [INFO] Installing environment for https://github.com/realm/SwiftLint.

Re: [PR] Add a lint CI [arrow-swift]

amoeba commented on code in PR #21: URL: https://github.com/apache/arrow-swift/pull/21#discussion_r2127410379 ## .github/workflows/test.yaml: ## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOT

Re: [I] [C++] 32 bit MSVC doesn't build [arrow]

jmckenna commented on issue #32111: URL: https://github.com/apache/arrow/issues/32111#issuecomment-2941400848 @WillAyd does the Meson port allow the Meson `PLATFORM=x86` setting at the project level? (assuming your mention of Meson, means that all settings are supported).(as this is im

Re: [PR] GH-46439: [C++] Rename internal Converter class in from_string.cc [arrow]

conbench-apache-arrow[bot] commented on PR #46697: URL: https://github.com/apache/arrow/pull/46697#issuecomment-2941391168 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit fbed20a9a23f23dc256539179a90ab465d1b1c2e. There were 70

Re: [PR] [Parquet] Add BooleanArray based row selection [arrow-rs]

XiangpengHao commented on code in PR #6624: URL: https://github.com/apache/arrow-rs/pull/6624#discussion_r2127391600 ## parquet/src/arrow/arrow_reader/boolean_selection.rs: ## @@ -0,0 +1,546 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributo

Re: [PR] Add a lint CI [arrow-swift]

kou commented on code in PR #21: URL: https://github.com/apache/arrow-swift/pull/21#discussion_r2127390584 ## .github/workflows/test.yaml: ## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE

Re: [PR] Add a lint CI [arrow-swift]

kou commented on PR #21: URL: https://github.com/apache/arrow-swift/pull/21#issuecomment-2941362241 Oh, could you share the results you got? I just executed `nice pre-commit run --show-diff-on-failure --color=always --all-files` like the workflow does. -- This is an automated messa

Re: [PR] Add `coalesce` kernel and`BatchCoalescer` for statefully combining selected b…atches: [arrow-rs]

alamb commented on PR #7597: URL: https://github.com/apache/arrow-rs/pull/7597#issuecomment-2941327496 Ok, I think this PR is ready for a real review and hopefully merge. My proposed next steps are: 1. Merge this PR 2. Iterate in subsequent PRs to improve the kernel using the ben

Re: [I] [C++] Fix ASAN issue in the arrow-dataset-dataset-writer-test [arrow]

amoeba commented on issue #45235: URL: https://github.com/apache/arrow/issues/45235#issuecomment-2941324921 Got it. I'll file a new issue for it since different form this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] [C++] Fix ASAN issue in the arrow-dataset-dataset-writer-test [arrow]

pitrou commented on issue #45235: URL: https://github.com/apache/arrow/issues/45235#issuecomment-2941320472 Hmm, that's annoying. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] [C++] Fix ASAN issue in the arrow-dataset-dataset-writer-test [arrow]

amoeba commented on issue #45235: URL: https://github.com/apache/arrow/issues/45235#issuecomment-2941302973 On the main branch, the test fails after just seconds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [I] [C++] Fix ASAN issue in the arrow-dataset-dataset-writer-test [arrow]

pitrou commented on issue #45235: URL: https://github.com/apache/arrow/issues/45235#issuecomment-2941300759 Did you try to run the test for as long on the main branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] [C++] Fix ASAN issue in the arrow-dataset-dataset-writer-test [arrow]

amoeba commented on issue #45235: URL: https://github.com/apache/arrow/issues/45235#issuecomment-2941271237 After about 5 minutes, the test hang again. I then, - attached gdb to the test process - ran `thread apply all bt` (output included in [gist](https://gist.github.com/amoeba/f

  1   2   3   >