klion26 commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2218119219
##
parquet-variant/src/builder.rs:
##
@@ -1134,39 +1197,86 @@ impl<'a> ObjectBuilder<'a> {
)));
}
-let data_size = self.buffer.offset()
klion26 commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2218045675
##
parquet-variant/src/builder.rs:
##
@@ -1118,8 +1181,8 @@ impl<'a> ObjectBuilder<'a> {
/// Finalizes this object and appends it to its parent, which otherwise
MichaelChirico commented on PR #46878:
URL: https://github.com/apache/arrow/pull/46878#issuecomment-3095283261
> > I basically had Gemini write this (on my free personal account). It did
95% of the work, from one prompt, then I tidied up the results and fixed the
tests. It looks reasonably
lidavidm commented on issue #3134:
URL: https://github.com/apache/arrow-adbc/issues/3134#issuecomment-3095269006
I think a PR to add an option to wait for the DoGet to get the schema might
be OK then, depending on how complex that change is. Anything more complicated
and I think we would wa
lidavidm commented on code in PR #3174:
URL: https://github.com/apache/arrow-adbc/pull/3174#discussion_r2218222000
##
go/adbc/driver/bigquery/driver_test.go:
##
@@ -1551,3 +1551,73 @@ func (suite *BigQueryTests)
TestMetadataGetObjectsColumnsXdbc() {
}
var _ validation.Drive
carpecodeum commented on code in PR #7965:
URL: https://github.com/apache/arrow-rs/pull/7965#discussion_r2218140366
##
parquet-variant-compute/src/variant_array_builder.rs:
##
@@ -146,7 +146,7 @@ impl VariantArrayBuilder {
}
/// Append the [`Variant`] to the builder
carpecodeum commented on code in PR #7965:
URL: https://github.com/apache/arrow-rs/pull/7965#discussion_r2218139338
##
parquet-variant-compute/src/variant_array_builder.rs:
##
@@ -146,7 +146,7 @@ impl VariantArrayBuilder {
}
/// Append the [`Variant`] to the builder
wgtmac commented on PR #47114:
URL: https://github.com/apache/arrow/pull/47114#issuecomment-3095094159
```
FAILED: [code=2]
src/parquet/CMakeFiles/parquet_shared.dir/arrow/path_internal.cc.obj
"C:\Program Files\Git\usr\bin\ccache.exe"
C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\
kou commented on issue #47146:
URL: https://github.com/apache/arrow/issues/47146#issuecomment-3095008518
How did you create https://github.com/rok/arrow/issues/14 ?
Our issue template and
https://github.com/apache/arrow/blob/main/.github/workflows/issue_bot.yml set
"component" automatica
lidavidm commented on code in PR #47139:
URL: https://github.com/apache/arrow/pull/47139#discussion_r2218050990
##
python/pyarrow/types.py:
##
@@ -46,6 +48,43 @@
lib.Type_STRUCT, lib.Type_MAP} | _UNION_TYPES
+class TypesEnum(Enum):
+"""
+An Enum tha
lidavidm commented on PR #47139:
URL: https://github.com/apache/arrow/pull/47139#issuecomment-3094998874
Actually, run-end-encoded is also missing. As are all the binary types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
lidavidm commented on code in PR #47139:
URL: https://github.com/apache/arrow/pull/47139#discussion_r2218049955
##
python/pyarrow/types.py:
##
@@ -46,6 +48,43 @@
lib.Type_STRUCT, lib.Type_MAP} | _UNION_TYPES
+class TypesEnum(Enum):
+"""
+An Enum tha
klion26 commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2218042453
##
parquet-variant/src/builder.rs:
##
@@ -1000,6 +1048,8 @@ impl<'a> ListBuilder<'a> {
// Get parent's buffer
let parent_buffer = self.parent_state
cetra3 opened a new pull request, #442:
URL: https://github.com/apache/arrow-rs-object-store/pull/442
# Rationale for this change
Spawn service was panicking when it was trying to write out the body to the
channel.
# What changes are included in this PR?
This PR adjusts
rmnskb commented on PR #47147:
URL: https://github.com/apache/arrow/pull/47147#issuecomment-3094864316
If this PR gets merged, we'd have to align with the pandas development team
to ensure that we don't have two clashing processes that do the same thing.
--
This is an automated message f
adamreeve commented on PR #46972:
URL: https://github.com/apache/arrow/pull/46972#issuecomment-3094845515
@wgtmac could you please take a look at this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
github-actions[bot] commented on PR #47147:
URL: https://github.com/apache/arrow/pull/47147#issuecomment-3094833678
:warning: GitHub issue #45382 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
viirya commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2217952918
##
parquet-variant/src/builder.rs:
##
@@ -506,6 +506,7 @@ enum ParentState<'a> {
metadata_builder: &'a mut MetadataBuilder,
fields: &'a mut IndexMap,
viirya commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2217940562
##
parquet-variant/src/builder.rs:
##
@@ -2357,8 +2673,8 @@ mod tests {
// Only the second attempt should appear in the final variant
let (metadata, v
viirya commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2217933884
##
parquet-variant/src/builder.rs:
##
@@ -1134,39 +1197,86 @@ impl<'a> ObjectBuilder<'a> {
)));
}
-let data_size = self.buffer.offset();
viirya commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2217933884
##
parquet-variant/src/builder.rs:
##
@@ -1134,39 +1197,86 @@ impl<'a> ObjectBuilder<'a> {
)));
}
-let data_size = self.buffer.offset();
viirya commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2217931769
##
parquet-variant/src/builder.rs:
##
@@ -1134,39 +1197,86 @@ impl<'a> ObjectBuilder<'a> {
)));
}
-let data_size = self.buffer.offset();
viirya commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2217930441
##
parquet-variant/src/builder.rs:
##
@@ -1134,39 +1197,86 @@ impl<'a> ObjectBuilder<'a> {
)));
}
-let data_size = self.buffer.offset();
fangchenli commented on issue #45382:
URL: https://github.com/apache/arrow/issues/45382#issuecomment-3094712057
Thank you for picking up this issue. It looks good to me so far. The Arrow
team will likely provide more insightful comments here.
--
This is an automated message from the Apach
viirya commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2217915311
##
parquet-variant/src/builder.rs:
##
@@ -1118,8 +1181,8 @@ impl<'a> ObjectBuilder<'a> {
/// Finalizes this object and appends it to its parent, which otherwise
klion26 commented on PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#issuecomment-3094634597
@alamb thank you very much for the review and help, happy to see these
improvements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
klion26 commented on code in PR #7935:
URL: https://github.com/apache/arrow-rs/pull/7935#discussion_r2217766357
##
parquet-variant/src/builder.rs:
##
@@ -598,6 +599,49 @@ impl ParentState<'_> {
}
}
}
+
+// returns the beginning offset of buffer for
zhuqi-lucas commented on PR #7967:
URL: https://github.com/apache/arrow-rs/pull/7967#issuecomment-3094616433
But the test failed, i am not sure if this is a reasonable optimization. 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
rmnskb commented on issue #45382:
URL: https://github.com/apache/arrow/issues/45382#issuecomment-3094615492
Hey @fangchenli, my name's Bogdan, I'm part of EuroPython Sprints 2025, I
was looking through the issues in this repo, and this one has piqued my
interest, since I'm a daily user of p
rmnskb opened a new pull request, #47147:
URL: https://github.com/apache/arrow/pull/47147
### Rationale for this change
Please see Issue #45382
### What changes are included in this PR?
Add support for pandas' attributes when writing to or reading from the files
### Are t
github-actions[bot] commented on PR #47147:
URL: https://github.com/apache/arrow/pull/47147#issuecomment-3094612447
:warning: GitHub issue #45382 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
zhuqi-lucas commented on issue #7802:
URL: https://github.com/apache/arrow-rs/issues/7802#issuecomment-3094601352
Continue adding more in progress tasks for this epic:
https://github.com/apache/arrow-rs/pull/7962
https://github.com/apache/arrow-rs/pull/7967
--
This is an automate
zhuqi-lucas opened a new pull request, #7967:
URL: https://github.com/apache/arrow-rs/pull/7967
# Which issue does this PR close?
This is a very interesting idea that we only calculate the data buffer size
when we choose to gc, because we almost only care about the gc for data
buffer
pitrou commented on PR #47090:
URL: https://github.com/apache/arrow/pull/47090#issuecomment-3094587105
Thanks. I'm on vacation so I'm going to be a bit slow, sorry!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
andishgar commented on PR #46229:
URL: https://github.com/apache/arrow/pull/46229#issuecomment-3094577874
@pitrou I apply two suggestions
Two notes
1-Regarding [this
comment](https://github.com/apache/arrow/pull/46229#discussion_r2208278290), my
current algorithm for adding intervals
rok commented on issue #32609:
URL: https://github.com/apache/arrow/issues/32609#issuecomment-3094519983
A point for discussion: if we were to use inline annotations a big downside
would be the big diff and broken blames. However this can perhaps be mitigated
by using a
[.git-blame-ignore-
github-actions[bot] commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094498477
Revision: df371b10c10325c94f3e1ee43aaa2c3e0f856934
Submitted crossbow builds: [ursacomputing/crossbow @
actions-4d54dadfaa](https://github.com/ursacomputing/crossbow/bra
rok commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094497060
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
paddyroddy commented on code in PR #47141:
URL: https://github.com/apache/arrow/pull/47141#discussion_r2217794587
##
python/LICENSE.txt:
##
Review Comment:
Have copied over the files for the tests @rok
--
This is an automated message from the Apache Git Service.
To resp
rok commented on issue #46374:
URL: https://github.com/apache/arrow/issues/46374#issuecomment-3094493393
@soroushrasti
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
rok commented on issue #46374:
URL: https://github.com/apache/arrow/issues/46374#issuecomment-3094493096
Issue resolved by pull request 47142
https://github.com/apache/arrow/pull/47142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rok merged PR #47142:
URL: https://github.com/apache/arrow/pull/47142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
github-actions[bot] commented on PR #47145:
URL: https://github.com/apache/arrow/pull/47145#issuecomment-3094484241
:warning: GitHub issue #47143 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
paddyroddy opened a new pull request, #47145:
URL: https://github.com/apache/arrow/pull/47145
### Rationale for this change
The `Rat` check was changed in https://github.com/apache/arrow/pull/46541,
but didn't update the corresponding `.gitignore`.
### What changes are included in
kou commented on issue #47143:
URL: https://github.com/apache/arrow/issues/47143#issuecomment-3094473029
OK. Let's add it.
I should have updated
https://github.com/apache/arrow/blob/9091c0b604615420bb3c6ca5a7502b97baac8020/.gitignore#L19-L20
when I worked on #46541.
--
This is an
paddyroddy commented on issue #47143:
URL: https://github.com/apache/arrow/issues/47143#issuecomment-3094468063
Do think it should still be included in the `.gitignore`. A careless
developer could easily have added it by mistake whilst ensuring that licence
headers are added.
--
This is
paddyroddy commented on code in PR #47141:
URL: https://github.com/apache/arrow/pull/47141#discussion_r221287
##
python/LICENSE.txt:
##
Review Comment:
Good point. I guess there's no other way to fix it then other than copying
or creating new licence and notice files.
github-actions[bot] commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094462511
Revision: 6b1a08b21df526b7962e79950acdc951e1e52198
Submitted crossbow builds: [ursacomputing/crossbow @
actions-fe79dfe84b](https://github.com/ursacomputing/crossbow/bra
github-actions[bot] commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094461587
:warning: GitHub issue #45867 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kou commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094461021
@github-actions crossbow submit -g wheel
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
kou commented on code in PR #47141:
URL: https://github.com/apache/arrow/pull/47141#discussion_r2217773476
##
python/LICENSE.txt:
##
Review Comment:
Does symbolic link work on Windows...?
--
This is an automated message from the Apache Git Service.
To respond to the
paddyroddy commented on issue #47143:
URL: https://github.com/apache/arrow/issues/47143#issuecomment-3094459016
Ah. I was actively developing and needed to fix the `rat` step. So this kept
happening. Working now.
--
This is an automated message from the Apache Git Service.
To respond to t
kou commented on issue #47143:
URL: https://github.com/apache/arrow/issues/47143#issuecomment-3094448913
It's removed automatically on success:
https://github.com/apache/arrow/blob/9091c0b604615420bb3c6ca5a7502b97baac8020/.pre-commit-config.yaml#L35
It doesn't work on your envi
github-actions[bot] commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094427540
Revision: 6b1a08b21df526b7962e79950acdc951e1e52198
Submitted crossbow builds: [ursacomputing/crossbow @
actions-2fdf3226a1](https://github.com/ursacomputing/crossbow/bra
github-actions[bot] commented on PR #47144:
URL: https://github.com/apache/arrow/pull/47144#issuecomment-3094427254
:warning: GitHub issue #46374 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
github-actions[bot] commented on PR #47144:
URL: https://github.com/apache/arrow/pull/47144#issuecomment-3094425904
:warning: GitHub issue #46374 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
github-actions[bot] commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094425174
```
Invalid group(s) {'wheels'}. Must be one of {'example-cpp', 'python',
'nightly-release', 'cpp', 'verify-rc-source-macos', 'wheel', 'test',
'verify-rc-source', 'cuda', '
raulcd commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094425794
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
soroushrasti opened a new pull request, #47144:
URL: https://github.com/apache/arrow/pull/47144
See https://github.com/apache/arrow/issues/46374
### Rationale for this change
### What changes are included in this PR?
### Are these changes tested?
--
Thi
github-actions[bot] commented on PR #47144:
URL: https://github.com/apache/arrow/pull/47144#issuecomment-3094425071
:warning: GitHub issue #46374 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
rmnskb commented on issue #47123:
URL: https://github.com/apache/arrow/issues/47123#issuecomment-3094424625
@lidavidm ok, then I will merge all existing enums that I've created into
one common `TypesEnum` for all the types.
--
This is an automated message from the Apache Git Service.
To r
raulcd commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094424573
@github-actions crossbow submit -g python -g wheels
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
github-actions[bot] commented on PR #47142:
URL: https://github.com/apache/arrow/pull/47142#issuecomment-3094420944
:warning: GitHub issue #46374 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
github-actions[bot] commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094423890
```
no tasks were provided for the job
The Archery job run can be found at:
https://github.com/apache/arrow/actions/runs/16398862798
```
--
This is an automated mes
rok commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094423411
@github-actions crossbow submit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
rmnskb commented on code in PR #47139:
URL: https://github.com/apache/arrow/pull/47139#discussion_r2217750727
##
python/pyarrow/types.py:
##
@@ -46,6 +48,104 @@
lib.Type_STRUCT, lib.Type_MAP} | _UNION_TYPES
+def _combine_enums(name: str, *enums: Enum) -> En
github-actions[bot] commented on PR #47142:
URL: https://github.com/apache/arrow/pull/47142#issuecomment-3094420581
:warning: GitHub issue #46374 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
github-actions[bot] commented on PR #47142:
URL: https://github.com/apache/arrow/pull/47142#issuecomment-3094419149
:warning: GitHub issue #46374 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
github-actions[bot] commented on PR #47142:
URL: https://github.com/apache/arrow/pull/47142#issuecomment-3094416788
:warning: GitHub issue #46374 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
github-actions[bot] commented on PR #47142:
URL: https://github.com/apache/arrow/pull/47142#issuecomment-3094415615
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue f
soroushrasti opened a new pull request, #47142:
URL: https://github.com/apache/arrow/pull/47142
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache
rok commented on code in PR #47141:
URL: https://github.com/apache/arrow/pull/47141#discussion_r2217743450
##
python/pyproject.toml:
##
@@ -27,7 +27,7 @@ requires = [
# configuring setuptools_scm in pyproject.toml requires
# versions released after 2022
"setuptool
github-actions[bot] commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094393761
:warning: GitHub issue #45867 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
rok commented on issue #45867:
URL: https://github.com/apache/arrow/issues/45867#issuecomment-3094361773
> top-level LICENSE.txt/NOTICE.txt include unrelated information for
python/. (sdist includes only python/ and wheels includes only binaries of cpp/
and python/.)
But it's a symli
github-actions[bot] commented on PR #47141:
URL: https://github.com/apache/arrow/pull/47141#issuecomment-3094353227
:warning: GitHub issue #45867 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
paddyroddy opened a new pull request, #47141:
URL: https://github.com/apache/arrow/pull/47141
### Rationale for this change
When building locally, I get many errors along the lines of
```
Please ensure the files specified are contained by the root
of the Python package (normal
paddyroddy commented on issue #47137:
URL: https://github.com/apache/arrow/issues/47137#issuecomment-3094337626
Happy to fix. Just need to work out how to do it first — on my TODO list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lidavidm commented on code in PR #47139:
URL: https://github.com/apache/arrow/pull/47139#discussion_r2217692306
##
python/pyarrow/types.py:
##
@@ -46,6 +48,104 @@
lib.Type_STRUCT, lib.Type_MAP} | _UNION_TYPES
+def _combine_enums(name: str, *enums: Enum) ->
lidavidm commented on issue #47123:
URL: https://github.com/apache/arrow/issues/47123#issuecomment-3094198043
Ah I see...that confused me since I would have figured `BaseExtensionType`
was an ABC, but rather it seems BaseExtensionType is the C++ class and
ExtensionType is the Python-specifi
Yuan-Ru-Lin commented on issue #434:
URL: https://github.com/apache/arrow-julia/issues/434#issuecomment-3093807424
> Is there a way to get the batch-offset table with Arrow.jl, if the data is
written in "file" mode?
Yes.
Consider `test.arrow` generated by the following script.
80 matches
Mail list logo
