willtemperley commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239762420
Tests and lint are green on my fork. I'm seeing an intermittent error with
GPG - it's failing on 5.10 now:
https://github.com/willtemperley/arrow-swift/actions/runs/173526040
willtemperley commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239762167
Tests and lint are green on my fork. I'm seeing an intermittent error with
GPG - it's failing on 5.10 now:
https://github.com/willtemperley/arrow-swift/actions/runs/173526040
joechenrh commented on code in PR #485:
URL: https://github.com/apache/arrow-go/pull/485#discussion_r2312235038
##
parquet/internal/encoding/typed_encoder.go:
##
@@ -556,6 +572,36 @@ func (enc *DictByteArrayEncoder) Type() parquet.Type {
return parquet.Types.ByteArray
}
kou commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239729144
We don't need to add auto generated files:
[0001-Don-t-add-auto-generated-files.patch](https://github.com/user-attachments/files/22062446/0001-Don-t-add-auto-generated-files.patch)
(
willtemperley commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239727929
> Ah, you mean that you can't edit the current implementations/tests on your
Xcode with the current structure, right? If we want to work on #82 before this,
people who can edit the
willtemperley commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239716832
> Why? We can generate test files by running `ci/scripts/build.sh` locally,
right? We don't need to add auto generated files for local test, right?
I'm not exactly sure what y
kou commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239714157
Ah, you mean that you can't edit the current implementations/tests on your
Xcode with the current structure, right?
If we want to work on #82 before this, people who can edit the current
i
sap1ens commented on issue #833:
URL: https://github.com/apache/arrow-java/issues/833#issuecomment-3239702989
> or are you two working together?
nope :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
lidavidm commented on issue #833:
URL: https://github.com/apache/arrow-java/issues/833#issuecomment-3239701976
CC @martin-traverse (or are you two working together?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kou commented on PR #560:
URL: https://github.com/apache/arrow-julia/pull/560#issuecomment-3239697483
Could you split this to smaller PRs for easy to review?
For example, we don't need to mix C data interface support and tensor
support, right?
> While having a career worth of codin
wgtmac commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2312164211
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,584 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadata i
ianmcook commented on issue #3258:
URL: https://github.com/apache/arrow-adbc/issues/3258#issuecomment-3239641184
I confirmed through informal testing that the Java driver manager works with
manifests. Closing this issue should only require adding tests and docs.
--
This is an automated me
etseidl commented on code in PR #8251:
URL: https://github.com/apache/arrow-rs/pull/8251#discussion_r2312149350
##
parquet/benches/metadata.rs:
##
@@ -93,7 +94,18 @@ fn encoded_meta() -> Vec {
index_page_offset: Some(rng.random()),
jecsand838 commented on code in PR #8254:
URL: https://github.com/apache/arrow-rs/pull/8254#discussion_r2312146709
##
arrow-avro/src/reader/record.rs:
##
@@ -590,10 +590,23 @@ impl Decoder {
)));
}
}
+
ollemartensson commented on issue #184:
URL: https://github.com/apache/arrow-julia/issues/184#issuecomment-3239576973
Hey I'm also in need of this so I did some research and put claude on the
task. It has the complete implementation + tensor support. #560
--
This is an automated message
yongkyunlee commented on code in PR #8254:
URL: https://github.com/apache/arrow-rs/pull/8254#discussion_r2312116105
##
arrow-avro/src/reader/record.rs:
##
@@ -590,10 +590,23 @@ impl Decoder {
)));
}
}
+
yongkyunlee commented on code in PR #8254:
URL: https://github.com/apache/arrow-rs/pull/8254#discussion_r2312115413
##
arrow-avro/src/reader/record.rs:
##
@@ -590,10 +590,23 @@ impl Decoder {
)));
}
}
+
yongkyunlee commented on code in PR #8254:
URL: https://github.com/apache/arrow-rs/pull/8254#discussion_r2312115413
##
arrow-avro/src/reader/record.rs:
##
@@ -590,10 +590,23 @@ impl Decoder {
)));
}
}
+
kou commented on issue #45722:
URL: https://github.com/apache/arrow/issues/45722#issuecomment-3239551082
You can proceed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
andishgar commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2312114957
##
cpp/src/arrow/record_batch_test.cc:
##
@@ -62,7 +63,49 @@ using util::Float16;
class TestRecordBatch : public ::testing::Test {};
TEST_F(TestRecordBatch, Equal
kou commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2312114551
##
cpp/src/arrow/record_batch.h:
##
@@ -118,22 +118,32 @@ class ARROW_EXPORT RecordBatch {
static Result> FromStructArray(
const std::shared_ptr& array, MemoryPoo
kou commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2312114359
##
cpp/src/arrow/record_batch.cc:
##
@@ -349,44 +349,27 @@ bool CanIgnoreNaNInEquality(const RecordBatch& batch,
const EqualOptions& opts)
bool RecordBatch::Equals(cons
kou commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2312112892
##
cpp/src/arrow/record_batch_test.cc:
##
@@ -62,7 +63,49 @@ using util::Float16;
class TestRecordBatch : public ::testing::Test {};
TEST_F(TestRecordBatch, Equals) {
-
kou commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239548265
BTW, could you fix the lint failures?
https://github.com/apache/arrow-swift/actions/runs/17342772415/job/49252032542?pr=77
FYI: You can run CI on your fork
https://github.com/moreno
kou commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2312111963
##
cpp/src/arrow/record_batch_test.cc:
##
@@ -62,7 +63,49 @@ using util::Float16;
class TestRecordBatch : public ::testing::Test {};
TEST_F(TestRecordBatch, Equals) {
-
ollemartensson opened a new pull request, #560:
URL: https://github.com/apache/arrow-julia/pull/560
### Motivation
The C Data Interface is the formal, ABI-stable contract that allows
different language runtimes to exchange complex datasets with zero
serialization or memory copying ov
kou commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-323951
Why? We can generate test files by running `ci/scripts/build.sh` locally,
right? We don't need to add auto generated files for local test, right?
--
This is an automated message from the Ap
jecsand838 commented on code in PR #8254:
URL: https://github.com/apache/arrow-rs/pull/8254#discussion_r2312110172
##
arrow-avro/src/reader/record.rs:
##
@@ -590,10 +590,23 @@ impl Decoder {
)));
}
}
+
jecsand838 commented on code in PR #8254:
URL: https://github.com/apache/arrow-rs/pull/8254#discussion_r2312095645
##
arrow-avro/src/reader/record.rs:
##
@@ -1471,4 +1485,111 @@ mod tests {
assert!(int_array.is_null(0)); // row1 is null
assert_eq!(int_array.val
jecsand838 commented on code in PR #8254:
URL: https://github.com/apache/arrow-rs/pull/8254#discussion_r2312094980
##
arrow-avro/src/reader/record.rs:
##
@@ -1471,4 +1485,111 @@ mod tests {
assert!(int_array.is_null(0)); // row1 is null
assert_eq!(int_array.val
jecsand838 commented on code in PR #8254:
URL: https://github.com/apache/arrow-rs/pull/8254#discussion_r2312094616
##
arrow-avro/src/reader/record.rs:
##
@@ -740,6 +753,7 @@ fn sign_extend_to(raw: &[u8]) ->
Result<[u8; N], ArrowError> {
mod tests {
use super::*;
use
jecsand838 commented on PR #8254:
URL: https://github.com/apache/arrow-rs/pull/8254#issuecomment-3239516618
I did add support for this in https://github.com/apache/arrow-rs/pull/8220
and was able to locally run the tests you included successfully. Would you be
open to getting those changes
jecsand838 commented on issue #8253:
URL: https://github.com/apache/arrow-rs/issues/8253#issuecomment-3239493602
@yongkyunlee Thank you for making this issue!
I already have this change covered in an open PR:
https://github.com/apache/arrow-rs/pull/8220
--
This is an automated mess
michaelfeil commented on issue #473:
URL:
https://github.com/apache/arrow-rs-object-store/issues/473#issuecomment-3239462659
Sounds good. Yes, adding that feature would be helpful. I am happy to
contribute this.
workaround for object_storage: Unset all the env variable globally.
Arkur745 commented on issue #45722:
URL: https://github.com/apache/arrow/issues/45722#issuecomment-3239415800
Hi, I’d like to work on this issue — is anyone currently progressing? If
not, may I proceed? @pitrou
--
This is an automated message from the Apache Git Service.
To respond to t
Arkur745 commented on issue #45722:
URL: https://github.com/apache/arrow/issues/45722#issuecomment-3239413822
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
Arkur745 commented on issue #46872:
URL: https://github.com/apache/arrow/issues/46872#issuecomment-3239416114
Hi , I’d like to work on this issue — is anyone currently progressing? If
not, may I proceed?
--
This is an automated message from the Apache Git Service.
To respond to the messag
Arkur745 commented on issue #46872:
URL: https://github.com/apache/arrow/issues/46872#issuecomment-3239412330
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
Arkur745 commented on issue #45722:
URL: https://github.com/apache/arrow/issues/45722#issuecomment-3239414021
can you please assign this task to me, i would like to work on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Dhruvit96 commented on PR #475:
URL: https://github.com/apache/arrow-go/pull/475#issuecomment-3239349059
FWIW, while exploring issues and PRs, I noticed that using ParseFloat isn’t
the right solution. The problem is that it loses precision for integers larger
than 2^53 (for example, "900719
andishgar commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2311983186
##
cpp/src/arrow/record_batch_test.cc:
##
@@ -62,7 +63,49 @@ using util::Float16;
class TestRecordBatch : public ::testing::Test {};
TEST_F(TestRecordBatch, Equal
andishgar commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2311976440
##
cpp/src/arrow/record_batch_test.cc:
##
@@ -62,7 +63,49 @@ using util::Float16;
class TestRecordBatch : public ::testing::Test {};
TEST_F(TestRecordBatch, Equal
andishgar commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2311965810
##
cpp/src/arrow/record_batch.h:
##
@@ -118,22 +118,32 @@ class ARROW_EXPORT RecordBatch {
static Result> FromStructArray(
const std::shared_ptr& array, Mem
andishgar commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2311965810
##
cpp/src/arrow/record_batch.h:
##
@@ -118,22 +118,32 @@ class ARROW_EXPORT RecordBatch {
static Result> FromStructArray(
const std::shared_ptr& array, Mem
andishgar commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2311965810
##
cpp/src/arrow/record_batch.h:
##
@@ -118,22 +118,32 @@ class ARROW_EXPORT RecordBatch {
static Result> FromStructArray(
const std::shared_ptr& array, Mem
andishgar commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2311953602
##
cpp/src/arrow/record_batch.cc:
##
@@ -349,44 +349,27 @@ bool CanIgnoreNaNInEquality(const RecordBatch& batch,
const EqualOptions& opts)
bool RecordBatch::Equal
andishgar commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2311949306
##
cpp/src/arrow/record_batch_test.cc:
##
@@ -62,7 +63,49 @@ using util::Float16;
class TestRecordBatch : public ::testing::Test {};
TEST_F(TestRecordBatch, Equal
andishgar commented on code in PR #47204:
URL: https://github.com/apache/arrow/pull/47204#discussion_r2311944023
##
cpp/src/arrow/record_batch_test.cc:
##
@@ -62,7 +63,49 @@ using util::Float16;
class TestRecordBatch : public ::testing::Test {};
TEST_F(TestRecordBatch, Equal
andishgar commented on PR #47204:
URL: https://github.com/apache/arrow/pull/47204#issuecomment-3239258251
Thank you for your feedback. I will look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
willtemperley commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239252382
Yes, before #77 it was impossible to test locally. The work @morenonicolelli
did enabled me to run the tests in a standard Swift testing environment, so I
was able to refactor them.
morenonicolelli commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239208269
in my opinion this two issues are strictly linked. you can't resolve tests
with the old structure and you can't close new structure with the old tests
--
This is an automated me
kou commented on issue #82:
URL: https://github.com/apache/arrow-swift/issues/82#issuecomment-3239206057
> Or at least document a generation step a developer can run locally.
FYI: We can build and run tests by `docker compose run ubuntu` or
`ci/scripts/build.sh $(pwd) ../arrow-swift.b
kou commented on issue #82:
URL: https://github.com/apache/arrow-swift/issues/82#issuecomment-3239204514
> Can these just be checked into the repo?
If you want to choose this approach, please rewrite these tests to use Swift
not Go instead of this approach.
See also:
https://gith
kou commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239203667
Please don't mix https://github.com/apache/arrow-swift/issues/82 and this.
If we need to fix #82 for this, let's work on #82 before this.
We can restart this after #82 is completed.
--
willtemperley commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239148968
> @willtemperley I'm struggling with CI/CD. if fixed we can move to other
improvements and if you want I can help. in my opinion test have to be make
during swift test not during CI
willtemperley commented on code in PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#discussion_r2311873409
##
Package.swift:
##
@@ -23,67 +23,69 @@ import PackageDescription
let package = Package(
name: "Arrow",
platforms: [
-.macOS(.v10_15)
+
kou commented on code in PR #28:
URL: https://github.com/apache/arrow-dotnet/pull/28#discussion_r2311866770
##
.github/workflows/test.yaml:
##
@@ -83,3 +83,14 @@ jobs:
- name: Test
shell: bash
run: ci/scripts/test.sh $(pwd)
+
+ docs:
+name: Build Do
morenonicolelli commented on PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#issuecomment-3239111930
@willtemperley I'm struggling with CI/CD. if fixed we can move to other
improvements and if you want I can help. in my opinion test have to be make
during swift test not during CI
morenonicolelli commented on code in PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#discussion_r2311863043
##
Package.swift:
##
@@ -23,67 +23,69 @@ import PackageDescription
let package = Package(
name: "Arrow",
platforms: [
-.macOS(.v10_15)
+
kou commented on code in PR #3115:
URL: https://github.com/apache/arrow-adbc/pull/3115#discussion_r2311861613
##
.github/workflows/csharp_databricks_e2e.yml:
##
@@ -0,0 +1,147 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreeme
kou commented on code in PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#discussion_r2311855635
##
Tests/ArrowTests/IPCTests.swift:
##
@@ -329,7 +329,7 @@ final class IPCFileReaderTests: XCTestCase { //
swiftlint:disable:this type_body
}
func testFileRead
kou commented on issue #78:
URL: https://github.com/apache/arrow-swift/issues/78#issuecomment-3239090706
I think that it's a temporary solution.
We should generate `testdata_*.arrow` by Swift instead of Go.
For integration test against other implementation, we should use Archery
willtemperley commented on code in PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#discussion_r2311853880
##
Tests/ArrowTests/IPCTests.swift:
##
@@ -329,7 +329,7 @@ final class IPCFileReaderTests: XCTestCase { //
swiftlint:disable:this type_body
}
func te
kou commented on code in PR #77:
URL: https://github.com/apache/arrow-swift/pull/77#discussion_r2311852200
##
Tests/ArrowTests/IPCTests.swift:
##
@@ -329,7 +329,7 @@ final class IPCFileReaderTests: XCTestCase { //
swiftlint:disable:this type_body
}
func testFileRead
wgtmac commented on PR #46906:
URL: https://github.com/apache/arrow/pull/46906#issuecomment-3239025314
I tried to reproduce it on my side with ASAN enabled. It didn't fail but got
the suspicious output:
```
[ RUN ] TestAdapterRead.ReadIntAndStringFileMultipleStripes
mimallo
wgtmac commented on PR #46906:
URL: https://github.com/apache/arrow/pull/46906#issuecomment-3239017658
That's weird. The `GetFieldMetadata` function does not call
`orc::TypeImpl::getTypeByColumnId` internally. Even the ORC library does not
call it internally.
```
Result> GetFieldM
66 matches
Mail list logo
