github-actions[bot] commented on PR #47484:
URL: https://github.com/apache/arrow/pull/47484#issuecomment-3252168066
Revision: 4fe33ca1f85094a34e6be60cb4c4e2dc2208b692
Submitted crossbow builds: [ursacomputing/crossbow @
actions-7c37c8ca43](https://github.com/ursacomputing/crossbow/bra
raulcd commented on code in PR #47476:
URL: https://github.com/apache/arrow/pull/47476#discussion_r2321008804
##
cpp/CMakeLists.txt:
##
@@ -351,6 +351,12 @@ endif()
include(SetupCxxFlags)
+if(${CMAKE_CXX_FLAGS_DEBUG} MATCHES "-Og")
Review Comment:
Thanks @kou , should w
benibus commented on code in PR #46973:
URL: https://github.com/apache/arrow/pull/46973#discussion_r2320980286
##
cpp/src/arrow/testing/random.cc:
##
@@ -1089,10 +1144,25 @@ std::shared_ptr
RandomArrayGenerator::ArrayOf(const Field& field, int64_t
GENERATE_INTEGRAL_CASE(
pitrou commented on code in PR #46973:
URL: https://github.com/apache/arrow/pull/46973#discussion_r2320920322
##
cpp/src/arrow/testing/random.cc:
##
@@ -1089,10 +1144,25 @@ std::shared_ptr
RandomArrayGenerator::ArrayOf(const Field& field, int64_t
GENERATE_INTEGRAL_CASE(I
ianmcook commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320486506
##
docs/source/glossary.rst:
##
@@ -46,16 +46,24 @@ Glossary
protocol, but exposes the JDBC client API instead.
Review Comment:
Thanks!
The problem
github-actions[bot] commented on PR #47494:
URL: https://github.com/apache/arrow/pull/47494#issuecomment-3251427775
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue f
amoeba commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320009216
##
docs/source/glossary.rst:
##
@@ -46,16 +46,24 @@ Glossary
protocol, but exposes the JDBC client API instead.
driver manager
- A library that helps
kou commented on PR #47495:
URL: https://github.com/apache/arrow/pull/47495#issuecomment-3251919582
This is another implementation for
https://github.com/apache/arrow/pull/47476#discussion_r2318810411 .
--
This is an automated message from the Apache Git Service.
To respond to the message
kou commented on code in PR #47476:
URL: https://github.com/apache/arrow/pull/47476#discussion_r2320858240
##
cpp/CMakeLists.txt:
##
@@ -351,6 +351,12 @@ endif()
include(SetupCxxFlags)
+if(${CMAKE_CXX_FLAGS_DEBUG} MATCHES "-Og")
Review Comment:
FYI: https://github.com/a
github-actions[bot] commented on PR #47495:
URL: https://github.com/apache/arrow/pull/47495#issuecomment-3251916445
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue f
alexeykudinkin commented on issue #47493:
URL: https://github.com/apache/arrow/issues/47493#issuecomment-3251853853
Correcting myself on the record here -- asertion has to actually be
```
assert list(bs)[0].num_rows == 1
```
And it actually works properly. Closing this
conbench-apache-arrow[bot] commented on PR #47448:
URL: https://github.com/apache/arrow/pull/47448#issuecomment-3251772972
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 743d0afd05573f0160ab9e15d09bd79a5387d1a4.
There weren't
lidavidm commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320765437
##
docs/source/glossary.rst:
##
@@ -45,16 +45,30 @@ Glossary
PostgreSQL wire protocol. The JDBC PostgreSQL driver uses the same wire
protocol, but expo
WillAyd commented on PR #46906:
URL: https://github.com/apache/arrow/pull/46906#issuecomment-3251728314
Ah nice find! Unfortunately, the conda installation seems to be pinning orc
to the 1.9.0 installation (I noticed this also in
https://github.com/apache/arrow/pull/47455#issuecomment-32495
kylebarron opened a new pull request, #8275:
URL: https://github.com/apache/arrow-rs/pull/8275
# Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an
amoeba commented on code in PR #3393:
URL: https://github.com/apache/arrow-adbc/pull/3393#discussion_r2320738263
##
rust/driver_manager/src/lib.rs:
##
@@ -182,6 +182,20 @@ impl DriverInfo {
let manifest = DeTable::parse(&contents)
.map_err(|e| Error::with_m
ianmcook commented on PR #3393:
URL: https://github.com/apache/arrow-adbc/pull/3393#issuecomment-3251688643
I will add a commit with some docs updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
zanmato1984 commented on code in PR #43698:
URL: https://github.com/apache/arrow/pull/43698#discussion_r2320723308
##
cpp/src/arrow/util/thread_pool.h:
##
@@ -603,11 +605,16 @@ typename Fut::SyncType
RunSynchronously(FnOnce get_future,
/// the iterator will use the calling t
amoeba commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320477872
##
docs/source/rust/driver_manager.rst:
##
@@ -20,34 +20,35 @@ Driver Manager
==
This document describes the installation and usage of the Rust :term:
lidavidm commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320476487
##
docs/source/rust/driver_manager.rst:
##
@@ -20,34 +20,35 @@ Driver Manager
==
This document describes the installation and usage of the Rust :ter
WillAyd commented on PR #46906:
URL: https://github.com/apache/arrow/pull/46906#issuecomment-3251492089
The CMake config could be used as well but it is also not part of the conda
installation
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
Rich-T-kid commented on code in PR #7713:
URL: https://github.com/apache/arrow-rs/pull/7713#discussion_r2320634788
##
arrow-cast/src/cast/run_array.rs:
##
@@ -0,0 +1,269 @@
+use crate::cast::*;
+
+/// Attempts to cast a Run-End Encoded array to another type, handling both
REE-t
amoeba opened a new pull request, #3394:
URL: https://github.com/apache/arrow-adbc/pull/3394
Follow on to #3388
Currently a draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
joechenrh commented on PR #485:
URL: https://github.com/apache/arrow-go/pull/485#issuecomment-3251450823
Sorry, I may not have time to do this these days, I perfer hold this, I'll
try to add test(maybe not too much) this week.
--
This is an automated message from the Apache Git Service.
T
Rich-T-kid commented on code in PR #7713:
URL: https://github.com/apache/arrow-rs/pull/7713#discussion_r2320628147
##
arrow-cast/src/cast/run_array.rs:
##
@@ -0,0 +1,269 @@
+use crate::cast::*;
+
+/// Attempts to cast a Run-End Encoded array to another type, handling both
REE-t
kou commented on code in PR #47164:
URL: https://github.com/apache/arrow/pull/47164#discussion_r2320611094
##
cpp/src/arrow/table.h:
##
@@ -203,11 +204,24 @@ class ARROW_EXPORT Table {
/// \brief Return the number of rows (equal to each column's logical length)
int64_t num
wgtmac commented on PR #46906:
URL: https://github.com/apache/arrow/pull/46906#issuecomment-3251412565
Unfortunately I'm not familiar with `pkgconfig` so it may still be the case
in the near future. Is there any workaround?
--
This is an automated message from the Apache Git Service.
To r
kou commented on PR #47164:
URL: https://github.com/apache/arrow/pull/47164#issuecomment-3251256732
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
kou commented on issue #47367:
URL: https://github.com/apache/arrow/issues/47367#issuecomment-3251363179
Thanks for working on the vcpkg log output! (Sorry for not working on it
yet...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
amoeba commented on PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#issuecomment-3251215862
All conversations have been resolved, I re-requested reviews and will wait
to merge until both are ✔️.
--
This is an automated message from the Apache Git Service.
To respond to the m
amoeba commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320528469
##
docs/source/glossary.rst:
##
@@ -46,16 +46,24 @@ Glossary
protocol, but exposes the JDBC client API instead.
Review Comment:
Changed in 80ad44651.
--
CurtHagenlocher merged PR #3392:
URL: https://github.com/apache/arrow-adbc/pull/3392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
ianmcook commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320489361
##
docs/source/glossary.rst:
##
@@ -46,16 +46,24 @@ Glossary
protocol, but exposes the JDBC client API instead.
Review Comment:
My comment above speaks to
amoeba commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320476512
##
docs/source/glossary.rst:
##
@@ -46,16 +46,24 @@ Glossary
protocol, but exposes the JDBC client API instead.
Review Comment:
That's a nice improvement. I
amoeba commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320479769
##
docs/source/rust/driver_manager.rst:
##
@@ -20,34 +20,35 @@ Driver Manager
==
This document describes the installation and usage of the Rust :term:
amoeba commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320478902
##
docs/source/rust/driver_manager.rst:
##
@@ -20,34 +20,35 @@ Driver Manager
==
This document describes the installation and usage of the Rust :term:
amoeba commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320473284
##
docs/source/rust/driver_manager.rst:
##
@@ -19,11 +19,10 @@
Driver Manager
==
-The driver manager is a library that implements the ADBC API by dele
amoeba commented on issue #3385:
URL: https://github.com/apache/arrow-adbc/issues/3385#issuecomment-3251124037
I'm reworking this in #3388 and updated this page in
09016d92ac65005dc25745110c17a67e687077aa.
--
This is an automated message from the Apache Git Service.
To respond to the mess
MasslessParticle opened a new pull request, #489:
URL: https://github.com/apache/arrow-go/pull/489
### Rationale for this change
When dictionary encoding is enabled and and repetitions are set to
`required`, the `null_count` statistic is negative because `defLevels` is
always 0.
#
lidavidm commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320447141
##
docs/source/glossary.rst:
##
@@ -46,15 +46,22 @@ Glossary
protocol, but exposes the JDBC client API instead.
driver manager
- A library that help
gitfy commented on PR #41311:
URL: https://github.com/apache/arrow/pull/41311#issuecomment-3251079858
i lost track...will try to add the test. It isnt trivial hence i left it
originally. We had occurrence of this issue when the system is way too busy
--
This is an automated message fr
MasslessParticle commented on PR #489:
URL: https://github.com/apache/arrow-go/pull/489#issuecomment-3251056346
I've added a new issue for the encoding panic I mentioned
[here](https://github.com/apache/arrow-go/issues/490)
--
This is an automated message from the Apache Git Service.
To r
alexeykudinkin commented on issue #47493:
URL: https://github.com/apache/arrow/issues/47493#issuecomment-3251049531
Looking at the code it seems that the following is the culprit:
- Specified `columns` aren't checked whether they include columns used in
the filter
- Batches are p
ianmcook commented on PR #3393:
URL: https://github.com/apache/arrow-adbc/pull/3393#issuecomment-3251042434
Maybe we should use `ADBC_STATUS_NOT_IMPLEMENTED` instead of
`ADBC_STATUS_INVALID_ARGUMENT`?
--
This is an automated message from the Apache Git Service.
To respond to the message,
WillAyd commented on issue #47465:
URL: https://github.com/apache/arrow/issues/47465#issuecomment-3250978412
Hmm interesting. At least with the Meson configuration it should just be:
```python
absl_log_severity_dep = dependency('absl_log_severity')
```
I'll have to trudge
felipecrv commented on PR #2998:
URL: https://github.com/apache/arrow-adbc/pull/2998#issuecomment-3250958540
I'm closing this one in favor of @jasonlin45's PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
felipecrv closed pull request #2998: feat(go/adbc): Initial implement
Databricks go ADBC driver
URL: https://github.com/apache/arrow-adbc/pull/2998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
kou opened a new pull request, #47492:
URL: https://github.com/apache/arrow/pull/47492
### Rationale for this change
We can't set include directories to targets that aren't created by our CMake
configuration.
### What changes are included in this PR?
Set include director
kou commented on issue #47465:
URL: https://github.com/apache/arrow/issues/47465#issuecomment-3250915428
I'm negative to use Abseil because it's difficult to maintain...
For example, `build_absl()` has almost 1000 lines...:
https://github.com/apache/arrow/blob/main/cpp/cmake_modules/T
conbench-apache-arrow[bot] commented on PR #47476:
URL: https://github.com/apache/arrow/pull/47476#issuecomment-3250923773
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 2284234ca7acaeb304fbb56c4b2fed696b891fad.
There weren't
github-actions[bot] commented on PR #47492:
URL: https://github.com/apache/arrow/pull/47492#issuecomment-3250900386
:warning: GitHub issue #47491 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kou merged PR #47487:
URL: https://github.com/apache/arrow/pull/47487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on issue #47446:
URL: https://github.com/apache/arrow/issues/47446#issuecomment-3250875863
Issue resolved by pull request 47448
https://github.com/apache/arrow/pull/47448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
birschick-bq commented on code in PR #3392:
URL: https://github.com/apache/arrow-adbc/pull/3392#discussion_r2320176131
##
csharp/src/Drivers/Apache/Spark/SparkStandardConnection.cs:
##
@@ -219,6 +219,6 @@ internal override IArrowArrayStream NewReader(T
statement, Schema schema,
kou merged PR #47448:
URL: https://github.com/apache/arrow/pull/47448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on issue #47486:
URL: https://github.com/apache/arrow/issues/47486#issuecomment-3250864694
Issue resolved by pull request 47487
https://github.com/apache/arrow/pull/47487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou commented on code in PR #47476:
URL: https://github.com/apache/arrow/pull/47476#discussion_r2320252683
##
cpp/CMakeLists.txt:
##
@@ -351,6 +351,12 @@ endif()
include(SetupCxxFlags)
+if(${CMAKE_CXX_FLAGS_DEBUG} MATCHES "-Og")
Review Comment:
No.
In general, we
CurtHagenlocher commented on code in PR #3392:
URL: https://github.com/apache/arrow-adbc/pull/3392#discussion_r2320143902
##
csharp/src/Drivers/Apache/Spark/SparkStandardConnection.cs:
##
@@ -219,6 +219,6 @@ internal override IArrowArrayStream NewReader(T
statement, Schema sche
birschick-bq opened a new pull request, #3392:
URL: https://github.com/apache/arrow-adbc/pull/3392
fix column metadata index offset for Spark standard.
Previous calls to GetObjects would throw an "index out of range" exception.
--
This is an automated message from the Apache Git Ser
zeroshade commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319910055
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,591 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadat
amoeba commented on code in PR #3388:
URL: https://github.com/apache/arrow-adbc/pull/3388#discussion_r2320043892
##
docs/source/python/driver_manager.rst:
##
@@ -21,15 +21,11 @@
Driver Manager
==
-The driver manager is a library that provides bindings to the ADBC
pitrou commented on issue #47367:
URL: https://github.com/apache/arrow/issues/47367#issuecomment-3250386946
Seems to match this StackOverflow question:
https://stackoverflow.com/questions/40018405/cannot-open-include-file-io-h-no-such-file-or-directory
--
This is an automated message f
amoeba commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319886014
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,591 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadata i
zeroshade commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319877197
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,584 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadat
zeroshade commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319876458
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,584 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadat
raulcd commented on issue #47367:
URL: https://github.com/apache/arrow/issues/47367#issuecomment-3250347941
Update: Both Arrow CPP and the Windows wheel were built successfully on that
job. It failed due to a couple of test failures that were already happening on
the nightly jobs some time
ianmcook commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319831354
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,591 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadata
scovich commented on code in PR #8274:
URL: https://github.com/apache/arrow-rs/pull/8274#discussion_r2318689900
##
arrow-avro/src/schema.rs:
##
@@ -790,12 +856,35 @@ fn merge_extras(schema: Value, mut extras:
JsonMap) -> Value {
}
}
-// Convert an Arrow `DataType` into
zeroshade commented on PR #485:
URL: https://github.com/apache/arrow-go/pull/485#issuecomment-3250207202
@joechenrh do you want me to hold this open for you to add a test? Or would
you want to add the test as a separate PR given this is already a fairly large
one?
--
This is an automated
ianmcook commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319729955
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -45,7 +45,11 @@ types:
* The specification text to be added *must* follow these requirements:
- 1) It *must*
ianmcook commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319729955
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -45,7 +45,11 @@ types:
* The specification text to be added *must* follow these requirements:
- 1) It *must*
zeroshade commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319724839
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,591 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadat
rok commented on issue #47435:
URL: https://github.com/apache/arrow/issues/47435#issuecomment-3250176870
@changhu-m if there's a reason we'd need a builder or a factory go for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
zeroshade commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319710678
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,591 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadat
zeroshade commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319710678
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,591 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadat
zanmato1984 commented on code in PR #47459:
URL: https://github.com/apache/arrow/pull/47459#discussion_r2319678070
##
cpp/src/arrow/compute/expression_test.cc:
##
@@ -800,6 +804,42 @@ TEST(Expression, BindWithImplicitCasts) {
ExpectBindsTo(cmp(field_ref("i32"),
literal(std
github-actions[bot] commented on PR #47488:
URL: https://github.com/apache/arrow/pull/47488#issuecomment-3250112457
:warning: GitHub issue #47472 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
SHARANcanCODE opened a new pull request, #47488:
URL: https://github.com/apache/arrow/pull/47488
### Rationale for this change
This PR addresses issue #47472 by adding a new section to list third-party
open source implementations of Apache Arrow.
### What changes are included i
changhu-m commented on issue #47435:
URL: https://github.com/apache/arrow/issues/47435#issuecomment-3250073512
@adamreeve - I can take a stab at it. Should I follow the builder pattern
in c++?
Like this:
https://github.com/apache/arrow/blob/2284234ca7acaeb304fbb56c4b2fed696b
conbench-apache-arrow[bot] commented on PR #47479:
URL: https://github.com/apache/arrow/pull/47479#issuecomment-3250064050
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 8ccdbe78063ad4b43872b8826aba37a1a73dc951.
There weren't
amoeba commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319541766
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,591 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadata i
zeroshade commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319586882
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,591 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadat
raulcd commented on issue #47367:
URL: https://github.com/apache/arrow/issues/47367#issuecomment-325586
I've patched vcpkg and I've been able to [get some
logs](https://github.com/ursacomputing/crossbow/actions/runs/17437661576/job/49511881847):
```
-- Check for working CXX compil
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319536697
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319573067
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319572219
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319564938
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
zeroshade commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319560013
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,591 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadat
zeroshade commented on code in PR #47456:
URL: https://github.com/apache/arrow/pull/47456#discussion_r2319565529
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -417,7 +421,591 @@ better zero-copy compatibility with various systems that
also store booleans usi
Metadat
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319547667
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319542322
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319540511
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319532082
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319532082
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319518770
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319514772
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319512345
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319504021
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -299,385 +552,988 @@ class RleEncoder {
uint8_t* literal_indicator_byte_;
};
+/*
+ *
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319495572
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -84,32 +85,278 @@ namespace util {
/// (total 26 bytes, 1 byte overhead)
//
+class RleRun {
+ public:
+ using b
pitrou commented on code in PR #47294:
URL: https://github.com/apache/arrow/pull/47294#discussion_r2319494732
##
cpp/src/arrow/util/rle_encoding_internal.h:
##
@@ -118,50 +365,56 @@ class RleDecoder {
/// input with zeros. Since the encoding does not differentiate between
1 - 100 of 289 matches
Mail list logo
