kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450383737
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450344074
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450332885
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450327095
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450318972
##
File path: cpp/src/arrow/scalar.cc
##
@@ -185,6 +192,35 @@
DictionaryScalar::DictionaryScalar(std::shared_ptr type)
0)
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450317608
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r450317608
##
File path: cpp/src/arrow/scalar_test.cc
##
@@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) {
ASSERT_RAISES(Invalid,
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r449512190
##
File path: python/pyarrow/tests/test_array.py
##
@@ -583,12 +584,14 @@ def test_dictionary_from_numpy():
assert d2.dictionary.to_pylist() ==
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r448620980
##
File path: python/pyarrow/scalar.pxi
##
@@ -16,1198 +16,745 @@
# under the License.
-_NULL = NA = None
+import collections
cdef class Scalar:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r448589973
##
File path: python/pyarrow/scalar.pxi
##
@@ -1217,21 +764,50 @@ cdef dict _scalar_classes = {
_Type_INT16: Int16Scalar,
_Type_INT32:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r448589857
##
File path: python/pyarrow/scalar.pxi
##
@@ -1217,21 +764,50 @@ cdef dict _scalar_classes = {
_Type_INT16: Int16Scalar,
_Type_INT32:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r448560952
##
File path: python/pyarrow/scalar.pxi
##
@@ -1217,21 +767,95 @@ cdef dict _scalar_classes = {
_Type_INT16: Int16Scalar,
_Type_INT32:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r448560164
##
File path: python/pyarrow/scalar.pxi
##
@@ -16,1198 +16,748 @@
# under the License.
-_NULL = NA = None
+import collections
cdef class Scalar:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r448559330
##
File path: python/pyarrow/tests/test_convert_builtin.py
##
@@ -968,25 +968,31 @@ def test_sequence_timestamp_from_int_with_unit():
arr_s =
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r448556316
##
File path: python/pyarrow/scalar.pxi
##
@@ -16,1198 +16,745 @@
# under the License.
-_NULL = NA = None
+import collections
cdef class Scalar:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r448551482
##
File path: python/pyarrow/scalar.pxi
##
@@ -16,1198 +16,745 @@
# under the License.
-_NULL = NA = None
+import collections
cdef class Scalar:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r448551033
##
File path: python/pyarrow/tests/test_scalars.py
##
@@ -16,427 +16,443 @@
# under the License.
import datetime
+import decimal
import pytest
-import
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r448551033
##
File path: python/pyarrow/tests/test_scalars.py
##
@@ -16,427 +16,443 @@
# under the License.
import datetime
+import decimal
import pytest
-import
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r448550619
##
File path: python/pyarrow/scalar.pxi
##
@@ -16,1198 +16,748 @@
# under the License.
-_NULL = NA = None
+import collections
cdef class Scalar:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r447758318
##
File path: python/pyarrow/tests/test_scalars.py
##
@@ -16,427 +16,443 @@
# under the License.
import datetime
+import decimal
import pytest
-import
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r447738979
##
File path: python/pyarrow/scalar.pxi
##
@@ -16,1198 +16,745 @@
# under the License.
-_NULL = NA = None
+import collections
cdef class Scalar:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r447734944
##
File path: python/pyarrow/scalar.pxi
##
@@ -16,1198 +16,745 @@
# under the License.
-_NULL = NA = None
+import collections
cdef class Scalar:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r447733611
##
File path: python/pyarrow/scalar.pxi
##
@@ -16,1198 +16,745 @@
# under the License.
-_NULL = NA = None
+import collections
cdef class Scalar:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r447731034
##
File path: python/pyarrow/scalar.pxi
##
@@ -16,1198 +16,745 @@
# under the License.
-_NULL = NA = None
+import collections
cdef class Scalar:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r447725217
##
File path: python/pyarrow/includes/libarrow.pxd
##
@@ -44,6 +44,11 @@ cdef extern from "arrow/util/key_value_metadata.h" namespace
"arrow" nogil:
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r446160460
##
File path: python/pyarrow/scalar.pxi
##
@@ -16,1198 +16,704 @@
# under the License.
-_NULL = NA = None
-
-
cdef class Scalar:
"""
-The
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r446148546
##
File path: python/pyarrow/scalar.pxi
##
@@ -16,1198 +16,704 @@
# under the License.
-_NULL = NA = None
-
-
cdef class Scalar:
"""
-The
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r446148105
##
File path: python/pyarrow/tests/test_parquet.py
##
@@ -2028,7 +2028,7 @@ def test_filters_invalid_pred_op(tempdir,
use_legacy_dataset):
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r446147913
##
File path: python/pyarrow/_dataset.pyx
##
@@ -216,22 +216,18 @@ cdef class Expression:
@staticmethod
def _scalar(value):
cdef:
-
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r445603562
##
File path: python/pyarrow/util.py
##
@@ -41,6 +41,24 @@ def wrapper(*args, **kwargs):
return wrapper
+def _deprecate_class(old_name, new_class,
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r445604627
##
File path: python/pyarrow/tests/test_scalars.py
##
@@ -17,426 +17,395 @@
import datetime
import pytest
-import unittest
import numpy as np
kszucs commented on a change in pull request #7519:
URL: https://github.com/apache/arrow/pull/7519#discussion_r445603562
##
File path: python/pyarrow/util.py
##
@@ -41,6 +41,24 @@ def wrapper(*args, **kwargs):
return wrapper
+def _deprecate_class(old_name, new_class,
32 matches
Mail list logo