[GitHub] [arrow] ovr commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

2021-03-04 Thread GitBox
ovr commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r587848244 ## File path: rust/datafusion/src/physical_plan/group_scalar.rs ## @@ -22,10 +22,12 @@ use std::convert::{From, TryFrom}; use

[GitHub] [arrow] ovr commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

2021-03-03 Thread GitBox
ovr commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r586722375 ## File path: rust/datafusion/src/physical_plan/group_scalar.rs ## @@ -22,10 +22,12 @@ use std::convert::{From, TryFrom}; use

[GitHub] [arrow] ovr commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

2021-03-03 Thread GitBox
ovr commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r586437638 ## File path: rust/datafusion/src/physical_plan/group_scalar.rs ## @@ -22,10 +22,12 @@ use std::convert::{From, TryFrom}; use

[GitHub] [arrow] ovr commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

2021-03-03 Thread GitBox
ovr commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r586437638 ## File path: rust/datafusion/src/physical_plan/group_scalar.rs ## @@ -22,10 +22,12 @@ use std::convert::{From, TryFrom}; use

[GitHub] [arrow] ovr commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

2021-01-24 Thread GitBox
ovr commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r563282158 ## File path: rust/arrow/src/compute/kernels/cast.rs ## @@ -443,6 +456,13 @@ pub fn cast(array: , to_type: ) -> Result { ))), }, +

[GitHub] [arrow] ovr commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

2021-01-21 Thread GitBox
ovr commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r561946613 ## File path: rust/arrow/src/datatypes/mod.rs ## @@ -199,6 +207,81 @@ pub struct Field { metadata: Option>, } +// Decimal (precision, scale) =

[GitHub] [arrow] ovr commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

2021-01-21 Thread GitBox
ovr commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r561946613 ## File path: rust/arrow/src/datatypes/mod.rs ## @@ -199,6 +207,81 @@ pub struct Field { metadata: Option>, } +// Decimal (precision, scale) =

[GitHub] [arrow] ovr commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

2021-01-21 Thread GitBox
ovr commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r561946613 ## File path: rust/arrow/src/datatypes/mod.rs ## @@ -199,6 +207,81 @@ pub struct Field { metadata: Option>, } +// Decimal (precision, scale) =

[GitHub] [arrow] ovr commented on a change in pull request #9232: ARROW-10818: [Rust] Implement DecimalType

2021-01-21 Thread GitBox
ovr commented on a change in pull request #9232: URL: https://github.com/apache/arrow/pull/9232#discussion_r561946613 ## File path: rust/arrow/src/datatypes/mod.rs ## @@ -199,6 +207,81 @@ pub struct Field { metadata: Option>, } +// Decimal (precision, scale) =