houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r651479583
##
File path: datafusion/src/logical_plan/dfschema.rs
##
@@ -208,6 +297,28 @@ impl Into for DFSchema {
}
}
+impl Into for &DFSchema {
+///
houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r651478410
##
File path: ballista/rust/core/proto/ballista.proto
##
@@ -408,6 +421,119 @@ message PhysicalPlanNode {
}
}
+// physical expressions
Review co
houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r650435911
##
File path: ballista/rust/core/src/serde/logical_plan/from_proto.rs
##
@@ -1361,43 +1224,3 @@ impl TryFrom for WindowFrame {
})
}
}
-
houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r632895922
##
File path: datafusion/src/logical_plan/plan.rs
##
@@ -141,7 +137,7 @@ pub enum LogicalPlan {
/// Produces rows from a table provider by referen
houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r622398455
##
File path: datafusion/src/logical_plan/plan.rs
##
@@ -141,7 +137,7 @@ pub enum LogicalPlan {
/// Produces rows from a table provider by referen
houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r621470506
##
File path: datafusion/src/logical_plan/plan.rs
##
@@ -141,7 +137,7 @@ pub enum LogicalPlan {
/// Produces rows from a table provider by referen
houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r619864093
##
File path: datafusion/src/execution/dataframe_impl.rs
##
@@ -252,7 +252,12 @@ mod tests {
let right = test_table()?.select_columns(&["c1",
houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r619891670
##
File path: datafusion/src/execution/dataframe_impl.rs
##
@@ -252,7 +252,12 @@ mod tests {
let right = test_table()?.select_columns(&["c1",
houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r619871814
##
File path: datafusion/src/physical_optimizer/coalesce_batches.rs
##
@@ -58,7 +59,17 @@ impl PhysicalOptimizerRule for CoalesceBatches {
//
houqp commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r619864093
##
File path: datafusion/src/execution/dataframe_impl.rs
##
@@ -252,7 +252,12 @@ mod tests {
let right = test_table()?.select_columns(&["c1",
10 matches
Mail list logo
