WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1745724686
##
meson.build:
##
@@ -35,6 +35,12 @@ project(
# add_project_arguments(['-fvisibility=hidden'], language: 'cpp')
# endif
+cpp = meson.get_compiler('cpp')
+a
WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1744621266
##
src/nanoarrow/common/array_test.cc:
##
@@ -98,9 +98,11 @@ TEST(ArrayTest, ArrayTestAllocateChildren) {
ArrowArrayRelease(&array);
ASSERT_EQ(ArrowArrayI
WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1744621266
##
src/nanoarrow/common/array_test.cc:
##
@@ -98,9 +98,11 @@ TEST(ArrayTest, ArrayTestAllocateChildren) {
ArrowArrayRelease(&array);
ASSERT_EQ(ArrowArrayI
WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1744375067
##
src/nanoarrow/common/array_test.cc:
##
@@ -98,9 +98,11 @@ TEST(ArrayTest, ArrayTestAllocateChildren) {
ArrowArrayRelease(&array);
ASSERT_EQ(ArrowArrayI
paleolimbot commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1737653271
##
meson.build:
##
@@ -35,6 +35,12 @@ project(
# add_project_arguments(['-fvisibility=hidden'], language: 'cpp')
# endif
+cpp = meson.get_compiler('cpp'
WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1735479958
##
meson.build:
##
@@ -35,6 +35,12 @@ project(
# add_project_arguments(['-fvisibility=hidden'], language: 'cpp')
# endif
+cpp = meson.get_compiler('cpp')
+a
paleolimbot commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1677950390
##
ci/scripts/build-arrow-cpp-minimal.sh:
##
@@ -45,10 +45,10 @@ ARROW_CPP_SCRATCH_DIR="arrow-cpp-build-${ARROW_CPP_VERSION}"
mkdir "${ARROW_CPP_SCRATCH_DIR}
WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1677945194
##
ci/scripts/build-arrow-cpp-minimal.sh:
##
@@ -45,10 +45,10 @@ ARROW_CPP_SCRATCH_DIR="arrow-cpp-build-${ARROW_CPP_VERSION}"
mkdir "${ARROW_CPP_SCRATCH_DIR}"
p
paleolimbot commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1677925130
##
ci/scripts/build-arrow-cpp-minimal.sh:
##
@@ -45,10 +45,10 @@ ARROW_CPP_SCRATCH_DIR="arrow-cpp-build-${ARROW_CPP_VERSION}"
mkdir "${ARROW_CPP_SCRATCH_DIR}
WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1602267855
##
src/nanoarrow/buffer_test.cc:
##
@@ -141,9 +141,6 @@ TEST(BufferTest, BufferTestFill) {
}
ArrowBufferReset(&buffer);
-
Review Comment:
The BufferTe
WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1602267855
##
src/nanoarrow/buffer_test.cc:
##
@@ -141,9 +141,6 @@ TEST(BufferTest, BufferTestFill) {
}
ArrowBufferReset(&buffer);
-
Review Comment:
The BufferTe
paleolimbot commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1602124977
##
src/nanoarrow/buffer_test.cc:
##
@@ -141,9 +141,6 @@ TEST(BufferTest, BufferTestFill) {
}
ArrowBufferReset(&buffer);
-
Review Comment:
Would ch
codecov-commenter commented on PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#issuecomment-2113201964
##
[Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/448?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign
WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r1602065133
##
src/nanoarrow/buffer_test.cc:
##
@@ -141,9 +141,6 @@ TEST(BufferTest, BufferTestFill) {
}
ArrowBufferReset(&buffer);
-
Review Comment:
These were r
WillAyd commented on code in PR #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448#discussion_r158624
##
ci/scripts/build-arrow-cpp-minimal.sh:
##
Review Comment:
These changes are not permanent - just setting them up to see what we need
for a clean build of
WillAyd opened a new pull request, #448:
URL: https://github.com/apache/arrow-nanoarrow/pull/448
This should be a relatively easy way to enforce -Werror in CI; moved the
Meson build from a scheduled job to be part of the normal CI runs.
Looks like there are still a few more upstream i
16 matches
Mail list logo