Re: [PR] GH-41813: [C++] Fix avx2 gather offset larger than 2GB in `CompareColumnsToRows` [arrow]

pitrou commented on code in PR #42188: URL: https://github.com/apache/arrow/pull/42188#discussion_r1651017028 ## cpp/src/arrow/compute/row/compare_internal_avx2.cc: ## @@ -251,6 +253,35 @@ uint32_t KeyCompare::CompareBinaryColumnToRowHelper_avx2( } } +namespace { + +/// In

Re: [PR] GH-41813: [C++] Fix avx2 gather offset larger than 2GB in `CompareColumnsToRows` [arrow]

zanmato1984 commented on code in PR #42188: URL: https://github.com/apache/arrow/pull/42188#discussion_r1650977600 ## cpp/src/arrow/compute/row/compare_internal_avx2.cc: ## @@ -236,6 +236,8 @@ uint32_t KeyCompare::CompareBinaryColumnToRowHelper_avx2( irow_right =

Re: [PR] GH-41813: [C++] Fix avx2 gather offset larger than 2GB in `CompareColumnsToRows` [arrow]

zanmato1984 commented on code in PR #42188: URL: https://github.com/apache/arrow/pull/42188#discussion_r1650973410 ## cpp/src/arrow/compute/row/compare_test.cc: ## @@ -164,5 +166,126 @@ TEST(KeyCompare, CompareColumnsToRowsTempStackUsage) { } } +// Compare columns to rows

Re: [PR] GH-41813: [C++] Fix avx2 gather offset larger than 2GB in `CompareColumnsToRows` [arrow]

zanmato1984 commented on PR #42188: URL: https://github.com/apache/arrow/pull/42188#issuecomment-2182124858 @pitrou @felipecrv @ZhangHuiGui @mapleFU Would you please help to take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] GH-41813: [C++] Fix avx2 gather offset larger than 2GB in `CompareColumnsToRows` [arrow]

zanmato1984 commented on code in PR #42188: URL: https://github.com/apache/arrow/pull/42188#discussion_r1643204564 ## cpp/src/arrow/compute/row/compare_test.cc: ## @@ -164,5 +166,126 @@ TEST(KeyCompare, CompareColumnsToRowsTempStackUsage) { } } +// Compare columns to rows

Re: [PR] GH-41813: [C++] Fix avx2 gather offset larger than 2GB in `CompareColumnsToRows` [arrow]

zanmato1984 commented on PR #42188: URL: https://github.com/apache/arrow/pull/42188#issuecomment-2174687269 > Hi @zanmato1984, thanks for your work on this. I'm hoping others can review the implementation but I did just check that the new test passes (it does) and also fixes the original is

Re: [PR] GH-41813: [C++] Fix avx2 gather offset larger than 2GB in `CompareColumnsToRows` [arrow]

amoeba commented on PR #42188: URL: https://github.com/apache/arrow/pull/42188#issuecomment-2174625977 Hi @zanmato1984, thanks for your work on this. I'm hoping others can review the implementation but I did just check that the new test passes (it does) and also fixes the original issue (it

Re: [PR] GH-41813: [C++] Fix avx2 gather offset larger than 2GB in `CompareColumnsToRows` [arrow]

zanmato1984 commented on code in PR #42188: URL: https://github.com/apache/arrow/pull/42188#discussion_r1643204564 ## cpp/src/arrow/compute/row/compare_test.cc: ## @@ -164,5 +166,126 @@ TEST(KeyCompare, CompareColumnsToRowsTempStackUsage) { } } +// Compare columns to rows

Re: [PR] GH-41813: [C++] Fix avx2 gather offset larger than 2GB in `CompareColumnsToRows` [arrow]

zanmato1984 commented on PR #42188: URL: https://github.com/apache/arrow/pull/42188#issuecomment-2173986331 cc @pitrou @amoeba @mrd0ll4r -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] GH-41813: [C++] Fix avx2 gather offset larger than 2GB in `CompareColumnsToRows` [arrow]

github-actions[bot] commented on PR #42188: URL: https://github.com/apache/arrow/pull/42188#issuecomment-2173981554 :warning: GitHub issue #41813 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-41813: [C++] Fix avx2 gather offset larger than 2GB in `CompareColumnsToRows` [arrow]

zanmato1984 opened a new pull request, #42188: URL: https://github.com/apache/arrow/pull/42188 ### Rationale for this change AVX2 intrinsics `_mm256_i32gather_epi32`/`_mm256_i32gather_epi64` are used in `CompareColumnsToRows` API, and treat the `vindex` as signed integer. In o