Re: [PR] GH-41952: [R] Turn S3, GCS, and ZSTD on by default for macOS [arrow]

2024-06-21 Thread via GitHub
nealrichardson commented on PR #42210: URL: https://github.com/apache/arrow/pull/42210#issuecomment-2180582378 > > I also wonder whether GCS is worth including. > > I agree + though similar when I checked if S3 alone was sufficient for quieting the message. I'm happy to pull GCS out o

Re: [PR] GH-41952: [R] Turn S3, GCS, and ZSTD on by default for macOS [arrow]

2024-06-21 Thread via GitHub
jonkeane commented on code in PR #42210: URL: https://github.com/apache/arrow/pull/42210#discussion_r1647508460 ## r/tools/nixlibs.R: ## @@ -574,6 +574,8 @@ build_libarrow <- function(src_dir, dst_dir) { env_var_list <- c(env_var_list, setNames("BUNDLED", env_var))

Re: [PR] GH-41952: [R] Turn S3, GCS, and ZSTD on by default for macOS [arrow]

2024-06-21 Thread via GitHub
jonkeane commented on PR #42210: URL: https://github.com/apache/arrow/pull/42210#issuecomment-2180574740 > I also wonder whether GCS is worth including. I agree + though similar when I checked if S3 alone was sufficient for quieting the message. I'm happy to pull GCS out of this, thou

Re: [PR] GH-41952: [R] Turn S3, GCS, and ZSTD on by default for macOS [arrow]

2024-06-21 Thread via GitHub
nealrichardson commented on code in PR #42210: URL: https://github.com/apache/arrow/pull/42210#discussion_r1647512602 ## r/tools/nixlibs.R: ## @@ -814,8 +816,14 @@ set_thirdparty_urls <- function(env_var_list) { env_var_list } -is_feature_requested <- function(env_varname,