zeroshade commented on PR #41595:
URL: https://github.com/apache/arrow/pull/41595#issuecomment-2113047575
Just confirming for you @candiduslynx, this did get included in the v16.1.0
release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
conbench-apache-arrow[bot] commented on PR #41595:
URL: https://github.com/apache/arrow/pull/41595#issuecomment-2101741063
After merging your PR, Conbench analyzed the 5 benchmarking runs that have
been run so far on merge-commit 5252c6ce13694fa31dbcb2623d1629cd8fe53a47.
There were
raulcd commented on PR #41595:
URL: https://github.com/apache/arrow/pull/41595#issuecomment-2101493858
no worries, I'll test this on the maintenance branch release before creating
a release candidate just to validate none of the release jobs break
--
This is an automated message from the
candiduslynx commented on PR #41595:
URL: https://github.com/apache/arrow/pull/41595#issuecomment-2101368289
> Revision:
[b70d470](https://github.com/apache/arrow/commit/b70d4706c844beae2e2bf2489627947baa1cd33c)
>
> Submitted crossbow builds: [ursacomputing/crossbow @
github-actions[bot] commented on PR #41595:
URL: https://github.com/apache/arrow/pull/41595#issuecomment-2101312978
Revision: b70d4706c844beae2e2bf2489627947baa1cd33c
Submitted crossbow builds: [ursacomputing/crossbow @
zeroshade merged PR #41595:
URL: https://github.com/apache/arrow/pull/41595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
raulcd commented on PR #41595:
URL: https://github.com/apache/arrow/pull/41595#issuecomment-2101309279
@github-actions crossbow submit *go*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
candiduslynx commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594532154
##
go/arrow/csv/reader.go:
##
@@ -982,7 +966,7 @@ func (c conversionColumn) inferType(v string)
arrow.DataType {
c.typ =
candiduslynx commented on PR #41595:
URL: https://github.com/apache/arrow/pull/41595#issuecomment-2101277391
> @candiduslynx can you also add a test for this?
a55cd5324d2c47932410b0c7a9c46075386645d2
--
This is an automated message from the Apache Git Service.
To respond to the
zeroshade commented on PR #41595:
URL: https://github.com/apache/arrow/pull/41595#issuecomment-2101257872
@candiduslynx can you also add a test for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
zeroshade commented on PR #41595:
URL: https://github.com/apache/arrow/pull/41595#issuecomment-2101255987
@raulcd since we're already doing a 16.1.0 release, do you think we could
get this into it?
--
This is an automated message from the Apache Git Service.
To respond to the message,
zeroshade commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594515317
##
go/arrow/csv/common.go:
##
@@ -239,21 +239,31 @@ func WithStringsReplacer(replacer *strings.Replacer)
Option {
func validate(schema *arrow.Schema) {
candiduslynx commented on PR #41595:
URL: https://github.com/apache/arrow/pull/41595#issuecomment-2101247291
@zeroshade I'd like to also ask to port it to v16, as we're using it & it's
a blocker to wait for the v17 release
--
This is an automated message from the Apache Git Service.
To
candiduslynx commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594509669
##
go/arrow/csv/common.go:
##
@@ -239,21 +239,31 @@ func WithStringsReplacer(replacer *strings.Replacer)
Option {
func validate(schema *arrow.Schema) {
candiduslynx commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594507030
##
go/arrow/csv/common.go:
##
@@ -239,21 +239,31 @@ func WithStringsReplacer(replacer *strings.Replacer)
Option {
func validate(schema *arrow.Schema) {
zeroshade commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594509034
##
go/arrow/csv/common.go:
##
@@ -239,21 +239,31 @@ func WithStringsReplacer(replacer *strings.Replacer)
Option {
func validate(schema *arrow.Schema) {
zeroshade commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594508222
##
go/arrow/csv/reader.go:
##
@@ -982,7 +966,7 @@ func (c conversionColumn) inferType(v string)
arrow.DataType {
c.typ =
candiduslynx commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594507030
##
go/arrow/csv/common.go:
##
@@ -239,21 +239,31 @@ func WithStringsReplacer(replacer *strings.Replacer)
Option {
func validate(schema *arrow.Schema) {
zeroshade commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594506272
##
go/arrow/csv/reader.go:
##
@@ -740,81 +740,67 @@ func (r *Reader) parseDate32(field array.Builder, str
string) {
candiduslynx commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594506201
##
go/arrow/csv/common.go:
##
@@ -239,21 +239,31 @@ func WithStringsReplacer(replacer *strings.Replacer)
Option {
func validate(schema *arrow.Schema) {
candiduslynx commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594505828
##
go/arrow/csv/reader.go:
##
@@ -982,7 +966,7 @@ func (c conversionColumn) inferType(v string)
arrow.DataType {
c.typ =
candiduslynx commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594505197
##
go/arrow/csv/reader.go:
##
@@ -740,81 +740,67 @@ func (r *Reader) parseDate32(field array.Builder, str
string) {
zeroshade commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594503371
##
go/arrow/csv/reader.go:
##
@@ -982,7 +966,7 @@ func (c conversionColumn) inferType(v string)
arrow.DataType {
c.typ =
zeroshade commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594501276
##
go/arrow/csv/reader.go:
##
@@ -740,81 +740,67 @@ func (r *Reader) parseDate32(field array.Builder, str
string) {
zeroshade commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594499804
##
go/arrow/csv/common.go:
##
@@ -239,21 +239,31 @@ func WithStringsReplacer(replacer *strings.Replacer)
Option {
func validate(schema *arrow.Schema) {
candiduslynx commented on PR #41595:
URL: https://github.com/apache/arrow/pull/41595#issuecomment-2101070846
@zeroshade I've been reviewing one of our libraries & found this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
26 matches
Mail list logo
