pitrou commented on pull request #8357:
URL: https://github.com/apache/arrow/pull/8357#issuecomment-704086450
Unrelated, but what's up with the Rust "dev_labeler"?
This is an automated message from the Apache Git Service.
To
pitrou edited a comment on pull request #8357:
URL: https://github.com/apache/arrow/pull/8357#issuecomment-704086450
Unrelated, but what's up with the Rust "dev_labeler"? It seems to be failing
on every PR.
This is an automa
pitrou closed pull request #8357:
URL: https://github.com/apache/arrow/pull/8357
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jorgecarleitao commented on pull request #8357:
URL: https://github.com/apache/arrow/pull/8357#issuecomment-704087532
> Unrelated, but what's up with the Rust "dev_labeler"? It seems to be
failing on every PR.
I made a mistake. It should be fixed in
https://github.com/apache/arrow/p
jorgecarleitao opened a new pull request #8358:
URL: https://github.com/apache/arrow/pull/8358
This is an acceptance test to the labeler. Please ignore.
This is an automated message from the Apache Git Service.
To respond to
jorgecarleitao commented on pull request #8358:
URL: https://github.com/apache/arrow/pull/8358#issuecomment-704090285
The test pass: the boot works as expected. I am thus closing this.
This is an automated message from the Ap
jorgecarleitao closed pull request #8358:
URL: https://github.com/apache/arrow/pull/8358
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
maartenbreddels commented on a change in pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#discussion_r500071766
##
File path: python/pyarrow/compute.py
##
@@ -253,6 +255,68 @@ def match_substring(array, pattern):
MatchSubstringOptions
romainfrancois commented on a change in pull request #8341:
URL: https://github.com/apache/arrow/pull/8341#discussion_r500076684
##
File path: r/tests/testthat/test-Array.R
##
@@ -749,3 +749,17 @@ test_that("Array$ApproxEquals", {
expect_true(a$ApproxEquals(b))
expect_fal
romainfrancois commented on a change in pull request #8341:
URL: https://github.com/apache/arrow/pull/8341#discussion_r500074475
##
File path: r/src/array_to_vector.cpp
##
@@ -960,6 +960,14 @@ bool ArraysCanFitInteger(ArrayVector arrays) {
return all_can_fit;
}
+bool opti
maartenbreddels commented on a change in pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#discussion_r500084727
##
File path: python/pyarrow/compute.py
##
@@ -253,6 +255,68 @@ def match_substring(array, pattern):
MatchSubstringOptions
pitrou commented on a change in pull request #8337:
URL: https://github.com/apache/arrow/pull/8337#discussion_r500077813
##
File path: cpp/src/arrow/python/arrow_to_pandas.cc
##
@@ -791,6 +791,117 @@ Status ConvertListsLike(const PandasOptions& options,
const ChunkedArray& dat
alamb commented on pull request #8333:
URL: https://github.com/apache/arrow/pull/8333#issuecomment-704152397
@jorgecarleitao FYI rebased
This is an automated message from the Apache Git Service.
To respond to the message, pl
kszucs commented on pull request #8315:
URL: https://github.com/apache/arrow/pull/8315#issuecomment-704176534
@github-actions crossbow submit wheel-osx-*
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on pull request #8315:
URL: https://github.com/apache/arrow/pull/8315#issuecomment-704177368
Revision: 97b5b3248a2becd7bf86d89cb8bd71de2bf43e30
Submitted crossbow builds: [ursa-labs/crossbow @
actions-605](https://github.com/ursa-labs/crossbow/branches/a
nevi-me commented on pull request #8330:
URL: https://github.com/apache/arrow/pull/8330#issuecomment-704204575
@carols10cents may you please create a JIRA account at
https://issues.apache.org, so that we can assign the tasks that you've worked
on to you. Thanks :)
---
github-actions[bot] commented on pull request #8330:
URL: https://github.com/apache/arrow/pull/8330#issuecomment-704207669
https://issues.apache.org/jira/browse/ARROW-10191
This is an automated message from the Apache Git Ser
nevi-me commented on pull request #8330:
URL: https://github.com/apache/arrow/pull/8330#issuecomment-704208332
Hi @andygrove @jorgecarleitao may you please kindly merge this for me, the
merge tool's failing to push to GH on my end :(
---
carols10cents commented on pull request #8330:
URL: https://github.com/apache/arrow/pull/8330#issuecomment-704223459
@nevi-me Done!
https://issues.apache.org/jira/secure/ViewProfile.jspa?name=carols10cents
This is an automat
github-actions[bot] commented on pull request #8354:
URL: https://github.com/apache/arrow/pull/8354#issuecomment-704224496
https://issues.apache.org/jira/browse/ARROW-10168
This is an automated message from the Apache Git Ser
alamb opened a new pull request #8359:
URL: https://github.com/apache/arrow/pull/8359
NOTE: this builds on #8333 and #8340 and #8346 so leaving as a draft until
those are merged
This PR adds basic physical expression / casting support to DataFusion.
Right now, it will cause all Dict
bkietz commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r500235525
##
File path: cpp/src/arrow/dataset/file_base.cc
##
@@ -143,97 +150,235 @@ FragmentIterator FileSystemDataset::GetFragmentsImpl(
return MakeVectorIterator
github-actions[bot] commented on pull request #8359:
URL: https://github.com/apache/arrow/pull/8359#issuecomment-704237332
https://issues.apache.org/jira/browse/ARROW-10163
This is an automated message from the Apache Git Ser
alamb commented on a change in pull request #8359:
URL: https://github.com/apache/arrow/pull/8359#discussion_r500236277
##
File path: rust/datafusion/src/physical_plan/expressions.rs
##
@@ -1166,16 +1201,13 @@ fn order_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Opti
maartenbreddels commented on a change in pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#discussion_r500243584
##
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##
@@ -53,8 +53,19 @@ class BaseTestStringKernels : public ::testing::Test {
st
maartenbreddels commented on a change in pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#discussion_r500275273
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -809,6 +809,475 @@ struct IsUpperAscii :
CharacterPredicateAscii {
}
};
+/
pitrou commented on a change in pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#discussion_r500282031
##
File path: cpp/src/arrow/compute/kernels/scalar_string.cc
##
@@ -809,6 +809,475 @@ struct IsUpperAscii :
CharacterPredicateAscii {
}
};
+// splitti
pitrou opened a new pull request #8361:
URL: https://github.com/apache/arrow/pull/8361
Fix a crash on conversion of e.g. struct of dictionaries.
This is an automated message from the Apache Git Service.
To respond to the mess
pitrou commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r500202061
##
File path: cpp/src/arrow/util/mutex.h
##
@@ -31,16 +31,20 @@ namespace util {
class ARROW_EXPORT Mutex {
public:
Mutex();
+ Mutex(Mutex&&) = defaul
pitrou commented on a change in pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#discussion_r500265136
##
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##
@@ -53,8 +53,19 @@ class BaseTestStringKernels : public ::testing::Test {
std::shared
bkietz commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r500287304
##
File path: cpp/src/arrow/dataset/file_base.h
##
@@ -128,6 +128,9 @@ class ARROW_DS_EXPORT FileFormat : public
std::enable_shared_from_this
pitrou commented on a change in pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#discussion_r500266219
##
File path: python/pyarrow/compute.py
##
@@ -253,6 +255,68 @@ def match_substring(array, pattern):
MatchSubstringOptions(pattern)
bkietz commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r500288334
##
File path: cpp/src/arrow/dataset/file_ipc.cc
##
@@ -159,18 +163,44 @@ Result
IpcFileFormat::ScanFile(std::shared_ptr op
bkietz commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r500290327
##
File path: cpp/src/arrow/util/string.h
##
@@ -56,5 +57,9 @@ bool AsciiEqualsCaseInsensitive(util::string_view left,
util::string_view right)
ARROW_EXPOR
pitrou commented on a change in pull request #8271:
URL: https://github.com/apache/arrow/pull/8271#discussion_r500268258
##
File path: python/pyarrow/compute.py
##
@@ -253,6 +255,68 @@ def match_substring(array, pattern):
MatchSubstringOptions(pattern)
pitrou commented on pull request #8356:
URL: https://github.com/apache/arrow/pull/8356#issuecomment-704263971
Do we want to update some CI build configurations with this? (I assume this
can make builds shorter)
This is an au
naman1996 closed pull request #8231:
URL: https://github.com/apache/arrow/pull/8231
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
bkietz commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r500295452
##
File path: cpp/src/arrow/util/mutex.cc
##
@@ -19,25 +19,36 @@
#include
+#include "arrow/util/logging.h"
+
namespace arrow {
namespace util {
-st
pitrou commented on a change in pull request #8343:
URL: https://github.com/apache/arrow/pull/8343#discussion_r500272157
##
File path: python/pyarrow/tests/test_dataset.py
##
@@ -2124,6 +2124,23 @@ def test_dataset_project_only_partition_columns(tempdir):
assert all_cols.c
bkietz commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r500297392
##
File path: cpp/src/arrow/util/mutex.h
##
@@ -31,16 +31,20 @@ namespace util {
class ARROW_EXPORT Mutex {
public:
Mutex();
+ Mutex(Mutex&&) = defaul
github-actions[bot] commented on pull request #8361:
URL: https://github.com/apache/arrow/pull/8361#issuecomment-704266502
https://issues.apache.org/jira/browse/ARROW-10192
This is an automated message from the Apache Git Ser
github-actions[bot] commented on pull request #8360:
URL: https://github.com/apache/arrow/pull/8360#issuecomment-704255542
https://issues.apache.org/jira/browse/ARROW-10193
This is an automated message from the Apache Git Ser
bkietz commented on a change in pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#discussion_r499859844
##
File path: python/pyarrow/dataset.py
##
@@ -694,22 +697,23 @@ def _ensure_write_partitioning(scheme):
return scheme
-def write_dataset(data, base
andygrove closed pull request #8355:
URL: https://github.com/apache/arrow/pull/8355
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #8333:
URL: https://github.com/apache/arrow/pull/8333
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove edited a comment on pull request #8330:
URL: https://github.com/apache/arrow/pull/8330#issuecomment-704320070
@nevi-me @carols10cents I ran the merge tool and the changes appear to have
been committed to the branch but this PR did not get closed, so I am closing it
manually.
--
andygrove commented on pull request #8330:
URL: https://github.com/apache/arrow/pull/8330#issuecomment-704320070
@nevi-me @carols10cents I ran the merge tool and the changes appear to have
been committed to the branch but this issue did not get closed, so I am closing
it manually.
--
andygrove closed pull request #8330:
URL: https://github.com/apache/arrow/pull/8330
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mrkn commented on pull request #6302:
URL: https://github.com/apache/arrow/pull/6302#issuecomment-704320830
This pull request is ready to review.
@pitrou Could you have a look?
This is an automated message from the Apa
bkietz opened a new pull request #8362:
URL: https://github.com/apache/arrow/pull/8362
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nealrichardson commented on a change in pull request #8341:
URL: https://github.com/apache/arrow/pull/8341#discussion_r500365879
##
File path: r/src/array_to_vector.cpp
##
@@ -1068,8 +1080,9 @@ std::shared_ptr Converter::Make(const
std::shared_ptr& type
return
std::mak
github-actions[bot] commented on pull request #8362:
URL: https://github.com/apache/arrow/pull/8362#issuecomment-704335087
https://issues.apache.org/jira/browse/ARROW-10196
This is an automated message from the Apache Git Ser
HedgehogCode opened a new pull request #8363:
URL: https://github.com/apache/arrow/pull/8363
When translating between the memory FieldType and message FieldType for
dictionary encoded vectors the children of the dictionary field were not
handled correctly.
* When going from memory f
github-actions[bot] commented on pull request #8363:
URL: https://github.com/apache/arrow/pull/8363#issuecomment-704359506
https://issues.apache.org/jira/browse/ARROW-10174
This is an automated message from the Apache Git Ser
nevi-me opened a new pull request #8364:
URL: https://github.com/apache/arrow/pull/8364
This extends filters to simple lists. CC @yordan-pavlov
This is an automated message from the Apache Git Service.
To respond to the mes
github-actions[bot] commented on pull request #8364:
URL: https://github.com/apache/arrow/pull/8364#issuecomment-704369422
https://issues.apache.org/jira/browse/ARROW-5350
This is an automated message from the Apache Git Serv
nevi-me commented on a change in pull request #8346:
URL: https://github.com/apache/arrow/pull/8346#discussion_r500409499
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -755,10 +784,253 @@ where
Ok(b.finish())
}
+/// Attempts to cast an `ArrayDictionary` wit
nevi-me commented on a change in pull request #8346:
URL: https://github.com/apache/arrow/pull/8346#discussion_r500409499
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -755,10 +784,253 @@ where
Ok(b.finish())
}
+/// Attempts to cast an `ArrayDictionary` wit
nealrichardson opened a new pull request #8365:
URL: https://github.com/apache/arrow/pull/8365
@romainfrancois see the comment I added with the reprex: this fails
differently now, presumably due to the cpp11 change
This is a
bkietz commented on a change in pull request #8343:
URL: https://github.com/apache/arrow/pull/8343#discussion_r500413021
##
File path: python/pyarrow/tests/test_dataset.py
##
@@ -2124,6 +2124,23 @@ def test_dataset_project_only_partition_columns(tempdir):
assert all_cols.c
nevi-me commented on pull request #8330:
URL: https://github.com/apache/arrow/pull/8330#issuecomment-704378123
> @nevi-me @carols10cents I ran the merge tool and the changes appear to
have been committed to the branch but this PR did not get closed, so I am
closing it manually.
It's
jorgecarleitao edited a comment on pull request #8287:
URL: https://github.com/apache/arrow/pull/8287#issuecomment-704388901
I have been heavily working in this problem based on your ideas, @pitrou on
a [separate branch](https://github.com/jorgecarleitao/arrow/pull/13/files), and
I think I
jorgecarleitao commented on pull request #8287:
URL: https://github.com/apache/arrow/pull/8287#issuecomment-704388901
I have been heavily working in this problem based on your ideas, @pitrou on
a [separate branch](https://github.com/jorgecarleitao/arrow/pull/13/files), and
I think I need s
pitrou commented on pull request #8366:
URL: https://github.com/apache/arrow/pull/8366#issuecomment-704409884
Also cc @jorisvandenbossche
This is an automated message from the Apache Git Service.
To respond to the message, p
pitrou commented on pull request #8342:
URL: https://github.com/apache/arrow/pull/8342#issuecomment-704413585
+1, will merge.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
pitrou commented on a change in pull request #8366:
URL: https://github.com/apache/arrow/pull/8366#discussion_r500443163
##
File path: cpp/src/parquet/arrow/schema.cc
##
@@ -689,10 +686,91 @@ Status GetOriginSchema(const std::shared_ptr& metadata,
// but that is not necessaril
pitrou opened a new pull request #8366:
URL: https://github.com/apache/arrow/pull/8366
This allows roundtripping complex types such as `list>`,
`list`, etc.
This is an automated message from the Apache Git Service.
To respon
github-actions[bot] commented on pull request #8365:
URL: https://github.com/apache/arrow/pull/8365#issuecomment-704396850
https://issues.apache.org/jira/browse/ARROW-6582
This is an automated message from the Apache Git Serv
alamb commented on a change in pull request #8346:
URL: https://github.com/apache/arrow/pull/8346#discussion_r500443425
##
File path: rust/arrow/src/compute/kernels/cast.rs
##
@@ -755,10 +784,253 @@ where
Ok(b.finish())
}
+/// Attempts to cast an `ArrayDictionary` with
kszucs commented on pull request #8360:
URL: https://github.com/apache/arrow/pull/8360#issuecomment-704412948
The CI failures are unrelated, merging. Thanks Antoine!
This is an automated message from the Apache Git Service.
T
github-actions[bot] commented on pull request #8366:
URL: https://github.com/apache/arrow/pull/8366#issuecomment-704421003
https://issues.apache.org/jira/browse/ARROW-9943
This is an automated message from the Apache Git Serv
pitrou commented on pull request #8287:
URL: https://github.com/apache/arrow/pull/8287#issuecomment-704423199
You're doing it wrong. I suggest again that you try to follow how C++ does
things, otherwise you'll get lost.
For example, your `release` callback assumes that buffers have b
pitrou closed pull request #8342:
URL: https://github.com/apache/arrow/pull/8342
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou commented on pull request #6302:
URL: https://github.com/apache/arrow/pull/6302#issuecomment-704429373
I'll take a look later this week.
This is an automated message from the Apache Git Service.
To respond to the messa
pitrou edited a comment on pull request #8287:
URL: https://github.com/apache/arrow/pull/8287#issuecomment-704423199
You're doing it wrong. I suggest again that you try to follow how C++ does
things, otherwise you'll get lost.
For example, your `release` callback assumes that buffers
pitrou edited a comment on pull request #8287:
URL: https://github.com/apache/arrow/pull/8287#issuecomment-704423199
You're doing it wrong. I suggest again that you try to follow how C++ does
things, otherwise you'll get lost.
For example, your `release` callback assumes that buffers
kszucs closed pull request #8360:
URL: https://github.com/apache/arrow/pull/8360
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nealrichardson commented on pull request #8151:
URL: https://github.com/apache/arrow/pull/8151#issuecomment-704440114
@tianchen92 could you please rebase this? would you like to try to get this
in the 2.0 release?
@pitrou could you please take a look?
--
pitrou commented on pull request #8151:
URL: https://github.com/apache/arrow/pull/8151#issuecomment-704440473
This is too involved for the 2.0 release.
This is an automated message from the Apache Git Service.
To respond to t
kszucs commented on a change in pull request #8361:
URL: https://github.com/apache/arrow/pull/8361#discussion_r500483306
##
File path: cpp/src/arrow/python/arrow_to_pandas.cc
##
@@ -641,29 +659,18 @@ inline Status ConvertStruct(const PandasOptions& options,
const ChunkedArray&
nealrichardson commented on pull request #7887:
URL: https://github.com/apache/arrow/pull/7887#issuecomment-704441085
@tianchen92 do you want to pick this up again? the bug that @emkornfield
mentioned has been fixed.
This is
nealrichardson commented on pull request #7942:
URL: https://github.com/apache/arrow/pull/7942#issuecomment-704443194
Is this mergeable now? According to the mailing list discussion:
> It does not seem too invasive to support native endianness in
implementation libraries. As long
nealrichardson commented on pull request #8265:
URL: https://github.com/apache/arrow/pull/8265#issuecomment-70724
Is this good to merge? Or needs review? 2.0 is fast approaching.
This is an automated message from the Apac
nealrichardson commented on pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#issuecomment-704450332
Is this done, or what is left?
This is an automated message from the Apache Git Service.
To respond to the
kiszk commented on pull request #7942:
URL: https://github.com/apache/arrow/pull/7942#issuecomment-704450710
Thank you for your comment.
According to Micah 's
[comment](https://github.com/apache/arrow/pull/7938#issuecomment-703381572), we
may wait until he will update the document s
pitrou commented on a change in pull request #8361:
URL: https://github.com/apache/arrow/pull/8361#discussion_r500496450
##
File path: cpp/src/arrow/python/arrow_to_pandas.cc
##
@@ -641,29 +659,18 @@ inline Status ConvertStruct(const PandasOptions& options,
const ChunkedArray&
bkietz commented on pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#issuecomment-704453473
@pitrou are you planning to review C++ again?
@jorisvandenbossche are you planning to review python?
This is an
kszucs commented on a change in pull request #8361:
URL: https://github.com/apache/arrow/pull/8361#discussion_r500499238
##
File path: cpp/src/arrow/python/arrow_to_pandas.cc
##
@@ -641,29 +659,18 @@ inline Status ConvertStruct(const PandasOptions& options,
const ChunkedArray&
kszucs commented on a change in pull request #8361:
URL: https://github.com/apache/arrow/pull/8361#discussion_r500499506
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -2297,6 +2310,24 @@ def test_from_tuples(self):
df, expected=expected_df, schema=expecte
kszucs commented on a change in pull request #8361:
URL: https://github.com/apache/arrow/pull/8361#discussion_r500499506
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -2297,6 +2310,24 @@ def test_from_tuples(self):
df, expected=expected_df, schema=expecte
Luminarys commented on pull request #8344:
URL: https://github.com/apache/arrow/pull/8344#issuecomment-704457623
I've looked through the CI failures, it seems there are a few kinds:
1. aws connector failure (I think this isn't our issue)
2. a python lint error (this should be fixed, bu
pitrou commented on pull request #8320:
URL: https://github.com/apache/arrow/pull/8320#issuecomment-704460267
Updated benchmarks on AMD Ryzen:
```
benchmark baseline contender
change %
lidavidm commented on pull request #8265:
URL: https://github.com/apache/arrow/pull/8265#issuecomment-704466369
Still needs review. We can take it off the 2.0 milestone.
This is an automated message from the Apache Git Servic
lidavidm edited a comment on pull request #8265:
URL: https://github.com/apache/arrow/pull/8265#issuecomment-704466369
Still needs review. I've taken it off the 2.0 milestone.
This is an automated message from the Apache Git
emkornfield commented on pull request #8320:
URL: https://github.com/apache/arrow/pull/8320#issuecomment-704482050
sorry some personal issues came up. hope to have time tonight to review
this and other parquet related CLs
T
bkietz opened a new pull request #8367:
URL: https://github.com/apache/arrow/pull/8367
Removed cardinality considerations for inferring partition field types.
There is now a boolean flag (`inspect_dictionary`, default false) which if set
causes fields to be inferred as a dictionary encoded
github-actions[bot] commented on pull request #8367:
URL: https://github.com/apache/arrow/pull/8367#issuecomment-704490021
https://issues.apache.org/jira/browse/ARROW-10099
This is an automated message from the Apache Git Ser
pitrou commented on pull request #8320:
URL: https://github.com/apache/arrow/pull/8320#issuecomment-704491476
For the record, if I profile `BM_ReadStructOfListColumn/50`, I get the
following hot spots (in cycles spent):
* ~19% in `DefRepLevelsToListInfo`
* ~15% in `DelimitRecords`
pitrou commented on pull request #8305:
URL: https://github.com/apache/arrow/pull/8305#issuecomment-704497970
The C++ changes addressed my comments. It would be nice though if
@fsaintjacques could take a look.
This is an aut
pitrou commented on a change in pull request #8362:
URL: https://github.com/apache/arrow/pull/8362#discussion_r500539248
##
File path: cpp/src/arrow/util/future.h
##
@@ -358,6 +357,13 @@ class Future {
return fut;
}
+ static Future DeferNotOk(Result maybe_future) {
1 - 100 of 173 matches
Mail list logo
