seddonm1 commented on pull request #8860:
URL: https://github.com/apache/arrow/pull/8860#issuecomment-740452777
Here is a link to the WIP i was doing:
https://github.com/seddonm1/arrow/compare/master...seddonm1:parquet-statistics?expand=1
--
jorisvandenbossche closed pull request #8775:
URL: https://github.com/apache/arrow/pull/8775
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jorisvandenbossche commented on pull request #8775:
URL: https://github.com/apache/arrow/pull/8775#issuecomment-740469065
Thanks @chrisavl !
This is an automated message from the Apache Git Service.
To respond to the message,
XiaokunDing closed pull request #8866:
URL: https://github.com/apache/arrow/pull/8866
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
xhochy closed pull request #8868:
URL: https://github.com/apache/arrow/pull/8868
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
romainfrancois commented on pull request #8650:
URL: https://github.com/apache/arrow/pull/8650#issuecomment-740504045
I believe `AppendMultiple()` is what I would be looking for. It would e.g.
solve my dilemma about converting data frames to struct types ...
I had missed the more eff
XiaokunDing commented on pull request #8866:
URL: https://github.com/apache/arrow/pull/8866#issuecomment-740507022
@seddonm1 , Thanks for your help
This is an automated message from the Apache Git Service.
To respond to the m
pitrou commented on pull request #8472:
URL: https://github.com/apache/arrow/pull/8472#issuecomment-740511215
Ok, I'll rebase a last time to make sure this doesn't break anything.
This is an automated message from the Apache
pitrou commented on a change in pull request #8818:
URL: https://github.com/apache/arrow/pull/8818#discussion_r538196698
##
File path: cpp/src/arrow/filesystem/s3fs.cc
##
@@ -1080,6 +1082,134 @@ void FileObjectToInfo(const S3Model::Object& obj,
FileInfo* info) {
info->set_m
liyafan82 commented on pull request #6208:
URL: https://github.com/apache/arrow/pull/6208#issuecomment-740518112
I am going to close this PR, at least for now, as it has been a long time
since the last comment was received.
liyafan82 closed pull request #6208:
URL: https://github.com/apache/arrow/pull/6208
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r538208202
##
File path: cpp/src/arrow/array/util.cc
##
@@ -84,6 +283,12 @@ std::shared_ptr MakeArray(const
std::shared_ptr& data) {
return out;
}
+void SwapEndia
jorisvandenbossche commented on a change in pull request #8657:
URL: https://github.com/apache/arrow/pull/8657#discussion_r538246392
##
File path: docs/source/python/api/tables.rst
##
@@ -29,6 +29,7 @@ Factory Functions
:toctree: ../generated/
chunked_array
+ combin
jorisvandenbossche commented on pull request #8657:
URL: https://github.com/apache/arrow/pull/8657#issuecomment-740551800
Just a small doc comment, sorry for the delay here
This is an automated message from the Apache Git Ser
jorisvandenbossche commented on pull request #8504:
URL: https://github.com/apache/arrow/pull/8504#issuecomment-740553237
@kszucs Looking at the PR, this is actually seems working and ready to merge?
This is an automated mess
pitrou commented on a change in pull request #8868:
URL: https://github.com/apache/arrow/pull/8868#discussion_r538249607
##
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##
@@ -267,14 +267,19 @@ uint64_t* PartitionNulls(uint64_t* indices_begin,
uint64_t* indices_end,
jorisvandenbossche commented on pull request #8504:
URL: https://github.com/apache/arrow/pull/8504#issuecomment-740556225
Rebased + created a JIRA ticket for it
This is an automated message from the Apache Git Service.
To res
alamb closed pull request #8839:
URL: https://github.com/apache/arrow/pull/8839
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jorisvandenbossche commented on pull request #8504:
URL: https://github.com/apache/arrow/pull/8504#issuecomment-740561767
@github-actions crossbow submit test-conda-python-3.8-pandas-nightly
This is an automated message from
github-actions[bot] commented on pull request #8504:
URL: https://github.com/apache/arrow/pull/8504#issuecomment-740564301
Revision: 5d770f9b7bdf225e4227439b0ebbd875f7af8bfb
Submitted crossbow builds: [ursa-labs/crossbow @
actions-744](https://github.com/ursa-labs/crossbow/branches/a
Dandandan commented on pull request #8748:
URL: https://github.com/apache/arrow/pull/8748#issuecomment-740564846
Would be nice if we can continue with this work. @alamb @andygrove any idea
how this fits in the current design, any alternatives?
-
kszucs commented on pull request #8504:
URL: https://github.com/apache/arrow/pull/8504#issuecomment-740566945
Thanks @jorisvandenbossche! Yes, if everything is green then it should be
good to go.
This is an automated message
kszucs commented on a change in pull request #8650:
URL: https://github.com/apache/arrow/pull/8650#discussion_r538269663
##
File path: r/src/r_to_arrow.cpp
##
@@ -0,0 +1,814 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
kszucs commented on a change in pull request #8650:
URL: https://github.com/apache/arrow/pull/8650#discussion_r538277187
##
File path: r/src/r_to_arrow.cpp
##
@@ -0,0 +1,814 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreem
alamb commented on pull request #8698:
URL: https://github.com/apache/arrow/pull/8698#issuecomment-740585522
Well, I left the benchmarks running overnight on my cloud instance and they
haven't finished yet... I am going to spend some time trying to pair them down
to run in a more reasonabl
pitrou closed pull request #8818:
URL: https://github.com/apache/arrow/pull/8818
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
pitrou closed pull request #8472:
URL: https://github.com/apache/arrow/pull/8472
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
xhochy commented on pull request #8504:
URL: https://github.com/apache/arrow/pull/8504#issuecomment-740594431
It would be nice to have this in a second flavour: build with old, test with
nightly numpy. Feel free to merge on green, I'll try to look into how the other
could be achieved.
--
alamb commented on pull request #8821:
URL: https://github.com/apache/arrow/pull/8821#issuecomment-740602719
I retriggered the C++ CI tests on github in hopes it passes on a subsequent
run.
@jorgecarleitao I propose we merge this PR in and then send a note to the
dev@arrow mailing l
romainfrancois commented on a change in pull request #8650:
URL: https://github.com/apache/arrow/pull/8650#discussion_r538349309
##
File path: r/src/r_to_arrow.cpp
##
@@ -0,0 +1,814 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
romainfrancois commented on a change in pull request #8650:
URL: https://github.com/apache/arrow/pull/8650#discussion_r538351779
##
File path: r/src/r_to_arrow.cpp
##
@@ -0,0 +1,814 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
alamb commented on a change in pull request #8867:
URL: https://github.com/apache/arrow/pull/8867#discussion_r538364348
##
File path: rust/arrow/src/json/reader.rs
##
@@ -250,19 +326,17 @@ pub fn infer_json_schema(
reader: &mut BufReader,
max_read_records: Option,
)
jorgecarleitao commented on pull request #8821:
URL: https://github.com/apache/arrow/pull/8821#issuecomment-740619423
Let's do that. I can write the note, as I can also describe the changes in
more depth, as IMO they are relevant to other parts of the project also.
---
alamb commented on a change in pull request #8866:
URL: https://github.com/apache/arrow/pull/8866#discussion_r538371128
##
File path: rust/datafusion/src/datasource/datasource.rs
##
@@ -24,6 +24,15 @@ use crate::arrow::datatypes::SchemaRef;
use crate::error::Result;
use crate
alamb commented on pull request #8821:
URL: https://github.com/apache/arrow/pull/8821#issuecomment-740627085
@jorgecarleitao -- sounds good (with you writing the note)
The windows C++ test is still failing in a strange way -- I can't seem to
find `AMD64 Windows 2019 C++` running on
jorgecarleitao commented on pull request #8821:
URL: https://github.com/apache/arrow/pull/8821#issuecomment-740634083
@alamb , these are unrelated and I (unfortunately) see them often whenever I
need to change dockerfiles and other CI files. I have been ignoring them, as I
expect / hope th
alamb commented on pull request #8821:
URL: https://github.com/apache/arrow/pull/8821#issuecomment-740635592
Ok, 🚀 it is then!
cc @nevi-me @andygrove @kszucs
This is an automated message from the Apache Git Service.
alamb closed pull request #8821:
URL: https://github.com/apache/arrow/pull/8821
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
andygrove commented on a change in pull request #8866:
URL: https://github.com/apache/arrow/pull/8866#discussion_r538442723
##
File path: rust/datafusion/src/datasource/datasource.rs
##
@@ -24,6 +24,15 @@ use crate::arrow::datatypes::SchemaRef;
use crate::error::Result;
use c
andygrove commented on pull request #8760:
URL: https://github.com/apache/arrow/pull/8760#issuecomment-740658677
I will be getting back to this PR in the next day or two.
This is an automated message from the Apache Git Servi
jorisvandenbossche closed pull request #8504:
URL: https://github.com/apache/arrow/pull/8504
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jorisvandenbossche commented on pull request #8504:
URL: https://github.com/apache/arrow/pull/8504#issuecomment-740665982
Indeed, that would be nice as well. I am not sure how easy it is with the
current docker-compose workflow ..
--
jorisvandenbossche opened a new pull request #8869:
URL: https://github.com/apache/arrow/pull/8869
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jorisvandenbossche commented on pull request #8869:
URL: https://github.com/apache/arrow/pull/8869#issuecomment-740679201
@github-actions crossbow submit test-conda-python-3.8-pandas-nightly
This is an automated message from
github-actions[bot] commented on pull request #8869:
URL: https://github.com/apache/arrow/pull/8869#issuecomment-740681502
Revision: 98e93a999e93fd4bc84cc9f708921f565d368b37
Submitted crossbow builds: [ursa-labs/crossbow @
actions-745](https://github.com/ursa-labs/crossbow/branches/a
github-actions[bot] commented on pull request #8869:
URL: https://github.com/apache/arrow/pull/8869#issuecomment-740690559
https://issues.apache.org/jira/browse/ARROW-10849
This is an automated message from the Apache Git Ser
rj-atw commented on pull request #7767:
URL: https://github.com/apache/arrow/pull/7767#issuecomment-740767675
I am still intersted.
Started new job, so diverted my attention. But hoping to close this out
during holiday break.
On Mon, Dec 7, 2020, 10:10 PM Jorge Leitao wrote
houqp commented on a change in pull request #8867:
URL: https://github.com/apache/arrow/pull/8867#discussion_r538675155
##
File path: rust/arrow/src/json/reader.rs
##
@@ -250,19 +326,17 @@ pub fn infer_json_schema(
reader: &mut BufReader,
max_read_records: Option,
)
houqp commented on pull request #8867:
URL: https://github.com/apache/arrow/pull/8867#issuecomment-740808479
Thanks @alamb for the review, I will add more tests as well as also change
to decouple IO from record batch reader.
codecov-io commented on pull request #8863:
URL: https://github.com/apache/arrow/pull/8863#issuecomment-740808850
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8863?src=pr&el=h1) Report
> Merging
[#8863](https://codecov.io/gh/apache/arrow/pull/8863?src=pr&el=desc) (3559d97)
into
Dandandan commented on pull request #8863:
URL: https://github.com/apache/arrow/pull/8863#issuecomment-740809969
@jorgecarleitao
Just extended the change for hash aggregates as well.
Turns out, a good speedup as well for hash aggregate queries!
[This version]
```
jorgecarleitao closed pull request #8852:
URL: https://github.com/apache/arrow/pull/8852
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
fsaintjacques commented on pull request #8855:
URL: https://github.com/apache/arrow/pull/8855#issuecomment-740820889
This is not a JSON reader like the C++'s json reader. This is only meant to
support the internal custom format used for integration testing between
implementation languages.
Dandandan commented on pull request #8865:
URL: https://github.com/apache/arrow/pull/8865#issuecomment-740824472
@seddonm1 could you rebase again?
This is an automated message from the Apache Git Service.
To respond to the me
houqp commented on a change in pull request #8853:
URL: https://github.com/apache/arrow/pull/8853#discussion_r538703517
##
File path: rust/arrow/src/array/builder.rs
##
@@ -3969,579 +3296,4 @@ mod tests {
// Special error if the key overflows (256th entry)
bui
nealrichardson commented on a change in pull request #8824:
URL: https://github.com/apache/arrow/pull/8824#discussion_r538745060
##
File path: .github/workflows/cpp.yml
##
@@ -21,7 +21,7 @@ on:
push:
paths:
- '.github/workflows/cpp.yml'
- - 'ci/docker/**'
+
xhochy commented on pull request #8855:
URL: https://github.com/apache/arrow/pull/8855#issuecomment-740901677
> This is not a JSON reader like the C++'s json reader. This is only meant
to support the internal custom format used for integration testing between
implementation languages.
>
xhochy edited a comment on pull request #8855:
URL: https://github.com/apache/arrow/pull/8855#issuecomment-740901677
> This is not a JSON reader like the C++'s json reader. This is only meant
to support the internal custom format used for integration testing between
implementation language
seddonm1 commented on pull request #8865:
URL: https://github.com/apache/arrow/pull/8865#issuecomment-740904102
rebased.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
jorgecarleitao commented on a change in pull request #8824:
URL: https://github.com/apache/arrow/pull/8824#discussion_r538749024
##
File path: .github/workflows/cpp.yml
##
@@ -21,7 +21,7 @@ on:
push:
paths:
- '.github/workflows/cpp.yml'
- - 'ci/docker/**'
+
seddonm1 commented on a change in pull request #8866:
URL: https://github.com/apache/arrow/pull/8866#discussion_r538750212
##
File path: rust/datafusion/src/datasource/datasource.rs
##
@@ -24,6 +24,15 @@ use crate::arrow::datatypes::SchemaRef;
use crate::error::Result;
use cr
seddonm1 removed a comment on pull request #8865:
URL: https://github.com/apache/arrow/pull/8865#issuecomment-740904102
rebased.
This is an automated message from the Apache Git Service.
To respond to the message, please log
kiszk commented on pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#issuecomment-740923764
Addressed comments except the following two items
- be addressing
https://github.com/apache/arrow/pull/7507#discussion_r513711536
- postpone https://github.com/apache/arrow/pul
jorgecarleitao commented on a change in pull request #8824:
URL: https://github.com/apache/arrow/pull/8824#discussion_r538756496
##
File path: .github/workflows/cpp.yml
##
@@ -21,7 +21,7 @@ on:
push:
paths:
- '.github/workflows/cpp.yml'
- - 'ci/docker/**'
+
seddonm1 commented on pull request #8865:
URL: https://github.com/apache/arrow/pull/8865#issuecomment-740930440
rebased.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
seddonm1 commented on pull request #8760:
URL: https://github.com/apache/arrow/pull/8760#issuecomment-740934197
I can help with this if you can describe your plans.
This is an automated message from the Apache Git Service.
To
alamb commented on a change in pull request #8698:
URL: https://github.com/apache/arrow/pull/8698#discussion_r538756445
##
File path: rust/parquet/src/data_type.rs
##
@@ -327,7 +422,12 @@ pub trait AsBytes {
pub trait SliceAsBytes: Sized {
/// Returns slice of bytes for a
alamb commented on pull request #8698:
URL: https://github.com/apache/arrow/pull/8698#issuecomment-740944598
FYI @sunchao @nevi-me @jorgecarleitao -- I spent quite a while verifying
the performance of this approach and reviewing the code (treatise is here:
https://github.com/apache/arro
andygrove commented on pull request #8760:
URL: https://github.com/apache/arrow/pull/8760#issuecomment-740950757
Thanks @seddonm1 that would be great if you have the time. I was really just
planning on addressing feedback. Feel free to push to this PR or create a new
one to replace this.
seddonm1 commented on pull request #8760:
URL: https://github.com/apache/arrow/pull/8760#issuecomment-740954932
@andygrove No worries. Hopefully I can help on some of these easier tasks to
free you up for the harder ones.
Th
jorgecarleitao commented on pull request #8698:
URL: https://github.com/apache/arrow/pull/8698#issuecomment-740958408
@alamb benchmarks formatted as a table (from worse to best, statistical
insignificant and changes <5% ignored). No judgement, just info:
| benchmark | variation (%)
jorgecarleitao edited a comment on pull request #8698:
URL: https://github.com/apache/arrow/pull/8698#issuecomment-740958408
@alamb benchmarks formatted as a table (from worse to best, statistical
insignificant and changes <5% ignored). No judgement, just info:
| benchmark | variati
Dandandan commented on pull request #8685:
URL: https://github.com/apache/arrow/pull/8685#issuecomment-740997894
@jhorstmann
I wonder if we should support a standardized ordering like IEEE 754 instead?
There is a (unstable) implementation in rust std for it.
https://doc.rust-l
alamb commented on pull request #8698:
URL: https://github.com/apache/arrow/pull/8698#issuecomment-741052690
Thank you @jorgecarleitao -- that table is much better than my hand wavy
analysis.
This is an automated message f
jorgecarleitao opened a new pull request #8870:
URL: https://github.com/apache/arrow/pull/8870
This PR simplifies the logical plan by removing `CsvScan`, `ParquetScan` and
`InMemoryScan` and encapsulating all of them into `TableScan`.
The underlying aspect here is that all these node
github-actions[bot] commented on pull request #8870:
URL: https://github.com/apache/arrow/pull/8870#issuecomment-741072900
https://issues.apache.org/jira/browse/ARROW-10854
This is an automated message from the Apache Git Ser
kou commented on a change in pull request #8868:
URL: https://github.com/apache/arrow/pull/8868#discussion_r538898690
##
File path: cpp/src/arrow/compute/kernels/vector_sort.cc
##
@@ -267,14 +267,19 @@ uint64_t* PartitionNulls(uint64_t* indices_begin,
uint64_t* indices_end,
/
kou opened a new pull request #8871:
URL: https://github.com/apache/arrow/pull/8871
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kou commented on pull request #8871:
URL: https://github.com/apache/arrow/pull/8871#issuecomment-741341269
@github-actions crossbow submit centos-8-*
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on pull request #8871:
URL: https://github.com/apache/arrow/pull/8871#issuecomment-741343305
Revision: ffc14991c0fcca0a038e291b5f1214c6942ea49c
Submitted crossbow builds: [ursa-labs/crossbow @
actions-746](https://github.com/ursa-labs/crossbow/branches/a
github-actions[bot] commented on pull request #8871:
URL: https://github.com/apache/arrow/pull/8871#issuecomment-741381752
https://issues.apache.org/jira/browse/ARROW-10857
This is an automated message from the Apache Git Ser
kou commented on pull request #8871:
URL: https://github.com/apache/arrow/pull/8871#issuecomment-741458568
+1
g++ crash is another problem:
```text
FAILED:
src/arrow/CMakeFiles/arrow_objlib.dir/compute/kernels/codegen_internal.cc.o
/usr/bin/c++ -DARROW_EXPORTING -DARR
kou closed pull request #8871:
URL: https://github.com/apache/arrow/pull/8871
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
kou opened a new pull request #8872:
URL: https://github.com/apache/arrow/pull/8872
`cpp/src/arrow/util/int128_internal.h` requires Boost.
This is an automated message from the Apache Git Service.
To respond to the message, p
github-actions[bot] commented on pull request #8872:
URL: https://github.com/apache/arrow/pull/8872#issuecomment-741491345
https://issues.apache.org/jira/browse/ARROW-10858
This is an automated message from the Apache Git Ser
polm opened a new issue #8873:
URL: https://github.com/apache/arrow/issues/8873
Thanks for your work on pyarrow.
Are there plans to release Python 3.9 wheels for pyarrow? The lack of wheels
makes installing software that relies on pyarrow difficult; here's an example
that bit me:
polm closed issue #8873:
URL: https://github.com/apache/arrow/issues/8873
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
polm commented on issue #8873:
URL: https://github.com/apache/arrow/issues/8873#issuecomment-741509919
Ah, just saw #8610, sorry for the noise.
This is an automated message from the Apache Git Service.
To respond to the messa
jorgecarleitao opened a new pull request #8874:
URL: https://github.com/apache/arrow/pull/8874
This PR observes that `ExecutionContext::collect(&self, plan: Arc)` does not use `self` on its implementation.
Using this observation, it refactors out `collect` out of `ExecutionContext`
(
github-actions[bot] commented on pull request #8874:
URL: https://github.com/apache/arrow/pull/8874#issuecomment-741529902
https://issues.apache.org/jira/browse/ARROW-10859
This is an automated message from the Apache Git Ser
codecov-io commented on pull request #8874:
URL: https://github.com/apache/arrow/pull/8874#issuecomment-741530586
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8874?src=pr&el=h1) Report
> Merging
[#8874](https://codecov.io/gh/apache/arrow/pull/8874?src=pr&el=desc) (562bc1f)
into
jorgecarleitao opened a new pull request #8875:
URL: https://github.com/apache/arrow/pull/8875
This PR is built on top of #8874 , and provides a modification to the
`ExecutionContext` necessary to run joins where `register_table` is called
between creation of `DataFrame`.
The underl
codecov-io edited a comment on pull request #8874:
URL: https://github.com/apache/arrow/pull/8874#issuecomment-741530586
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8874?src=pr&el=h1) Report
> Merging
[#8874](https://codecov.io/gh/apache/arrow/pull/8874?src=pr&el=desc) (976878f)
codecov-io commented on pull request #8875:
URL: https://github.com/apache/arrow/pull/8875#issuecomment-741535928
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8875?src=pr&el=h1) Report
> Merging
[#8875](https://codecov.io/gh/apache/arrow/pull/8875?src=pr&el=desc) (4dd056c)
into
github-actions[bot] commented on pull request #8875:
URL: https://github.com/apache/arrow/pull/8875#issuecomment-741536605
https://issues.apache.org/jira/browse/ARROW-10844
This is an automated message from the Apache Git Ser
codecov-io edited a comment on pull request #8875:
URL: https://github.com/apache/arrow/pull/8875#issuecomment-741535928
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8875?src=pr&el=h1) Report
> Merging
[#8875](https://codecov.io/gh/apache/arrow/pull/8875?src=pr&el=desc) (925caf9)
codecov-io edited a comment on pull request #8874:
URL: https://github.com/apache/arrow/pull/8874#issuecomment-741530586
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8874?src=pr&el=h1) Report
> Merging
[#8874](https://codecov.io/gh/apache/arrow/pull/8874?src=pr&el=desc) (af52402)
XiaokunDing commented on a change in pull request #8866:
URL: https://github.com/apache/arrow/pull/8866#discussion_r539020866
##
File path: rust/datafusion/src/datasource/datasource.rs
##
@@ -24,6 +24,15 @@ use crate::arrow::datatypes::SchemaRef;
use crate::error::Result;
use
XiaokunDing commented on a change in pull request #8866:
URL: https://github.com/apache/arrow/pull/8866#discussion_r539020866
##
File path: rust/datafusion/src/datasource/datasource.rs
##
@@ -24,6 +24,15 @@ use crate::arrow::datatypes::SchemaRef;
use crate::error::Result;
use
seddonm1 commented on a change in pull request #8866:
URL: https://github.com/apache/arrow/pull/8866#discussion_r539028012
##
File path: rust/datafusion/src/datasource/datasource.rs
##
@@ -24,6 +24,15 @@ use crate::arrow::datatypes::SchemaRef;
use crate::error::Result;
use cr
1 - 100 of 112 matches
Mail list logo
