[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
xhochy commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742361428 @github-actions crossbow submit wheel-win-cp38 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742363030 Revision: b723f0cd2bdcf729d581250600164e6f265c3dd5 Submitted crossbow builds: [ursa-labs/crossbow @ actions-760](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
xhochy commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742393667 @github-actions crossbow submit wheel-win-cp38 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
xhochy commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742411615 @github-actions crossbow submit wheel-win-cp38 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742412628 Revision: bdb5df7887dd34bdaa15e583b934d498019278b8 Submitted crossbow builds: [ursa-labs/crossbow @ actions-761](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] xhochy commented on pull request #8878: ARROW-10861: [Python] Update minimal NumPy version to 1.16.6

2020-12-10 Thread GitBox
xhochy commented on pull request #8878: URL: https://github.com/apache/arrow/pull/8878#issuecomment-742417983 Windows Wheels in general are currently broken. I have a WIP PR in https://github.com/apache/arrow/pull/8881 to have everything build from `BUNDLED` instead of using `conda-forge`

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8878: ARROW-10861: [Python] Update minimal NumPy version to 1.16.6

2020-12-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #8878: URL: https://github.com/apache/arrow/pull/8878#discussion_r540035388 ## File path: python/pyproject.toml ## @@ -18,8 +18,8 @@ [build-system] requires = [ "cython >= 0.29", -"numpy==1.14.5; python_version

[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
xhochy commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742423863 @github-actions crossbow submit wheel-win-cp38 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742435860 Revision: 4d5d7c0cca7b593fea10560a28af69abd3ac19d9 Submitted crossbow builds: [ursa-labs/crossbow @ actions-762](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] xhochy commented on pull request #8884: ARROW-10870: include Julia in project documentation

2020-12-10 Thread GitBox
xhochy commented on pull request #8884: URL: https://github.com/apache/arrow/pull/8884#issuecomment-742445602 @quinnj The `arrow.apache.org` code is over at https://github.com/apache/arrow-site This is an automated message f

[GitHub] [arrow] pitrou commented on pull request #8806: ARROW-10776: [C++] Allow STL iteration over concrete primitive arrays

2020-12-10 Thread GitBox
pitrou commented on pull request #8806: URL: https://github.com/apache/arrow/pull/8806#issuecomment-742446624 Travis-CI build (green): https://travis-ci.org/github/pitrou/arrow/builds/748730373 This is an automated message f

[GitHub] [arrow] Dandandan commented on pull request #8842: ARROW-10812: [Rust] Make BooleanArray not a PrimitiveArray

2020-12-10 Thread GitBox
Dandandan commented on pull request #8842: URL: https://github.com/apache/arrow/pull/8842#issuecomment-742448903 @alamb @andygrove @nevi-me If you have time would be nice to have this PR reviewed and https://github.com/apache/arrow/pull/8863 both bringing ~10-20% perf. improvements

[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
xhochy commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742454261 @github-actions crossbow submit wheel-win-cp38 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742454981 Revision: d1dea6a417eba6131b3b5400fe4ce600065ade77 Submitted crossbow builds: [ursa-labs/crossbow @ actions-763](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] pitrou closed pull request #8806: ARROW-10776: [C++] Allow STL iteration over concrete primitive arrays

2020-12-10 Thread GitBox
pitrou closed pull request #8806: URL: https://github.com/apache/arrow/pull/8806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kszucs opened a new pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

2020-12-10 Thread GitBox
kszucs opened a new pull request #8886: URL: https://github.com/apache/arrow/pull/8886 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] pitrou removed a comment on pull request #8811: ARROW-6883: [C++][Python] Allow writing dictionary deltas

2020-12-10 Thread GitBox
pitrou removed a comment on pull request #8811: URL: https://github.com/apache/arrow/pull/8811#issuecomment-742141036 TODO: need to update the feature matrix This is an automated message from the Apache Git Service. To respon

[GitHub] [arrow] kszucs commented on a change in pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

2020-12-10 Thread GitBox
kszucs commented on a change in pull request #8886: URL: https://github.com/apache/arrow/pull/8886#discussion_r540102788 ## File path: cpp/src/arrow/util/converter.h ## @@ -52,7 +52,15 @@ class Converter { return Init(pool); } - virtual Status Append(InputType value)

[GitHub] [arrow] github-actions[bot] commented on pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8886: URL: https://github.com/apache/arrow/pull/8886#issuecomment-742470961 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then could

[GitHub] [arrow] kszucs commented on a change in pull request #8886: [C++] Add Extend and ExtendMasked to the converter interface

2020-12-10 Thread GitBox
kszucs commented on a change in pull request #8886: URL: https://github.com/apache/arrow/pull/8886#discussion_r540105542 ## File path: cpp/src/arrow/util/converter.h ## @@ -294,6 +302,34 @@ class Chunker { return status; } + // we could get bit smarter here since the

[GitHub] [arrow] sweb commented on pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader WIP

2020-12-10 Thread GitBox
sweb commented on pull request #8880: URL: https://github.com/apache/arrow/pull/8880#issuecomment-742488003 > Also https://issues.apache.org/jira/browse/ARROW-10818 @seddonm1 Thanks for mentioning this issue - I was not aware of it. Could you point me in the direction of some modules

[GitHub] [arrow] Dandandan edited a comment on pull request #8842: ARROW-10812: [Rust] Make BooleanArray not a PrimitiveArray

2020-12-10 Thread GitBox
Dandandan edited a comment on pull request #8842: URL: https://github.com/apache/arrow/pull/8842#issuecomment-742448903 @alamb @andygrove @nevi-me If you have time would be nice to have this PR reviewed and https://github.com/apache/arrow/pull/8863 both bringing ~10-20% perf. impro

[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
xhochy commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742492298 @github-actions crossbow submit wheel-win-cp38 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742493048 Revision: 774d91c8cabaee63d5da57269d761acea4fb3f68 Submitted crossbow builds: [ursa-labs/crossbow @ actions-764](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] xhochy commented on pull request #8491: WIP: ARROW-10349: [Python] linux aarch64 wheels

2020-12-10 Thread GitBox
xhochy commented on pull request #8491: URL: https://github.com/apache/arrow/pull/8491#issuecomment-742493941 A possible way to unblock this would also be just running the `aarch64` container with emulation on Github Actions or Azure Pipelines. This will take 3-5x the time but it will at l

[GitHub] [arrow] jorisvandenbossche opened a new pull request #8887: ARROW-10863: [Python] Fix ExtensionArray.to_pandas to use underlying storage array

2020-12-10 Thread GitBox
jorisvandenbossche opened a new pull request #8887: URL: https://github.com/apache/arrow/pull/8887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
xhochy commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742516297 @github-actions crossbow submit wheel-win-cp38 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] jorisvandenbossche commented on pull request #8816: ARROW-9027: [Python][Testing] Split parquet tests into multiple files + clean-up

2020-12-10 Thread GitBox
jorisvandenbossche commented on pull request #8816: URL: https://github.com/apache/arrow/pull/8816#issuecomment-742517633 Sorry, we merged another PR which added a test to `to_parquet.py`: https://github.com/apache/arrow/pull/8861. Can you check this is included correctly? --

[GitHub] [arrow] github-actions[bot] commented on pull request #8887: ARROW-10863: [Python] Fix ExtensionArray.to_pandas to use underlying storage array

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8887: URL: https://github.com/apache/arrow/pull/8887#issuecomment-742518447 https://issues.apache.org/jira/browse/ARROW-10863 This is an automated message from the Apache Git Ser

[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742519672 Revision: 547a693955dc3fa9d15793468c9431e86d6b7bab Submitted crossbow builds: [ursa-labs/crossbow @ actions-765](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8816: ARROW-9027: [Python][Testing] Split parquet tests into multiple files + clean-up

2020-12-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #8816: URL: https://github.com/apache/arrow/pull/8816#discussion_r540167236 ## File path: python/pyarrow/tests/parquet/common.py ## @@ -0,0 +1,313 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or mor

[GitHub] [arrow] alamb opened a new pull request #8888: ARROW-10865: [Rust] Easier to use Schema -> DFSchema conversion

2020-12-10 Thread GitBox
alamb opened a new pull request #: URL: https://github.com/apache/arrow/pull/ While trying to update to the latest arrow code in IOx (https://github.com/influxdata/influxdb_iox/pull/540) I found it quite cumbersome to convert between `SchemaRef` <--> `DFSchemaRef` so I wanted to tr

[GitHub] [arrow] alamb commented on a change in pull request #8888: ARROW-10865: [Rust] Easier to use Schema -> DFSchema conversion

2020-12-10 Thread GitBox
alamb commented on a change in pull request #: URL: https://github.com/apache/arrow/pull/#discussion_r540189450 ## File path: rust/datafusion/src/logical_plan/dfschema.rs ## @@ -89,11 +89,11 @@ impl DFSchema { } /// Create a `DFSchema` from an Arrow schema -

[GitHub] [arrow] codecov-io commented on pull request #8888: ARROW-10865: [Rust] Easier to use Schema -> DFSchema conversion

2020-12-10 Thread GitBox
codecov-io commented on pull request #: URL: https://github.com/apache/arrow/pull/#issuecomment-742541463 # [Codecov](https://codecov.io/gh/apache/arrow/pull/?src=pr&el=h1) Report > Merging [#](https://codecov.io/gh/apache/arrow/pull/?src=pr&el=desc) (c46c5eb) into

[GitHub] [arrow] jorisvandenbossche commented on pull request #8672: ARROW-10574: [Python][Parquet] Enhance hive partition filtering.

2020-12-10 Thread GitBox
jorisvandenbossche commented on pull request #8672: URL: https://github.com/apache/arrow/pull/8672#issuecomment-742543077 @wyzhao thanks for the update! I am waiting until https://github.com/apache/arrow/pull/8816 gets merged, and then will get back to this PR (this will give a merge confl

[GitHub] [arrow] github-actions[bot] commented on pull request #8888: ARROW-10865: [Rust] Easier to use Schema -> DFSchema conversion

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #: URL: https://github.com/apache/arrow/pull/#issuecomment-742544913 https://issues.apache.org/jira/browse/ARROW-10865 This is an automated message from the Apache Git Ser

[GitHub] [arrow] waynexia commented on pull request #8862: ARROW-10836: [Rust] Extend take kernel to FixedSizeListArray

2020-12-10 Thread GitBox
waynexia commented on pull request #8862: URL: https://github.com/apache/arrow/pull/8862#issuecomment-742550724 Hi @alamb @jorgecarleitao, could you please take a look at this:wink:. Thanks! The purpose of this pr is to support `list_sort` in #8856.

[GitHub] [arrow] xhochy commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
xhochy commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742572138 @github-actions crossbow submit wheel-win-cp38 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8805: ARROW-10725: [Python][Compute] Expose sort options in Python bindings

2020-12-10 Thread GitBox
jorisvandenbossche commented on a change in pull request #8805: URL: https://github.com/apache/arrow/pull/8805#discussion_r540235330 ## File path: python/pyarrow/compute.py ## @@ -155,7 +157,7 @@ def _handle_options(name, option_class, options, kwargs): "Function {

[GitHub] [arrow] github-actions[bot] commented on pull request #8881: WIP: Fix Windows wheel

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8881: URL: https://github.com/apache/arrow/pull/8881#issuecomment-742573626 Revision: d548b72b57149d0b4267c4cd0754129c9623861d Submitted crossbow builds: [ursa-labs/crossbow @ actions-766](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] alamb commented on pull request #8842: ARROW-10812: [Rust] Make BooleanArray not a PrimitiveArray

2020-12-10 Thread GitBox
alamb commented on pull request #8842: URL: https://github.com/apache/arrow/pull/8842#issuecomment-742607866 I will review it carefully shortly On Thu, Dec 10, 2020 at 9:53 AM Andy Grove wrote: > *@andygrove* approved this pull request. > > I haven't had time to review t

[GitHub] [arrow] nealrichardson commented on a change in pull request #8885: ARROW-10871: [Julia][CI] Setup Julia testing via Github Actions

2020-12-10 Thread GitBox
nealrichardson commented on a change in pull request #8885: URL: https://github.com/apache/arrow/pull/8885#discussion_r540290376 ## File path: .github/workflows/julia.yml ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

[GitHub] [arrow] alamb commented on a change in pull request #8842: ARROW-10812: [Rust] Make BooleanArray not a PrimitiveArray

2020-12-10 Thread GitBox
alamb commented on a change in pull request #8842: URL: https://github.com/apache/arrow/pull/8842#discussion_r540295695 ## File path: rust/arrow/src/array/array_boolean.rs ## @@ -0,0 +1,331 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributo

[GitHub] [arrow] Dandandan commented on pull request #8860: ARROW-10783: [Rust] [DataFusion] Implement row count statistics for Parquet TableProviderParquet statistics [WIP]

2020-12-10 Thread GitBox
Dandandan commented on pull request #8860: URL: https://github.com/apache/arrow/pull/8860#issuecomment-742651345 @XiaokunDing what about changing the statistics to be optional per statistic, but not the `statistics` itself? I was looking at adding it e.g. for a MemTable where it is easy

[GitHub] [arrow] Dandandan commented on pull request #8860: ARROW-10783: [Rust] [DataFusion] Implement row count statistics for Parquet TableProviderParquet statistics [WIP]

2020-12-10 Thread GitBox
Dandandan commented on pull request #8860: URL: https://github.com/apache/arrow/pull/8860#issuecomment-742653929 So the proposal would be to change the statistics struct to ```rust pub struct Statistics { /// The number of table rows pub num_rows: Option, ///

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8842: ARROW-10812: [Rust] Make BooleanArray not a PrimitiveArray

2020-12-10 Thread GitBox
jorgecarleitao commented on a change in pull request #8842: URL: https://github.com/apache/arrow/pull/8842#discussion_r540338798 ## File path: rust/arrow/src/array/array_boolean.rs ## @@ -0,0 +1,331 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8842: ARROW-10812: [Rust] Make BooleanArray not a PrimitiveArray

2020-12-10 Thread GitBox
jorgecarleitao commented on a change in pull request #8842: URL: https://github.com/apache/arrow/pull/8842#discussion_r540339137 ## File path: rust/arrow/src/array/array_boolean.rs ## @@ -0,0 +1,331 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8888: ARROW-10865: [Rust] Easier to use Schema -> DFSchema conversion

2020-12-10 Thread GitBox
jorgecarleitao commented on a change in pull request #: URL: https://github.com/apache/arrow/pull/#discussion_r540340548 ## File path: rust/datafusion/src/logical_plan/dfschema.rs ## @@ -89,11 +89,11 @@ impl DFSchema { } /// Create a `DFSchema` from an Arrow

[GitHub] [arrow] Dandandan opened a new pull request #8889: ARROW-10874: Add statistics for MemTable,

2020-12-10 Thread GitBox
Dandandan opened a new pull request #8889: URL: https://github.com/apache/arrow/pull/8889 This adds the `num_rows` for `MemTable` (which would allow optimizations for joins). This also changes the trait to allow to have individual stats optional instead of "all or nothing". -

[GitHub] [arrow] Dandandan commented on pull request #8860: ARROW-10783: [Rust] [DataFusion] Implement row count statistics for Parquet TableProviderParquet statistics [WIP]

2020-12-10 Thread GitBox
Dandandan commented on pull request #8860: URL: https://github.com/apache/arrow/pull/8860#issuecomment-742665691 Added a PR for that here: https://github.com/apache/arrow/pull/8889 This is an automated message from the Apache

[GitHub] [arrow] github-actions[bot] commented on pull request #8889: ARROW-10874: [Rust][DataFusion] Add statistics for MemTable, change statistics trait

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8889: URL: https://github.com/apache/arrow/pull/8889#issuecomment-742675179 https://issues.apache.org/jira/browse/ARROW-10874 This is an automated message from the Apache Git Ser

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8842: ARROW-10812: [Rust] Make BooleanArray not a PrimitiveArray

2020-12-10 Thread GitBox
jorgecarleitao commented on a change in pull request #8842: URL: https://github.com/apache/arrow/pull/8842#discussion_r540338798 ## File path: rust/arrow/src/array/array_boolean.rs ## @@ -0,0 +1,331 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more c

[GitHub] [arrow] pitrou opened a new pull request #8890: ARROW-10796: [C++] Implement optimized RecordBatch sorting

2020-12-10 Thread GitBox
pitrou opened a new pull request #8890: URL: https://github.com/apache/arrow/pull/8890 Add two RecordBatch sorting implementations: * A single-pass left-to-right radix sort that's fast up to ~8 sort keys * A single-pass multiple-key-comparing sort that gives decent performance for lar

[GitHub] [arrow] codecov-io commented on pull request #8889: ARROW-10874: [Rust][DataFusion] Add statistics for MemTable, change statistics trait

2020-12-10 Thread GitBox
codecov-io commented on pull request #8889: URL: https://github.com/apache/arrow/pull/8889#issuecomment-742689858 # [Codecov](https://codecov.io/gh/apache/arrow/pull/8889?src=pr&el=h1) Report > Merging [#8889](https://codecov.io/gh/apache/arrow/pull/8889?src=pr&el=desc) (51562ad) into

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8842: ARROW-10812: [Rust] Make BooleanArray not a PrimitiveArray

2020-12-10 Thread GitBox
jorgecarleitao commented on a change in pull request #8842: URL: https://github.com/apache/arrow/pull/8842#discussion_r540380327 ## File path: rust/arrow/src/array/equal_json.rs ## @@ -49,6 +49,20 @@ impl JsonEqual for PrimitiveArray { } } +/// Implement array equals fo

[GitHub] [arrow] Dandandan commented on a change in pull request #8842: ARROW-10812: [Rust] Make BooleanArray not a PrimitiveArray

2020-12-10 Thread GitBox
Dandandan commented on a change in pull request #8842: URL: https://github.com/apache/arrow/pull/8842#discussion_r540385163 ## File path: rust/arrow/src/array/equal_json.rs ## @@ -49,6 +49,20 @@ impl JsonEqual for PrimitiveArray { } } +/// Implement array equals for num

[GitHub] [arrow] pitrou commented on pull request #8890: ARROW-10796: [C++] Implement optimized RecordBatch sorting

2020-12-10 Thread GitBox
pitrou commented on pull request #8890: URL: https://github.com/apache/arrow/pull/8890#issuecomment-742697603 cc @kou This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [arrow] houqp opened a new pull request #8891: ARROW-10875 [Rust] simplify simd cfg check with cfg_aliases

2020-12-10 Thread GitBox
houqp opened a new pull request #8891: URL: https://github.com/apache/arrow/pull/8891 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [arrow] github-actions[bot] commented on pull request #8890: ARROW-10796: [C++] Implement optimized RecordBatch sorting

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8890: URL: https://github.com/apache/arrow/pull/8890#issuecomment-742715663 https://issues.apache.org/jira/browse/ARROW-10796 This is an automated message from the Apache Git Ser

[GitHub] [arrow] github-actions[bot] commented on pull request #8891: ARROW-10875 [Rust] simplify simd cfg check with cfg_aliases

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8891: URL: https://github.com/apache/arrow/pull/8891#issuecomment-742715664 https://issues.apache.org/jira/browse/ARROW-10875 This is an automated message from the Apache Git Ser

[GitHub] [arrow] terencehonles commented on pull request #8386: ARROW-10224: [Python] Build, test, and support Python 3.9

2020-12-10 Thread GitBox
terencehonles commented on pull request #8386: URL: https://github.com/apache/arrow/pull/8386#issuecomment-742719093 I'll try to build locally, there seems to be a SSL/TLS error when trying to use `yum` This is an automated

[GitHub] [arrow] terencehonles edited a comment on pull request #8386: ARROW-10224: [Python] Build, test, and support Python 3.9

2020-12-10 Thread GitBox
terencehonles edited a comment on pull request #8386: URL: https://github.com/apache/arrow/pull/8386#issuecomment-742719093 I'll try to build locally, there seems to be a SSL/TLS error when trying to use `yum` Looks like it is likely this https://github.com/pypa/manylinux/pull/845 so

[GitHub] [arrow] terencehonles commented on pull request #8386: ARROW-10224: [Python] Build, test, and support Python 3.9

2020-12-10 Thread GitBox
terencehonles commented on pull request #8386: URL: https://github.com/apache/arrow/pull/8386#issuecomment-742723943 @github-actions crossbow submit wheel-manylinux* This is an automated message from the Apache Git Service. T

[GitHub] [arrow] terencehonles commented on pull request #8386: ARROW-10224: [Python] Build, test, and support Python 3.9

2020-12-10 Thread GitBox
terencehonles commented on pull request #8386: URL: https://github.com/apache/arrow/pull/8386#issuecomment-742726547 @xhochy is windows failing on `master`? I see your PR #8881 and not sure if I should leave windows as is. I also notice that the osx wheels aren't building either and not su

[GitHub] [arrow] codecov-io commented on pull request #8891: ARROW-10875 [Rust] simplify simd cfg check with cfg_aliases

2020-12-10 Thread GitBox
codecov-io commented on pull request #8891: URL: https://github.com/apache/arrow/pull/8891#issuecomment-742727854 # [Codecov](https://codecov.io/gh/apache/arrow/pull/8891?src=pr&el=h1) Report > Merging [#8891](https://codecov.io/gh/apache/arrow/pull/8891?src=pr&el=desc) (c20dde7) into

[GitHub] [arrow] github-actions[bot] commented on pull request #8386: ARROW-10224: [Python] Build, test, and support Python 3.9

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8386: URL: https://github.com/apache/arrow/pull/8386#issuecomment-742740508 Revision: bc59c47e99067ea8dd60d1a2f99533235c612a7c Submitted crossbow builds: [ursa-labs/crossbow @ actions-767](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] seddonm1 opened a new pull request #8892: ARROW-10817: [Rust] [DataFusion] Implement TypedString

2020-12-10 Thread GitBox
seddonm1 opened a new pull request #8892: URL: https://github.com/apache/arrow/pull/8892 This PR adds support for what the `sqlparser` crate calls `TypedString` which is basically syntactic sugar for an inline-cast. As this was an effort to get the `TPC-H` queries behaving correctly I then

[GitHub] [arrow] seddonm1 commented on pull request #8880: ARROW-10674: [Rust][Parquet] Add Decimal to ArrayBuilderReader

2020-12-10 Thread GitBox
seddonm1 commented on pull request #8880: URL: https://github.com/apache/arrow/pull/8880#issuecomment-742764143 The TPC-H queries are fairly basic but do decimal operations like these which I think are all decimal type: ```sql sum(l_quantity) as sum_qty,

[GitHub] [arrow] github-actions[bot] commented on pull request #8892: ARROW-10817: [Rust] [DataFusion] Implement TypedString

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8892: URL: https://github.com/apache/arrow/pull/8892#issuecomment-742766152 https://issues.apache.org/jira/browse/ARROW-10817 This is an automated message from the Apache Git Ser

[GitHub] [arrow] codecov-io commented on pull request #8892: ARROW-10817: [Rust] [DataFusion] Implement TypedString

2020-12-10 Thread GitBox
codecov-io commented on pull request #8892: URL: https://github.com/apache/arrow/pull/8892#issuecomment-742770895 # [Codecov](https://codecov.io/gh/apache/arrow/pull/8892?src=pr&el=h1) Report > Merging [#8892](https://codecov.io/gh/apache/arrow/pull/8892?src=pr&el=desc) (d21097e) into

[GitHub] [arrow] terencehonles commented on pull request #8386: ARROW-10224: [Python] Build, test, and support Python 3.9

2020-12-10 Thread GitBox
terencehonles commented on pull request #8386: URL: https://github.com/apache/arrow/pull/8386#issuecomment-742780393 @github-actions crossbow submit wheel-manylinux1-cp36m wheel-manylinux1-cp38 This is an automated message fr

[GitHub] [arrow] github-actions[bot] commented on pull request #8386: ARROW-10224: [Python] Build, test, and support Python 3.9

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8386: URL: https://github.com/apache/arrow/pull/8386#issuecomment-742781425 Revision: bc59c47e99067ea8dd60d1a2f99533235c612a7c Submitted crossbow builds: [ursa-labs/crossbow @ actions-768](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] terencehonles commented on pull request #8386: ARROW-10224: [Python] Build, test, and support Python 3.9

2020-12-10 Thread GitBox
terencehonles commented on pull request #8386: URL: https://github.com/apache/arrow/pull/8386#issuecomment-742783390 That's odd that yum worked on one and not the other. It looks like it might be a tempermental issue and the fix in #8881 may need to be applied to manylinux1? It looks like

[GitHub] [arrow] quinnj commented on a change in pull request #8885: ARROW-10871: [Julia][CI] Setup Julia testing via Github Actions

2020-12-10 Thread GitBox
quinnj commented on a change in pull request #8885: URL: https://github.com/apache/arrow/pull/8885#discussion_r540489744 ## File path: .github/workflows/julia.yml ## @@ -0,0 +1,59 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

[GitHub] [arrow] codecov-io edited a comment on pull request #8892: ARROW-10817: [Rust] [DataFusion] Implement TypedString

2020-12-10 Thread GitBox
codecov-io edited a comment on pull request #8892: URL: https://github.com/apache/arrow/pull/8892#issuecomment-742770895 # [Codecov](https://codecov.io/gh/apache/arrow/pull/8892?src=pr&el=h1) Report > Merging [#8892](https://codecov.io/gh/apache/arrow/pull/8892?src=pr&el=desc) (056a199)

[GitHub] [arrow] xhochy opened a new pull request #8893: ARROW-10873: [C++] Apple Silicon is reported as arm64 in CMake

2020-12-10 Thread GitBox
xhochy opened a new pull request #8893: URL: https://github.com/apache/arrow/pull/8893 I'll add a CI entry soon that cross-compiles using `conda`, for now I keep submitting patches when things break for me. This is an automa

[GitHub] [arrow] codecov-io edited a comment on pull request #8892: ARROW-10817: [Rust] [DataFusion] Implement TypedString

2020-12-10 Thread GitBox
codecov-io edited a comment on pull request #8892: URL: https://github.com/apache/arrow/pull/8892#issuecomment-742770895 # [Codecov](https://codecov.io/gh/apache/arrow/pull/8892?src=pr&el=h1) Report > Merging [#8892](https://codecov.io/gh/apache/arrow/pull/8892?src=pr&el=desc) (536bb1b)

[GitHub] [arrow] github-actions[bot] commented on pull request #8893: ARROW-10873: [C++] Apple Silicon is reported as arm64 in CMake

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8893: URL: https://github.com/apache/arrow/pull/8893#issuecomment-742810104 https://issues.apache.org/jira/browse/ARROW-10873 This is an automated message from the Apache Git Ser

[GitHub] [arrow] quinnj commented on pull request #8884: ARROW-10870: [Julia][Doc] Include Julia in project documentation

2020-12-10 Thread GitBox
quinnj commented on pull request #8884: URL: https://github.com/apache/arrow/pull/8884#issuecomment-742813383 Ok, made a PR to arrow-site as well: https://github.com/apache/arrow-site/pull/84 This is an automated message fro

[GitHub] [arrow] kou commented on a change in pull request #8885: ARROW-10871: [Julia][CI] Setup Julia testing via Github Actions

2020-12-10 Thread GitBox
kou commented on a change in pull request #8885: URL: https://github.com/apache/arrow/pull/8885#discussion_r540511836 ## File path: .github/workflows/julia.yml ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agree

[GitHub] [arrow] kou commented on pull request #8883: ARROW-10869: [GLib] Add garrow_*_sort_indices() and related options

2020-12-10 Thread GitBox
kou commented on pull request #8883: URL: https://github.com/apache/arrow/pull/8883#issuecomment-742818128 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow] kou closed pull request #8883: ARROW-10869: [GLib] Add garrow_*_sort_indices() and related options

2020-12-10 Thread GitBox
kou closed pull request #8883: URL: https://github.com/apache/arrow/pull/8883 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8842: ARROW-10812: [Rust] Make BooleanArray not a PrimitiveArray

2020-12-10 Thread GitBox
jorgecarleitao commented on a change in pull request #8842: URL: https://github.com/apache/arrow/pull/8842#discussion_r540517947 ## File path: rust/arrow/src/array/equal_json.rs ## @@ -49,6 +49,20 @@ impl JsonEqual for PrimitiveArray { } } +/// Implement array equals fo

[GitHub] [arrow] quinnj commented on a change in pull request #8885: ARROW-10871: [Julia][CI] Setup Julia testing via Github Actions

2020-12-10 Thread GitBox
quinnj commented on a change in pull request #8885: URL: https://github.com/apache/arrow/pull/8885#discussion_r540525488 ## File path: .github/workflows/julia.yml ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

[GitHub] [arrow] jorgecarleitao commented on a change in pull request #8862: ARROW-10836: [Rust] Extend take kernel to FixedSizeListArray

2020-12-10 Thread GitBox
jorgecarleitao commented on a change in pull request #8862: URL: https://github.com/apache/arrow/pull/8862#discussion_r540522804 ## File path: rust/arrow/src/compute/kernels/take.rs ## @@ -1109,6 +1187,62 @@ mod tests { test_take_list_with_nulls!(i64, LargeList, LargeL

[GitHub] [arrow] quinnj commented on a change in pull request #8885: ARROW-10871: [Julia][CI] Setup Julia testing via Github Actions

2020-12-10 Thread GitBox
quinnj commented on a change in pull request #8885: URL: https://github.com/apache/arrow/pull/8885#discussion_r540525561 ## File path: .github/workflows/julia.yml ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

[GitHub] [arrow] alamb commented on a change in pull request #8888: ARROW-10865: [Rust] Easier to use Schema -> DFSchema conversion

2020-12-10 Thread GitBox
alamb commented on a change in pull request #: URL: https://github.com/apache/arrow/pull/#discussion_r540527213 ## File path: rust/datafusion/src/logical_plan/dfschema.rs ## @@ -89,11 +89,11 @@ impl DFSchema { } /// Create a `DFSchema` from an Arrow schema -

[GitHub] [arrow] quinnj commented on a change in pull request #8885: ARROW-10871: [Julia][CI] Setup Julia testing via Github Actions

2020-12-10 Thread GitBox
quinnj commented on a change in pull request #8885: URL: https://github.com/apache/arrow/pull/8885#discussion_r540528568 ## File path: .github/workflows/julia.yml ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license ag

[GitHub] [arrow] nealrichardson commented on a change in pull request #8885: ARROW-10871: [Julia][CI] Setup Julia testing via Github Actions

2020-12-10 Thread GitBox
nealrichardson commented on a change in pull request #8885: URL: https://github.com/apache/arrow/pull/8885#discussion_r540544340 ## File path: .github/workflows/julia.yml ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

[GitHub] [arrow] alamb commented on a change in pull request #8888: ARROW-10865: [Rust] Easier to use Schema -> DFSchema conversion

2020-12-10 Thread GitBox
alamb commented on a change in pull request #: URL: https://github.com/apache/arrow/pull/#discussion_r540551268 ## File path: rust/datafusion/src/logical_plan/dfschema.rs ## @@ -89,11 +89,11 @@ impl DFSchema { } /// Create a `DFSchema` from an Arrow schema -

[GitHub] [arrow] bkietz opened a new pull request #8894: ARROW-10322: [C++][Dataset] Minimize Expression

2020-12-10 Thread GitBox
bkietz opened a new pull request #8894: URL: https://github.com/apache/arrow/pull/8894 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #8894: ARROW-10322: [C++][Dataset] Minimize Expression

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8894: URL: https://github.com/apache/arrow/pull/8894#issuecomment-742856776 https://issues.apache.org/jira/browse/ARROW-10322 This is an automated message from the Apache Git Ser

[GitHub] [arrow] kou commented on a change in pull request #8885: ARROW-10871: [Julia][CI] Setup Julia testing via Github Actions

2020-12-10 Thread GitBox
kou commented on a change in pull request #8885: URL: https://github.com/apache/arrow/pull/8885#discussion_r540597776 ## File path: .github/workflows/julia.yml ## @@ -0,0 +1,57 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agree

[GitHub] [arrow] kou closed pull request #8885: ARROW-10871: [Julia][CI] Setup Julia testing via Github Actions

2020-12-10 Thread GitBox
kou closed pull request #8885: URL: https://github.com/apache/arrow/pull/8885 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [arrow] kou commented on a change in pull request #8890: ARROW-10796: [C++] Implement optimized RecordBatch sorting

2020-12-10 Thread GitBox
kou commented on a change in pull request #8890: URL: https://github.com/apache/arrow/pull/8890#discussion_r540613034 ## File path: cpp/src/arrow/compute/kernels/vector_sort.cc ## @@ -834,6 +1355,10 @@ class TableRadixSorter { // Sort a table using a single sort and multiple-k

[GitHub] [arrow] houqp opened a new pull request #8895: ARROW-10876 [Rust] validate row value type in json reader

2020-12-10 Thread GitBox
houqp opened a new pull request #8895: URL: https://github.com/apache/arrow/pull/8895 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [arrow] kou commented on pull request #8884: ARROW-10870: [Julia][Doc] Include Julia in project documentation

2020-12-10 Thread GitBox
kou commented on pull request #8884: URL: https://github.com/apache/arrow/pull/8884#issuecomment-742913950 @github-actions crossbow submit test-ubuntu-18.04-docs This is an automated message from the Apache Git Service. To re

[GitHub] [arrow] github-actions[bot] commented on pull request #8884: ARROW-10870: [Julia][Doc] Include Julia in project documentation

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8884: URL: https://github.com/apache/arrow/pull/8884#issuecomment-742914370 Revision: 063c4d43a1295149f4a62aa82fd152a55997cbc9 Submitted crossbow builds: [ursa-labs/crossbow @ actions-769](https://github.com/ursa-labs/crossbow/branches/a

[GitHub] [arrow] github-actions[bot] commented on pull request #8895: ARROW-10876 [Rust] validate row value type in json reader

2020-12-10 Thread GitBox
github-actions[bot] commented on pull request #8895: URL: https://github.com/apache/arrow/pull/8895#issuecomment-742915739 https://issues.apache.org/jira/browse/ARROW-10876 This is an automated message from the Apache Git Ser

[GitHub] [arrow] codecov-io commented on pull request #8895: ARROW-10876 [Rust] validate row value type in json reader

2020-12-10 Thread GitBox
codecov-io commented on pull request #8895: URL: https://github.com/apache/arrow/pull/8895#issuecomment-742917320 # [Codecov](https://codecov.io/gh/apache/arrow/pull/8895?src=pr&el=h1) Report > Merging [#8895](https://codecov.io/gh/apache/arrow/pull/8895?src=pr&el=desc) (1620af2) into

  1   2   >