jorgecarleitao opened a new pull request #8951:
URL: https://github.com/apache/arrow/pull/8951
This PR offers a 20% performance improvement to `MutableArrayData` by
removing un-needed bound checks.
This is an automated messa
jorgecarleitao closed pull request #8951:
URL: https://github.com/apache/arrow/pull/8951
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
sweb commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-747305340
@nevi-me @andygrove I fixed the issue. There is still a CI failure, though I
think that this is unrelated and just a hickup. Is there a way to restart the
CI job without whitespace-c
nevi-me commented on pull request #8880:
URL: https://github.com/apache/arrow/pull/8880#issuecomment-747311895
I've restarted the job, we can merge this after CI is all green. Thanks
@sweb
This is an automated message from
codecov-io edited a comment on pull request #8936:
URL: https://github.com/apache/arrow/pull/8936#issuecomment-747259380
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8936?src=pr&el=h1) Report
> Merging
[#8936](https://codecov.io/gh/apache/arrow/pull/8936?src=pr&el=desc) (dddc1ce)
Dandandan commented on a change in pull request #8938:
URL: https://github.com/apache/arrow/pull/8938#discussion_r544980166
##
File path: rust/arrow/src/json/reader.rs
##
@@ -888,265 +855,362 @@ impl Decoder {
))
}
-fn build_list_array(
+/// Build a nest
jorgecarleitao commented on pull request #8748:
URL: https://github.com/apache/arrow/pull/8748#issuecomment-747387849
Closing this as it is not the right approach.
This is an automated message from the Apache Git Service.
To
jorgecarleitao closed pull request #8748:
URL: https://github.com/apache/arrow/pull/8748
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
jorisvandenbossche opened a new pull request #8952:
URL: https://github.com/apache/arrow/pull/8952
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jorisvandenbossche commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-747391886
This is rather ugly and brittle (since it relies on the exact place where
this method is defined in pandas). But I also can't directly think of a better
way to keep the
jorisvandenbossche commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-747392379
@github-actions crossbow submit test-conda-python-3.7-pandas-master
test-conda-python-3.8-pandas-nightly
--
github-actions[bot] commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-747398578
Revision: fc5b3a0d3839212119c148500a59953b89dc5f98
Submitted crossbow builds: [ursa-labs/crossbow @
actions-811](https://github.com/ursa-labs/crossbow/branches/a
github-actions[bot] commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-747399346
https://issues.apache.org/jira/browse/ARROW-10951
This is an automated message from the Apache Git Ser
alamb commented on a change in pull request #8946:
URL: https://github.com/apache/arrow/pull/8946#discussion_r545051950
##
File path: rust/arrow/src/compute/kernels/aggregate.rs
##
@@ -135,6 +137,40 @@ where
Some(n)
}
+/// Helper function to perform min/max lambda funct
alamb commented on a change in pull request #8946:
URL: https://github.com/apache/arrow/pull/8946#discussion_r545051950
##
File path: rust/arrow/src/compute/kernels/aggregate.rs
##
@@ -135,6 +137,40 @@ where
Some(n)
}
+/// Helper function to perform min/max lambda funct
mqy opened a new pull request #8953:
URL: https://github.com/apache/arrow/pull/8953
If a commit contains only fixes for rust format, it would be very sad to
wait for the slow CI checking done, and it may block checking of PRs.
So, this PR adds a git pre-commit hook file, which perfo
jorgecarleitao opened a new pull request #8954:
URL: https://github.com/apache/arrow/pull/8954
This PR improves the filter kernel:
* made the filter benchmarks more realistic
* performance improved by 1.2-200x
* filter now supports all types supported by `MutableArrayData`
*
codecov-io commented on pull request #8953:
URL: https://github.com/apache/arrow/pull/8953#issuecomment-747436190
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8953?src=pr&el=h1) Report
> Merging
[#8953](https://codecov.io/gh/apache/arrow/pull/8953?src=pr&el=desc) (f38fc19)
into
github-actions[bot] commented on pull request #8954:
URL: https://github.com/apache/arrow/pull/8954#issuecomment-747440971
https://issues.apache.org/jira/browse/ARROW-10540
This is an automated message from the Apache Git Ser
github-actions[bot] commented on pull request #8953:
URL: https://github.com/apache/arrow/pull/8953#issuecomment-747440973
https://issues.apache.org/jira/browse/ARROW-10952
This is an automated message from the Apache Git Ser
mqy commented on pull request #8954:
URL: https://github.com/apache/arrow/pull/8954#issuecomment-747475634
Amazing, great work! Here is my bench result on mac book pro 2018:
$ git checkout mutable_filter2
Previous HEAD position was 54da4378d Improved filter bench.
Switched to br
mqy edited a comment on pull request #8954:
URL: https://github.com/apache/arrow/pull/8954#issuecomment-747475634
Amazing, great work! Here is my bench result on mac book pro 2018:
```
$ git checkout mutable_filter2
Previous HEAD position was 54da4378d Improved filter bench.
mqy edited a comment on pull request #8954:
URL: https://github.com/apache/arrow/pull/8954#issuecomment-747475634
Amazing, great work! Here is my bench result on mac book pro 2018:
```
$ git checkout mutable_filter2
Previous HEAD position was 54da4378d Improved filter bench.
nealrichardson commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747493444
Unfortunately it doesn't look like devtoolset is being used by arrow/R:
https://dev.azure.com/ursa-labs/crossbow/_build/results?buildId=21892&view=logs&j=0da5d1d9-276d-5173-
pitrou commented on a change in pull request #8941:
URL: https://github.com/apache/arrow/pull/8941#discussion_r545162804
##
File path: cpp/src/arrow/filesystem/s3fs.cc
##
@@ -1241,6 +1245,13 @@ class S3FileSystem::Impl {
return std::string(FromAwsString(builder_.config().r
pitrou commented on pull request #8941:
URL: https://github.com/apache/arrow/pull/8941#issuecomment-747498039
> Would it make sense to do something similar in IsNonEmptyDirectory?
I don't think so. I doesn't use the same S3 API call so so will be subject
to different conditions. But
pitrou closed pull request #8941:
URL: https://github.com/apache/arrow/pull/8941
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747498471
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
This is an automated message from the Apache Gi
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545167684
##
File path: cpp/src/arrow/util/future_test.cc
##
@@ -276,6 +282,593 @@ TEST(FutureSyncTest, Int) {
}
}
+TEST(FutureRefTest, ChainRemoved) {
+ //
jorgecarleitao commented on pull request #8954:
URL: https://github.com/apache/arrow/pull/8954#issuecomment-747505671
I am moving this to draft as I do not believe the 200x. It seems too much.
This is an automated message fro
jorgecarleitao edited a comment on pull request #8954:
URL: https://github.com/apache/arrow/pull/8954#issuecomment-747505671
I am moving this to draft as I do not believe the 200x. It looks too good to
be true.
This is an au
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747509072
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
This is an automated message from the Apache Gi
jorgecarleitao closed pull request #8954:
URL: https://github.com/apache/arrow/pull/8954
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545195108
##
File path: cpp/src/arrow/util/thread_pool_benchmark.cc
##
@@ -136,21 +168,24 @@ static void ThreadedTaskGroup(benchmark::State& state) {
for (aut
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545201217
##
File path: cpp/src/arrow/util/future.cc
##
@@ -229,6 +229,16 @@ class ConcreteFutureImpl : public FutureImpl {
void DoMarkFailed() { DoMarkFinish
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545201645
##
File path: cpp/src/arrow/util/future.h
##
@@ -19,63 +19,150 @@
#include
#include
+#include
#include
#include
#include
#include
#incl
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545201781
##
File path: cpp/src/arrow/util/future.h
##
@@ -264,11 +335,125 @@ class Future {
}
/// \brief Make a finished Future<> with the provided Status
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747531377
Revision: efeaf91e1ed0ade4158d7537811e00f86a216ac6
Submitted crossbow builds: [ursa-labs/crossbow @
actions-812](https://github.com/ursa-labs/crossbow/branches/a
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545213923
##
File path: cpp/src/arrow/util/future.h
##
@@ -264,11 +335,125 @@ class Future {
}
/// \brief Make a finished Future<> with the provided Status
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545214296
##
File path: cpp/src/arrow/util/task_group.cc
##
@@ -116,25 +109,15 @@ class ThreadedTaskGroup : public TaskGroup {
cv_.wait(lock, [&]() { return
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545214673
##
File path: cpp/src/arrow/util/task_group.h
##
@@ -22,22 +22,33 @@
#include
#include "arrow/status.h"
+#include "arrow/util/future.h"
Review comm
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747547675
Revision: efeaf91e1ed0ade4158d7537811e00f86a216ac6
Submitted crossbow builds: [ursa-labs/crossbow @
actions-813](https://github.com/ursa-labs/crossbow/branches/a
Dandandan commented on pull request #8946:
URL: https://github.com/apache/arrow/pull/8946#issuecomment-747559686
On closer inspection, is it actually correc now. What would max(null, false)
be?
This is an automated message f
Dandandan edited a comment on pull request #8946:
URL: https://github.com/apache/arrow/pull/8946#issuecomment-747559686
On closer inspection, is it actually correct now? What would max(null,
false) be?
This is an automated m
rdettai commented on a change in pull request #8917:
URL: https://github.com/apache/arrow/pull/8917#discussion_r545240967
##
File path: rust/datafusion/src/datasource/datasource.rs
##
@@ -34,6 +35,23 @@ pub struct Statistics {
pub total_byte_size: Option,
}
+/// Indicat
jonkeane commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747562922
@github-actions crossbow submit test-r-rstudio-r-base-3.6-centos*
This is an automated message from the Apache Gi
rdettai commented on a change in pull request #8917:
URL: https://github.com/apache/arrow/pull/8917#discussion_r544351700
##
File path: rust/datafusion/src/datasource/datasource.rs
##
@@ -34,6 +35,23 @@ pub struct Statistics {
pub total_byte_size: Option,
}
+/// Indicat
github-actions[bot] commented on pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#issuecomment-747563999
Revision: 0cff84e2aa1f76c911311b5464452921d70c0589
Submitted crossbow builds: [ursa-labs/crossbow @
actions-814](https://github.com/ursa-labs/crossbow/branches/a
Dandandan edited a comment on pull request #8946:
URL: https://github.com/apache/arrow/pull/8946#issuecomment-747559686
On closer inspection, is it actually correct now? What would max(null,
false) be in the current implementation?
-
Dandandan edited a comment on pull request #8946:
URL: https://github.com/apache/arrow/pull/8946#issuecomment-747559686
On closer inspection, is it actually correct now? What would the output of
max(null, false) be in the current implementation?
---
jorisvandenbossche commented on pull request #8952:
URL: https://github.com/apache/arrow/pull/8952#issuecomment-747582175
There is still a failure, but a different one now:
```
_ TestConvertMetadata.test_mixed_column_names
__
self =
Dandandan commented on pull request #8946:
URL: https://github.com/apache/arrow/pull/8946#issuecomment-747597413
I think correct would be
`array.iter().find(|&b| b == Some(false)).flatten().or(Some(true))` and the
other way around?
--
wesm commented on pull request #8908:
URL: https://github.com/apache/arrow/pull/8908#issuecomment-747607764
hi @kou, I noticed that you simplified some things related to the Flight
serialization customization -- is that a simplification that's due to a newer
version of gRPC or was my worka
nealrichardson commented on pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#issuecomment-747607867
R centos-7 (gcc 4.8) compilation fails:
https://github.com/apache/arrow/pull/8894/checks?check_run_id=1572105784#step:9:513
---
arw2019 opened a new pull request #8955:
URL: https://github.com/apache/arrow/pull/8955
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on pull request #8955:
URL: https://github.com/apache/arrow/pull/8955#issuecomment-747646366
https://issues.apache.org/jira/browse/ARROW-9948
This is an automated message from the Apache Git Serv
pitrou commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545359826
##
File path: cpp/src/arrow/util/future.h
##
@@ -273,11 +349,134 @@ class Future {
}
/// \brief Make a finished Future<> with the provided Status.
-
pitrou commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545361101
##
File path: cpp/src/arrow/util/future.h
##
@@ -264,11 +335,125 @@ class Future {
}
/// \brief Make a finished Future<> with the provided Status.
-
pitrou commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545362036
##
File path: cpp/src/arrow/util/future_test.cc
##
@@ -122,15 +125,19 @@ void AssertFinished(const Future& fut) {
// Assert the future is successful *now*
pitrou commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545362938
##
File path: cpp/src/arrow/util/future_test.cc
##
@@ -276,6 +282,593 @@ TEST(FutureSyncTest, Int) {
}
}
+TEST(FutureRefTest, ChainRemoved) {
+ // Cre
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545363890
##
File path: cpp/src/arrow/util/future.h
##
@@ -264,11 +335,125 @@ class Future {
}
/// \brief Make a finished Future<> with the provided Status
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545367277
##
File path: cpp/src/arrow/util/future_test.cc
##
@@ -122,15 +125,19 @@ void AssertFinished(const Future& fut) {
// Assert the future is successful *no
pitrou commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545368032
##
File path: cpp/src/arrow/util/future_test.cc
##
@@ -276,6 +283,636 @@ TEST(FutureSyncTest, Int) {
}
}
+TEST(FutureRefTest, ChainRemoved) {
+ // Cre
pitrou commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545368422
##
File path: cpp/src/arrow/util/future_test.cc
##
@@ -276,6 +283,636 @@ TEST(FutureSyncTest, Int) {
}
}
+TEST(FutureRefTest, ChainRemoved) {
+ // Cre
pitrou commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545368032
##
File path: cpp/src/arrow/util/future_test.cc
##
@@ -276,6 +283,636 @@ TEST(FutureSyncTest, Int) {
}
}
+TEST(FutureRefTest, ChainRemoved) {
+ // Cre
pitrou commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545368951
##
File path: cpp/src/arrow/util/future_test.cc
##
@@ -276,6 +283,636 @@ TEST(FutureSyncTest, Int) {
}
}
+TEST(FutureRefTest, ChainRemoved) {
+ // Cre
nealrichardson opened a new pull request #8956:
URL: https://github.com/apache/arrow/pull/8956
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545375274
##
File path: cpp/examples/arrow/dataset-parquet-scan-example.cc
##
@@ -62,7 +60,8 @@ struct Configuration {
// Indicates the filter by which rows will
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545376296
##
File path: cpp/src/arrow/compute/cast.cc
##
@@ -118,8 +118,86 @@ class CastMetaFunction : public MetaFunction {
} // namespace
+const FunctionDoc st
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545376880
##
File path: cpp/src/arrow/compute/cast.cc
##
@@ -135,7 +213,7 @@ CastFunction::CastFunction(std::string name, Type::type
out_type)
impl_->out_type = ou
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545377183
##
File path: cpp/src/arrow/compute/kernels/scalar_cast_temporal.cc
##
@@ -256,14 +251,45 @@ struct CastFunctor {
template <>
struct CastFunctor {
stati
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545377183
##
File path: cpp/src/arrow/compute/kernels/scalar_cast_temporal.cc
##
@@ -256,14 +251,45 @@ struct CastFunctor {
template <>
struct CastFunctor {
stati
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545377670
##
File path: cpp/src/arrow/util/future_test.cc
##
@@ -276,6 +283,636 @@ TEST(FutureSyncTest, Int) {
}
}
+TEST(FutureRefTest, ChainRemoved) {
+ //
westonpace commented on a change in pull request #8680:
URL: https://github.com/apache/arrow/pull/8680#discussion_r545378494
##
File path: cpp/src/arrow/util/future_test.cc
##
@@ -276,6 +283,636 @@ TEST(FutureSyncTest, Int) {
}
}
+TEST(FutureRefTest, ChainRemoved) {
+ //
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545379841
##
File path: cpp/src/arrow/dataset/partition.h
##
@@ -63,13 +63,13 @@ class ARROW_DS_EXPORT Partitioning {
/// produce sub-batches which satisfy mutually
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545380280
##
File path: cpp/src/arrow/dataset/partition.h
##
@@ -294,5 +285,22 @@ class ARROW_DS_EXPORT PartitioningOrFactory {
std::shared_ptr partitioning_;
};
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545381777
##
File path: cpp/src/arrow/dataset/partition_test.cc
##
@@ -21,52 +21,51 @@
#include
#include
-#include
#include
#include
#include
#include
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545382248
##
File path: cpp/src/arrow/dataset/scanner.h
##
@@ -62,10 +63,7 @@ class ARROW_DS_EXPORT ScanOptions {
std::shared_ptr ReplaceSchema(std::shared_ptr sche
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545382579
##
File path: cpp/src/arrow/dataset/scanner_test.cc
##
@@ -184,14 +183,26 @@ TEST_F(TestScannerBuilder, TestProject) {
TEST_F(TestScannerBuilder, TestFilter
github-actions[bot] commented on pull request #8956:
URL: https://github.com/apache/arrow/pull/8956#issuecomment-747683259
https://issues.apache.org/jira/browse/ARROW-10642
This is an automated message from the Apache Git Ser
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545383431
##
File path: cpp/src/arrow/type.cc
##
@@ -1039,13 +1042,31 @@ Result> FieldPath::Get(const
FieldVector& fields) const {
Result> FieldPath::Get(const Rec
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545384018
##
File path: cpp/src/arrow/dataset/expression_internal.h
##
@@ -0,0 +1,465 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more con
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545384788
##
File path: cpp/src/arrow/dataset/expression_internal.h
##
@@ -0,0 +1,465 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more con
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545385249
##
File path: cpp/src/arrow/dataset/expression_internal.h
##
@@ -0,0 +1,465 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more con
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545385787
##
File path: cpp/src/arrow/dataset/expression_internal.h
##
@@ -0,0 +1,465 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more con
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545385942
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545387603
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545387491
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545388036
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545389079
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545389676
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545390028
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545390346
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545394621
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545395503
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545396816
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545397572
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545400514
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545400983
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
bkietz commented on a change in pull request #8894:
URL: https://github.com/apache/arrow/pull/8894#discussion_r545402838
##
File path: cpp/src/arrow/dataset/expression.cc
##
@@ -0,0 +1,1177 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
1 - 100 of 161 matches
Mail list logo
