ursabot edited a comment on pull request #12044:
URL: https://github.com/apache/arrow/pull/12044#issuecomment-1007001772
Benchmark runs are scheduled for baseline =
7929cc803b093d082a5b8e52edb593807693a6d5 and contender =
1e7bfa24c579887f324982a27c0e06f6f9f5a803.
1e7bfa24c579887f324982a27
liukun4515 commented on a change in pull request #1525:
URL: https://github.com/apache/arrow-datafusion/pull/1525#discussion_r780096756
##
File path: datafusion/src/physical_plan/expressions/stddev.rs
##
@@ -0,0 +1,312 @@
+// Licensed to the Apache Software Foundation (ASF) und
liukun4515 commented on a change in pull request #1525:
URL: https://github.com/apache/arrow-datafusion/pull/1525#discussion_r780097748
##
File path: datafusion/src/physical_plan/expressions/mod.rs
##
@@ -84,9 +86,13 @@ pub use nth_value::NthValue;
pub use nullif::{nullif_func
liukun4515 commented on a change in pull request #1525:
URL: https://github.com/apache/arrow-datafusion/pull/1525#discussion_r780099721
##
File path: datafusion/src/physical_plan/expressions/stddev.rs
##
@@ -0,0 +1,312 @@
+// Licensed to the Apache Software Foundation (ASF) und
liukun4515 commented on a change in pull request #1525:
URL: https://github.com/apache/arrow-datafusion/pull/1525#discussion_r780100249
##
File path: datafusion/src/physical_plan/expressions/stddev.rs
##
@@ -0,0 +1,312 @@
+// Licensed to the Apache Software Foundation (ASF) und
liukun4515 commented on a change in pull request #1525:
URL: https://github.com/apache/arrow-datafusion/pull/1525#discussion_r780103988
##
File path: datafusion/src/physical_plan/expressions/variance.rs
##
@@ -0,0 +1,376 @@
+// Licensed to the Apache Software Foundation (ASF) u
andersonm-ibm commented on pull request #10450:
URL: https://github.com/apache/arrow/pull/10450#issuecomment-1007233380
> Right, can we get a functional PyArrow even without encryption enabled?
@pitrou - I separated parquet encryption, so it's no longer mandatory to
enable parquet en
ursabot edited a comment on pull request #12031:
URL: https://github.com/apache/arrow/pull/12031#issuecomment-1007001783
Benchmark runs are scheduled for baseline =
1e7bfa24c579887f324982a27c0e06f6f9f5a803 and contender =
e64480db51fc9622d02613f3ec60bac34d765092.
e64480db51fc9622d02613f3e
thisisnic commented on a change in pull request #12097:
URL: https://github.com/apache/arrow/pull/12097#discussion_r780125202
##
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##
@@ -382,6 +382,15 @@ test_that("extract epiweek from timestamp", {
)
})
+test_that("
thisisnic commented on a change in pull request #12097:
URL: https://github.com/apache/arrow/pull/12097#discussion_r780126775
##
File path: r/R/dplyr-funcs-datetime.R
##
@@ -101,6 +101,10 @@ register_bindings_datetime <- function() {
Expression$create("day_of_week", x, opt
jvanstraten opened a new pull request #12098:
URL: https://github.com/apache/arrow/pull/12098
Changes the type returned by `list_parent_indices` to `int64` regardless of
list index type (it used to return `int32` for `list`), as the output refers to
row indices rather than list indices.
github-actions[bot] commented on pull request #12098:
URL: https://github.com/apache/arrow/pull/12098#issuecomment-1007258192
https://issues.apache.org/jira/browse/ARROW-14592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
AlenkaF commented on a change in pull request #12097:
URL: https://github.com/apache/arrow/pull/12097#discussion_r780134565
##
File path: r/R/dplyr-funcs-datetime.R
##
@@ -101,6 +101,10 @@ register_bindings_datetime <- function() {
Expression$create("day_of_week", x, optio
ursabot edited a comment on pull request #12031:
URL: https://github.com/apache/arrow/pull/12031#issuecomment-1007001783
Benchmark runs are scheduled for baseline =
1e7bfa24c579887f324982a27c0e06f6f9f5a803 and contender =
e64480db51fc9622d02613f3ec60bac34d765092.
e64480db51fc9622d02613f3e
yjshen opened a new pull request #1526:
URL: https://github.com/apache/arrow-datafusion/pull/1526
# Which issue does this PR close?
Closes #587 .
# Rationale for this change
When DataFusion processes a single partition, it will keep allocating memory
until the
alamb commented on a change in pull request #1141:
URL: https://github.com/apache/arrow-rs/pull/1141#discussion_r780207803
##
File path: CHANGELOG.md
##
@@ -19,8 +19,146 @@
For older versions, see
[apache/arrow/CHANGELOG.md](https://github.com/apache/arrow/blob/master/CHANG
alamb commented on pull request #1401:
URL:
https://github.com/apache/arrow-datafusion/pull/1401#issuecomment-1007352996
@houqp or @Dandandan -- any concern if I merge this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
Dandandan commented on a change in pull request #1401:
URL: https://github.com/apache/arrow-datafusion/pull/1401#discussion_r780235612
##
File path: datafusion/src/optimizer/simplify_expressions.rs
##
@@ -554,212 +416,250 @@ impl<'a> Simplifier<'a> {
false
}
-
Dandandan commented on a change in pull request #1401:
URL: https://github.com/apache/arrow-datafusion/pull/1401#discussion_r780235612
##
File path: datafusion/src/optimizer/simplify_expressions.rs
##
@@ -554,212 +416,250 @@ impl<'a> Simplifier<'a> {
false
}
-
rok commented on a change in pull request #12097:
URL: https://github.com/apache/arrow/pull/12097#discussion_r780237616
##
File path: r/R/dplyr-funcs-datetime.R
##
@@ -101,6 +101,10 @@ register_bindings_datetime <- function() {
Expression$create("day_of_week", x, options =
rok commented on a change in pull request #12097:
URL: https://github.com/apache/arrow/pull/12097#discussion_r780237616
##
File path: r/R/dplyr-funcs-datetime.R
##
@@ -101,6 +101,10 @@ register_bindings_datetime <- function() {
Expression$create("day_of_week", x, options =
lidavidm commented on a change in pull request #11991:
URL: https://github.com/apache/arrow/pull/11991#discussion_r780263584
##
File path: cpp/src/arrow/dataset/scanner.h
##
@@ -138,41 +133,46 @@ struct ARROW_DS_EXPORT ScanOptions {
// This is used by Fragment implementation
paddyhoran commented on pull request #1140:
URL: https://github.com/apache/arrow-rs/pull/1140#issuecomment-1007431548
Thank you very much for this @helgikrs!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
jonkeane closed pull request #11894:
URL: https://github.com/apache/arrow/pull/11894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
jonkeane closed pull request #12090:
URL: https://github.com/apache/arrow/pull/12090
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
ursabot commented on pull request #11894:
URL: https://github.com/apache/arrow/pull/11894#issuecomment-1007435606
Benchmark runs are scheduled for baseline =
e64480db51fc9622d02613f3ec60bac34d765092 and contender =
f0544403b36c1d994f01d37d7ee77c08a87a6d29.
f0544403b36c1d994f01d37d7ee77c08
ursabot commented on pull request #12090:
URL: https://github.com/apache/arrow/pull/12090#issuecomment-1007435619
Benchmark runs are scheduled for baseline =
f0544403b36c1d994f01d37d7ee77c08a87a6d29 and contender =
66832557006a39c356d8608ad9cbbdb773bed0c7.
66832557006a39c356d8608ad9cbbdb7
ursabot edited a comment on pull request #11894:
URL: https://github.com/apache/arrow/pull/11894#issuecomment-1007435606
Benchmark runs are scheduled for baseline =
e64480db51fc9622d02613f3ec60bac34d765092 and contender =
f0544403b36c1d994f01d37d7ee77c08a87a6d29.
f0544403b36c1d994f01d37d7
ursabot edited a comment on pull request #12090:
URL: https://github.com/apache/arrow/pull/12090#issuecomment-1007435619
Benchmark runs are scheduled for baseline =
f0544403b36c1d994f01d37d7ee77c08a87a6d29 and contender =
66832557006a39c356d8608ad9cbbdb773bed0c7.
66832557006a39c356d8608ad
chriscasola commented on a change in pull request #11832:
URL: https://github.com/apache/arrow/pull/11832#discussion_r780300956
##
File path: go/arrow/array.go
##
@@ -0,0 +1,71 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
zois-tasoulas commented on issue #11654:
URL: https://github.com/apache/arrow/issues/11654#issuecomment-1007473071
Sure, I will do that this weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
matthewmturner commented on pull request #1525:
URL:
https://github.com/apache/arrow-datafusion/pull/1525#issuecomment-1007492724
Perhaps @Dandandan would be interested in this as he was involved in
db-benchmark which this will help
--
This is an automated message from the Apache Git Se
Dandandan commented on a change in pull request #1525:
URL: https://github.com/apache/arrow-datafusion/pull/1525#discussion_r780335960
##
File path: datafusion/src/physical_plan/aggregates.rs
##
@@ -212,6 +222,26 @@ pub fn create_aggregate_expr(
"AVG(DISTINCT)
thisisnic commented on pull request #11921:
URL: https://github.com/apache/arrow/pull/11921#issuecomment-1007516733
> There is a [new(ish) GHA workflow for installing
dependencies](https://github.com/r-lib/actions/tree/v2-branch/setup-r-dependencies).
Do we want to make use of it or should
ursabot edited a comment on pull request #11894:
URL: https://github.com/apache/arrow/pull/11894#issuecomment-1007435606
Benchmark runs are scheduled for baseline =
e64480db51fc9622d02613f3ec60bac34d765092 and contender =
f0544403b36c1d994f01d37d7ee77c08a87a6d29.
f0544403b36c1d994f01d37d7
ursabot edited a comment on pull request #11894:
URL: https://github.com/apache/arrow/pull/11894#issuecomment-1007435606
Benchmark runs are scheduled for baseline =
e64480db51fc9622d02613f3ec60bac34d765092 and contender =
f0544403b36c1d994f01d37d7ee77c08a87a6d29.
f0544403b36c1d994f01d37d7
eerhardt commented on a change in pull request #12068:
URL: https://github.com/apache/arrow/pull/12068#discussion_r780371694
##
File path: csharp/examples/IoTDataPipelineExample/Program.cs
##
@@ -0,0 +1,107 @@
+// Licensed to the Apache Software Foundation (ASF) under one or m
lidavidm closed pull request #12098:
URL: https://github.com/apache/arrow/pull/12098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
wjones127 commented on issue #83:
URL: https://github.com/apache/arrow-cookbook/issues/83#issuecomment-1007584263
As a part of apache/arrow#11894, I added an example to the datasets vignette
to show how to create a sample from a dataset that doesn't fit into memory.
This will be available
ursabot commented on pull request #12098:
URL: https://github.com/apache/arrow/pull/12098#issuecomment-1007587829
Benchmark runs are scheduled for baseline =
66832557006a39c356d8608ad9cbbdb773bed0c7 and contender =
ddea0c9e5d50d0c147b1577e4aa0dc3cf9e64831.
ddea0c9e5d50d0c147b1577e4aa0dc3c
jonkeane closed pull request #12072:
URL: https://github.com/apache/arrow/pull/12072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
ursabot edited a comment on pull request #12098:
URL: https://github.com/apache/arrow/pull/12098#issuecomment-1007587829
Benchmark runs are scheduled for baseline =
66832557006a39c356d8608ad9cbbdb773bed0c7 and contender =
ddea0c9e5d50d0c147b1577e4aa0dc3cf9e64831.
ddea0c9e5d50d0c147b1577e4
ursabot edited a comment on pull request #12090:
URL: https://github.com/apache/arrow/pull/12090#issuecomment-1007435619
Benchmark runs are scheduled for baseline =
f0544403b36c1d994f01d37d7ee77c08a87a6d29 and contender =
66832557006a39c356d8608ad9cbbdb773bed0c7.
66832557006a39c356d8608ad
ursabot commented on pull request #12072:
URL: https://github.com/apache/arrow/pull/12072#issuecomment-1007600991
Benchmark runs are scheduled for baseline =
ddea0c9e5d50d0c147b1577e4aa0dc3cf9e64831 and contender =
b325ef7f95f8348cc7b3230dd65a172bfd0ce650.
b325ef7f95f8348cc7b3230dd65a172b
wjones127 commented on pull request #11714:
URL: https://github.com/apache/arrow/pull/11714#issuecomment-1007601326
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #11714:
URL: https://github.com/apache/arrow/pull/11714#issuecomment-1007602079
Revision: a269a69b8f1fab130a5f0948179bacfdd9b0e178
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1379](https://github.com/ursacomputing/crossbo
zeroshade commented on a change in pull request #11832:
URL: https://github.com/apache/arrow/pull/11832#discussion_r780427481
##
File path: go/arrow/record.go
##
@@ -0,0 +1,45 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agre
ursabot edited a comment on pull request #12090:
URL: https://github.com/apache/arrow/pull/12090#issuecomment-1007435619
Benchmark runs are scheduled for baseline =
f0544403b36c1d994f01d37d7ee77c08a87a6d29 and contender =
66832557006a39c356d8608ad9cbbdb773bed0c7.
66832557006a39c356d8608ad
ursabot edited a comment on pull request #12072:
URL: https://github.com/apache/arrow/pull/12072#issuecomment-1007600991
Benchmark runs are scheduled for baseline =
ddea0c9e5d50d0c147b1577e4aa0dc3cf9e64831 and contender =
b325ef7f95f8348cc7b3230dd65a172bfd0ce650.
b325ef7f95f8348cc7b3230dd
zeroshade commented on pull request #11832:
URL: https://github.com/apache/arrow/pull/11832#issuecomment-1007622829
@chriscasola comments added and updated. also rebased. thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
coryan commented on a change in pull request #11996:
URL: https://github.com/apache/arrow/pull/11996#discussion_r780442988
##
File path: cpp/src/arrow/filesystem/gcsfs.cc
##
@@ -505,20 +555,23 @@ class GcsFileSystem::Impl {
}
private:
- static Result GetFileInfoDirector
realno commented on a change in pull request #1525:
URL: https://github.com/apache/arrow-datafusion/pull/1525#discussion_r780443231
##
File path: datafusion/src/physical_plan/expressions/stddev.rs
##
@@ -0,0 +1,312 @@
+// Licensed to the Apache Software Foundation (ASF) under o
coryan commented on a change in pull request #11996:
URL: https://github.com/apache/arrow/pull/11996#discussion_r780443584
##
File path: cpp/src/arrow/filesystem/gcsfs.cc
##
@@ -310,93 +318,107 @@ class GcsFileSystem::Impl {
Result GetFileInfo(const GcsPath& path) {
if
realno commented on a change in pull request #1525:
URL: https://github.com/apache/arrow-datafusion/pull/1525#discussion_r780444768
##
File path: datafusion/src/physical_plan/expressions/variance.rs
##
@@ -0,0 +1,376 @@
+// Licensed to the Apache Software Foundation (ASF) under
westonpace commented on pull request #11991:
URL: https://github.com/apache/arrow/pull/11991#issuecomment-1007638718
> Did we file a JIRA for removing the deprecated flags in 8.0.0?
I just created ARROW-15283
--
This is an automated message from the Apache Git Service.
To respond t
lidavidm opened a new pull request #12099:
URL: https://github.com/apache/arrow/pull/12099
When the dataset writer is configured to delete existing data before
writing, the target directory is on S3, the dataset is partitioned, and there
are at least as many partitions as threads in the I/
github-actions[bot] commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007645730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lidavidm commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007647894
Hmm, this sometimes hangs on >8 partitions, taking another look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
jonkeane commented on pull request #11360:
URL: https://github.com/apache/arrow/pull/11360#issuecomment-1007649170
@github-actions crossbow submit -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #11360:
URL: https://github.com/apache/arrow/pull/11360#issuecomment-1007649766
Revision: 43bda65ad113d82079ebfb83241895212058464c
Submitted crossbow builds: [ursacomputing/crossbow @
actions-1380](https://github.com/ursacomputing/crossbo
westonpace commented on a change in pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#discussion_r780457910
##
File path: cpp/src/arrow/dataset/dataset_writer.cc
##
@@ -328,12 +328,12 @@ class DatasetWriterDirectoryQueue : public
util::AsyncDestroyable {
lidavidm commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007654362
Ah, there's _another_ deadlock: finishing a FileWriter closes the underlying
file. This is done as a continuation that runs on the I/O thread pool (I
think). (On a side note,
lidavidm commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007657502
And there's definitely a race condition somewhere… (using the reproducer
from JIRA)
```
8 partitions
Traceback (most recent call last):
File "/home/lidavidm/C
westonpace commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007657899
I think finishing a file actually happens on the CPU thread pool at the
moment. Although it's at the mercy of the writer.
--
This is an automated message from the Apache
wjones127 commented on a change in pull request #11714:
URL: https://github.com/apache/arrow/pull/11714#discussion_r780466218
##
File path: ci/scripts/r_windows_build.sh
##
@@ -97,15 +97,15 @@ if [ -d mingw32/lib/ ]; then
mkdir -p $DST_DIR/lib/i386
mv mingw32/lib/*.a $DST
westonpace commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007659299
> On a side note, would anyone complain if I #ifdef'd in the pthread calls
to name threads on Linux to make debugging easier?
Please do.
--
This is an automated mes
westonpace commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007661614
> I think finishing a file actually happens on the CPU thread pool at the
moment. Although it's at the mercy of the writer.
Ah, but the background Close/Wait also bloc
nealrichardson commented on a change in pull request #11360:
URL: https://github.com/apache/arrow/pull/11360#discussion_r780469400
##
File path: .github/workflows/r.yml
##
@@ -324,6 +324,10 @@ jobs:
cd r/tests
sed -i.bak -E -e 's/"arrow"/"arrow", reporter
westonpace commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007663490
Moving the Close/Wait to the I/O thread pool will probably be an easy fix.
Then the rules we are building are...
* If you are going to call a synchronous filesystem m
nealrichardson commented on a change in pull request #11360:
URL: https://github.com/apache/arrow/pull/11360#discussion_r780470569
##
File path: r/DESCRIPTION
##
@@ -59,6 +59,7 @@ Suggests:
testthat (>= 3.1.0),
tibble,
withr
+LinkingTo: cpp11 (>= 0.4.2)
Review c
nealrichardson commented on a change in pull request #11360:
URL: https://github.com/apache/arrow/pull/11360#discussion_r780471592
##
File path: .github/workflows/r.yml
##
@@ -324,6 +324,10 @@ jobs:
cd r/tests
sed -i.bak -E -e 's/"arrow"/"arrow", reporter
jonkeane commented on a change in pull request #11360:
URL: https://github.com/apache/arrow/pull/11360#discussion_r780471562
##
File path: .github/workflows/r.yml
##
@@ -324,6 +324,10 @@ jobs:
cd r/tests
sed -i.bak -E -e 's/"arrow"/"arrow", reporter = "loc
lidavidm commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007667064
Surprisingly it is the I/O thread pool:
```
(gdb) info thread
Id Target Id Frame
* 1Thread 0x7f8856a04740 (LWP 27248) "python" 0x7f88565f5ad
nealrichardson commented on a change in pull request #11360:
URL: https://github.com/apache/arrow/pull/11360#discussion_r780472530
##
File path: .github/workflows/r.yml
##
@@ -324,6 +324,10 @@ jobs:
cd r/tests
sed -i.bak -E -e 's/"arrow"/"arrow", reporter
jonkeane commented on a change in pull request #11360:
URL: https://github.com/apache/arrow/pull/11360#discussion_r780472665
##
File path: r/DESCRIPTION
##
@@ -59,6 +59,7 @@ Suggests:
testthat (>= 3.1.0),
tibble,
withr
+LinkingTo: cpp11 (>= 0.4.2)
Review comment
jonkeane commented on a change in pull request #11360:
URL: https://github.com/apache/arrow/pull/11360#discussion_r780473234
##
File path: .github/workflows/r.yml
##
@@ -324,6 +324,10 @@ jobs:
cd r/tests
sed -i.bak -E -e 's/"arrow"/"arrow", reporter = "loc
westonpace commented on a change in pull request #11991:
URL: https://github.com/apache/arrow/pull/11991#discussion_r780473351
##
File path: python/pyarrow/_dataset.pyx
##
@@ -2239,10 +2233,6 @@ cdef class Scanner(_Weakrefable):
use_threads : bool, default True
If
westonpace commented on a change in pull request #11991:
URL: https://github.com/apache/arrow/pull/11991#discussion_r780473574
##
File path: cpp/src/arrow/dataset/scanner.cc
##
@@ -823,10 +584,77 @@ Result AsyncScanner::CountRows() {
return total.load();
}
+Result> AsyncS
westonpace commented on a change in pull request #11991:
URL: https://github.com/apache/arrow/pull/11991#discussion_r780475401
##
File path: cpp/src/arrow/dataset/scanner.h
##
@@ -138,41 +133,46 @@ struct ARROW_DS_EXPORT ScanOptions {
// This is used by Fragment implementati
lidavidm edited a comment on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007667064
Surprisingly it is the I/O thread pool:
```
(gdb) info thread
Id Target Id Frame
* 1Thread 0x7f8856a04740 (LWP 27248) "python" 0x7f88
alamb commented on pull request #1127:
URL: https://github.com/apache/arrow-rs/pull/1127#issuecomment-1007678179
> I missed it 😿
No worries @liukun4515 -- I would be happy to make any changes /
suggestions you may have.
--
This is an automated message from the Apache Git Service.
lidavidm commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007681528
Thanks for the help Weston, this last commit should fix the deadlock…though
I still occasionally see that `OSError`, but I think we can try to track that
down separately.
--
lidavidm commented on a change in pull request #11991:
URL: https://github.com/apache/arrow/pull/11991#discussion_r780484531
##
File path: cpp/src/arrow/dataset/scanner.h
##
@@ -138,41 +133,46 @@ struct ARROW_DS_EXPORT ScanOptions {
// This is used by Fragment implementation
emkornfield commented on a change in pull request #11996:
URL: https://github.com/apache/arrow/pull/11996#discussion_r780487058
##
File path: cpp/src/arrow/filesystem/gcsfs.cc
##
@@ -310,93 +318,107 @@ class GcsFileSystem::Impl {
Result GetFileInfo(const GcsPath& path) {
ursabot edited a comment on pull request #12098:
URL: https://github.com/apache/arrow/pull/12098#issuecomment-1007587829
Benchmark runs are scheduled for baseline =
66832557006a39c356d8608ad9cbbdb773bed0c7 and contender =
ddea0c9e5d50d0c147b1577e4aa0dc3cf9e64831.
ddea0c9e5d50d0c147b1577e4
emkornfield commented on pull request #11996:
URL: https://github.com/apache/arrow/pull/11996#issuecomment-1007687049
Looks like all failures are unrelated. I'll merge this on Monday if there
are no further comments.
--
This is an automated message from the Apache Git Service.
To respon
alamb commented on a change in pull request #1401:
URL: https://github.com/apache/arrow-datafusion/pull/1401#discussion_r780489370
##
File path: datafusion/src/optimizer/simplify_expressions.rs
##
@@ -554,212 +416,250 @@ impl<'a> Simplifier<'a> {
false
}
-fn
ursabot edited a comment on pull request #12098:
URL: https://github.com/apache/arrow/pull/12098#issuecomment-1007587829
Benchmark runs are scheduled for baseline =
66832557006a39c356d8608ad9cbbdb773bed0c7 and contender =
ddea0c9e5d50d0c147b1577e4aa0dc3cf9e64831.
ddea0c9e5d50d0c147b1577e4
lidavidm commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007703162
1) Filed ARROW-15285 for the OSError, though, it seems quite rare (2/200
runs)
2) Increasing partitions to 16 causes it to hang again…taking a look…
--
This is an automat
lidavidm commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007706164
It's the same hang with 16 partitions so I think we will need a CloseAsync().
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
lidavidm commented on pull request #12099:
URL: https://github.com/apache/arrow/pull/12099#issuecomment-1007726131
Ah, the fundamental issue is S3FS implements writes asynchronously (unless
background_writes=False), but our file interfaces are still mostly synchronous,
and the dataset writ
mbrobbel opened a new pull request #12100:
URL: https://github.com/apache/arrow/pull/12100
I'm still working on this but opening this for visibility.
@lidavidm @westonpace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
github-actions[bot] commented on pull request #12100:
URL: https://github.com/apache/arrow/pull/12100#issuecomment-1007745646
https://issues.apache.org/jira/browse/ARROW-15061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
kou closed pull request #12093:
URL: https://github.com/apache/arrow/pull/12093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
kou opened a new pull request #12101:
URL: https://github.com/apache/arrow/pull/12101
* Raw Hash is accepted as options
* #call-able
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
github-actions[bot] commented on pull request #12101:
URL: https://github.com/apache/arrow/pull/12101#issuecomment-1007747559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
alamb commented on a change in pull request #1525:
URL: https://github.com/apache/arrow-datafusion/pull/1525#discussion_r780516560
##
File path: datafusion/src/scalar.rs
##
@@ -526,6 +526,282 @@ macro_rules! eq_array_primitive {
}
impl ScalarValue {
+/// Return true if
ursabot commented on pull request #12093:
URL: https://github.com/apache/arrow/pull/12093#issuecomment-1007749487
Benchmark runs are scheduled for baseline =
b325ef7f95f8348cc7b3230dd65a172bfd0ce650 and contender =
79436648baed0d5b26f7b10f362e6136efc3f4f4.
79436648baed0d5b26f7b10f362e6136
lidavidm commented on pull request #12100:
URL: https://github.com/apache/arrow/pull/12100#issuecomment-1007754548
Cool! The macro definitions look fairly useful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
lidavidm commented on pull request #12100:
URL: https://github.com/apache/arrow/pull/12100#issuecomment-1007754899
If you have a screenshot or any quick example of the output to share here it
would also be useful, I think.
--
This is an automated message from the Apache Git Service.
To r
1 - 100 of 142 matches
Mail list logo
