xudong963 commented on issue #1544:
URL:
https://github.com/apache/arrow-datafusion/issues/1544#issuecomment-1014255048
> anyone looking to assist or just review.
If ready, please ping me!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
ursabot edited a comment on pull request #12164:
URL: https://github.com/apache/arrow/pull/12164#issuecomment-1014212304
Benchmark runs are scheduled for baseline =
0c1fd88953585485b772dfd405bbc5b1b5417324 and contender =
f549a15c6e7613afee3a1af07c00bcc6959f7690. Results will be available
Jimexist commented on issue #1544:
URL:
https://github.com/apache/arrow-datafusion/issues/1544#issuecomment-1014296068
@hntd187 if you want you can transfer that to datafusion-contrib for better
visibility.
--
This is an automated message from the Apache Git Service.
To respond to the m
gaojun2048 opened a new issue #1594:
URL: https://github.com/apache/arrow-datafusion/issues/1594
Now if we want to define our own udf/udaf function, we also have to modify
the implementation of ballista. Because `ScalarFunction` and
`AggregateFunction` are defined as enum in ballista's pro
zhanglistar opened a new issue #12166:
URL: https://github.com/apache/arrow/issues/12166
Now, there is no statistic interface for orc file in
arrow::adapaters::orc::ORCFileReader, why?
Thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the me
tustvold commented on issue #1108:
URL: https://github.com/apache/arrow-rs/issues/1108#issuecomment-1014309178
Yes it should be largely just a case of adding `_binary` versions of the
`_utf8` kernels in that module.
Typically there are three variants of each operator:
* One w
tustvold edited a comment on issue #1108:
URL: https://github.com/apache/arrow-rs/issues/1108#issuecomment-1014309178
Yes it should be largely just a case of adding `_binary` versions of the
`_utf8` kernels in that module.
Typically there are three variants of each operator:
jorisvandenbossche commented on a change in pull request #12153:
URL: https://github.com/apache/arrow/pull/12153#discussion_r785757447
##
File path: python/pyarrow/orc.py
##
@@ -175,3 +176,33 @@ def write_table(table, where):
writer = ORCWriter(where)
writer.write(tab
AlenkaF opened a new pull request #12167:
URL: https://github.com/apache/arrow/pull/12167
Adding last corrections to the New Contributors Guide before the new release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
github-actions[bot] commented on pull request #12167:
URL: https://github.com/apache/arrow/pull/12167#issuecomment-1014323636
https://issues.apache.org/jira/browse/ARROW-15337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
ursabot edited a comment on pull request #12164:
URL: https://github.com/apache/arrow/pull/12164#issuecomment-1014212304
Benchmark runs are scheduled for baseline =
0c1fd88953585485b772dfd405bbc5b1b5417324 and contender =
f549a15c6e7613afee3a1af07c00bcc6959f7690. Results will be available
HaoYang670 commented on issue #1108:
URL: https://github.com/apache/arrow-rs/issues/1108#issuecomment-1014329838
Thank you, Raphael! I'd like to try if no one else has been doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
thisisnic closed pull request #12167:
URL: https://github.com/apache/arrow/pull/12167
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
ursabot commented on pull request #12167:
URL: https://github.com/apache/arrow/pull/12167#issuecomment-1014339535
Benchmark runs are scheduled for baseline =
13b66b57b454d2b6c4ea35e3d19adbdd85b17810 and contender =
7e012736611cdda2b1d7082f41bb2e77eb16bbbd.
7e012736611cdda2b1d7082f41bb2e77
viirya opened a new pull request #1595:
URL: https://github.com/apache/arrow-datafusion/pull/1595
# Which issue does this PR close?
Closes #1591.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing chang
ursabot edited a comment on pull request #12167:
URL: https://github.com/apache/arrow/pull/12167#issuecomment-1014339535
Benchmark runs are scheduled for baseline =
13b66b57b454d2b6c4ea35e3d19adbdd85b17810 and contender =
7e012736611cdda2b1d7082f41bb2e77eb16bbbd.
7e012736611cdda2b1d7082f4
jorisvandenbossche commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r785833236
##
File path: python/pyarrow/_compute.pyx
##
@@ -785,6 +785,30 @@ class
ElementWiseAggregateOptions(_ElementWiseAggregateOptions):
se
ursabot edited a comment on pull request #12151:
URL: https://github.com/apache/arrow/pull/12151#issuecomment-1014218781
Benchmark runs are scheduled for baseline =
0c1fd88953585485b772dfd405bbc5b1b5417324 and contender =
13b66b57b454d2b6c4ea35e3d19adbdd85b17810.
13b66b57b454d2b6c4ea35e3d
liukun4515 commented on issue #1273:
URL:
https://github.com/apache/arrow-datafusion/issues/1273#issuecomment-1014403293
> @realno @liukun4515 do you have any plans for ballista that you think are
worth adding to the Q1 roadmap?
@matthewmturner
Sorry for my limited time, May
thisisnic commented on a change in pull request #12154:
URL: https://github.com/apache/arrow/pull/12154#discussion_r785872219
##
File path: r/R/util.R
##
@@ -209,3 +209,74 @@ handle_csv_read_error <- function(e, schema) {
abort(e)
}
+
+
+parse_period_unit <- function(x) {
codecov-commenter edited a comment on pull request #1082:
URL: https://github.com/apache/arrow-rs/pull/1082#issuecomment-998923929
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1082?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_
rok commented on pull request #12154:
URL: https://github.com/apache/arrow/pull/12154#issuecomment-1014440937
> I think I've taken this as far as I can right now? I had been hoping to
write shims to support the `week_start` and `change_on_boundary` arguments but
I'm not sure if that's poss
ursabot edited a comment on pull request #12151:
URL: https://github.com/apache/arrow/pull/12151#issuecomment-1014218781
Benchmark runs are scheduled for baseline =
0c1fd88953585485b772dfd405bbc5b1b5417324 and contender =
13b66b57b454d2b6c4ea35e3d19adbdd85b17810.
13b66b57b454d2b6c4ea35e3d
yjshen opened a new pull request #1596:
URL: https://github.com/apache/arrow-datafusion/pull/1596
# Which issue does this PR close?
Closes #1571 and #1572.
# Rationale for this change
1. `in_mem_sort` and `SortPreservingMergeStream` share similar goal.
2.
alamb commented on a change in pull request #1589:
URL: https://github.com/apache/arrow-datafusion/pull/1589#discussion_r785931197
##
File path: datafusion/src/from_slice.rs
##
@@ -19,27 +19,119 @@
//!
//! This file essentially exists to ease the transition onto arrow2
-use
yjshen commented on a change in pull request #1596:
URL: https://github.com/apache/arrow-datafusion/pull/1596#discussion_r785935850
##
File path: datafusion/src/physical_plan/sorts/external_sort.rs
##
@@ -353,12 +386,79 @@ pub struct ExternalSortExec {
input: Arc,
///
Jimexist commented on a change in pull request #1589:
URL: https://github.com/apache/arrow-datafusion/pull/1589#discussion_r785949640
##
File path: datafusion/src/from_slice.rs
##
@@ -19,27 +19,119 @@
//!
//! This file essentially exists to ease the transition onto arrow2
-
Jimexist commented on a change in pull request #1589:
URL: https://github.com/apache/arrow-datafusion/pull/1589#discussion_r785950014
##
File path: datafusion/src/from_slice.rs
##
@@ -19,27 +19,119 @@
//!
//! This file essentially exists to ease the transition onto arrow2
-
pitrou commented on pull request #12143:
URL: https://github.com/apache/arrow/pull/12143#issuecomment-1014478996
Ping @kszucs :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
Jimexist opened a new pull request #1188:
URL: https://github.com/apache/arrow-rs/pull/1188
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing change
Jimexist commented on a change in pull request #1589:
URL: https://github.com/apache/arrow-datafusion/pull/1589#discussion_r785977125
##
File path: datafusion/src/from_slice.rs
##
@@ -19,27 +19,119 @@
//!
//! This file essentially exists to ease the transition onto arrow2
-
ursabot edited a comment on pull request #12167:
URL: https://github.com/apache/arrow/pull/12167#issuecomment-1014339535
Benchmark runs are scheduled for baseline =
13b66b57b454d2b6c4ea35e3d19adbdd85b17810 and contender =
7e012736611cdda2b1d7082f41bb2e77eb16bbbd.
7e012736611cdda2b1d7082f4
github-actions[bot] commented on pull request #12168:
URL: https://github.com/apache/arrow/pull/12168#issuecomment-1014490049
https://issues.apache.org/jira/browse/ARROW-15316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
codecov-commenter commented on pull request #1188:
URL: https://github.com/apache/arrow-rs/pull/1188#issuecomment-1014500835
#
[Codecov](https://codecov.io/gh/apache/arrow-rs/pull/1188?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
kszucs closed pull request #12143:
URL: https://github.com/apache/arrow/pull/12143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
ursabot commented on pull request #12143:
URL: https://github.com/apache/arrow/pull/12143#issuecomment-1014516988
Benchmark runs are scheduled for baseline =
7e012736611cdda2b1d7082f41bb2e77eb16bbbd and contender =
c4ef0486b16112813857e587dab84b3461b90542.
c4ef0486b16112813857e587dab84b34
bkmgit commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r786000919
##
File path: python/pyarrow/_compute.pyx
##
@@ -785,6 +785,30 @@ class
ElementWiseAggregateOptions(_ElementWiseAggregateOptions):
self._set_opti
ursabot edited a comment on pull request #12143:
URL: https://github.com/apache/arrow/pull/12143#issuecomment-1014516988
Benchmark runs are scheduled for baseline =
7e012736611cdda2b1d7082f41bb2e77eb16bbbd and contender =
c4ef0486b16112813857e587dab84b3461b90542.
c4ef0486b16112813857e587d
lidavidm commented on pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#issuecomment-1014555006
@bkmgit as Eduardo mentioned, would you like to write a short description
for the PR? (It's the first post at top.) This gets used in the commit message.
--
This is an autom
lidavidm commented on a change in pull request #11982:
URL: https://github.com/apache/arrow/pull/11982#discussion_r786014493
##
File path: format/FlightSql.proto
##
@@ -867,6 +867,69 @@ enum SqlSupportsConvert {
SQL_CONVERT_VARCHAR = 19;
}
+/*
+ * Represents a request to
HaoYang670 commented on issue #1108:
URL: https://github.com/apache/arrow-rs/issues/1108#issuecomment-1014561953
Following your advice, I will file 2 PRs to match this feature. The first PR
will add support for fully qualified binary array. The second PR will support
comparison for dynamic
lidavidm commented on a change in pull request #12100:
URL: https://github.com/apache/arrow/pull/12100#discussion_r786017483
##
File path: cpp/src/arrow/compute/exec/aggregate_node.cc
##
@@ -165,7 +166,18 @@ class ScalarAggregateNode : public ExecNode {
const char* kind_name
lidavidm commented on a change in pull request #12100:
URL: https://github.com/apache/arrow/pull/12100#discussion_r786021110
##
File path: cpp/src/arrow/compute/exec/sink_node.cc
##
@@ -275,6 +302,11 @@ struct OrderBySinkNode final : public SinkNode {
}
void InputReceiv
lidavidm commented on a change in pull request #12162:
URL: https://github.com/apache/arrow/pull/12162#discussion_r786022104
##
File path: cpp/src/arrow/compute/kernels/scalar_nested.cc
##
@@ -17,6 +17,7 @@
// Vector kernels involving nested types
+#include
Review commen
bkmgit commented on pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#issuecomment-1014568870
@lidavidm Hopefully ok now. Thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
alamb merged pull request #1562:
URL: https://github.com/apache/arrow-datafusion/pull/1562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-
alamb closed issue #1565:
URL: https://github.com/apache/arrow-datafusion/issues/1565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
alamb commented on a change in pull request #1593:
URL: https://github.com/apache/arrow-datafusion/pull/1593#discussion_r786025309
##
File path: ballista/rust/client/src/context.rs
##
@@ -256,6 +288,14 @@ impl BallistaContext {
)
};
+let is_show
alamb commented on pull request #1559:
URL:
https://github.com/apache/arrow-datafusion/pull/1559#issuecomment-1014572980
I took the liberty of `git merge apache/master` on this branch to hopefully
get a clean CI run and then will merge. Sorry for the delay @yahoNanJing
--
This is an au
Jimexist opened a new pull request #1189:
URL: https://github.com/apache/arrow-rs/pull/1189
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing change
Jimexist opened a new pull request #1597:
URL: https://github.com/apache/arrow-datafusion/pull/1597
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes
alamb commented on a change in pull request #1554:
URL: https://github.com/apache/arrow-datafusion/pull/1554#discussion_r786034055
##
File path: datafusion/src/physical_plan/coercion_rule/binary_rule.rs
##
@@ -162,12 +162,141 @@ fn get_comparison_common_decimal_type(
}
}
alamb commented on a change in pull request #1582:
URL: https://github.com/apache/arrow-datafusion/pull/1582#discussion_r786044972
##
File path: datafusion/src/physical_plan/expressions/array_agg.rs
##
@@ -137,6 +129,39 @@ impl Accumulator for ArrayAggAccumulator {
}
alamb commented on issue #1591:
URL:
https://github.com/apache/arrow-datafusion/issues/1591#issuecomment-1014593828
It should be noted that this is an 'optimization' bug rather than a
correctness bug -- in the sense that returning `false` means "don't filter the
row group" and returning
ursabot edited a comment on pull request #12167:
URL: https://github.com/apache/arrow/pull/12167#issuecomment-1014339535
Benchmark runs are scheduled for baseline =
13b66b57b454d2b6c4ea35e3d19adbdd85b17810 and contender =
7e012736611cdda2b1d7082f41bb2e77eb16bbbd.
7e012736611cdda2b1d7082f4
kszucs closed pull request #12165:
URL: https://github.com/apache/arrow/pull/12165
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
lidavidm commented on a change in pull request #114:
URL: https://github.com/apache/arrow-cookbook/pull/114#discussion_r786057619
##
File path: r/content/arrays.Rmd
##
@@ -185,4 +185,4 @@ Scalar, Array, and ChunkedArray objects. The returned
object will be an Arrow o
### S
alamb commented on issue #924:
URL:
https://github.com/apache/arrow-datafusion/issues/924#issuecomment-1014606297
@yjshen started consolidating such config settings in
https://github.com/apache/arrow-datafusion/pull/1562
--
This is an automated message from the Apache Git Service.
ursabot commented on pull request #12165:
URL: https://github.com/apache/arrow/pull/12165#issuecomment-1014606048
Benchmark runs are scheduled for baseline =
c4ef0486b16112813857e587dab84b3461b90542 and contender =
bbbe668ef54f7679f01a3d8b76cf23a365006e74.
bbbe668ef54f7679f01a3d8b76cf23a3
Jimexist commented on a change in pull request #1582:
URL: https://github.com/apache/arrow-datafusion/pull/1582#discussion_r786060808
##
File path: datafusion/src/physical_plan/expressions/array_agg.rs
##
@@ -137,6 +129,39 @@ impl Accumulator for ArrayAggAccumulator {
xudong963 commented on pull request #1566:
URL:
https://github.com/apache/arrow-datafusion/pull/1566#issuecomment-1014608623
add tests and fix the extreme case. cc @alamb @pjmore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
Jimexist opened a new issue #1598:
URL: https://github.com/apache/arrow-datafusion/issues/1598
I think it would be a good idea as a follow on PR to update these
implementations to avoid the use of ScalarValue.
I'll try find some time this week to do it (I need some coding time :) --
xudong963 commented on a change in pull request #1566:
URL: https://github.com/apache/arrow-datafusion/pull/1566#discussion_r786061330
##
File path: datafusion/src/sql/planner.rs
##
@@ -3818,6 +3832,31 @@ mod tests {
\n TableScan: public.person projection=None";
xudong963 commented on a change in pull request #1566:
URL: https://github.com/apache/arrow-datafusion/pull/1566#discussion_r786062776
##
File path: datafusion/src/logical_plan/plan.rs
##
@@ -214,8 +220,14 @@ pub struct Extension {
pub node: Arc,
}
+impl PartialEq for E
pitrou commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r786042927
##
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##
@@ -445,6 +445,29 @@ static void VisitTwoArrayValuesInline(const ArrayData&
arr0, const
alamb commented on issue #1527:
URL:
https://github.com/apache/arrow-datafusion/issues/1527#issuecomment-1014610661
Thanks for the report @capkurmagati -- I am not sure if your usecase ever
worked (in which case it is a bug).
Regardless, as @tustvold mentions, we basically have th
kszucs commented on pull request #11182:
URL: https://github.com/apache/arrow/pull/11182#issuecomment-1014613271
ping @zhztheplayer @emkornfield
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
xudong963 commented on issue #1576:
URL:
https://github.com/apache/arrow-datafusion/issues/1576#issuecomment-1014614011
Thanks @alamb , I'll try it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kszucs commented on pull request #10114:
URL: https://github.com/apache/arrow/pull/10114#issuecomment-1014615916
Thanks everyone, merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
kszucs closed pull request #10114:
URL: https://github.com/apache/arrow/pull/10114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
alamb merged pull request #1589:
URL: https://github.com/apache/arrow-datafusion/pull/1589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-
alamb commented on issue #162:
URL:
https://github.com/apache/arrow-datafusion/issues/162#issuecomment-1014618116
@xudong963 has filed https://github.com/apache/arrow-datafusion/issues/1576
to track this issue 👍
--
This is an automated message from the Apache Git Service.
To respond t
alamb closed issue #1321:
URL: https://github.com/apache/arrow-datafusion/issues/1321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
alamb commented on issue #1321:
URL:
https://github.com/apache/arrow-datafusion/issues/1321#issuecomment-1014620290
closing as a dupe of https://github.com/apache/arrow-datafusion/issues/1586
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
ursabot edited a comment on pull request #12165:
URL: https://github.com/apache/arrow/pull/12165#issuecomment-1014606048
Benchmark runs are scheduled for baseline =
c4ef0486b16112813857e587dab84b3461b90542 and contender =
bbbe668ef54f7679f01a3d8b76cf23a365006e74.
bbbe668ef54f7679f01a3d8b7
ursabot commented on pull request #10114:
URL: https://github.com/apache/arrow/pull/10114#issuecomment-1014623484
Benchmark runs are scheduled for baseline =
bbbe668ef54f7679f01a3d8b76cf23a365006e74 and contender =
e12a4545bdc5a8683c8dfdbb0468922d444c0500.
e12a4545bdc5a8683c8dfdbb0468922d
lidavidm commented on a change in pull request #12162:
URL: https://github.com/apache/arrow/pull/12162#discussion_r786060176
##
File path: cpp/src/arrow/compute/api_scalar.cc
##
@@ -573,6 +605,7 @@ void RegisterScalarOptions(FunctionRegistry* registry) {
DCHECK_OK(registry->
bkmgit commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r786076345
##
File path: cpp/src/arrow/compute/kernels/scalar_compare.cc
##
@@ -156,39 +212,52 @@ struct Maximum {
}
};
+// Check if timestamp timezones are com
hntd187 commented on issue #1544:
URL:
https://github.com/apache/arrow-datafusion/issues/1544#issuecomment-1014625104
> @hntd187 if you want you can transfer that to datafusion-contrib for
better visibility.
Perfect I wasn’t sure what my permissions were I’ll do that right now.
-
pitrou commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r786076989
##
File path: cpp/src/arrow/compute/kernels/scalar_compare.cc
##
@@ -156,39 +212,52 @@ struct Maximum {
}
};
+// Check if timestamp timezones are com
liukun4515 commented on a change in pull request #1554:
URL: https://github.com/apache/arrow-datafusion/pull/1554#discussion_r786079635
##
File path: datafusion/src/physical_plan/coercion_rule/binary_rule.rs
##
@@ -162,12 +162,141 @@ fn get_comparison_common_decimal_type(
liukun4515 commented on a change in pull request #1554:
URL: https://github.com/apache/arrow-datafusion/pull/1554#discussion_r786079490
##
File path: datafusion/src/physical_plan/coercion_rule/binary_rule.rs
##
@@ -162,12 +162,141 @@ fn get_comparison_common_decimal_type(
bkmgit commented on a change in pull request #11882:
URL: https://github.com/apache/arrow/pull/11882#discussion_r786079703
##
File path: cpp/src/arrow/compute/kernels/scalar_compare.cc
##
@@ -772,6 +1107,16 @@ const FunctionDoc less_equal_doc{
("A null on either side emits
lidavidm commented on a change in pull request #12162:
URL: https://github.com/apache/arrow/pull/12162#discussion_r786082875
##
File path: cpp/src/arrow/compute/kernels/scalar_nested.cc
##
@@ -429,6 +430,97 @@ const FunctionDoc make_struct_doc{"Wrap Arrays into a
StructArray",
hntd187 edited a comment on issue #1544:
URL:
https://github.com/apache/arrow-datafusion/issues/1544#issuecomment-1014625104
> @hntd187 if you want you can transfer that to datafusion-contrib for
better visibility.
Perfect I wasn’t sure what my permissions were I’ll do that right no
lidavidm commented on a change in pull request #12162:
URL: https://github.com/apache/arrow/pull/12162#discussion_r786084635
##
File path: cpp/src/arrow/compute/kernels/scalar_nested_test.cc
##
@@ -225,6 +225,30 @@ TEST(TestScalarNested, StructField) {
}
}
+TEST(TestScala
alamb commented on issue #587:
URL:
https://github.com/apache/arrow-datafusion/issues/587#issuecomment-1014631605
I wrote up some thoughts about externalized joins on
https://github.com/apache/arrow-datafusion/issues/1599
--
This is an automated message from the Apache Git Service.
To r
ursabot edited a comment on pull request #10114:
URL: https://github.com/apache/arrow/pull/10114#issuecomment-1014623484
Benchmark runs are scheduled for baseline =
bbbe668ef54f7679f01a3d8b76cf23a365006e74 and contender =
e12a4545bdc5a8683c8dfdbb0468922d444c0500.
e12a4545bdc5a8683c8dfdbb0
alamb commented on issue #1599:
URL:
https://github.com/apache/arrow-datafusion/issues/1599#issuecomment-1014635302
I would love to implement this algorithm in DataFusion:
https://arxiv.org/abs/2010.00152
Sort-based grouping and aggregation
Thanh Do, Goetz Graefe
https://a
dhruv9vats commented on a change in pull request #12162:
URL: https://github.com/apache/arrow/pull/12162#discussion_r786089476
##
File path: cpp/src/arrow/compute/kernels/scalar_nested_test.cc
##
@@ -225,6 +225,30 @@ TEST(TestScalarNested, StructField) {
}
}
+TEST(TestSca
alamb edited a comment on issue #1599:
URL:
https://github.com/apache/arrow-datafusion/issues/1599#issuecomment-1014635302
I would love to implement this algorithm in DataFusion:
https://arxiv.org/abs/2010.00152
Sort-based grouping and aggregation
Thanh Do, Goetz Graefe
xudong963 commented on issue #1599:
URL:
https://github.com/apache/arrow-datafusion/issues/1599#issuecomment-1014644855
> I would love to implement this algorithm in DataFusion:
>
> https://arxiv.org/abs/2010.00152 Sort-based grouping and aggregation Thanh
Do, Goetz Graefe
Ma
hntd187 edited a comment on issue #1544:
URL:
https://github.com/apache/arrow-datafusion/issues/1544#issuecomment-1014206250
I checking my basic PoC work, I have much to do still but for anyone looking
to assist or just review.
https://github.com/datafusion-contrib/datafusion-stream
ursabot edited a comment on pull request #12143:
URL: https://github.com/apache/arrow/pull/12143#issuecomment-1014516988
Benchmark runs are scheduled for baseline =
7e012736611cdda2b1d7082f41bb2e77eb16bbbd and contender =
c4ef0486b16112813857e587dab84b3461b90542.
c4ef0486b16112813857e587d
Jimexist merged pull request #1597:
URL: https://github.com/apache/arrow-datafusion/pull/1597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gith
alamb commented on a change in pull request #1554:
URL: https://github.com/apache/arrow-datafusion/pull/1554#discussion_r786099180
##
File path: datafusion/src/physical_plan/coercion_rule/binary_rule.rs
##
@@ -162,12 +162,141 @@ fn get_comparison_common_decimal_type(
}
}
xudong963 commented on a change in pull request #1566:
URL: https://github.com/apache/arrow-datafusion/pull/1566#discussion_r786099463
##
File path: datafusion/src/sql/planner.rs
##
@@ -731,20 +732,33 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
}
alamb commented on pull request #1595:
URL:
https://github.com/apache/arrow-datafusion/pull/1595#issuecomment-1014653042
Thank you @viirya -- I will try to review this carefully, but likely won't
be able to do so until tomorrow
--
This is an automated message from the Apache Git Servic
alamb commented on pull request #1596:
URL:
https://github.com/apache/arrow-datafusion/pull/1596#issuecomment-1014654729
Thank you @yjshen -- this looks awesome -- I will try and review this
carefully, but likely won't have time until tomorrow
--
This is an automated message from the A
hntd187 opened a new pull request #1600:
URL: https://github.com/apache/arrow-datafusion/pull/1600
# Which issue does this PR close?
#1544
# Rationale for this change
Just some basic hooking into logical plan where necessary. I'm not sure if
this is the correct way to do
1 - 100 of 244 matches
Mail list logo