Re: [PR] Remove dict_id from schema and make it an IPC concern only [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on PR #7467: URL: https://github.com/apache/arrow-rs/pull/7467#issuecomment-2970490439 > I guess we theoretically could, but that seems inconsistent with the rest of the codebase and it could cause unexpected failure and behavior without the remaining changes of this PR.

Re: [PR] GH-46674: [C++] Construct Array from ExtensionType Scalar [arrow]

2025-06-13 Thread via GitHub
thisisnic commented on code in PR #46675: URL: https://github.com/apache/arrow/pull/46675#discussion_r2145139872 ## cpp/src/arrow/array/array_test.cc: ## @@ -815,6 +815,23 @@ TEST_F(TestArray, TestMakeArrayFromMapScalar) { AssertAppendScalar(pool_, std::make_shared(scalar));

[I] [Variant] Introduce structs for Variant::Decimal types [arrow-rs]

2025-06-13 Thread via GitHub
alamb opened a new issue, #7660: URL: https://github.com/apache/arrow-rs/issues/7660 It's hard to pass around the content of tuple/struct enum variants with multiple members -- you have to unpack them and pass scalar values around, which is bulky and error-prone (**). Should we consider cre

[PR] ci: Pin tracing-attributes to fix CI [arrow-rs-object-store]

2025-06-13 Thread via GitHub
kylebarron opened a new pull request, #404: URL: https://github.com/apache/arrow-rs-object-store/pull/404 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-f

Re: [PR] GH-46719: [R] Add 32 and 64 bit Decimal types [arrow]

2025-06-13 Thread via GitHub
jonkeane commented on code in PR #46720: URL: https://github.com/apache/arrow/pull/46720#discussion_r2145865021 ## r/R/enums.R: ## @@ -80,17 +80,23 @@ Type <- enum("Type::type", LARGE_BINARY = 35L, LARGE_LIST = 36L, INTERVAL_MONTH_DAY_NANO = 37L, - RUN_END_ENCODED = 38

Re: [PR] GH-46719: [R] Add 32 and 64 bit Decimal types [arrow]

2025-06-13 Thread via GitHub
jonkeane commented on code in PR #46720: URL: https://github.com/apache/arrow/pull/46720#discussion_r2145868597 ## r/tests/testthat/test-data-type.R: ## @@ -497,10 +496,6 @@ test_that("decimal type and validation", { expect_error(decimal128(4, NA), "`scale` must be an integer

Re: [I] [Docs] Link to same version of docs from Implementations page [arrow]

2025-06-13 Thread via GitHub
ianmcook commented on issue #46782: URL: https://github.com/apache/arrow/issues/46782#issuecomment-2970524097 Closed by #46784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] arrow-row: Add support for REE [arrow-rs]

2025-06-13 Thread via GitHub
brancz commented on PR #7649: URL: https://github.com/apache/arrow-rs/pull/7649#issuecomment-2970703802 @alamb you can ignore all intermediate commits, the last commit pretty much re-writes everything and I think is also way more readable and understandable (and most of all correct). --

Re: [PR] [Variant] Implement read support for remaining primitive types [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on code in PR #7644: URL: https://github.com/apache/arrow-rs/pull/7644#discussion_r2145213257 ## parquet-variant/src/variant.rs: ## @@ -483,6 +632,57 @@ impl<'m, 'v> From for Variant<'m, 'v> { } } +impl<'m, 'v> From for Variant<'m, 'v> { +fn from(valu

Re: [PR] Add option to Azure client to ignore unparsable paths [arrow-rs-object-store]

2025-06-13 Thread via GitHub
kylebarron commented on code in PR #376: URL: https://github.com/apache/arrow-rs-object-store/pull/376#discussion_r2145334055 ## src/azure/builder.rs: ## @@ -180,6 +180,8 @@ pub struct MicrosoftAzureBuilder { fabric_cluster_identifier: Option, /// The [`HttpConnector`

Re: [I] [CI][Dev][Swift] Is ci/scripts/swift_test.sh still necessary? [arrow]

2025-06-13 Thread via GitHub
hiroyuki-sato commented on issue #46806: URL: https://github.com/apache/arrow/issues/46806#issuecomment-2970479694 FYI: [Implementations](https://arrow.apache.org/docs/dev/implementations.html) used above URL. And It seems that this link also need update. I couldn't find the source.

[I] Optimize infallible dictionary key casting in `try_new_from_builder` method [arrow-rs]

2025-06-13 Thread via GitHub
albertlockett opened a new issue, #7662: URL: https://github.com/apache/arrow-rs/issues/7662 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** **Describe the solution you'd like** In https://github.com/apache/arrow

Re: [PR] [Variant] Implement read support for remaining primitive types [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on PR #7644: URL: https://github.com/apache/arrow-rs/pull/7644#issuecomment-2970787523 > I'll try and contribute an example shortly - Here is a PR: https://github.com/apache/arrow-rs/pull/7661 -- This is an automated message from the Apache Git Service. To respon

Re: [PR] [Variant] Add variant docs and examples [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on code in PR #7661: URL: https://github.com/apache/arrow-rs/pull/7661#discussion_r2145388804 ## parquet-variant/src/variant.rs: ## @@ -394,43 +398,152 @@ impl<'m, 'v> VariantArray<'m, 'v> { } } -// impl<'m, 'v> Index for VariantArray<'m, 'v> { -// ty

Re: [PR] feat: add constructor to help efficiently upgrade key for GenericBytesDictionaryBuilder [arrow-rs]

2025-06-13 Thread via GitHub
albertlockett commented on code in PR #7611: URL: https://github.com/apache/arrow-rs/pull/7611#discussion_r2145389529 ## arrow-array/src/builder/generic_bytes_dictionary_builder.rs: ## @@ -152,6 +155,65 @@ where values_builder, }) } + +/// Creates

Re: [PR] GH-46801: [Dev] Remove some leftovers for Java, Go, JS and Swift on some config files [arrow]

2025-06-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46802: URL: https://github.com/apache/arrow/pull/46802#issuecomment-2971150652 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 1a6e479b026971abe6f6e693d39d82711c94ee99. There were 11

Re: [PR] [Variant] Implement read support for remaining primitive types [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on code in PR #7644: URL: https://github.com/apache/arrow-rs/pull/7644#discussion_r2145244230 ## parquet-variant/src/variant.rs: ## @@ -402,11 +403,21 @@ pub enum Variant<'m, 'v> { // TODO: Add types for the rest of the primitive types, once API is agreed u

Re: [I] [Variant] Implement read support for remaining primitive types [arrow-rs]

2025-06-13 Thread via GitHub
alamb closed issue #7630: [Variant] Implement read support for remaining primitive types URL: https://github.com/apache/arrow-rs/issues/7630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] GH-46674: [C++] Construct Array from ExtensionType Scalar [arrow]

2025-06-13 Thread via GitHub
thisisnic commented on PR #46675: URL: https://github.com/apache/arrow/pull/46675#issuecomment-2970597444 @amoeba Mind taking a look at this? It's the prerequisite to fixing the segfault in #46431 and the code I wrote seems to fix it, but I can't figure out how to write a test that passes.

[PR] [Variant] Add variant docs and examples [arrow-rs]

2025-06-13 Thread via GitHub
alamb opened a new pull request, #7661: URL: https://github.com/apache/arrow-rs/pull/7661 # Which issue does this PR close? We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issu

Re: [PR] [Variant] Add variant docs and examples [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on PR #7661: URL: https://github.com/apache/arrow-rs/pull/7661#issuecomment-2970788262 FYI @mkarbo @superserious-dev @scovich and @PinkCrow007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[PR] chore(deps): update prost-build requirement from =0.13.5 to =0.14.0 [arrow-rs]

2025-06-13 Thread via GitHub
dependabot[bot] opened a new pull request, #7657: URL: https://github.com/apache/arrow-rs/pull/7657 Updates the requirements on [prost-build](https://github.com/tokio-rs/prost) to permit the latest version. Changelog Sourced from https://github.com/tokio-rs/prost/blob/master/CHANGE

[PR] chore(deps): update prost requirement from 0.13.1 to 0.14.0 [arrow-rs]

2025-06-13 Thread via GitHub
dependabot[bot] opened a new pull request, #7658: URL: https://github.com/apache/arrow-rs/pull/7658 Updates the requirements on [prost](https://github.com/tokio-rs/prost) to permit the latest version. Changelog Sourced from https://github.com/tokio-rs/prost/blob/master/CHANGELOG.md

[PR] chore: group prost dependabot updates [arrow-rs]

2025-06-13 Thread via GitHub
mbrobbel opened a new pull request, #7659: URL: https://github.com/apache/arrow-rs/pull/7659 # Which issue does this PR close? None. # Rationale for this change Group PRs like - #7656 - #7657 - #7658 # What changes are included in this PR? Group fo

[PR] chore(deps): update prost-types requirement from 0.13.1 to 0.14.0 [arrow-rs]

2025-06-13 Thread via GitHub
dependabot[bot] opened a new pull request, #7656: URL: https://github.com/apache/arrow-rs/pull/7656 Updates the requirements on [prost-types](https://github.com/tokio-rs/prost) to permit the latest version. Changelog Sourced from https://github.com/tokio-rs/prost/blob/master/CHANGE

Re: [PR] feat: add constructor to help efficiently upgrade key for GenericBytesDictionaryBuilder [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on code in PR #7611: URL: https://github.com/apache/arrow-rs/pull/7611#discussion_r2145110532 ## arrow-array/src/builder/generic_bytes_dictionary_builder.rs: ## @@ -152,6 +155,65 @@ where values_builder, }) } + +/// Creates a new `G

Re: [PR] feat: add constructor to help efficiently upgrade key for GenericBytesDictionaryBuilder [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on code in PR #7611: URL: https://github.com/apache/arrow-rs/pull/7611#discussion_r2145111340 ## arrow-array/src/builder/generic_bytes_dictionary_builder.rs: ## @@ -152,6 +155,71 @@ where values_builder, }) } + +/// Creates a new `G

Re: [PR] GH-46719: [R] Add 32 and 64 bit Decimal types [arrow]

2025-06-13 Thread via GitHub
thisisnic commented on code in PR #46720: URL: https://github.com/apache/arrow/pull/46720#discussion_r2145340640 ## r/vignettes/data_types.Rmd: ## @@ -96,26 +122,38 @@ Note that the Arrow specification also permits half-precision (16 bit) floating ## Fixed point decimal type

[PR] Add `RecordBatch::metadata_mut` and `Field::metadata_mut` [arrow-rs]

2025-06-13 Thread via GitHub
emilk opened a new pull request, #7664: URL: https://github.com/apache/arrow-rs/pull/7664 # Which issue does this PR close? * Closes https://github.com/apache/arrow-rs/issues/7628 # Rationale for this change Allows for fast and convenient mutating of the metadata of record batche

Re: [PR] feat: add constructor to help efficiently upgrade key for GenericBytesDictionaryBuilder [arrow-rs]

2025-06-13 Thread via GitHub
alamb merged PR #7611: URL: https://github.com/apache/arrow-rs/pull/7611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] GH-46809: [CI][Packaging] Stop trying to add headers from arrow/compu… [arrow]

2025-06-13 Thread via GitHub
raulcd commented on PR #46810: URL: https://github.com/apache/arrow/pull/46810#issuecomment-2970887830 @github-actions crossbow submit almalinux-8-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] GH-46809: [CI][Packaging] Stop trying to add headers from arrow/compu… [arrow]

2025-06-13 Thread via GitHub
raulcd commented on PR #46810: URL: https://github.com/apache/arrow/pull/46810#issuecomment-2970887240 @github0-actions crossbow submit almalinux-8-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] [Variant] Simplify creation of Variants from metadata and value [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on PR #7663: URL: https://github.com/apache/arrow-rs/pull/7663#issuecomment-2970891075 FYI @scovich @mkarbo @PinkCrow007 @superserious-dev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] GH-46809: [CI][Packaging] Stop trying to add headers from arrow/compu… [arrow]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #46810: URL: https://github.com/apache/arrow/pull/46810#issuecomment-2970892552 Revision: d2318295abe480372ad01c77728a7faceb0af15a Submitted crossbow builds: [ursacomputing/crossbow @ actions-cae580291f](https://github.com/ursacomputing/crossbow/bra

Re: [I] Add efficient way to change the keys of string dictionary builder [arrow-rs]

2025-06-13 Thread via GitHub
alamb closed issue #7610: Add efficient way to change the keys of string dictionary builder URL: https://github.com/apache/arrow-rs/issues/7610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] GH-46809: [CI][Packaging] Stop trying to add headers from arrow/compu… [arrow]

2025-06-13 Thread via GitHub
raulcd opened a new pull request, #46810: URL: https://github.com/apache/arrow/pull/46810 ### Rationale for this change The PR to split the Arrow compute kernels into its own shared library had some headers at arrow/compute/kernels during development. Those were moved to arrow/comput

Re: [I] [Variant] Implement `VariantObject::field` and `VariantObject::fields` [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on issue #7665: URL: https://github.com/apache/arrow-rs/issues/7665#issuecomment-2971014901 I think this is a good first issue for anyone who wants to learn about variant as it is well specified and has well known results -- This is an automated message from the Apache Git

Re: [PR] GH-46809: [CI][Packaging] Stop trying to add headers from arrow/compu… [arrow]

2025-06-13 Thread via GitHub
raulcd commented on PR #46810: URL: https://github.com/apache/arrow/pull/46810#issuecomment-2971078018 @github-actions crossbow submit almalinux-* centos-* amazon-linux-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] GH-46809: [CI][Packaging] Stop trying to add headers from arrow/compu… [arrow]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #46810: URL: https://github.com/apache/arrow/pull/46810#issuecomment-2971084948 Revision: d2318295abe480372ad01c77728a7faceb0af15a Submitted crossbow builds: [ursacomputing/crossbow @ actions-e259729c6c](https://github.com/ursacomputing/crossbow/bra

Re: [PR] [Variant] Implement read support for remaining primitive types [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on code in PR #7644: URL: https://github.com/apache/arrow-rs/pull/7644#discussion_r2145217655 ## parquet-variant/src/variant.rs: ## @@ -402,11 +403,21 @@ pub enum Variant<'m, 'v> { // TODO: Add types for the rest of the primitive types, once API is agreed u

Re: [PR] [Variant] Implement read support for remaining primitive types [arrow-rs]

2025-06-13 Thread via GitHub
alamb merged PR #7644: URL: https://github.com/apache/arrow-rs/pull/7644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] [Variant] Add variant docs and examples [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on code in PR #7661: URL: https://github.com/apache/arrow-rs/pull/7661#discussion_r2145418272 ## parquet-variant/src/variant.rs: ## @@ -394,43 +398,152 @@ impl<'m, 'v> VariantArray<'m, 'v> { } } -// impl<'m, 'v> Index for VariantArray<'m, 'v> { -// ty

Re: [PR] [Variant] Simplify creation of Variants [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on code in PR #7663: URL: https://github.com/apache/arrow-rs/pull/7663#discussion_r2145415638 ## parquet-variant/src/variant.rs: ## @@ -303,7 +303,7 @@ impl<'m> VariantMetadata<'m> { #[derive(Clone, Copy, Debug, PartialEq)] pub struct VariantObject<'m, 'v> {

[PR] [Variant] Simplify creation of Variants [arrow-rs]

2025-06-13 Thread via GitHub
alamb opened a new pull request, #7663: URL: https://github.com/apache/arrow-rs/pull/7663 # Which issue does this PR close? - Part of https://github.com/apache/arrow-rs/issues/6736 # Rationale for this change While making documentation / examples for working with `Variant

Re: [I] Fast and ergonomic method to add metadata to a `RecordBatch` [arrow-rs]

2025-06-13 Thread via GitHub
jleibs commented on issue #7628: URL: https://github.com/apache/arrow-rs/issues/7628#issuecomment-2970823649 It's a bit orthogonal to the specific request, but I believe the motivating factors for @emilk 's request here bring up a deeper confusing issue. When we talk about attaching

Re: [PR] GH-44208: [R] Adding test to ensure bit64's new semantic works with arrow [arrow]

2025-06-13 Thread via GitHub
NazilaAk commented on code in PR #46651: URL: https://github.com/apache/arrow/pull/46651#discussion_r2145129042 ## r/tests/testthat/test-Array.R: ## @@ -352,6 +352,20 @@ test_that("array supports integer64", { expect_true(as.vector(is.na(all_na))) }) +test_that("array supp

Re: [PR] arrow-row: Add support for REE [arrow-rs]

2025-06-13 Thread via GitHub
brancz commented on code in PR #7649: URL: https://github.com/apache/arrow-rs/pull/7649#discussion_r2145292078 ## arrow-row/src/run.rs: ## @@ -0,0 +1,164 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE

Re: [PR] arrow-row: Add support for REE [arrow-rs]

2025-06-13 Thread via GitHub
brancz commented on code in PR #7649: URL: https://github.com/apache/arrow-rs/pull/7649#discussion_r2145291279 ## arrow-row/src/run_test.rs: ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NO

Re: [PR] GH-46528: [CI][Dev] Remove "archery lint" [arrow]

2025-06-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46686: URL: https://github.com/apache/arrow/pull/46686#issuecomment-2970770404 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c314e80eec38684d3080694e5c1d3b5a3089e219. There were 73

Re: [PR] Initial Builder API for Creating Variant Values [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on PR #7653: URL: https://github.com/apache/arrow-rs/pull/7653#issuecomment-2970983400 It also looks like there are some CI failures on this PR: * RAT means you have to put the apache license at the start of the file * Clippy means run `cargo clippy -p parquet-variant`

Re: [I] Optimize infallible dictionary key casting in `try_new_from_builder` method [arrow-rs]

2025-06-13 Thread via GitHub
albertlockett commented on issue #7662: URL: https://github.com/apache/arrow-rs/issues/7662#issuecomment-2970983692 Can assign this to me. I'll probably be able to find some time next couple weeks -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Initial Builder API for Creating Variant Values [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on code in PR #7653: URL: https://github.com/apache/arrow-rs/pull/7653#discussion_r2145517024 ## parquet-variant/src/builder.rs: ## @@ -0,0 +1,424 @@ +use crate::decoder::{VariantBasicType, VariantPrimitiveType}; +use crate::Variant; +use std::collections::HashMa

[I] [Variant] Implement `VariantObject::field` and `VariantObject::fields` [arrow-rs]

2025-06-13 Thread via GitHub
alamb opened a new issue, #7665: URL: https://github.com/apache/arrow-rs/issues/7665 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** I was trying to write some tests for the VariantBuilder from @PinkCrow007 in - https://github.c

Re: [I] [Variant] Implement `VariantObject::field` and `VariantObject::fields` [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on issue #7665: URL: https://github.com/apache/arrow-rs/issues/7665#issuecomment-2971013837 FYI @mkarbo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] chore(deps): update pyo3 requirement from 0.24.1 to 0.25.1 [arrow-rs]

2025-06-13 Thread via GitHub
dependabot[bot] opened a new pull request, #7655: URL: https://github.com/apache/arrow-rs/pull/7655 Updates the requirements on [pyo3](https://github.com/pyo3/pyo3) to permit the latest version. Release notes Sourced from https://github.com/pyo3/pyo3/releases";>pyo3's releases.

Re: [PR] GH-46775: [Docs] Fix navigation issues [arrow]

2025-06-13 Thread via GitHub
ianmcook merged PR #46784: URL: https://github.com/apache/arrow/pull/46784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] GH-32: Add support for Timestamp data type #46753 [arrow-swift]

2025-06-13 Thread via GitHub
mgrazianoc commented on PR #33: URL: https://github.com/apache/arrow-swift/pull/33#issuecomment-2970660328 I've fixed linters by sing the `pre-commit` suggestion, and reviewed the Copilot AI suggestion. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] GH-46719: [R] Add 32 and 64 bit Decimal types [arrow]

2025-06-13 Thread via GitHub
thisisnic commented on code in PR #46720: URL: https://github.com/apache/arrow/pull/46720#discussion_r2145920066 ## r/tests/testthat/test-data-type.R: ## @@ -497,10 +496,6 @@ test_that("decimal type and validation", { expect_error(decimal128(4, NA), "`scale` must be an intege

Re: [PR] Add `pretty_format_batches_with_schema` function [arrow-rs]

2025-06-13 Thread via GitHub
alamb commented on PR #7642: URL: https://github.com/apache/arrow-rs/pull/7642#issuecomment-2971511532 Thanks again @lewiszlw -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] GH-46757: [CI][Packaging][Conan] Synchronize upstream conan [arrow]

2025-06-13 Thread via GitHub
assignUser commented on PR #46758: URL: https://github.com/apache/arrow/pull/46758#issuecomment-2971509539 There are some additional changes in the PR for 20.0.0: https://github.com/conan-io/conan-center-index/pull/27311 Maybe it makes sense to add them too? -- This is an automated mes

[PR] ci: Remove Meson default_option to set buildtype of release [arrow-nanoarrow]

2025-06-13 Thread via GitHub
WillAyd opened a new pull request, #785: URL: https://github.com/apache/arrow-nanoarrow/pull/785 I have a suspicion this is why the wrapdb Windows build is failing. When developing locally, I think Meson will propogate this setting to subprojects, but when nanoarrow is itself a subproject,

Re: [PR] fix(go/adbc/driver/snowflake): Adjust the precision of the Timestamp values in the JSON-only path [arrow-adbc]

2025-06-13 Thread via GitHub
davidhcoe commented on PR #2965: URL: https://github.com/apache/arrow-adbc/pull/2965#issuecomment-2971884204 > I think this should have a test in Go. That probably requires creating a table that has a primary key? There should be existing tests for returning a schema whose setup can be reus

[PR] GH-46207: [C++] Rename arrow::util::StringBuilder and move to internal namespace [arrow]

2025-06-13 Thread via GitHub
Ziy1-Tan opened a new pull request, #46813: URL: https://github.com/apache/arrow/pull/46813 ### Rationale for this change - Move and Rename function `arrow::util::StringBuilder` to internal namespace to avoid confusion with class `arrow::StringBuilder` ### What changes are incl

Re: [PR] GH-46806: [Ci][Dev][Swift] Remove Swift related settings [arrow]

2025-06-13 Thread via GitHub
assignUser merged PR #46807: URL: https://github.com/apache/arrow/pull/46807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] chore: group prost dependabot updates [arrow-rs]

2025-06-13 Thread via GitHub
mbrobbel merged PR #7659: URL: https://github.com/apache/arrow-rs/pull/7659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [PR] chore: group prost dependabot updates [arrow-rs]

2025-06-13 Thread via GitHub
mbrobbel commented on PR #7659: URL: https://github.com/apache/arrow-rs/pull/7659#issuecomment-2971538470 Thanks for the review @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Add `pretty_format_batches_with_schema` function [arrow-rs]

2025-06-13 Thread via GitHub
alamb merged PR #7642: URL: https://github.com/apache/arrow-rs/pull/7642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

Re: [I] [Variant] Implement `VariantObject::field` and `VariantObject::fields` [arrow-rs]

2025-06-13 Thread via GitHub
scovich commented on issue #7665: URL: https://github.com/apache/arrow-rs/issues/7665#issuecomment-2971955047 Oh! @KrishnaSindhur -- I already had a PR almost ready to go and just saw this issue... -- This is an automated message from the Apache Git Service. To respond to the message, pl

[PR] Finish implementing Variant::Object and Variant::List [arrow-rs]

2025-06-13 Thread via GitHub
scovich opened a new pull request, #7666: URL: https://github.com/apache/arrow-rs/pull/7666 # Which issue does this PR close? Closes https://github.com/apache/arrow-rs/issues/7665 # Rationale for this change Continuing the ongoing variant implementation effort. # W

Re: [PR] GH-46775: [Docs] Fix navigation issues [arrow]

2025-06-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46784: URL: https://github.com/apache/arrow/pull/46784#issuecomment-2971962886 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 2ba455f17e7cdbfe2b2f1aa3dfb2bf00878a17e1. There were 11

Re: [PR] Finish implementing Variant::Object and Variant::List [arrow-rs]

2025-06-13 Thread via GitHub
scovich commented on PR #7666: URL: https://github.com/apache/arrow-rs/pull/7666#issuecomment-2971958203 Attn @alamb @mkarbo since I can't request reviewers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] [CI][Dev][Swift] Is ci/scripts/swift_test.sh still necessary? [arrow]

2025-06-13 Thread via GitHub
assignUser commented on issue #46806: URL: https://github.com/apache/arrow/issues/46806#issuecomment-2971414787 Issue resolved by pull request 46807 https://github.com/apache/arrow/pull/46807 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [I] [Variant] Implement `VariantObject::field` and `VariantObject::fields` [arrow-rs]

2025-06-13 Thread via GitHub
KrishnaSindhur commented on issue #7665: URL: https://github.com/apache/arrow-rs/issues/7665#issuecomment-2971639087 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] arrow-row: Add support for REE [arrow-rs]

2025-06-13 Thread via GitHub
brancz commented on code in PR #7649: URL: https://github.com/apache/arrow-rs/pull/7649#discussion_r2144508333 ## arrow-row/src/run.rs: ## @@ -0,0 +1,164 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE

Re: [PR] arrow-row: Add support for REE [arrow-rs]

2025-06-13 Thread via GitHub
brancz commented on code in PR #7649: URL: https://github.com/apache/arrow-rs/pull/7649#discussion_r2144519339 ## arrow-row/src/run.rs: ## @@ -0,0 +1,164 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE

Re: [PR] GH-40754: [Python] Expose tls_ca_file_path to S3FileSystem [arrow]

2025-06-13 Thread via GitHub
bw513 commented on PR #45881: URL: https://github.com/apache/arrow/pull/45881#issuecomment-2969574456 > Thanks for submitting this @bw513 . Is there a reason this PR is still in draft? I've posted two comments, feel free to update. Really sorry, I got prioritised onto other work and a

Re: [PR] GH-46801: [Dev] Remove some leftovers for Java, Go, JS and Swift on some config files [arrow]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #46802: URL: https://github.com/apache/arrow/pull/46802#issuecomment-2969622784 :warning: GitHub issue #46801 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-46801: [Dev] Remove some leftovers for Java, Go, JS and Swift on some config files [arrow]

2025-06-13 Thread via GitHub
raulcd opened a new pull request, #46802: URL: https://github.com/apache/arrow/pull/46802 ### Rationale for this change The config for Java, Go, JS and Swift on those files is not relevant anymore. ### What changes are included in this PR? Remove references for those impl

Re: [I] [Dev] Add Swift component to issue template and PR labeller [arrow]

2025-06-13 Thread via GitHub
raulcd commented on issue #33870: URL: https://github.com/apache/arrow/issues/33870#issuecomment-2969627763 The swift repo has been moved to their own repository we can close this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] arrow-row: Add support for REE [arrow-rs]

2025-06-13 Thread via GitHub
brancz commented on code in PR #7649: URL: https://github.com/apache/arrow-rs/pull/7649#discussion_r2144549751 ## arrow-row/src/run.rs: ## @@ -0,0 +1,164 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE

[PR] GH-46803: [Swift] Remove swift implementation from apache/arrow after migration to new repository [arrow]

2025-06-13 Thread via GitHub
raulcd opened a new pull request, #46804: URL: https://github.com/apache/arrow/pull/46804 ### Rationale for this change The Swift implementation has been moved to their own repository at https://github.com/apache/arrow-swift ### What changes are included in this PR? Remo

Re: [PR] arrow-row: Add support for REE [arrow-rs]

2025-06-13 Thread via GitHub
brancz commented on code in PR #7649: URL: https://github.com/apache/arrow-rs/pull/7649#discussion_r2144548240 ## arrow-row/src/run.rs: ## @@ -0,0 +1,164 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE

Re: [PR] GH-46803: [Swift] Remove swift implementation from apache/arrow after migration to new repository [arrow]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #46804: URL: https://github.com/apache/arrow/pull/46804#issuecomment-2969640823 :warning: GitHub issue #46803 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] arrow-row: Add support for REE [arrow-rs]

2025-06-13 Thread via GitHub
brancz commented on code in PR #7649: URL: https://github.com/apache/arrow-rs/pull/7649#discussion_r2144552733 ## arrow-row/src/run.rs: ## @@ -0,0 +1,164 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE

Re: [PR] arrow-row: Add support for REE [arrow-rs]

2025-06-13 Thread via GitHub
brancz commented on code in PR #7649: URL: https://github.com/apache/arrow-rs/pull/7649#discussion_r2144557604 ## arrow-row/src/run.rs: ## @@ -0,0 +1,164 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE

Re: [PR] GH-46794: [CI][Dev] fix shellcheck errors in the ci/scripts/csharp_test.sh [arrow]

2025-06-13 Thread via GitHub
raulcd commented on code in PR #46795: URL: https://github.com/apache/arrow/pull/46795#discussion_r2144558540 ## .pre-commit-config.yaml: ## @@ -305,6 +305,7 @@ repos: ?^ci/scripts/cpp_test\.sh$| ?^ci/scripts/csharp_build\.sh$| ?^ci/scripts/cshar

Re: [PR] GH-46708: [C++][Gandiva] Added zero return values for castDECIMAL_utf8 [arrow]

2025-06-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46709: URL: https://github.com/apache/arrow/pull/46709#issuecomment-2969951389 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit c97e21af612e4d91f6ad3ee329b839c5d665532b. There were 68

Re: [PR] GH-46806: Remove Swift related settings [arrow]

2025-06-13 Thread via GitHub
github-actions[bot] commented on PR #46807: URL: https://github.com/apache/arrow/pull/46807#issuecomment-2970071842 :warning: GitHub issue #46806 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-46806: Remove Swift related settings [arrow]

2025-06-13 Thread via GitHub
hiroyuki-sato opened a new pull request, #46807: URL: https://github.com/apache/arrow/pull/46807 ### Rationale for this change #46803 Removed switch implementation. But, Some Swift relate files are still exists. ### What changes are included in this PR? Remove Swift rela

Re: [I] [CI][Dev][Swift] Is ci/scripts/swift_test.sh still necessary? [arrow]

2025-06-13 Thread via GitHub
raulcd commented on issue #46806: URL: https://github.com/apache/arrow/issues/46806#issuecomment-2969959629 sorry, those should have been removed! Good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] [CI][Dev][Swift] Is ci/scripts/swift_test.sh still necessary? [arrow]

2025-06-13 Thread via GitHub
hiroyuki-sato commented on issue #46806: URL: https://github.com/apache/arrow/issues/46806#issuecomment-2970099380 Hello, @raulcd. Thank you for your comment. As a reporter, I created #46807. If you create a PR by yourself, I'll close it. It seems that the following part needs update

Re: [PR] ci: add cargo deny [arrow-rs]

2025-06-13 Thread via GitHub
timsaucer commented on PR #7651: URL: https://github.com/apache/arrow-rs/pull/7651#issuecomment-2970194579 Moving to draft until I can resolve maintainer suggestion in the original issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] fix: Align flatbuffer test data stored as globals [arrow-nanoarrow]

2025-06-13 Thread via GitHub
WillAyd commented on PR #783: URL: https://github.com/apache/arrow-nanoarrow/pull/783#issuecomment-2970192903 Nice find! I don't think the Windows CI error is related (?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] fix: Align flatbuffer test data stored as globals [arrow-nanoarrow]

2025-06-13 Thread via GitHub
paleolimbot merged PR #783: URL: https://github.com/apache/arrow-nanoarrow/pull/783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

Re: [I] Unimplemented error when the output table contains timestamp with timezone [arrow-java]

2025-06-13 Thread via GitHub
lidavidm commented on issue #787: URL: https://github.com/apache/arrow-java/issues/787#issuecomment-2970208397 I think it's more likely https://github.com/apache/arrow-java/pull/464 but I don't have the time to confirm. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] feat: add constructor to help efficiently upgrade key for GenericBytesDictionaryBuilder [arrow-rs]

2025-06-13 Thread via GitHub
albertlockett commented on code in PR #7611: URL: https://github.com/apache/arrow-rs/pull/7611#discussion_r2144971950 ## arrow-array/src/builder/generic_bytes_dictionary_builder.rs: ## @@ -152,6 +155,65 @@ where values_builder, }) } + +/// Creates

[I] Add efficient way to upgrade keys for additional dictionary builders [arrow-rs]

2025-06-13 Thread via GitHub
albertlockett opened a new issue, #7654: URL: https://github.com/apache/arrow-rs/issues/7654 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** **Describe the solution you'd like** In https://github.com/apache/arrow-rs/pull

[PR] debug wrapdb error [arrow-nanoarrow]

2025-06-13 Thread via GitHub
WillAyd opened a new pull request, #784: URL: https://github.com/apache/arrow-nanoarrow/pull/784 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] feat: add constructor to help efficiently upgrade key for GenericBytesDictionaryBuilder [arrow-rs]

2025-06-13 Thread via GitHub
albertlockett commented on PR #7611: URL: https://github.com/apache/arrow-rs/pull/7611#issuecomment-2970237688 > Thank you @albertlockett -- this PR looks really nice to me. It is well documented and well tested and the need makes a lot of sense > > I did have a question on potentiall

Re: [PR] feat: add constructor to help efficiently upgrade key for GenericBytesDictionaryBuilder [arrow-rs]

2025-06-13 Thread via GitHub
albertlockett commented on code in PR #7611: URL: https://github.com/apache/arrow-rs/pull/7611#discussion_r2144985583 ## arrow-array/src/builder/generic_bytes_dictionary_builder.rs: ## @@ -152,6 +155,65 @@ where values_builder, }) } + +/// Creates

  1   2   >