Hannah-Jiang commented on pull request #11548:
URL: https://github.com/apache/beam/pull/11548#issuecomment-620990823
@tvalentyn, I changed it to pull licenses only with Jenkins test. License
pulling is skipped by default. Can you please take a look?
---
pabloem commented on pull request #11560:
URL: https://github.com/apache/beam/pull/11560#issuecomment-620986934
py37 postcommit:
https://builds.apache.org/job/beam_PostCommit_Python37_PR/128/
This is an automated message fro
pabloem commented on pull request #11560:
URL: https://github.com/apache/beam/pull/11560#issuecomment-620985048
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, pl
damondouglas opened a new pull request #11564:
URL: https://github.com/apache/beam/pull/11564
This pull request adds a section related to Core Transforms with one Map
transforms lesson to the Go SDK katas. It patterns after the existing [Java
katas](https://github.com/apache/beam/tree/mas
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620981601
Agh it's looking like it's a more complicated problem. I'm working on
project inference, and I'll add ReadFromBQ to tornadoes in that PR. Is that
reasonable Yichi? So sorry a
Hannah-Jiang commented on pull request #11548:
URL: https://github.com/apache/beam/pull/11548#issuecomment-620977492
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the messa
Hannah-Jiang commented on pull request #11548:
URL: https://github.com/apache/beam/pull/11548#issuecomment-620977305
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
amaliujia commented on pull request #11333:
URL: https://github.com/apache/beam/pull/11333#issuecomment-620976106
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia commented on pull request #11333:
URL: https://github.com/apache/beam/pull/11333#issuecomment-620975620
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
Hannah-Jiang commented on pull request #11548:
URL: https://github.com/apache/beam/pull/11548#issuecomment-620974622
Run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log
y1chi commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620973239
Should I remove the project option and use project auto-inference?
This is an automated message from the Apache Git
Hannah-Jiang commented on pull request #11552:
URL: https://github.com/apache/beam/pull/11552#issuecomment-620970095
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, plea
Hannah-Jiang commented on pull request #11563:
URL: https://github.com/apache/beam/pull/11563#issuecomment-620964485
Is it ok to merge the threadpool part to my PR?
This is an automated message from the Apache Git Service.
To
pabloem commented on pull request #11547:
URL: https://github.com/apache/beam/pull/11547#issuecomment-620961633
Ah indeed it should fix that. I'll mark it as fixed.
On Tue, Apr 28, 2020, 7:33 PM Ahmet Altay wrote:
> Do you know if this will fix
> https://issues.apache.org/j
aaltay commented on pull request #11547:
URL: https://github.com/apache/beam/pull/11547#issuecomment-620959237
Do you know if this will fix https://issues.apache.org/jira/browse/BEAM-7885
?
This is an automated message from
robertwb commented on pull request #11495:
URL: https://github.com/apache/beam/pull/11495#issuecomment-620929683
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11560:
URL: https://github.com/apache/beam/pull/11560#issuecomment-620928773
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, pl
aaltay commented on pull request #11210:
URL: https://github.com/apache/beam/pull/11210#issuecomment-620924876
@chamikaramj - could you review this PR?
This is an automated message from the Apache Git Service.
To respond to t
jaketf commented on a change in pull request #11538:
URL: https://github.com/apache/beam/pull/11538#discussion_r417000696
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##
@@ -437,6 +444,20 @@ private Message f
Hannah-Jiang commented on pull request #11563:
URL: https://github.com/apache/beam/pull/11563#issuecomment-620915446
I created a ticket for caching between runs.
https://issues.apache.org/jira/browse/BEAM-9849
This is an aut
chamikaramj commented on pull request #11495:
URL: https://github.com/apache/beam/pull/11495#issuecomment-620913946
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
robertwb commented on pull request #11521:
URL: https://github.com/apache/beam/pull/11521#issuecomment-620913082
R: @ihji
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
robertwb commented on pull request #11495:
URL: https://github.com/apache/beam/pull/11495#issuecomment-620912558
Thanks. Rebased.
This is an automated message from the Apache Git Service.
To respond to the message, please lo
robertwb commented on pull request #11511:
URL: https://github.com/apache/beam/pull/11511#issuecomment-620912703
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
robertwb commented on pull request #11563:
URL: https://github.com/apache/beam/pull/11563#issuecomment-620909314
Yes, I think we should cache things between runs, but within a run is
low-hanging fruit, especially when 1000+ dependencies mostly share a small set
of licenses.
Waiting
robertwb commented on pull request #11452:
URL: https://github.com/apache/beam/pull/11452#issuecomment-620907966
R: @robertwb
This is an automated message from the Apache Git Service.
To respond to the message, please log on
aaltay commented on pull request #11210:
URL: https://github.com/apache/beam/pull/11210#issuecomment-620907421
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
Hannah-Jiang commented on pull request #11563:
URL: https://github.com/apache/beam/pull/11563#issuecomment-620903180
I thought you meant caching the URLs between different runs, so my
estimation of the workload was high and I didn't think I can deliver that
approach by 2.21.0.
Cachi
aaltay commented on pull request #11210:
URL: https://github.com/apache/beam/pull/11210#issuecomment-620903075
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please l
ibzib commented on a change in pull request #11556:
URL: https://github.com/apache/beam/pull/11556#discussion_r416974908
##
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##
@@ -433,13 +435,12 @@ def run_pipeline(self, pipeline, options):
sta
Hannah-Jiang commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416976074
##
File path: sdks/java/container/build.gradle
##
@@ -101,16 +84,44 @@ docker {
project.rootProject["docker-tag"] : project.sdk_ver
iemejia commented on a change in pull request #10546:
URL: https://github.com/apache/beam/pull/10546#discussion_r416976043
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -391,36 +393,57 @@ static Cluster getCluster(
Hannah-Jiang commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416975896
##
File path: sdks/java/container/build.gradle
##
@@ -101,16 +84,44 @@ docker {
project.rootProject["docker-tag"] : project.sdk_ver
iemejia commented on a change in pull request #10546:
URL: https://github.com/apache/beam/pull/10546#discussion_r416975426
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -391,36 +393,57 @@ static Cluster getCluster(
iemejia commented on pull request #11480:
URL: https://github.com/apache/beam/pull/11480#issuecomment-620892620
Run Flink ValidatesRunner Java 11
This is an automated message from the Apache Git Service.
To respond to the mes
iemejia commented on pull request #11480:
URL: https://github.com/apache/beam/pull/11480#issuecomment-620892562
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
robertwb opened a new pull request #11563:
URL: https://github.com/apache/beam/pull/11563
* Memoize checking accessibility of (very often re-used) license urls.
* Use a threadpool rather than manually managing threads.
Thank you for your contribution
tvalentyn commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416962452
##
File path: sdks/java/container/build.gradle
##
@@ -101,16 +84,44 @@ docker {
project.rootProject["docker-tag"] : project.sdk_versio
pabloem commented on pull request #11560:
URL: https://github.com/apache/beam/pull/11560#issuecomment-620888999
Run Portable_Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message
tvalentyn commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416962452
##
File path: sdks/java/container/build.gradle
##
@@ -101,16 +84,44 @@ docker {
project.rootProject["docker-tag"] : project.sdk_versio
jaketf commented on a change in pull request #11339:
URL: https://github.com/apache/beam/pull/11339#discussion_r416957719
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
##
@@ -0,0 +1,977 @@
+/*
+ * Licensed to t
jaketf commented on a change in pull request #11538:
URL: https://github.com/apache/beam/pull/11538#discussion_r416957276
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##
@@ -437,6 +444,20 @@ private Message f
Ardagan removed a comment on pull request #11477:
URL: https://github.com/apache/beam/pull/11477#issuecomment-620876614
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, p
Ardagan commented on pull request #11477:
URL: https://github.com/apache/beam/pull/11477#issuecomment-620876614
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
lostluck commented on a change in pull request #11517:
URL: https://github.com/apache/beam/pull/11517#discussion_r416930600
##
File path: sdks/go/examples/stringsplit/offsetrange/offsetrange.go
##
@@ -89,21 +89,23 @@ func (tracker *Tracker) GetError() error {
}
// TrySplit
dpmills commented on pull request #10983:
URL: https://github.com/apache/beam/pull/10983#issuecomment-620874181
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
stale[bot] commented on pull request #10983:
URL: https://github.com/apache/beam/pull/10983#issuecomment-620870062
This pull request is no longer marked as stale.
This is an automated message from the Apache Git Service.
reuvenlax commented on pull request #10983:
URL: https://github.com/apache/beam/pull/10983#issuecomment-620869944
@dpmills any comments on this PR?
This is an automated message from the Apache Git Service.
To respond to the m
chamikaramj commented on pull request #11039:
URL: https://github.com/apache/beam/pull/11039#issuecomment-620864801
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, ple
chamikaramj commented on pull request #11039:
URL: https://github.com/apache/beam/pull/11039#issuecomment-620864937
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
chamikaramj commented on pull request #11039:
URL: https://github.com/apache/beam/pull/11039#issuecomment-620864665
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, pleas
ibzib commented on pull request #11537:
URL: https://github.com/apache/beam/pull/11537#issuecomment-620864491
> @ibzib Maybe also worth backporting?
Might as well. `SEVERE: *~*~*~ Beam is horribly broken! *~*~*~` definitely
tends to frighten new users.
-
chamikaramj commented on pull request #11495:
URL: https://github.com/apache/beam/pull/11495#issuecomment-620863418
Modulo the conflict.
This is an automated message from the Apache Git Service.
To respond to the message, ple
iemejia commented on pull request #11527:
URL: https://github.com/apache/beam/pull/11527#issuecomment-620863411
I am having an amnesia moment about this, trying hard to remember and I
cannot even find references on the previous issues, so much time has happened
that maybe it is just not an
pabloem commented on pull request #11538:
URL: https://github.com/apache/beam/pull/11538#issuecomment-620862736
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
lostluck commented on pull request #11524:
URL: https://github.com/apache/beam/pull/11524#issuecomment-620860334
"No artifacts staged" state has been verified. Merging.
This is an automated message from the Apache Git Service
pabloem commented on pull request #11538:
URL: https://github.com/apache/beam/pull/11538#issuecomment-620860467
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on a change in pull request #11538:
URL: https://github.com/apache/beam/pull/11538#discussion_r416060393
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java
##
@@ -475,7 +497,14 @@ public void init
pabloem commented on pull request #11538:
URL: https://github.com/apache/beam/pull/11538#issuecomment-620859719
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #11554:
URL: https://github.com/apache/beam/pull/11554#issuecomment-620856358
Staging still looks odd: : / -
http://apache-beam-website-pull-requests.storage.googleapis.com/11554/index.html
lostluck commented on pull request #11524:
URL: https://github.com/apache/beam/pull/11524#issuecomment-620855224
I'll merge once I sanity check that we're back to "No artifacts" for the
Dataflow tests, and otherwise passed.
lostluck commented on a change in pull request #11524:
URL: https://github.com/apache/beam/pull/11524#discussion_r416922273
##
File path: sdks/go/test/run_integration_tests.sh
##
@@ -102,9 +102,8 @@ case $key in
esac
done
-if [[ "$RUNNER" != "universal" ]]; then
- PUSH_CON
pabloem commented on a change in pull request #11492:
URL: https://github.com/apache/beam/pull/11492#discussion_r416921999
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##
@@ -845,10 +845,12 @@ def process_bundle(self,
(result_
lostluck commented on a change in pull request #11524:
URL: https://github.com/apache/beam/pull/11524#discussion_r416922004
##
File path: sdks/go/test/run_integration_tests.sh
##
@@ -118,7 +117,7 @@ test -d sdks/go/test
command -v docker
docker -v
-if [[ PUSH_CONTAINER_TO_G
lostluck commented on pull request #11524:
URL: https://github.com/apache/beam/pull/11524#issuecomment-620854348
Run Go Postcommit
This is an automated message from the Apache Git Service.
To respond to the message, please lo
mxm removed a comment on pull request #11558:
URL: https://github.com/apache/beam/pull/11558#issuecomment-620847201
Run Python Load Tests ParDo Flink Streaming
This is an automated message from the Apache Git Service.
To resp
mxm commented on pull request #11558:
URL: https://github.com/apache/beam/pull/11558#issuecomment-620847201
Run Python Load Tests ParDo Flink Streaming
This is an automated message from the Apache Git Service.
To respond to t
mxm commented on pull request #11558:
URL: https://github.com/apache/beam/pull/11558#issuecomment-620846828
Run Python Load Tests ParDo Flink Streaming
This is an automated message from the Apache Git Service.
To respond to t
robertwb commented on pull request #11419:
URL: https://github.com/apache/beam/pull/11419#issuecomment-620845876
Thanks. Merging as soon as tests pass.
This is an automated message from the Apache Git Service.
To respond to
mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-620842616
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log
pabloem commented on pull request #11523:
URL: https://github.com/apache/beam/pull/11523#issuecomment-620842927
Hm lint and autoformat are complaining : (
Lint:
```
13:08:40 apache_beam/runners/interactive/interactive_runner.py:30:0: W0611:
Unused import sys (unused-import)
```
mxm commented on pull request #11492:
URL: https://github.com/apache/beam/pull/11492#issuecomment-620842521
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
mxm commented on pull request #11537:
URL: https://github.com/apache/beam/pull/11537#issuecomment-620842028
@ibzib Maybe also worth backporting?
This is an automated message from the Apache Git Service.
To respond to the mess
mxm commented on pull request #11537:
URL: https://github.com/apache/beam/pull/11537#issuecomment-620841780
Merging, we can follow-up with the nits if we feel like it, since they are
very minor.
This is an automated message
mxm removed a comment on pull request #11558:
URL: https://github.com/apache/beam/pull/11558#issuecomment-620839972
Run Website_Stage_GCS PreCommit
This is an automated message from the Apache Git Service.
To respond to the m
mxm commented on pull request #11558:
URL: https://github.com/apache/beam/pull/11558#issuecomment-620839972
Run Website_Stage_GCS PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11554:
URL: https://github.com/apache/beam/pull/11554#issuecomment-620839537
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
mxm commented on pull request #11558:
URL: https://github.com/apache/beam/pull/11558#issuecomment-620837611
Run Python Load Tests ParDo Flink Streaming
This is an automated message from the Apache Git Service.
To respond to t
pabloem commented on pull request #11523:
URL: https://github.com/apache/beam/pull/11523#issuecomment-620825431
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620825306
Run Python 3.5 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, pl
lukecwik commented on pull request #11562:
URL: https://github.com/apache/beam/pull/11562#issuecomment-620823343
R: @yifanzou
This is an automated message from the Apache Git Service.
To respond to the message, please log on
lukecwik opened a new pull request #11562:
URL: https://github.com/apache/beam/pull/11562
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://b
pabloem commented on pull request #11545:
URL: https://github.com/apache/beam/pull/11545#issuecomment-620815458
Adding project auto-inference here; https://github.com/apache/beam/pull/11560
This is an automated message from t
robertwb opened a new pull request #11561:
URL: https://github.com/apache/beam/pull/11561
I noticed this while trying to look at presubmit logs.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly an
Hannah-Jiang commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416874101
##
File path: sdks/java/container/build.gradle
##
@@ -101,16 +84,44 @@ docker {
project.rootProject["docker-tag"] : project.sdk_ver
pabloem commented on pull request #11547:
URL: https://github.com/apache/beam/pull/11547#issuecomment-620808273
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem opened a new pull request #11560:
URL: https://github.com/apache/beam/pull/11560
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickl
pabloem commented on pull request #11554:
URL: https://github.com/apache/beam/pull/11554#issuecomment-620804674
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Akshay-Iyangar commented on pull request #10078:
URL: https://github.com/apache/beam/pull/10078#issuecomment-620803551
@aromanenko-dev - could you also have a look at this?
This is an automated message from the Apache Git
tvalentyn commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416855737
##
File path: sdks/java/container/build.gradle
##
@@ -101,16 +84,44 @@ docker {
project.rootProject["docker-tag"] : project.sdk_versio
Akshay-Iyangar commented on a change in pull request #11341:
URL: https://github.com/apache/beam/pull/11341#discussion_r416853789
##
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/options/AwsOptions.java
##
@@ -103,6 +103,34 @@ public AWSC
chamikaramj commented on pull request #11495:
URL: https://github.com/apache/beam/pull/11495#issuecomment-620792019
Thanks looking.
This is an automated message from the Apache Git Service.
To respond to the message, please l
aaltay commented on pull request #11507:
URL: https://github.com/apache/beam/pull/11507#issuecomment-620791900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
pabloem commented on pull request #11554:
URL: https://github.com/apache/beam/pull/11554#issuecomment-620787861
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
bntnam edited a comment on pull request #11554:
URL: https://github.com/apache/beam/pull/11554#issuecomment-620784079
@pabloem : Thanks for letting me know. I'll look into it. And, there are
conflicts. Probably, it stops you "retest this please". :D
Update: Ok I resoved it!
About
bntnam edited a comment on pull request #11554:
URL: https://github.com/apache/beam/pull/11554#issuecomment-620784079
@pabloem : Thanks for letting me know. I'll look into it. And, there are
conflicts. Probably, it stops you "retest this please". :D
Update: Ok I resoved it!
And ab
bntnam edited a comment on pull request #11554:
URL: https://github.com/apache/beam/pull/11554#issuecomment-620784079
@pabloem : Thanks for letting me know. I'll look into it. And, there are
conflicts. Probably, it stops you "retest this please". :D
Update: Ok I resoved it!
And ab
pabloem commented on pull request #11523:
URL: https://github.com/apache/beam/pull/11523#issuecomment-620786687
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please lo
bntnam edited a comment on pull request #11554:
URL: https://github.com/apache/beam/pull/11554#issuecomment-620784079
@pabloem : Thanks for letting me know. I'll look into it. There is a commit
which cleans Jekyll files, it causes conflicts. Probably, it stops you "retest
this please". :D
bntnam edited a comment on pull request #11554:
URL: https://github.com/apache/beam/pull/11554#issuecomment-620784079
@pabloem : Thanks for letting me know. I'll look into it. There is a commit
which cleans Jekyll files, it causes conflicts. I couldn't resolve due to no
permission. Probabl
1 - 100 of 204 matches
Mail list logo
