[GitHub] [beam] henryken commented on a change in pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

2020-05-17 Thread GitBox
henryken commented on a change in pull request #11731: URL: https://github.com/apache/beam/pull/11731#discussion_r426224090 ## File path: learning/katas/python/Windowing/Adding Timestamp/ParDo/task-info.yaml ## @@ -22,10 +22,10 @@ files: - name: task.py visible: true pla

[GitHub] [beam] iht commented on a change in pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

2020-05-17 Thread GitBox
iht commented on a change in pull request #11731: URL: https://github.com/apache/beam/pull/11731#discussion_r426235925 ## File path: learning/katas/python/Windowing/Adding Timestamp/ParDo/task.py ## @@ -16,6 +16,7 @@ import datetime import time Review comment: Done

[GitHub] [beam] iht commented on a change in pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

2020-05-17 Thread GitBox
iht commented on a change in pull request #11731: URL: https://github.com/apache/beam/pull/11731#discussion_r426235990 ## File path: learning/katas/python/Windowing/Adding Timestamp/ParDo/task-info.yaml ## @@ -22,10 +22,10 @@ files: - name: task.py visible: true placehol

[GitHub] [beam] iht commented on a change in pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

2020-05-17 Thread GitBox
iht commented on a change in pull request #11731: URL: https://github.com/apache/beam/pull/11731#discussion_r426241264 ## File path: learning/katas/python/Windowing/Adding Timestamp/ParDo/task.py ## @@ -24,30 +25,30 @@ class Event: -def __init__(self, id, event, date):

[GitHub] [beam] iht commented on a change in pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

2020-05-17 Thread GitBox
iht commented on a change in pull request #11731: URL: https://github.com/apache/beam/pull/11731#discussion_r426241932 ## File path: learning/katas/python/Windowing/Fixed Time Window/Fixed Time Window/task-info.yaml ## @@ -22,7 +22,7 @@ files: - name: task.py visible: true

[GitHub] [beam] henryken opened a new pull request #11736: Katas - Convert task description from HTML to Markdown

2020-05-17 Thread GitBox
henryken opened a new pull request #11736: URL: https://github.com/apache/beam/pull/11736 Convert all Katas task descriptions from HTML to Markdown. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] henryken commented on pull request #11736: Katas - Convert task description from HTML to Markdown

2020-05-17 Thread GitBox
henryken commented on pull request #11736: URL: https://github.com/apache/beam/pull/11736#issuecomment-629773512 R: @pabloem This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] rehmanmuradali commented on pull request #11350: [BEAM-1589] Added @OnWindowExpiration annotation.

2020-05-17 Thread GitBox
rehmanmuradali commented on pull request #11350: URL: https://github.com/apache/beam/pull/11350#issuecomment-629778043 R: @reuvenlax This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] rehmanmuradali removed a comment on pull request #11350: [BEAM-1589] Added @OnWindowExpiration annotation.

2020-05-17 Thread GitBox
rehmanmuradali removed a comment on pull request #11350: URL: https://github.com/apache/beam/pull/11350#issuecomment-628082101 R: @reuvenlax This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] henryken commented on pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

2020-05-17 Thread GitBox
henryken commented on pull request #11731: URL: https://github.com/apache/beam/pull/11731#issuecomment-629801033 Thanks for the changes @iht. LGTM now. @pabloem, can you help to merge and close this issue? This is an autom

[GitHub] [beam] stale[bot] commented on pull request #10809: [BEAM-8932] Add MessageWithOrderingKey and add a usable method to generate a PCollection with this type.

2020-05-17 Thread GitBox
stale[bot] commented on pull request #10809: URL: https://github.com/apache/beam/pull/10809#issuecomment-629859367 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. --

[GitHub] [beam] stale[bot] commented on pull request #10807: [BEAM-8932][Cleanup] Fix metric reader to use an actually accessible Nonnull annotation.

2020-05-17 Thread GitBox
stale[bot] commented on pull request #10807: URL: https://github.com/apache/beam/pull/10807#issuecomment-629859364 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. --

[GitHub] [beam] stale[bot] closed pull request #10807: [BEAM-8932][Cleanup] Fix metric reader to use an actually accessible Nonnull annotation.

2020-05-17 Thread GitBox
stale[bot] closed pull request #10807: URL: https://github.com/apache/beam/pull/10807 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] stale[bot] closed pull request #10808: [BEAM-8932] Modify PubsubUnboundedSource and PubsubReader to use the PubsubMessage proto.

2020-05-17 Thread GitBox
stale[bot] closed pull request #10808: URL: https://github.com/apache/beam/pull/10808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] stale[bot] commented on pull request #10808: [BEAM-8932] Modify PubsubUnboundedSource and PubsubReader to use the PubsubMessage proto.

2020-05-17 Thread GitBox
stale[bot] commented on pull request #10808: URL: https://github.com/apache/beam/pull/10808#issuecomment-629859360 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. --

[GitHub] [beam] stale[bot] closed pull request #10809: [BEAM-8932] Add MessageWithOrderingKey and add a usable method to generate a PCollection with this type.

2020-05-17 Thread GitBox
stale[bot] closed pull request #10809: URL: https://github.com/apache/beam/pull/10809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] stale[bot] commented on pull request #10165: [BEAM-7390] Add code snippet for GroupIntoBatches

2020-05-17 Thread GitBox
stale[bot] commented on pull request #10165: URL: https://github.com/apache/beam/pull/10165#issuecomment-629859355 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

[GitHub] [beam] omarismail94 opened a new pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-17 Thread GitBox
omarismail94 opened a new pull request #11737: URL: https://github.com/apache/beam/pull/11737 R: @amaliujia CC: @kennknowles Added support for BIT_OR aggregation function in Beam SQL. I have to add a unit test in **ZetaSQLDialectSpecTest**. Struggling to do that right now.

[GitHub] [beam] omarismail94 commented on pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-17 Thread GitBox
omarismail94 commented on pull request #11737: URL: https://github.com/apache/beam/pull/11737#issuecomment-629890142 This is my second ever pull, let me know if you have any feedback! This is an automated message from the Apa

[GitHub] [beam] omarismail94 edited a comment on pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-17 Thread GitBox
omarismail94 edited a comment on pull request #11737: URL: https://github.com/apache/beam/pull/11737#issuecomment-629890142 This is my second ever pr, let me know if you have any feedback! This is an automated message from th

[GitHub] [beam] rezarokni commented on pull request #11437: [BEAM-9770] Add BigQueryIO deadletter pattern

2020-05-17 Thread GitBox
rezarokni commented on pull request #11437: URL: https://github.com/apache/beam/pull/11437#issuecomment-629906164 org.apache.beam.runners.spark.SparkPortableExecutionTest.testExecution org.apache.beam.fn.harness.FnHarnessTest.testLaunchFnHarnessAndTeardownCleanly Flaky tests? -

[GitHub] [beam] henryken commented on pull request #11736: Katas - Convert task description from HTML to Markdown

2020-05-17 Thread GitBox
henryken commented on pull request #11736: URL: https://github.com/apache/beam/pull/11736#issuecomment-629920425 @pabloem, if the review is fine, please let me know before you merge it. I need to upload to Stepik before we can close this.

[GitHub] [beam] mwalenia merged pull request #11692: [BEAM-2530] Implement Zeta SQL precommit compile tests and run on java 11

2020-05-17 Thread GitBox
mwalenia merged pull request #11692: URL: https://github.com/apache/beam/pull/11692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

2020-05-17 Thread GitBox
darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-629979195 Failed org.apache.beam.examples.WordCountIT > testE2EWordCount FAILED Task :runners:google-cloud-dataflow-java:examples-streaming:windmillPreCommit FAILED @amaliujia