boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-631891047
Run Java Flink PortableValidatesRunner Streaming
This is an automated message from the Apache Git Service.
To
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-631890990
Run Java Flink PortableValidatesRunner Batch
This is an automated message from the Apache Git Service.
To
tweise commented on pull request #11722:
URL: https://github.com/apache/beam/pull/11722#issuecomment-631884230
Unrelated test failure
`org.apache.beam.sdk.extensions.ml.VideoIntelligenceIT.annotateVideoFromURINoContext`
tweise merged pull request #11722:
URL: https://github.com/apache/beam/pull/11722
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
boyuanzz commented on a change in pull request #11756:
URL: https://github.com/apache/beam/pull/11756#discussion_r428438971
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -962,16 +971,25 @@ private Progress getProgress() {
veblush commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631882467
Thanks, Brian and Chamikara!
This is an automated message from the Apache Git Service.
To respond to the
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-631882129
retest all please
This is an automated message from the Apache Git Service.
To respond to the message, please
chamikaramj commented on pull request #11757:
URL: https://github.com/apache/beam/pull/11757#issuecomment-631880290
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chamikaramj merged pull request #11651:
URL: https://github.com/apache/beam/pull/11651
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tweise commented on pull request #11722:
URL: https://github.com/apache/beam/pull/11722#issuecomment-631867326
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit closed pull request #11769:
URL: https://github.com/apache/beam/pull/11769
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-631860763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-631859266
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
TheNeuralBit opened a new pull request #11770:
URL: https://github.com/apache/beam/pull/11770
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
rionmonster edited a comment on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-631728007
@henryken
I was able to successfully export the content of this course over to Stepik
and generate all of the expected new metadata associated with it (e.g.
chamikaramj commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631854098
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chamikaramj commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631854178
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
chamikaramj commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631854055
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631853980
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11757:
URL: https://github.com/apache/beam/pull/11757#issuecomment-631853840
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
lukecwik merged pull request #11746:
URL: https://github.com/apache/beam/pull/11746
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-631853304
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on pull request #11769:
URL: https://github.com/apache/beam/pull/11769#issuecomment-631849940
Run Gradle Publish
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit opened a new pull request #11769:
URL: https://github.com/apache/beam/pull/11769
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
TheNeuralBit commented on pull request #11769:
URL: https://github.com/apache/beam/pull/11769#issuecomment-631838720
Run Gradle Publish
This is an automated message from the Apache Git Service.
To respond to the message,
tweise commented on pull request #11722:
URL: https://github.com/apache/beam/pull/11722#issuecomment-631828652
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
darshanj commented on a change in pull request #11682:
URL: https://github.com/apache/beam/pull/11682#discussion_r428399929
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java
##
@@ -124,21 +190,26 @@ private Partition(PartitionDoFn
darshanj commented on a change in pull request #11682:
URL: https://github.com/apache/beam/pull/11682#discussion_r428399738
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java
##
@@ -124,21 +190,26 @@ private Partition(PartitionDoFn
darshanj commented on a change in pull request #11682:
URL: https://github.com/apache/beam/pull/11682#discussion_r428399634
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java
##
@@ -85,7 +141,14 @@
* @throws IllegalArgumentException
darshanj commented on a change in pull request #11682:
URL: https://github.com/apache/beam/pull/11682#discussion_r428399671
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java
##
@@ -76,6 +93,45 @@
int partitionFor(T elem, int
darshanj commented on a change in pull request #11682:
URL: https://github.com/apache/beam/pull/11682#discussion_r428399770
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java
##
@@ -124,21 +190,26 @@ private Partition(PartitionDoFn
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428399477
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/BeamBatchWorker.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428399112
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2PipelineResult.java
##
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428397620
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2LegacyRunner.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the
TheNeuralBit commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631825554
Run Dataflow ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit merged pull request #11529:
URL: https://github.com/apache/beam/pull/11529
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
veblush commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631815316
Thanks for running the test and the result doesn't make sense because this
change won't introduce any runtime behavior other than dependency. Is it
possible to be caused by
lostluck commented on pull request #11768:
URL: https://github.com/apache/beam/pull/11768#issuecomment-631812306
R: @youngoli
This is an automated message from the Apache Git Service.
To respond to the message, please log
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428385521
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/translators/functions/AssignWindowsFunction.java
##
@@ -0,0 +1,119 @@
+/*
tweise commented on pull request #11722:
URL: https://github.com/apache/beam/pull/11722#issuecomment-631811467
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428384829
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/package-info.java
##
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428384075
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2StreamTranslationContext.java
##
@@ -0,0 +1,21 @@
+/*
+ * Licensed
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428381476
##
File path: runners/twister2/build.gradle
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
pabloem merged pull request #11339:
URL: https://github.com/apache/beam/pull/11339
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lostluck opened a new pull request #11768:
URL: https://github.com/apache/beam/pull/11768
The closed reader check, in it's current position prevents the "normal
teardown" that the reader expects. This means that readers for instructions
that terminate early such as due to splitting stay
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428380317
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2LegacyRunner.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631805319
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428378347
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2PipelineOptions.java
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the
apilloud commented on a change in pull request #11682:
URL: https://github.com/apache/beam/pull/11682#discussion_r428371418
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Partition.java
##
@@ -124,21 +190,26 @@ private Partition(PartitionDoFn
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428376950
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2PipelineOptions.java
##
@@ -0,0 +1,93 @@
+/*
+ * Licensed to the
lukecwik commented on pull request #11746:
URL: https://github.com/apache/beam/pull/11746#issuecomment-631800147
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
boyuanzz merged pull request #11715:
URL: https://github.com/apache/beam/pull/11715
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
boyuanzz commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-631794981
Thanks for your help!
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-631794665
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-631792217
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem merged pull request #11762:
URL: https://github.com/apache/beam/pull/11762
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #11762:
URL: https://github.com/apache/beam/pull/11762#issuecomment-631791451
thanks @epicfaace !
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia merged pull request #11724:
URL: https://github.com/apache/beam/pull/11724
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
TheNeuralBit commented on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-631789673
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631786516
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit merged pull request #11701:
URL: https://github.com/apache/beam/pull/11701
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jkff commented on a change in pull request #11406:
URL: https://github.com/apache/beam/pull/11406#discussion_r428356257
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Reshuffle.java
##
@@ -107,10 +108,57 @@ public void processElement(
/**
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631782829
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
ibzib commented on pull request #11755:
URL: https://github.com/apache/beam/pull/11755#issuecomment-631781814
> > This looks pretty neat. We could maybe specialize this for some
particular common cases. I found myself many times requiring to run something
like "Run All Spark Runners
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631778141
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631777614
are we able to run post commit?
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631776883
It looks like Dataflow VR tests are going to fail:
```
15:10:31 org.apache.beam.sdk.transforms.join.CoGroupByKeyTest >
testCoGroupByKeyWithWindowing FAILED
15:10:31
TheNeuralBit commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631773038
That definitely seems like a flake to me
This is an automated message from the Apache Git Service.
To
tysonjh commented on a change in pull request #11331:
URL: https://github.com/apache/beam/pull/11331#discussion_r428351403
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/AnnotateImages.java
##
@@ -0,0 +1,209 @@
+/*
+ * Licensed to the
jaketf commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-631768508
Seems pre-commit is stuck reporting back to github.
There's one unrelated test that failed
ibzib commented on pull request #11755:
URL: https://github.com/apache/beam/pull/11755#issuecomment-631766935
> This looks pretty neat. We could maybe specialize this for some particular
common cases. I found myself many times requiring to run something like "Run
All Spark Runners
ibzib commented on pull request #11764:
URL: https://github.com/apache/beam/pull/11764#issuecomment-631766210
> Will take a look once this PR becomes stable. (Seems still evolving).
I'm done with it for now sorry for the churn
amaliujia commented on pull request #11764:
URL: https://github.com/apache/beam/pull/11764#issuecomment-631764165
Will take a look once this PR becomes stable. (Seems still evolving).
This is an automated message from the
boyuanzz commented on a change in pull request #11715:
URL: https://github.com/apache/beam/pull/11715#discussion_r428343813
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/OffsetRangeTracker.java
##
@@ -120,13 +136,27 @@ public String
boyuanzz commented on a change in pull request #11715:
URL: https://github.com/apache/beam/pull/11715#discussion_r428343752
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTracker.java
##
@@ -0,0 +1,143 @@
+/*
+ *
iemejia commented on pull request #11755:
URL: https://github.com/apache/beam/pull/11755#issuecomment-631761505
This looks pretty neat. We could maybe specialize this for some particular
common cases. I found myself many times requiring to run something like "Run
All Spark Runners
TheNeuralBit commented on pull request #11701:
URL: https://github.com/apache/beam/pull/11701#issuecomment-631760558
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #11762:
URL: https://github.com/apache/beam/pull/11762#issuecomment-631758390
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
reuvenlax opened a new pull request #11767:
URL: https://github.com/apache/beam/pull/11767
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
pulasthi commented on a change in pull request #10888:
URL: https://github.com/apache/beam/pull/10888#discussion_r428335678
##
File path:
runners/twister2/src/main/java/org/apache/beam/runners/twister2/Twister2LegacyRunner.java
##
@@ -0,0 +1,339 @@
+/*
+ * Licensed to the
HuangLED commented on a change in pull request #11746:
URL: https://github.com/apache/beam/pull/11746#discussion_r428333755
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/StateBackedIterable.java
##
@@ -0,0 +1,223 @@
+/*
+ * Licensed to the
TheNeuralBit edited a comment on pull request #11701:
URL: https://github.com/apache/beam/pull/11701#issuecomment-631751672
Python PreCommit failure is a flake due to
https://issues.apache.org/jira/browse/BEAM-9975
This is
TheNeuralBit commented on pull request #11701:
URL: https://github.com/apache/beam/pull/11701#issuecomment-631751672
Python PreCommit failure is due to
https://issues.apache.org/jira/browse/BEAM-9975
This is an automated
TheNeuralBit commented on pull request #11754:
URL: https://github.com/apache/beam/pull/11754#issuecomment-631750861
I'm going to go ahead and merge since CI failure is unrelated
This is an automated message from the Apache
TheNeuralBit merged pull request #11754:
URL: https://github.com/apache/beam/pull/11754
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TheNeuralBit merged pull request #11575:
URL: https://github.com/apache/beam/pull/11575
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
robertwb opened a new pull request #11766:
URL: https://github.com/apache/beam/pull/11766
Also adds (naive) dataframe.agg() that uses this.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and
rohdesamuel opened a new pull request #11765:
URL: https://github.com/apache/beam/pull/11765
Change-Id: I8c2d660b175442d1917fe2b1ae166c0f4a1caaca
This turns "passthrough_pcollection_output_ids" and
"force_generated_pcollection_output_ids" to True by default.
ibzib merged pull request #11755:
URL: https://github.com/apache/beam/pull/11755
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
TheNeuralBit commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631748270
whoops
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TheNeuralBit commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631748120
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-631747496
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11651:
URL: https://github.com/apache/beam/pull/11651#issuecomment-631745259
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chamikaramj commented on pull request #11360:
URL: https://github.com/apache/beam/pull/11360#issuecomment-631745574
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
lostluck commented on a change in pull request #11763:
URL: https://github.com/apache/beam/pull/11763#discussion_r428305778
##
File path: sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange_test.go
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF)
chamikaramj commented on pull request #11757:
URL: https://github.com/apache/beam/pull/11757#issuecomment-631736712
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11757:
URL: https://github.com/apache/beam/pull/11757#issuecomment-631736587
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
ihji commented on a change in pull request #11757:
URL: https://github.com/apache/beam/pull/11757#discussion_r428314117
##
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##
@@ -314,8 +314,15 @@ def __init__(
if container_image_url in
rionmonster commented on pull request #11761:
URL: https://github.com/apache/beam/pull/11761#issuecomment-631728007
@henryken
I was able to successfully export the content of this course over to Stepik
and generate all of the expected new metadata associated with it (e.g.
lukecwik commented on a change in pull request #11715:
URL: https://github.com/apache/beam/pull/11715#discussion_r428304723
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTracker.java
##
@@ -0,0 +1,143 @@
+/*
+ *
1 - 100 of 256 matches
Mail list logo
