chamikaramj commented on pull request #12168:
URL: https://github.com/apache/beam/pull/12168#issuecomment-653358890
LGTM. Thanks Robert.
This is an automated message from the Apache Git Service.
To respond to the message,
codeBehindMe commented on pull request #12170:
URL: https://github.com/apache/beam/pull/12170#issuecomment-653358006
R: @lostluck
This is an automated message from the Apache Git Service.
To respond to the message, please
purbanow commented on pull request #12149:
URL: https://github.com/apache/beam/pull/12149#issuecomment-653357937
@chamikaramj sounds good to me :) Thanks
This is an automated message from the Apache Git Service.
To respond
codeBehindMe opened a new pull request #12170:
URL: https://github.com/apache/beam/pull/12170
The Go SDK uses errors returned by DoFns to signal failures to process
bundles, and terminate bundle processing. However, if the preceding DoFn uses
emitters, rather than error returns, the code
pabloem merged pull request #12158:
URL: https://github.com/apache/beam/pull/12158
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #12158:
URL: https://github.com/apache/beam/pull/12158#issuecomment-653322920
Thanks @ettirapp - this is a great start! : )
This is an automated message from the Apache Git Service.
To
pabloem removed a comment on pull request #12158:
URL: https://github.com/apache/beam/pull/12158#issuecomment-653322676
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the
kennknowles commented on pull request #12162:
URL: https://github.com/apache/beam/pull/12162#issuecomment-653295836
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
kennknowles edited a comment on pull request #12162:
URL: https://github.com/apache/beam/pull/12162#issuecomment-653252161
@TheNeuralBit I finally got to it.
This is an automated message from the Apache Git Service.
To
amaliujia closed pull request #12068:
URL: https://github.com/apache/beam/pull/12068
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
amaliujia commented on pull request #12169:
URL: https://github.com/apache/beam/pull/12169#issuecomment-653274247
R: @ibzib
This is an automated message from the Apache Git Service.
To respond to the message, please log on
amaliujia opened a new pull request #12169:
URL: https://github.com/apache/beam/pull/12169
This PR adds the support of
```
"CREATE TABLE FUNCTION CustomerRange(MinID INT64, MaxID INT64)\n"
" AS\n"
"SELECT *\n"
"FROM KeyValue\n"
"WHERE key >= MinId AND key <=
pabloem commented on pull request #12084:
URL: https://github.com/apache/beam/pull/12084#issuecomment-653268082
Run Python 2 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
robertwb commented on a change in pull request #12086:
URL: https://github.com/apache/beam/pull/12086#discussion_r449317183
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py
##
@@ -375,6 +375,8 @@ def get_all_side_inputs():
for o in
pabloem commented on pull request #12158:
URL: https://github.com/apache/beam/pull/12158#issuecomment-653267257
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb commented on pull request #12086:
URL: https://github.com/apache/beam/pull/12086#issuecomment-653267148
Could you clarify what the bug that you're trying to fix here is?
This is an automated message from the Apache
tvalentyn merged pull request #11709:
URL: https://github.com/apache/beam/pull/11709
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653260583
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
rjbordon commented on pull request #12148:
URL: https://github.com/apache/beam/pull/12148#issuecomment-653255800
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tvalentyn removed a comment on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653131533
Run Seed Job
This is an automated message from the Apache Git Service.
To respond to the message,
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653252897
Run Seed Job
This is an automated message from the Apache Git Service.
To respond to the message, please log
kennknowles commented on pull request #12162:
URL: https://github.com/apache/beam/pull/12162#issuecomment-653252161
@TheNeuralBit I finally got to it in my free time.
This is an automated message from the Apache Git Service.
tweise commented on a change in pull request #12133:
URL: https://github.com/apache/beam/pull/12133#discussion_r449298751
##
File path: sdks/python/apache_beam/transforms/sql.py
##
@@ -67,10 +66,9 @@ class SqlTransform(ExternalTransform):
"""
URN =
robertwb edited a comment on pull request #12168:
URL: https://github.com/apache/beam/pull/12168#issuecomment-653228545
(The high line count is just due to the file move; the content required no
editing. This is visible by looking at the commits individually.)
robertwb commented on pull request #12168:
URL: https://github.com/apache/beam/pull/12168#issuecomment-653228545
(The high line count is just due to the file move; the content required no
editing.)
This is an automated
robertwb commented on pull request #12168:
URL: https://github.com/apache/beam/pull/12168#issuecomment-653228312
R: @chamikaramj CC: @tvalentyn
This is an automated message from the Apache Git Service.
To respond to the
robertwb opened a new pull request #12168:
URL: https://github.com/apache/beam/pull/12168
It'd be good to get this into the next release before people start using it
(and we add a lot of documentation).
Stubs left in the old location for backwards compatibility.
kennknowles commented on a change in pull request #12162:
URL: https://github.com/apache/beam/pull/12162#discussion_r449273320
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricFiltering.java
##
@@ -19,6 +19,7 @@
import java.util.Set;
import
pabloem commented on pull request #12158:
URL: https://github.com/apache/beam/pull/12158#issuecomment-653225448
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
robertwb commented on a change in pull request #12133:
URL: https://github.com/apache/beam/pull/12133#discussion_r449266867
##
File path: sdks/python/apache_beam/transforms/sql.py
##
@@ -67,10 +66,9 @@ class SqlTransform(ExternalTransform):
"""
URN =
tvalentyn commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r449254651
##
File path: release/src/main/scripts/download_github_actions_artifacts.py
##
@@ -0,0 +1,234 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
tvalentyn commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r449254651
##
File path: release/src/main/scripts/download_github_actions_artifacts.py
##
@@ -0,0 +1,234 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
tvalentyn commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r449178144
##
File path: release/src/main/scripts/download_github_actions_artifacts.py
##
@@ -0,0 +1,234 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
jaketf commented on pull request #11959:
URL: https://github.com/apache/beam/pull/11959#issuecomment-653207804
ultimately we need to make sure
service-[project_number]@gcp-sa-healthcare.iam.gserviceaccount.com has Storage
Object Viewer on the buckets we are importing from.
jaketf edited a comment on pull request #11959:
URL: https://github.com/apache/beam/pull/11959#issuecomment-653188130
I was able to reproduce this failure.
It occurs when using the import method and [falling back to using the temp
jaketf commented on pull request #11959:
URL: https://github.com/apache/beam/pull/11959#issuecomment-653188130
I was able to reproduce this failure.
It occurs when using the import method and [falling back to using the temp
pabloem commented on pull request #12158:
URL: https://github.com/apache/beam/pull/12158#issuecomment-653182742
(that's a code phrase to run the tests)
This is an automated message from the Apache Git Service.
To respond to
pabloem commented on pull request #12158:
URL: https://github.com/apache/beam/pull/12158#issuecomment-653182672
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
jaketf commented on pull request #11959:
URL: https://github.com/apache/beam/pull/11959#issuecomment-653182234
My focus has been shifted to other customers.
Taking a look at why this test was failing now, will update this thread with
a commit to fix or findings.
amaliujia merged pull request #12052:
URL: https://github.com/apache/beam/pull/12052
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lostluck commented on pull request #12061:
URL: https://github.com/apache/beam/pull/12061#issuecomment-653175129
I'm fine with it either way for the reasons Robert (Bradshaw) describes.
Given that standard is the default for the actual go bigquery API,
defaulting to legacy would be
pabloem commented on pull request #12084:
URL: https://github.com/apache/beam/pull/12084#issuecomment-653168951
Run Python 3.5 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
robertwb commented on pull request #12061:
URL: https://github.com/apache/beam/pull/12061#issuecomment-653167957
(1) is not (yet) a concern for Go, but good (if unfortunate) point about
(2). Something that could mitigate this is to make it required.
On Thu, Jul 2, 2020 at 11:25 AM
bamnet commented on pull request #12061:
URL: https://github.com/apache/beam/pull/12061#issuecomment-653157515
I'm very new to Beam so don't have strong thoughts here, but two things jump
out:
1) It's a breaking change.
2) LegacySQL appears to be the default for Python and Java.
robertwb commented on pull request #12061:
URL: https://github.com/apache/beam/pull/12061#issuecomment-653150195
Given that Go is still experimental, any thoughts on switching the default
to non-legacy?
On Tue, Jun 23, 2020 at 5:31 PM Robert Burke
wrote:
>
lgajowy commented on a change in pull request #12117:
URL: https://github.com/apache/beam/pull/12117#discussion_r449152583
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java
##
@@ -155,7 +157,7 @@
* items.apply(
*
robertwb commented on pull request #12075:
URL: https://github.com/apache/beam/pull/12075#issuecomment-653147904
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
aromanenko-dev merged pull request #12131:
URL: https://github.com/apache/beam/pull/12131
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
tvalentyn edited a comment on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653132163
@kamilwu I anticipate that some of the postcommit tests may be failing,
possibly due to outdated IO libraries. If so, you could help identify, isolate
and investigate
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653132163
@kamilwu I anticipate that some of the postcommit tests may be failing,
possibly due to outdated IO libraries. If so, you could help identify, isolate
and investigate
tvalentyn commented on pull request #11788:
URL: https://github.com/apache/beam/pull/11788#issuecomment-653131533
Run Seed Job
This is an automated message from the Apache Git Service.
To respond to the message, please log
tvalentyn commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r449165261
##
File path: release/src/main/scripts/download_github_actions_artifacts.py
##
@@ -0,0 +1,231 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
tvalentyn commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r449160887
##
File path: release/src/main/scripts/build_release_candidate.sh
##
@@ -170,26 +174,50 @@ if [[ $confirmation = "y" ]]; then
git clone
kamilwu commented on pull request #12167:
URL: https://github.com/apache/beam/pull/12167#issuecomment-653117466
R: @Ardagan Will you find a moment to make a code review?
cc: @iemejia
This is an automated message from
kamilwu opened a new pull request #12167:
URL: https://github.com/apache/beam/pull/12167
The goal of these changes is to make the process of creating and modifying
Grafana dashboards easier by populating InfluxDB database with real data.
Two workflows have been implemented:
* a
lgajowy commented on pull request #12117:
URL: https://github.com/apache/beam/pull/12117#issuecomment-653116162
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
kamilwu commented on a change in pull request #12065:
URL: https://github.com/apache/beam/pull/12065#discussion_r449141423
##
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##
@@ -147,10 +151,18 @@ def process(self, element, state=state_param):
aromanenko-dev commented on a change in pull request #12131:
URL: https://github.com/apache/beam/pull/12131#discussion_r449112432
##
File path: sdks/java/io/amazon-web-services/build.gradle
##
@@ -18,8 +18,14 @@ import groovy.json.JsonOutput
* limitations under the License.
mxm commented on pull request #12137:
URL: https://github.com/apache/beam/pull/12137#issuecomment-653102269
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lazylynx commented on pull request #12115:
URL: https://github.com/apache/beam/pull/12115#issuecomment-653101559
@tvalentyn Updated. PTAL when tests are passed.
This is an automated message from the Apache Git Service.
To
lazylynx commented on a change in pull request #12115:
URL: https://github.com/apache/beam/pull/12115#discussion_r449128227
##
File path: sdks/python/container/boot.go
##
@@ -127,6 +129,10 @@ func main() {
// Guard from concurrent artifact retrieval and installation,
lazylynx commented on a change in pull request #12115:
URL: https://github.com/apache/beam/pull/12115#discussion_r449126596
##
File path: sdks/python/container/boot.go
##
@@ -170,6 +176,28 @@ func main() {
log.Fatalf("Python exited: %v", execx.Execute("python",
mxm merged pull request #12148:
URL: https://github.com/apache/beam/pull/12148
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
aromanenko-dev commented on a change in pull request #12063:
URL: https://github.com/apache/beam/pull/12063#discussion_r449044147
##
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/metrics/MetricsAccumulator.java
##
@@ -58,13 +57,13 @@ public static void
aromanenko-dev commented on a change in pull request #12063:
URL: https://github.com/apache/beam/pull/12063#discussion_r449044147
##
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/metrics/MetricsAccumulator.java
##
@@ -58,13 +57,13 @@ public static void
aromanenko-dev commented on a change in pull request #12063:
URL: https://github.com/apache/beam/pull/12063#discussion_r449044147
##
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/metrics/MetricsAccumulator.java
##
@@ -58,13 +57,13 @@ public static void
aromanenko-dev commented on a change in pull request #12063:
URL: https://github.com/apache/beam/pull/12063#discussion_r449044147
##
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/metrics/MetricsAccumulator.java
##
@@ -58,13 +57,13 @@ public static void
aromanenko-dev commented on pull request #12063:
URL: https://github.com/apache/beam/pull/12063#issuecomment-653015794
Run Spark ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the
aromanenko-dev commented on pull request #12063:
URL: https://github.com/apache/beam/pull/12063#issuecomment-653014984
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r448983103
##
File path: release/src/main/scripts/download_github_actions_artifacts.py
##
@@ -0,0 +1,231 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-652985646
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the
TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r448974933
##
File path: release/src/main/scripts/download_github_actions_artifacts.py
##
@@ -0,0 +1,231 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r448974075
##
File path: release/src/main/scripts/download_github_actions_artifacts.py
##
@@ -0,0 +1,231 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r448971722
##
File path: release/src/main/scripts/download_github_actions_artifacts.py
##
@@ -0,0 +1,231 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
TobKed opened a new pull request #12166:
URL: https://github.com/apache/beam/pull/12166
We need to Cancel builds to PR too.
similar change in Apache Airflow
https://github.com/apache/airflow/pull/9513
Thank you for your contribution! Follow
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-652972556
Run PythonFormatter PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
mxm commented on pull request #12065:
URL: https://github.com/apache/beam/pull/12065#issuecomment-652972679
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log
kamilwu commented on pull request #12146:
URL: https://github.com/apache/beam/pull/12146#issuecomment-652950416
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r448928301
##
File path: release/src/main/scripts/build_release_candidate.sh
##
@@ -170,26 +174,50 @@ if [[ $confirmation = "y" ]]; then
git clone ${GIT_REPO_URL}
TobKed commented on a change in pull request #12049:
URL: https://github.com/apache/beam/pull/12049#discussion_r448909493
##
File path: .github/workflows/clear_staging_bucket.yml
##
@@ -0,0 +1,67 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
lgajowy commented on pull request #12117:
URL: https://github.com/apache/beam/pull/12117#issuecomment-652925396
@purbanow I will try to take a look at that today or tomorrow. If I won't
leave a review by then, please try to ping somebody else (that will mean that I
did not have enough
ihji commented on pull request #12165:
URL: https://github.com/apache/beam/pull/12165#issuecomment-652921247
R: @aaltay
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ihji opened a new pull request #12165:
URL: https://github.com/apache/beam/pull/12165
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
kamilwu commented on pull request #12146:
URL: https://github.com/apache/beam/pull/12146#issuecomment-652890299
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
mxm commented on a change in pull request #12133:
URL: https://github.com/apache/beam/pull/12133#discussion_r448859883
##
File path: sdks/python/apache_beam/transforms/sql.py
##
@@ -67,10 +66,9 @@ class SqlTransform(ExternalTransform):
"""
URN =
ihji opened a new pull request #12164:
URL: https://github.com/apache/beam/pull/12164
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
kkucharc commented on pull request #12151:
URL: https://github.com/apache/beam/pull/12151#issuecomment-652863614
@pabloem would you find time to take a look? Or maybe you can suggest
someone? (Java PreCommit is failing is not connected with those changes.)
je-ik commented on pull request #12155:
URL: https://github.com/apache/beam/pull/12155#issuecomment-652846468
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log
stale[bot] commented on pull request #11589:
URL: https://github.com/apache/beam/pull/11589#issuecomment-652832568
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
robinyqiu opened a new pull request #12163:
URL: https://github.com/apache/beam/pull/12163
Enable setting default timezone option on ZetaSQL analyzer. Default timezone
is used both at
- query analysis time (e.g. `CAST` literal to `TIMESTAMP`), and
- expression execution time (e.g.
90 matches
Mail list logo
