[GitHub] [beam] codecov[bot] edited a comment on pull request #12748: [BEAM-8715] update avro - extract avro to it's own module [WIP]

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12748: URL: https://github.com/apache/beam/pull/12748#issuecomment-684999675 # [Codecov](https://codecov.io/gh/apache/beam/pull/12748?src=pr&el=h1) Report > Merging [#12748](https://codecov.io/gh/apache/beam/pull/12748?src=pr&el=desc) into

[GitHub] [beam] piotr-szuberski commented on pull request #12780: [WIP] [BEAM-10857] Add Pubsub Avro table provider

2020-09-08 Thread GitBox
piotr-szuberski commented on pull request #12780: URL: https://github.com/apache/beam/pull/12780#issuecomment-689347328 Run SQL PostCommit This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] ihji merged pull request #12754: [BEAM-10791] Identify and log additional information needed to debug …

2020-09-08 Thread GitBox
ihji merged pull request #12754: URL: https://github.com/apache/beam/pull/12754 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] ihji commented on pull request #12754: [BEAM-10791] Identify and log additional information needed to debug …

2020-09-08 Thread GitBox
ihji commented on pull request #12754: URL: https://github.com/apache/beam/pull/12754#issuecomment-689342339 > Please address the test coverage warnings I inspected the warnings and confirmed that most of them are false alarms (there are tests covering the lines detected by codecov).

[GitHub] [beam] codecov[bot] edited a comment on pull request #12748: [BEAM-8715] update avro - extract avro to it's own module [WIP]

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12748: URL: https://github.com/apache/beam/pull/12748#issuecomment-684999675 # [Codecov](https://codecov.io/gh/apache/beam/pull/12748?src=pr&el=h1) Report > Merging [#12748](https://codecov.io/gh/apache/beam/pull/12748?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12748: [BEAM-8715] update avro - extract avro to it's own module [WIP]

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12748: URL: https://github.com/apache/beam/pull/12748#issuecomment-684999675 # [Codecov](https://codecov.io/gh/apache/beam/pull/12748?src=pr&el=h1) Report > Merging [#12748](https://codecov.io/gh/apache/beam/pull/12748?src=pr&el=desc) into

[GitHub] [beam] youngoli opened a new pull request #12792: [DO NOT MERGE] Run Python RC Validation Tests

2020-09-08 Thread GitBox
youngoli opened a new pull request #12792: URL: https://github.com/apache/beam/pull/12792 Run Python ReleaseCandidate This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-08 Thread GitBox
piotr-szuberski commented on a change in pull request #12758: URL: https://github.com/apache/beam/pull/12758#discussion_r485361661 ## File path: CHANGES.md ## @@ -100,6 +101,8 @@ * Support for X source added (Java/Python) ([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X

[GitHub] [beam] boyuanzz commented on pull request #12791: [BEAM-10863] Change encoding of Pubsub sink to global window.

2020-09-08 Thread GitBox
boyuanzz commented on pull request #12791: URL: https://github.com/apache/beam/pull/12791#issuecomment-689264804 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] chamikaramj commented on pull request #12791: [BEAM-10863] Change encoding of Pubsub sink to global window.

2020-09-08 Thread GitBox
chamikaramj commented on pull request #12791: URL: https://github.com/apache/beam/pull/12791#issuecomment-689264412 LGTM. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] epicfaace commented on pull request #12779: [BEAM-10856] Support for NestedValueProvider for Python SDK

2020-09-08 Thread GitBox
epicfaace commented on pull request #12779: URL: https://github.com/apache/beam/pull/12779#issuecomment-689251584 By the way, how do you normally lint your code according to the Beam guidelines / PR checks? I couldn't find any guidance / a quick reference in the Beam development guide on h

[GitHub] [beam] epicfaace commented on pull request #12779: [BEAM-10856] Support for NestedValueProvider for Python SDK

2020-09-08 Thread GitBox
epicfaace commented on pull request #12779: URL: https://github.com/apache/beam/pull/12779#issuecomment-689250939 Thanks for the heads up @pabloem . @tvalentyn , would you be able to review? This is an automated message from

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-08 Thread GitBox
Hannah-Jiang commented on a change in pull request #12756: URL: https://github.com/apache/beam/pull/12756#discussion_r485276327 ## File path: sdks/python/apache_beam/transforms/stats_test.py ## @@ -41,13 +40,15 @@ from apache_beam.transforms.display import DisplayData from ap

[GitHub] [beam] boyuanzz opened a new pull request #12791: [BEAM-10863] Change encoding of Pubsub sink to global window.

2020-09-08 Thread GitBox
boyuanzz opened a new pull request #12791: URL: https://github.com/apache/beam/pull/12791 r: @chamikaramj Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] codecov[bot] edited a comment on pull request #12790: [BEAM-10862] Handle empty tfrecord files within a glob

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12790: URL: https://github.com/apache/beam/pull/12790#issuecomment-689221038 # [Codecov](https://codecov.io/gh/apache/beam/pull/12790?src=pr&el=h1) Report > Merging [#12790](https://codecov.io/gh/apache/beam/pull/12790?src=pr&el=desc) into

[GitHub] [beam] aaltay merged pull request #12789: Support updating from a job in DRAINING state

2020-09-08 Thread GitBox
aaltay merged pull request #12789: URL: https://github.com/apache/beam/pull/12789 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [beam] aaltay commented on a change in pull request #12789: Support updating from a job in DRAINING state

2020-09-08 Thread GitBox
aaltay commented on a change in pull request #12789: URL: https://github.com/apache/beam/pull/12789#discussion_r485271686 ## File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py ## @@ -923,8 +923,9 @@ def job_id_for_name(self, job_name): pageToke

[GitHub] [beam] aaltay commented on a change in pull request #12789: Support updating from a job in DRAINING state

2020-09-08 Thread GitBox
aaltay commented on a change in pull request #12789: URL: https://github.com/apache/beam/pull/12789#discussion_r485271282 ## File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py ## @@ -923,8 +923,9 @@ def job_id_for_name(self, job_name): pageToke

[GitHub] [beam] cghawthorne commented on pull request #12790: [BEAM-10862] Handle empty tfrecord files within a glob

2020-09-08 Thread GitBox
cghawthorne commented on pull request #12790: URL: https://github.com/apache/beam/pull/12790#issuecomment-689227722 I think the macos python test failures are unrelated to my changes, but let me know if I've missed anything there. --

[GitHub] [beam] codecov[bot] edited a comment on pull request #12790: [BEAM-10862] Handle empty tfrecord files within a glob

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12790: URL: https://github.com/apache/beam/pull/12790#issuecomment-689221038 # [Codecov](https://codecov.io/gh/apache/beam/pull/12790?src=pr&el=h1) Report > Merging [#12790](https://codecov.io/gh/apache/beam/pull/12790?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12790: [BEAM-10862] Handle empty tfrecord files within a glob

2020-09-08 Thread GitBox
codecov[bot] commented on pull request #12790: URL: https://github.com/apache/beam/pull/12790#issuecomment-689221038 # [Codecov](https://codecov.io/gh/apache/beam/pull/12790?src=pr&el=h1) Report > Merging [#12790](https://codecov.io/gh/apache/beam/pull/12790?src=pr&el=desc) into [master

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485264309 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -194,6 +204,10 @@ public static ReadFiles readFiles

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485264174 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -299,9 +344,14 @@ public ReadFiles withSplit() {

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485264135 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -135,6 +135,16 @@ * ... * } * + * Reading wit

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485262811 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -336,36 +388,41 @@ public void processElement(

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485260498 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -336,36 +388,41 @@ public void processElement(

[GitHub] [beam] cghawthorne commented on pull request #12790: [BEAM-10862] Handle empty tfrecord files within a glob

2020-09-08 Thread GitBox
cghawthorne commented on pull request #12790: URL: https://github.com/apache/beam/pull/12790#issuecomment-689200734 R: @chamikaramj This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] cghawthorne opened a new pull request #12790: [BEAM-10862] Handle empty tfrecord files within a glob

2020-09-08 Thread GitBox
cghawthorne opened a new pull request #12790: URL: https://github.com/apache/beam/pull/12790 Handle empty TFRecord file within a glob. Same as #, but I actually narrowed down the cause and included a unit test this time! Thank you for your c

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485260498 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -336,36 +388,41 @@ public void processElement(

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485260306 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -336,36 +388,41 @@ public void processElement(

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485260041 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -312,12 +362,14 @@ public ReadFiles withSplit() {

[GitHub] [beam] robertwb commented on a change in pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-08 Thread GitBox
robertwb commented on a change in pull request #12787: URL: https://github.com/apache/beam/pull/12787#discussion_r485239407 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@ -704,6 +705,64 @@ def fix_side_input_pcoll_coders(stages, p

[GitHub] [beam] ihji commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
ihji commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485238785 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -135,6 +135,16 @@ * ... * } * + * Reading with pro

[GitHub] [beam] edre commented on a change in pull request #12789: Support updating from a job in DRAINING state

2020-09-08 Thread GitBox
edre commented on a change in pull request #12789: URL: https://github.com/apache/beam/pull/12789#discussion_r485257231 ## File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py ## @@ -923,8 +923,9 @@ def job_id_for_name(self, job_name): pageToken=

[GitHub] [beam] codecov[bot] edited a comment on pull request #12789: Support updating from a job in DRAINING state

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12789: URL: https://github.com/apache/beam/pull/12789#issuecomment-689189325 # [Codecov](https://codecov.io/gh/apache/beam/pull/12789?src=pr&el=h1) Report > Merging [#12789](https://codecov.io/gh/apache/beam/pull/12789?src=pr&el=desc) into

[GitHub] [beam] lostluck commented on pull request #12789: Support updating from a job in DRAINING state

2020-09-08 Thread GitBox
lostluck commented on pull request #12789: URL: https://github.com/apache/beam/pull/12789#issuecomment-689194131 > /cc - @lostluck - How are updates handled in Go SDK? Currently Google Cloud Dataflow doesn't officially support use of the Apache Beam Go SDK, and no testing of such fea

[GitHub] [beam] codecov[bot] edited a comment on pull request #12789: Support updating from a job in DRAINING state

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12789: URL: https://github.com/apache/beam/pull/12789#issuecomment-689189325 # [Codecov](https://codecov.io/gh/apache/beam/pull/12789?src=pr&el=h1) Report > Merging [#12789](https://codecov.io/gh/apache/beam/pull/12789?src=pr&el=desc) into

[GitHub] [beam] aaltay commented on a change in pull request #12789: Support updating from a job in DRAINING state

2020-09-08 Thread GitBox
aaltay commented on a change in pull request #12789: URL: https://github.com/apache/beam/pull/12789#discussion_r485251184 ## File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py ## @@ -923,8 +923,9 @@ def job_id_for_name(self, job_name): pageToke

[GitHub] [beam] codecov[bot] commented on pull request #12789: Support updating from a job in DRAINING state

2020-09-08 Thread GitBox
codecov[bot] commented on pull request #12789: URL: https://github.com/apache/beam/pull/12789#issuecomment-689189325 # [Codecov](https://codecov.io/gh/apache/beam/pull/12789?src=pr&el=h1) Report > Merging [#12789](https://codecov.io/gh/apache/beam/pull/12789?src=pr&el=desc) into [master

[GitHub] [beam] edre opened a new pull request #12789: Support updating from a job in DRAINING state

2020-09-08 Thread GitBox
edre opened a new pull request #12789: URL: https://github.com/apache/beam/pull/12789 Java translates RUNNING and DRAINING to an internal Running state, so just have python check against both. Thank you for your contribution! Follow this checklist to h

[GitHub] [beam] codecov[bot] edited a comment on pull request #12709: add more options and monitoring to nexmark launcher

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12709: URL: https://github.com/apache/beam/pull/12709#issuecomment-682247488 # [Codecov](https://codecov.io/gh/apache/beam/pull/12709?src=pr&el=h1) Report > Merging [#12709](https://codecov.io/gh/apache/beam/pull/12709?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12709: add more options and monitoring to nexmark launcher

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12709: URL: https://github.com/apache/beam/pull/12709#issuecomment-682247488 # [Codecov](https://codecov.io/gh/apache/beam/pull/12709?src=pr&el=h1) Report > Merging [#12709](https://codecov.io/gh/apache/beam/pull/12709?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12709: add more options and monitoring to nexmark launcher

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12709: URL: https://github.com/apache/beam/pull/12709#issuecomment-682247488 # [Codecov](https://codecov.io/gh/apache/beam/pull/12709?src=pr&el=h1) Report > Merging [#12709](https://codecov.io/gh/apache/beam/pull/12709?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12788: [BEAM-8893] Fix issues with state and multiple workers.

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12788: URL: https://github.com/apache/beam/pull/12788#issuecomment-689163543 # [Codecov](https://codecov.io/gh/apache/beam/pull/12788?src=pr&el=h1) Report > Merging [#12788](https://codecov.io/gh/apache/beam/pull/12788?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12788: [BEAM-8893] Fix issues with state and multiple workers.

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12788: URL: https://github.com/apache/beam/pull/12788#issuecomment-689163543 # [Codecov](https://codecov.io/gh/apache/beam/pull/12788?src=pr&el=h1) Report > Merging [#12788](https://codecov.io/gh/apache/beam/pull/12788?src=pr&el=desc) into

[GitHub] [beam] chamikaramj merged pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-09-08 Thread GitBox
chamikaramj merged pull request #12655: URL: https://github.com/apache/beam/pull/12655 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] codecov[bot] commented on pull request #12788: [BEAM-8893] Fix issues with state and multiple workers.

2020-09-08 Thread GitBox
codecov[bot] commented on pull request #12788: URL: https://github.com/apache/beam/pull/12788#issuecomment-689163543 # [Codecov](https://codecov.io/gh/apache/beam/pull/12788?src=pr&el=h1) Report > Merging [#12788](https://codecov.io/gh/apache/beam/pull/12788?src=pr&el=desc) into [master

[GitHub] [beam] tvalentyn commented on a change in pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-08 Thread GitBox
tvalentyn commented on a change in pull request #12756: URL: https://github.com/apache/beam/pull/12756#discussion_r485223986 ## File path: sdks/python/apache_beam/transforms/stats_test.py ## @@ -41,13 +40,15 @@ from apache_beam.transforms.display import DisplayData from apach

[GitHub] [beam] robertwb commented on pull request #12788: [BEAM-8893] Fix issues with state and multiple workers.

2020-09-08 Thread GitBox
robertwb commented on pull request #12788: URL: https://github.com/apache/beam/pull/12788#issuecomment-689160275 R: @chamikaramj This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] pabloem merged pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-09-08 Thread GitBox
pabloem merged pull request #12703: URL: https://github.com/apache/beam/pull/12703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] tvalentyn commented on a change in pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-08 Thread GitBox
tvalentyn commented on a change in pull request #12756: URL: https://github.com/apache/beam/pull/12756#discussion_r485218862 ## File path: sdks/python/apache_beam/transforms/stats.py ## @@ -46,6 +57,35 @@ V = typing.TypeVar('V') +def _default_hash_fn(value): + """Hash val

[GitHub] [beam] pabloem commented on pull request #12771: Change setup.py command to only write files to the /tmp dir instead of the current dir

2020-09-08 Thread GitBox
pabloem commented on pull request #12771: URL: https://github.com/apache/beam/pull/12771#issuecomment-689159733 alright, thanks for looking into it anyway! This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] ohnorobo closed pull request #12771: Change setup.py command to only write files to the /tmp dir instead of the current dir

2020-09-08 Thread GitBox
ohnorobo closed pull request #12771: URL: https://github.com/apache/beam/pull/12771 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] yifanmai commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-09-08 Thread GitBox
yifanmai commented on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-689157858 Precommits (besides codecov) look good. This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] yifanmai commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-08 Thread GitBox
yifanmai commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-689157882 Precommits (besides codecov) look good. This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] ohnorobo commented on pull request #12771: Change setup.py command to only write files to the /tmp dir instead of the current dir

2020-09-08 Thread GitBox
ohnorobo commented on pull request #12771: URL: https://github.com/apache/beam/pull/12771#issuecomment-689158008 I've looked into this some more and it turns out sdist unavoidably still writes some other files to ./ Given that fact I don't think this PR really improves anything and I

[GitHub] [beam] robertwb opened a new pull request #12788: [BEAM-8893] Fix issues with state and multiple workers.

2020-09-08 Thread GitBox
robertwb opened a new pull request #12788: URL: https://github.com/apache/beam/pull/12788 Also avoid worker pool when there is no actual parallelism. Thank you for your contribution! Follow this checklist to help us incorporate your contribution qu

[GitHub] [beam] codecov[bot] edited a comment on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-683610461 # [Codecov](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=h1) Report > Merging [#12655](https://codecov.io/gh/apache/beam/pull/12655?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=desc) into

[GitHub] [beam] udim commented on pull request #12739: [BEAM-10840] Don't run code coverage on microbenchmarks

2020-09-08 Thread GitBox
udim commented on pull request #12739: URL: https://github.com/apache/beam/pull/12739#issuecomment-689124061 I was out all last week. Thanks Robert! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr&el=desc) into

[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-09-08 Thread GitBox
terryxian78 commented on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-689122663 > Usual wait period for votes is three business days so we can do the same here. > > BTW @nielm mentioned that he create a bug in the Spanner side for updating the API

[GitHub] [beam] yifanmai commented on pull request #12655: [BEAM-10779] Support multiple main inputs and side inputs for PTransformOverride

2020-09-08 Thread GitBox
yifanmai commented on pull request #12655: URL: https://github.com/apache/beam/pull/12655#issuecomment-689120923 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] danielxjd commented on pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on pull request #12786: URL: https://github.com/apache/beam/pull/12786#issuecomment-689118928 R:@ihji R:@chamikaramj This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] codecov[bot] edited a comment on pull request #12776: [BEAM-9456] Upgrade Gradle to 6.6.1 (smaller version of #12568)

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12776: URL: https://github.com/apache/beam/pull/12776#issuecomment-686895323 # [Codecov](https://codecov.io/gh/apache/beam/pull/12776?src=pr&el=h1) Report > Merging [#12776](https://codecov.io/gh/apache/beam/pull/12776?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12787: URL: https://github.com/apache/beam/pull/12787#issuecomment-689105076 # [Codecov](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=h1) Report > Merging [#12787](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12776: [BEAM-9456] Upgrade Gradle to 6.6.1 (smaller version of #12568)

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12776: URL: https://github.com/apache/beam/pull/12776#issuecomment-686895323 # [Codecov](https://codecov.io/gh/apache/beam/pull/12776?src=pr&el=h1) Report > Merging [#12776](https://codecov.io/gh/apache/beam/pull/12776?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12787: URL: https://github.com/apache/beam/pull/12787#issuecomment-689105076 # [Codecov](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=h1) Report > Merging [#12787](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12787: URL: https://github.com/apache/beam/pull/12787#issuecomment-689105076 # [Codecov](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=h1) Report > Merging [#12787](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-08 Thread GitBox
codecov[bot] commented on pull request #12787: URL: https://github.com/apache/beam/pull/12787#issuecomment-689105076 # [Codecov](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=h1) Report > Merging [#12787](https://codecov.io/gh/apache/beam/pull/12787?src=pr&el=desc) into [master

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into

[GitHub] [beam] yifanmai commented on pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-08 Thread GitBox
yifanmai commented on pull request #12787: URL: https://github.com/apache/beam/pull/12787#issuecomment-689094984 R: @robertwb This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] yifanmai opened a new pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-08 Thread GitBox
yifanmai opened a new pull request #12787: URL: https://github.com/apache/beam/pull/12787 If multiple `KeyWithNone` stages share a common input, then all but one stages will be eliminated along with their output `PCollection`s. Transforms that originally read input from the output `PCollec

[GitHub] [beam] kennknowles commented on pull request #12776: [BEAM-9456] Upgrade Gradle to 6.6.1 (smaller version of #12568)

2020-09-08 Thread GitBox
kennknowles commented on pull request #12776: URL: https://github.com/apache/beam/pull/12776#issuecomment-689094007 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [beam] kennknowles commented on pull request #12776: [BEAM-9456] Upgrade Gradle to 6.6.1 (smaller version of #12568)

2020-09-08 Thread GitBox
kennknowles commented on pull request #12776: URL: https://github.com/apache/beam/pull/12776#issuecomment-689093437 (that one, https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/13427/, looked like a flake) This is an

[GitHub] [beam] danielxjd commented on pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on pull request #12786: URL: https://github.com/apache/beam/pull/12786#issuecomment-689089962 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=desc) into

[GitHub] [beam] kennknowles commented on pull request #12776: [BEAM-9456] Upgrade Gradle to 6.6.1 (smaller version of #12568)

2020-09-08 Thread GitBox
kennknowles commented on pull request #12776: URL: https://github.com/apache/beam/pull/12776#issuecomment-689083553 run java precommit This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] codecov[bot] edited a comment on pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12770: URL: https://github.com/apache/beam/pull/12770#issuecomment-686768654 # [Codecov](https://codecov.io/gh/apache/beam/pull/12770?src=pr&el=h1) Report > Merging [#12770](https://codecov.io/gh/apache/beam/pull/12770?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into

[GitHub] [beam] prodonjs commented on a change in pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-08 Thread GitBox
prodonjs commented on a change in pull request #12770: URL: https://github.com/apache/beam/pull/12770#discussion_r485129135 ## File path: sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/SidePanel.ts ## @@ -0,0 +1,120 @@ +// Licensed

[GitHub] [beam] codecov[bot] edited a comment on pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12770: URL: https://github.com/apache/beam/pull/12770#issuecomment-686768654 # [Codecov](https://codecov.io/gh/apache/beam/pull/12770?src=pr&el=h1) Report > Merging [#12770](https://codecov.io/gh/apache/beam/pull/12770?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689053328 # [Codecov](https://codecov.io/gh/apache/beam/pull/12760?src=pr&el=h1) Report > Merging [#12760](https://codecov.io/gh/apache/beam/pull/12760?src=pr&el=desc) into

[GitHub] [beam] monicadsong commented on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-08 Thread GitBox
monicadsong commented on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-689070359 Run Portable_Python PreCommit This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [beam] danielxjd opened a new pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd opened a new pull request #12786: URL: https://github.com/apache/beam/pull/12786 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quic

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into

[GitHub] [beam] leiyiz commented on a change in pull request #12709: add more options and monitoring to nexmark launcher

2020-09-08 Thread GitBox
leiyiz commented on a change in pull request #12709: URL: https://github.com/apache/beam/pull/12709#discussion_r485125023 ## File path: sdks/python/apache_beam/testing/benchmarks/nexmark/nexmark_launcher.py ## @@ -200,46 +223,126 @@ def generate_events(self): logging.in

[GitHub] [beam] codecov[bot] edited a comment on pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12770: URL: https://github.com/apache/beam/pull/12770#issuecomment-686768654 # [Codecov](https://codecov.io/gh/apache/beam/pull/12770?src=pr&el=h1) Report > Merging [#12770](https://codecov.io/gh/apache/beam/pull/12770?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12703: URL: https://github.com/apache/beam/pull/12703#issuecomment-684004590 # [Codecov](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=h1) Report > Merging [#12703](https://codecov.io/gh/apache/beam/pull/12703?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689053328 # [Codecov](https://codecov.io/gh/apache/beam/pull/12760?src=pr&el=h1) Report > Merging [#12760](https://codecov.io/gh/apache/beam/pull/12760?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12704: [BEAM-10603] Implement the new Large Source Recording API.

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12704: URL: https://github.com/apache/beam/pull/12704#issuecomment-689048887 # [Codecov](https://codecov.io/gh/apache/beam/pull/12704?src=pr&el=h1) Report > Merging [#12704](https://codecov.io/gh/apache/beam/pull/12704?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-08 Thread GitBox
codecov[bot] commented on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689053328 # [Codecov](https://codecov.io/gh/apache/beam/pull/12760?src=pr&el=h1) Report > Merging [#12760](https://codecov.io/gh/apache/beam/pull/12760?src=pr&el=desc) into [master

[GitHub] [beam] codecov[bot] edited a comment on pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12770: URL: https://github.com/apache/beam/pull/12770#issuecomment-686768654 # [Codecov](https://codecov.io/gh/apache/beam/pull/12770?src=pr&el=h1) Report > Merging [#12770](https://codecov.io/gh/apache/beam/pull/12770?src=pr&el=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-08 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr&el=desc) into

[GitHub] [beam] rohdesamuel commented on a change in pull request #12703: [BEAM-10603] Add describe and cancel to RecordingManager

2020-09-08 Thread GitBox
rohdesamuel commented on a change in pull request #12703: URL: https://github.com/apache/beam/pull/12703#discussion_r485108295 ## File path: sdks/python/apache_beam/runners/interactive/recording_manager.py ## @@ -63,6 +63,12 @@ def var(self): """Returns the variable named

[GitHub] [beam] KevinGG commented on pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-08 Thread GitBox
KevinGG commented on pull request #12770: URL: https://github.com/apache/beam/pull/12770#issuecomment-689049573 R: @prodonjs PTAL, thx! This is an automated message from the Apache Git Service. To respond to the message, p

  1   2   3   >