[GitHub] [beam] mosche commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
mosche commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1055165450 ## sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/io/DynamicAvroDestinations.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [beam] mosche commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
mosche commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1055165037 ## sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/io/DynamicAvroDestinations.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [beam] mosche commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
mosche commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1055164683 ## sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/io/DynamicAvroDestinations.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [beam] Abacn commented on pull request #24633: Add Python xlang KafkaIO performance test

2022-12-21 Thread GitBox
Abacn commented on PR #24633: URL: https://github.com/apache/beam/pull/24633#issuecomment-1362418176 Run Python xlang KafkaIO Batch Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] Abacn commented on pull request #24633: Add Python xlang KafkaIO performance test

2022-12-21 Thread GitBox
Abacn commented on PR #24633: URL: https://github.com/apache/beam/pull/24633#issuecomment-1362417531 Run Java KafkaIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] Abacn commented on pull request #24633: Add Python xlang KafkaIO performance test

2022-12-21 Thread GitBox
Abacn commented on PR #24633: URL: https://github.com/apache/beam/pull/24633#issuecomment-1362412982 Run Python xlang KafkaIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] Abacn commented on pull request #24633: Add Python xlang KafkaIO performance test

2022-12-21 Thread GitBox
Abacn commented on PR #24633: URL: https://github.com/apache/beam/pull/24633#issuecomment-1362392720 run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [beam] Abacn merged pull request #24746: Fix a small wrong url link in notebook

2022-12-21 Thread GitBox
Abacn merged PR #24746: URL: https://github.com/apache/beam/pull/24746 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[GitHub] [beam] Abacn merged pull request #24753: Fix SingleStoreIO performance test job

2022-12-21 Thread GitBox
Abacn merged PR #24753: URL: https://github.com/apache/beam/pull/24753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[GitHub] [beam] Abacn closed issue #23299: [Feature Request]: AvroUtils.toAvroSchema supports a logicaltypes.Date type

2022-12-21 Thread GitBox
Abacn closed issue #23299: [Feature Request]: AvroUtils.toAvroSchema supports a logicaltypes.Date type URL: https://github.com/apache/beam/issues/23299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] Abacn merged pull request #24756: Support SqlTypes Date in AvroUtils

2022-12-21 Thread GitBox
Abacn merged PR #24756: URL: https://github.com/apache/beam/pull/24756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[GitHub] [beam] Abacn closed issue #24638: [Feature Request]: A more detailed logging with file deletion in filebasedsink

2022-12-21 Thread GitBox
Abacn closed issue #24638: [Feature Request]: A more detailed logging with file deletion in filebasedsink URL: https://github.com/apache/beam/issues/24638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] Abacn commented on issue #24638: [Feature Request]: A more detailed logging with file deletion in filebasedsink

2022-12-21 Thread GitBox
Abacn commented on issue #24638: URL: https://github.com/apache/beam/issues/24638#issuecomment-1362291536 Fixed by #24653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] Abacn commented on issue #24181: [Task]: Eliminate deprecated finalize method (overrides Object.finalize) throughout Java SDK

2022-12-21 Thread GitBox
Abacn commented on issue #24181: URL: https://github.com/apache/beam/issues/24181#issuecomment-1362291322 Thanks @dspasic for the detailed investigation. If it is a DoFn then the same approach can be used (finalize -> tearDown) as @dspasic already did. If not I haven't look into the alterna

[GitHub] [beam] zhengbuqian commented on pull request #14302: [BEAM-11886] Sickbay unsupported MapState, SetState, committed metrics for Dataflow streaming

2022-12-21 Thread GitBox
zhengbuqian commented on PR #14302: URL: https://github.com/apache/beam/pull/14302#issuecomment-1362284453 Those tests are still sickbayed. @reuvenlax why do you think the test was testing something that wasn't part of the API contract? The tests seem valid to me (that the output should con

[GitHub] [beam] yyy1000 commented on pull request #24746: Fix a small wrong url link in notebook

2022-12-21 Thread GitBox
yyy1000 commented on PR #24746: URL: https://github.com/apache/beam/pull/24746#issuecomment-1362278104 > Thanks, however I see both https://colab.sandbox.google.com/github/apache/beam/blob/master/examples/notebooks/tour-of-beam/reading-and-writing-data.ipynb and https://colab.sandbox.googl

[GitHub] [beam] zhengbuqian commented on pull request #24758: Exclude MultimapState related tests in Dataflow legacy worker validates runner tests

2022-12-21 Thread GitBox
zhengbuqian commented on PR #24758: URL: https://github.com/apache/beam/pull/24758#issuecomment-1362255931 Run Dataflow ValidatesRunner Java 11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] dspasic commented on issue #24181: [Task]: Eliminate deprecated finalize method (overrides Object.finalize) throughout Java SDK

2022-12-21 Thread GitBox
dspasic commented on issue #24181: URL: https://github.com/apache/beam/issues/24181#issuecomment-1362250796 Hi @DhirajSardar, I already replaced all finalize methods with the Teardown Context. At least the ones that could be replaced with the Teardown Context. However, as far

[GitHub] [beam] github-actions[bot] commented on pull request #24758: Exclude MultimapState related tests in Dataflow legacy worker validates runner tests

2022-12-21 Thread GitBox
github-actions[bot] commented on PR #24758: URL: https://github.com/apache/beam/pull/24758#issuecomment-1362230406 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] zhengbuqian commented on pull request #24758: Exclude MultimapState related tests in Dataflow legacy worker validates runner tests

2022-12-21 Thread GitBox
zhengbuqian commented on PR #24758: URL: https://github.com/apache/beam/pull/24758#issuecomment-1362229783 R: @lukecwik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] zhengbuqian opened a new pull request, #24758: Exclude MultimapState related tests in Dataflow legacy worker validates runner tests

2022-12-21 Thread GitBox
zhengbuqian opened a new pull request, #24758: URL: https://github.com/apache/beam/pull/24758 See https://github.com/apache/beam/issues/24750, we need to exclude MultimapState related tests in Dataflow legacy worker validates runner tests, https://github.com/apache/beam/pull/23491 excluded

[GitHub] [beam] pabloem commented on pull request #24757: Adding watermark support to DebeziumIO transform

2022-12-21 Thread GitBox
pabloem commented on PR #24757: URL: https://github.com/apache/beam/pull/24757#issuecomment-1362195098 r: @chamikaramj would you be ablet o help out? : ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] github-actions[bot] commented on pull request #24757: Adding watermark support to DebeziumIO transform

2022-12-21 Thread GitBox
github-actions[bot] commented on PR #24757: URL: https://github.com/apache/beam/pull/24757#issuecomment-1362194163 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] pabloem commented on pull request #24757: Adding watermark support to DebeziumIO transform

2022-12-21 Thread GitBox
pabloem commented on PR #24757: URL: https://github.com/apache/beam/pull/24757#issuecomment-1362193420 r: @chamikaramj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [beam] pabloem opened a new pull request, #24757: Adding watermark support to DebeziumIO transform

2022-12-21 Thread GitBox
pabloem opened a new pull request, #24757: URL: https://github.com/apache/beam/pull/24757 We had no watermark support before, which is a serious problem : / Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] Abacn commented on pull request #23785: [Test only] check flink loadtest args

2022-12-21 Thread GitBox
Abacn commented on PR #23785: URL: https://github.com/apache/beam/pull/23785#issuecomment-1362190749 Run Java KafkaIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] Abacn commented on pull request #23785: [Test only] check flink loadtest args

2022-12-21 Thread GitBox
Abacn commented on PR #23785: URL: https://github.com/apache/beam/pull/23785#issuecomment-1362173216 run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [beam] Abacn commented on pull request #24753: Fix SingleStoreIO performance test job

2022-12-21 Thread GitBox
Abacn commented on PR #24753: URL: https://github.com/apache/beam/pull/24753#issuecomment-1362140644 R: @ahmedabu98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [beam] github-actions[bot] commented on pull request #24756: Support SqlTypes Date in AvroUtils

2022-12-21 Thread GitBox
github-actions[bot] commented on PR #24756: URL: https://github.com/apache/beam/pull/24756#issuecomment-1362139701 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] Abacn commented on pull request #24756: Support SqlTypes Date in AvroUtils

2022-12-21 Thread GitBox
Abacn commented on PR #24756: URL: https://github.com/apache/beam/pull/24756#issuecomment-1362139538 [Java_Examples_Dataflow_Java17](https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java17_Commit/4923/) and [Java_GCP_IO_Direct](https://ci-beam.apache.org/job/beam_PreCom

[GitHub] [beam] Abacn commented on pull request #24756: Support SqlTypes Date in AvroUtils

2022-12-21 Thread GitBox
Abacn commented on PR #24756: URL: https://github.com/apache/beam/pull/24756#issuecomment-1362137137 R: @apilloud -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [beam] Abacn commented on a diff in pull request #24633: Add Python xlang KafkaIO performance test

2022-12-21 Thread GitBox
Abacn commented on code in PR #24633: URL: https://github.com/apache/beam/pull/24633#discussion_r1054838730 ## sdks/python/apache_beam/io/external/xlang_kafkaio_perf_test.py: ## @@ -0,0 +1,133 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contrib

[GitHub] [beam] robertwb commented on pull request #23975: Implement sibling protocol for Typescript.

2022-12-21 Thread GitBox
robertwb commented on PR #23975: URL: https://github.com/apache/beam/pull/23975#issuecomment-1362090175 Ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [beam] Abacn commented on a diff in pull request #24633: Add Python xlang KafkaIO performance test

2022-12-21 Thread GitBox
Abacn commented on code in PR #24633: URL: https://github.com/apache/beam/pull/24633#discussion_r1054835731 ## sdks/python/apache_beam/io/external/xlang_kafkaio_perf_test.py: ## @@ -0,0 +1,133 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contrib

[GitHub] [beam] Abacn commented on a diff in pull request #24633: Add Python xlang KafkaIO performance test

2022-12-21 Thread GitBox
Abacn commented on code in PR #24633: URL: https://github.com/apache/beam/pull/24633#discussion_r1054835731 ## sdks/python/apache_beam/io/external/xlang_kafkaio_perf_test.py: ## @@ -0,0 +1,133 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contrib

[GitHub] [beam] pabloem commented on pull request #24443: Implement PubsubWriteSchemaTransformProvider

2022-12-21 Thread GitBox
pabloem commented on PR #24443: URL: https://github.com/apache/beam/pull/24443#issuecomment-1362068422 ill merge one tests are green. lmk if I take a while. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] Miuler commented on pull request #23610: feat(azure-cosmosdb): Add support for cosmosdb with Core (SQL) API

2022-12-21 Thread GitBox
Miuler commented on PR #23610: URL: https://github.com/apache/beam/pull/23610#issuecomment-1362056214 > Sorry for delay. R: @kennknowles what was it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] johnjcasey commented on a diff in pull request #24633: Add Python xlang KafkaIO performance test

2022-12-21 Thread GitBox
johnjcasey commented on code in PR #24633: URL: https://github.com/apache/beam/pull/24633#discussion_r1054810218 ## sdks/python/apache_beam/io/external/xlang_kafkaio_perf_test.py: ## @@ -0,0 +1,133 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# co

[GitHub] [beam] pabloem commented on pull request #24674: Refactor focusing to contextLine

2022-12-21 Thread GitBox
pabloem commented on PR #24674: URL: https://github.com/apache/beam/pull/24674#issuecomment-1362032468 lgtm thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [beam] pabloem merged pull request #24674: Refactor focusing to contextLine

2022-12-21 Thread GitBox
pabloem merged PR #24674: URL: https://github.com/apache/beam/pull/24674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.

[GitHub] [beam] pabloem closed issue #24613: [Bug]: Cursor jumps after first edit

2022-12-21 Thread GitBox
pabloem closed issue #24613: [Bug]: Cursor jumps after first edit URL: https://github.com/apache/beam/issues/24613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [beam] github-actions[bot] commented on pull request #24756: Support SqlTypes Date in AvroUtils

2022-12-21 Thread GitBox
github-actions[bot] commented on PR #24756: URL: https://github.com/apache/beam/pull/24756#issuecomment-1361999735 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @lukecwik for label java. Available commands: - `stop re

[GitHub] [beam] Abacn commented on pull request #24744: [Website] delete 404 links

2022-12-21 Thread GitBox
Abacn commented on PR #24744: URL: https://github.com/apache/beam/pull/24744#issuecomment-1361987831 The first 2 links should be linked to https://github.com/apache/beam/blob/master/sdks/java/io/sparkreceiver/2/src/main/java/org/apache/beam/sdk/io/sparkreceiver/HasOffset.java SparkRec

[GitHub] [beam] Abacn commented on pull request #24746: Fix a small wrong url link in notebook

2022-12-21 Thread GitBox
Abacn commented on PR #24746: URL: https://github.com/apache/beam/pull/24746#issuecomment-1361959664 Thanks, however I see both https://colab.sandbox.google.com/github/apache/beam/blob/master/examples/notebooks/tour-of-beam/reading-and-writing-data.ipynb and https://colab.sandbox.google.co

[GitHub] [beam] pabloem commented on pull request #24443: Implement PubsubWriteSchemaTransformProvider

2022-12-21 Thread GitBox
pabloem commented on PR #24443: URL: https://github.com/apache/beam/pull/24443#issuecomment-1361920741 lgtm! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [beam] github-actions[bot] commented on pull request #24720: [Release Tasks Migration] - Build RC Publish Docs Workflow

2022-12-21 Thread GitBox
github-actions[bot] commented on PR #24720: URL: https://github.com/apache/beam/pull/24720#issuecomment-1361915759 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] MarcoRob commented on pull request #24720: [Release Tasks Migration] - Build RC Publish Docs Workflow

2022-12-21 Thread GitBox
MarcoRob commented on PR #24720: URL: https://github.com/apache/beam/pull/24720#issuecomment-1361912337 R: @damccorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2022-12-21 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1361893115 Run Python 3.8 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] robertwb commented on a diff in pull request #24735: Better naming and inference for PythonCallable.

2022-12-21 Thread GitBox
robertwb commented on code in PR #24735: URL: https://github.com/apache/beam/pull/24735#discussion_r1054707417 ## sdks/python/apache_beam/utils/python_callable.py: ## @@ -106,6 +106,19 @@ def load_from_script(source): exec('\n'.join(lines), exec_globals) return exec_gl

[GitHub] [beam] Abacn commented on pull request #24756: Support SqlTypes Date in AvroUtils

2022-12-21 Thread GitBox
Abacn commented on PR #24756: URL: https://github.com/apache/beam/pull/24756#issuecomment-1361855865 This PR suffices to fix the requested use case of #23299 (beam:logical_type:date:v1 which is SqlTypes.DATE) , though SqlTypes.TIMESTAMP remains unsupported to AvroUtils -- This is an auto

[GitHub] [beam] Abacn opened a new pull request, #24756: Support SqlTypes Date in AvroUtils

2022-12-21 Thread GitBox
Abacn opened a new pull request, #24756: URL: https://github.com/apache/beam/pull/24756 Fixes #23299 Re-introduce part of #23969 (one direction SqlTypes Date to Avro Date) which was later reverted due to breaking change to Beam SQL. The breaking change of #23969 was the introduce o

[GitHub] [beam] robertwb opened a new issue, #24755: [Feature Request]: Add support for type inference of through kwargs calls.

2022-12-21 Thread GitBox
robertwb opened a new issue, #24755: URL: https://github.com/apache/beam/issues/24755 ### What would you like to happen? Current, functions calls like `foo(*args, **kwargs)` are inferred to produce `Any`. ### Issue Priority Priority: 3 (nice-to-have improvement) #

[GitHub] [beam] github-actions[bot] commented on pull request #24753: Fix SingleStoreIO performance test job

2022-12-21 Thread GitBox
github-actions[bot] commented on PR #24753: URL: https://github.com/apache/beam/pull/24753#issuecomment-1361834055 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] Abacn commented on pull request #24753: Fix SingleStoreIO performance test job

2022-12-21 Thread GitBox
Abacn commented on PR #24753: URL: https://github.com/apache/beam/pull/24753#issuecomment-1361830062 R: @AdalbertMemSQL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] robertwb merged pull request #24718: Add a couple of well-known Google properties that use Beam extensively.

2022-12-21 Thread GitBox
robertwb merged PR #24718: URL: https://github.com/apache/beam/pull/24718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] github-actions[bot] commented on pull request #24720: [Release Tasks Migration] - Build RC Publish Docs Workflow

2022-12-21 Thread GitBox
github-actions[bot] commented on PR #24720: URL: https://github.com/apache/beam/pull/24720#issuecomment-1361781685 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label build. Available commands: - `stop revi

[GitHub] [beam] Abacn commented on pull request #24753: Fix SingleStoreIO performance test job

2022-12-21 Thread GitBox
Abacn commented on PR #24753: URL: https://github.com/apache/beam/pull/24753#issuecomment-1361758113 Run Java SingleStoreIO Performance Test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] codecov[bot] commented on pull request #24720: [Release Tasks Migration] - Build RC Publish Docs Workflow

2022-12-21 Thread GitBox
codecov[bot] commented on PR #24720: URL: https://github.com/apache/beam/pull/24720#issuecomment-1361733210 # [Codecov](https://codecov.io/gh/apache/beam/pull/24720?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] Abacn commented on pull request #24753: Fix SingleStoreIO performance test job

2022-12-21 Thread GitBox
Abacn commented on PR #24753: URL: https://github.com/apache/beam/pull/24753#issuecomment-1361726314 run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [beam] Abacn opened a new pull request, #24753: Fix SingleStoreIO performance test job

2022-12-21 Thread GitBox
Abacn opened a new pull request, #24753: URL: https://github.com/apache/beam/pull/24753 Followup of #24290 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate

[GitHub] [beam] dependabot[bot] commented on pull request #24739: Bump github.com/aws/aws-sdk-go-v2/config from 1.18.6 to 1.18.7 in /sdks

2022-12-21 Thread GitBox
dependabot[bot] commented on PR #24739: URL: https://github.com/apache/beam/pull/24739#issuecomment-1361718688 Looks like github.com/aws/aws-sdk-go-v2/config is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] dependabot[bot] closed pull request #24739: Bump github.com/aws/aws-sdk-go-v2/config from 1.18.6 to 1.18.7 in /sdks

2022-12-21 Thread GitBox
dependabot[bot] closed pull request #24739: Bump github.com/aws/aws-sdk-go-v2/config from 1.18.6 to 1.18.7 in /sdks URL: https://github.com/apache/beam/pull/24739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [beam] dependabot[bot] commented on pull request #24741: Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.6 to 1.13.7 in /sdks

2022-12-21 Thread GitBox
dependabot[bot] commented on PR #24741: URL: https://github.com/apache/beam/pull/24741#issuecomment-1361718541 Looks like github.com/aws/aws-sdk-go-v2/credentials is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] dependabot[bot] closed pull request #24741: Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.6 to 1.13.7 in /sdks

2022-12-21 Thread GitBox
dependabot[bot] closed pull request #24741: Bump github.com/aws/aws-sdk-go-v2/credentials from 1.13.6 to 1.13.7 in /sdks URL: https://github.com/apache/beam/pull/24741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [beam] Abacn commented on pull request #24290: Implemented SchemaTransforms for SingleStoreIO

2022-12-21 Thread GitBox
Abacn commented on PR #24290: URL: https://github.com/apache/beam/pull/24290#issuecomment-1361718475 Looks like this PR breaks SingleStoreIO performance test: https://ci-beam.apache.org/view/PerformanceTests/job/beam_PerformanceTests_SingleStoreIO/79/ because the test source file has

[GitHub] [beam] damccorm merged pull request #24740: Bump github.com/aws/aws-sdk-go-v2/feature/s3/manager from 1.11.44 to 1.11.46 in /sdks

2022-12-21 Thread GitBox
damccorm merged PR #24740: URL: https://github.com/apache/beam/pull/24740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] lukecwik commented on issue #24750: [Failing Test]: Exclude MultimapState tests from Dataflow VR suites

2022-12-21 Thread GitBox
lukecwik commented on issue #24750: URL: https://github.com/apache/beam/issues/24750#issuecomment-1361699344 This should be as simple as excluding the test category -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [beam] MarcoRob commented on pull request #24418: [Release Tasks Migration] - Git Tag Workflow

2022-12-21 Thread GitBox
MarcoRob commented on PR #24418: URL: https://github.com/apache/beam/pull/24418#issuecomment-1361696685 > @MarcoRob could you please add this job to CI.md? @damccorm Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [beam] codecov[bot] commented on pull request #24751: [Playground] multifile examples

2022-12-21 Thread GitBox
codecov[bot] commented on PR #24751: URL: https://github.com/apache/beam/pull/24751#issuecomment-1361678512 # [Codecov](https://codecov.io/gh/apache/beam/pull/24751?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Fo

[GitHub] [beam] AnandInguva commented on a diff in pull request #23312: GA migration and sharding Python Postcommit ML

2022-12-21 Thread GitBox
AnandInguva commented on code in PR #23312: URL: https://github.com/apache/beam/pull/23312#discussion_r1054603062 ## .github/workflows/job-postcommit-python-ml.yml: ## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2022-12-21 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1361650325 thanks. that's WAI. Bot sent it for review too early. I have intentionally temporarily increased the lower bound temporarily to have a meaningful postcommit signal in https://ci-beam.ap

[GitHub] [beam] aromanenko-dev commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
aromanenko-dev commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1054590709 ## sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/io/AvroSink.java: ## @@ -0,0 +1,151 @@ +/* Review Comment: It's beed added ther

[GitHub] [beam] tvalentyn commented on pull request #24752: Add empty file in order to create PR

2022-12-21 Thread GitBox
tvalentyn commented on PR #24752: URL: https://github.com/apache/beam/pull/24752#issuecomment-1361631446 Run Gradle Publish -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] tvalentyn opened a new pull request, #24752: Add empty file in order to create PR

2022-12-21 Thread GitBox
tvalentyn opened a new pull request, #24752: URL: https://github.com/apache/beam/pull/24752 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quic

[GitHub] [beam] aromanenko-dev commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
aromanenko-dev commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1054589320 ## sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/schemas/utils/AvroUtils.java: ## @@ -0,0 +1,1341 @@ +/* + * Licensed to the Apache

[GitHub] [beam] aromanenko-dev commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
aromanenko-dev commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1054588991 ## sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/schemas/AvroSchemaTest.java: ## @@ -0,0 +1,508 @@ +/* + * Licensed to the Apache So

[GitHub] [beam] aromanenko-dev commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
aromanenko-dev commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1054587463 ## sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/io/DynamicAvroDestinations.java: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache

[GitHub] [beam] aromanenko-dev commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
aromanenko-dev commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1054585075 ## sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/io/AvroIO.java: ## @@ -0,0 +1,2026 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [beam] eantyshev opened a new pull request, #24751: [Playground] multifile examples

2022-12-21 Thread GitBox
eantyshev opened a new pull request, #24751: URL: https://github.com/apache/beam/pull/24751 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quic

[GitHub] [beam] aromanenko-dev commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
aromanenko-dev commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1054578980 ## sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/io/AvroIO.java: ## @@ -0,0 +1,2026 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [beam] jrmccluskey commented on pull request #24725: Update upper bound for numpy.

2022-12-21 Thread GitBox
jrmccluskey commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1361597967 Error message on the precommits: ``` Container does not include required Beam dependencies or has conflicting dependencies. If Beam dependencies have changed, you need to reg

[GitHub] [beam] tvalentyn commented on issue #24750: [Failing Test]: Exclude MultimapState tests from Dataflow VR suites

2022-12-21 Thread GitBox
tvalentyn commented on issue #24750: URL: https://github.com/apache/beam/issues/24750#issuecomment-1361595336 @zhengbuqian would you mind excluding relevant tests on Dataflow for now? Thanks! cc: @lukecwik -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] tvalentyn opened a new issue, #24750: [Failing Test]: Exclude MultimapState tests from Dataflow VR suites

2022-12-21 Thread GitBox
tvalentyn opened a new issue, #24750: URL: https://github.com/apache/beam/issues/24750 ### What happened? _No response_ ### Issue Failure Failure: Test is continually failing ### Issue Priority Priority: 2 (backlog / disabled test but we think the product is

[GitHub] [beam] Abacn commented on pull request #24015: [Bigtable] Migrate BigtableIO to use the veneer client under the hood

2022-12-21 Thread GitBox
Abacn commented on PR #24015: URL: https://github.com/apache/beam/pull/24015#issuecomment-1361560314 Thanks for the work! Looking into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [beam] github-actions[bot] commented on pull request #24635: [Website] update links with 404 status code

2022-12-21 Thread GitBox
github-actions[bot] commented on PR #24635: URL: https://github.com/apache/beam/pull/24635#issuecomment-1361519626 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] bullet03 commented on pull request #24635: [Website] update links with 404 status code

2022-12-21 Thread GitBox
bullet03 commented on PR #24635: URL: https://github.com/apache/beam/pull/24635#issuecomment-1361515793 R: @aromanenko-dev, could you, kindly, help with review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [beam] aromanenko-dev commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
aromanenko-dev commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1054526987 ## sdks/java/extensions/avro/build.gradle: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

[GitHub] [beam] github-actions[bot] commented on pull request #24731: Integration test to load the default example of the default SDK and change the example

2022-12-21 Thread GitBox
github-actions[bot] commented on PR #24731: URL: https://github.com/apache/beam/pull/24731#issuecomment-1361488359 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] alexeyinkin commented on pull request #24731: Integration test to load the default example of the default SDK and change the example

2022-12-21 Thread GitBox
alexeyinkin commented on PR #24731: URL: https://github.com/apache/beam/pull/24731#issuecomment-1361485698 R: @damondouglas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] mosche commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
mosche commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1054424906 ## sdks/java/extensions/avro/src/main/java/org/apache/beam/sdk/extensions/avro/io/AvroSink.java: ## @@ -0,0 +1,151 @@ +/* Review Comment: Looks like `syncInterval` wa

[GitHub] [beam] alexeyinkin commented on a diff in pull request #24731: Integration test to load the default example of the default SDK and change the example

2022-12-21 Thread GitBox
alexeyinkin commented on code in PR #24731: URL: https://github.com/apache/beam/pull/24731#discussion_r1054499203 ## playground/frontend/integration_test/standalone_change_example_test.dart: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [beam] aromanenko-dev commented on pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
aromanenko-dev commented on PR #24294: URL: https://github.com/apache/beam/pull/24294#issuecomment-1361455975 @mosche > This PR doesn't close the ticket yet, right? It does since it's just a sub-task of #24292 -- This is an automated message from the Apache Git Service. To resp

[GitHub] [beam] viniciusdsmello commented on issue #21432: `beam.CombineValues` on DataFlow runner causes ambiguous failure with python SDK

2022-12-21 Thread GitBox
viniciusdsmello commented on issue #21432: URL: https://github.com/apache/beam/issues/21432#issuecomment-1361451153 Hi, I'm facing the same issue here. Did anyone figure out a workaround? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] alexeyinkin commented on a diff in pull request #24731: Integration test to load the default example of the default SDK and change the example

2022-12-21 Thread GitBox
alexeyinkin commented on code in PR #24731: URL: https://github.com/apache/beam/pull/24731#discussion_r1054491010 ## playground/frontend/playground_components/LICENSE: ## @@ -200,208 +200,3 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See t

[GitHub] [beam] damccorm merged pull request #24712: Adding Setup python to Dataflow job in Java Tests

2022-12-21 Thread GitBox
damccorm merged PR #24712: URL: https://github.com/apache/beam/pull/24712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] damccorm merged pull request #24736: Fix some typos

2022-12-21 Thread GitBox
damccorm merged PR #24736: URL: https://github.com/apache/beam/pull/24736 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] damccorm commented on pull request #24740: Bump github.com/aws/aws-sdk-go-v2/feature/s3/manager from 1.11.44 to 1.11.46 in /sdks

2022-12-21 Thread GitBox
damccorm commented on PR #24740: URL: https://github.com/apache/beam/pull/24740#issuecomment-1361357685 Run Go PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] damccorm merged pull request #24559: Bump actions/setup-java from 3.6.0 to 3.8.0

2022-12-21 Thread GitBox
damccorm merged PR #24559: URL: https://github.com/apache/beam/pull/24559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[GitHub] [beam] github-actions[bot] commented on pull request #24725: Update upper bound for numpy.

2022-12-21 Thread GitBox
github-actions[bot] commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1361351971 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label python. Available commands: - `st

[GitHub] [beam] mosche commented on a diff in pull request #24294: Create Avro extension for Java SDK

2022-12-21 Thread GitBox
mosche commented on code in PR #24294: URL: https://github.com/apache/beam/pull/24294#discussion_r1054390175 ## sdks/java/extensions/avro/build.gradle: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreemen

  1   2   >