github-actions[bot] commented on PR #35818:
URL: https://github.com/apache/beam/pull/35818#issuecomment-3166645514
Assigning reviewers:
R: @lostluck for label go.
Note: If you would like to opt out of this review, comment `assign to next
reviewer`.
Available commands
dependabot[bot] opened a new pull request, #35818:
URL: https://github.com/apache/beam/pull/35818
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.42.0 to
0.43.0.
Commits
https://github.com/golang/net/commit/e74bc31d69f225b635e065a602db3fbfa9850f93";>e74bc31
go.m
github-actions[bot] commented on PR #35817:
URL: https://github.com/apache/beam/pull/35817#issuecomment-3166266680
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control. If you'd like to restart, comment
`assign set of reviewer
liferoad commented on PR #35817:
URL: https://github.com/apache/beam/pull/35817#issuecomment-3166265493
R: @stankiewicz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
liferoad opened a new pull request, #35817:
URL: https://github.com/apache/beam/pull/35817
Add _get_temp_dataset_project helper method to determine the correct project
ID for temporary dataset operations. Update _setup_temporary_dataset and
finish_bundle to use this method instead of _get_p
ksobrenat32 commented on code in PR #35524:
URL: https://github.com/apache/beam/pull/35524#discussion_r2261621939
##
infra/keys/config.yaml:
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTIC
ksobrenat32 commented on code in PR #35524:
URL: https://github.com/apache/beam/pull/35524#discussion_r2261621610
##
infra/keys/README.md:
##
@@ -0,0 +1,93 @@
+
+
+# Service Account Management
+
+This module is used to manage Google Cloud service accounts, including
creating, r
tomstepp commented on PR #35814:
URL: https://github.com/apache/beam/pull/35814#issuecomment-3165479603
It looks like runs still have `--no-parallel` and `max_workers: 8` at
https://github.com/apache/beam/actions/runs/16813631304/job/47624897595
Is it using the version in master inste
mohamedawnallah commented on PR #35816:
URL: https://github.com/apache/beam/pull/35816#issuecomment-3166000143
The precommit ml tests failing are currently the ones running on
`ubuntu-latest`. I will try to investigate this by using the same
`ubuntu-latest` variant locally and if any errors
damccorm commented on PR #35816:
URL: https://github.com/apache/beam/pull/35816#issuecomment-3165723044
> Thanks! I copied your changes and am running a couple of test runs to try
them out:
>
> * https://github.com/apache/beam/actions/runs/16814631250
> * https://github.com/apache/
tomstepp commented on PR #35815:
URL: https://github.com/apache/beam/pull/35815#issuecomment-3165487586
The PreCommit still seems to be running with `--no-parallel` for some reason
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
github-actions[bot] commented on PR #35816:
URL: https://github.com/apache/beam/pull/35816#issuecomment-3165564441
Assigning reviewers:
R: @damccorm for label build.
Note: If you would like to opt out of this review, comment `assign to next
reviewer`.
Available comma
damccorm commented on PR #35816:
URL: https://github.com/apache/beam/pull/35816#issuecomment-3165559836
Thanks! I copied your changes and am running a couple of test runs to try
them out:
- https://github.com/apache/beam/actions/runs/16814631250
- https://github.com/apache/beam/act
mohamedawnallah opened a new pull request, #35816:
URL: https://github.com/apache/beam/pull/35816
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contributio
jrmccluskey merged PR #35805:
URL: https://github.com/apache/beam/pull/35805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apa
mohamedawnallah commented on PR #35816:
URL: https://github.com/apache/beam/pull/35816#issuecomment-3165503106
cc @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
gemini-code-assist[bot] commented on PR #35816:
URL: https://github.com/apache/beam/pull/35816#issuecomment-3165492160
> [!NOTE]
> Gemini is unable to generate a summary for this pull request due to the
file types involved not being currently supported.
--
This is an automated message
Abacn commented on PR #35815:
URL: https://github.com/apache/beam/pull/35815#issuecomment-3165411386
I'm testing #35814. Changes won't be effective because .github/ changes are
not picked up for PR runs. I'm running with workflow_dispatch trigger there
--
This is an automated message from
Abacn merged PR #35812:
URL: https://github.com/apache/beam/pull/35812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.or
Abacn commented on PR #35815:
URL: https://github.com/apache/beam/pull/35815#issuecomment-3165417844
Tests are running on issue comment trigger:
https://github.com/apache/beam/actions/runs/16813452367
but due to github action limit it does not get reflected on PR status page
until it
Abacn opened a new pull request, #35814:
URL: https://github.com/apache/beam/pull/35814
Enable parallel for KafkaIO precommit
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to he
github-actions[bot] commented on PR #35815:
URL: https://github.com/apache/beam/pull/35815#issuecomment-3165407291
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control. If you'd like to restart, comment
`assign set of reviewer
tomstepp commented on PR #35815:
URL: https://github.com/apache/beam/pull/35815#issuecomment-3165403816
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
tomstepp commented on PR #35815:
URL: https://github.com/apache/beam/pull/35815#issuecomment-3165404357
Still trying to trigger the Kafka precommit execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
tomstepp commented on PR #35815:
URL: https://github.com/apache/beam/pull/35815#issuecomment-3165398373
Run Java_Kafka_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
tomstepp opened a new pull request, #35815:
URL: https://github.com/apache/beam/pull/35815
Remove no-parallel flag on kafka IO direct precommit
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](
gemini-code-assist[bot] commented on PR #35815:
URL: https://github.com/apache/beam/pull/35815#issuecomment-3165394235
> [!NOTE]
> Gemini is unable to generate a summary for this pull request due to the
file types involved not being currently supported.
--
This is an automated message
gemini-code-assist[bot] commented on PR #35814:
URL: https://github.com/apache/beam/pull/35814#issuecomment-3165299150
> [!NOTE]
> Gemini is unable to generate a summary for this pull request due to the
file types involved not being currently supported.
--
This is an automated message
Abacn commented on PR #35814:
URL: https://github.com/apache/beam/pull/35814#issuecomment-3165305584
Testing: https://github.com/apache/beam/actions/runs/16812690222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
stankiewicz commented on issue #35813:
URL: https://github.com/apache/beam/issues/35813#issuecomment-3165228884
BQ wrapper has issue here
https://github.com/apache/beam/blob/d427d3731e4653374310d693c5e13933529ac488/sdks/python/apache_beam/io/gcp/bigquery_tools.py#L621-L652
temp dat
ksobrenat32 commented on code in PR #35524:
URL: https://github.com/apache/beam/pull/35524#discussion_r2260876685
##
infra/keys/service_account.py:
##
@@ -0,0 +1,485 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See t
ksobrenat32 commented on code in PR #35524:
URL: https://github.com/apache/beam/pull/35524#discussion_r2261005131
##
infra/keys/secret_manager.py:
##
@@ -0,0 +1,651 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See th
github-actions[bot] commented on PR #35811:
URL: https://github.com/apache/beam/pull/35811#issuecomment-3165160148
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated me
ksobrenat32 commented on code in PR #35524:
URL: https://github.com/apache/beam/pull/35524#discussion_r2261016822
##
infra/keys/secret_manager.py:
##
@@ -0,0 +1,651 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See th
stankiewicz commented on issue #35813:
URL: https://github.com/apache/beam/issues/35813#issuecomment-3165062599
ask:
in `_BigQueryReadSplit` , if temp_dataset is `DatasetReference` it should
take projectId from temp_dataset to create dataset. this shouldn't change which
project is billed
stankiewicz opened a new issue, #35813:
URL: https://github.com/apache/beam/issues/35813
### What happened?
Code:
```
# 1. Define a reference to a dataset in your BigQuery project.
temp_dataset_ref = DatasetReference(
projectId='foo',
datasetId='my_temp_b
github-actions[bot] commented on PR #35796:
URL: https://github.com/apache/beam/pull/35796#issuecomment-3164965878
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control. If you'd like to restart, comment
`assign set of reviewer
Abacn commented on PR #35796:
URL: https://github.com/apache/beam/pull/35796#issuecomment-3164962593
R: @shunping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
tomstepp commented on code in PR #35812:
URL: https://github.com/apache/beam/pull/35812#discussion_r2260849466
##
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##
@@ -1098,14 +1098,39 @@
return toBuilder().setRedistributed(true).build();
tomstepp commented on code in PR #35812:
URL: https://github.com/apache/beam/pull/35812#discussion_r2260848217
##
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##
@@ -1098,14 +1098,39 @@ public Read withRedistribute() {
return toBuilder().set
tomstepp commented on PR #35812:
URL: https://github.com/apache/beam/pull/35812#issuecomment-3164913236
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
gemini-code-assist[bot] commented on code in PR #35812:
URL: https://github.com/apache/beam/pull/35812#discussion_r2260830323
##
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java:
##
@@ -1098,14 +1098,39 @@ public Read withRedistribute() {
return
github-actions[bot] commented on PR #35812:
URL: https://github.com/apache/beam/pull/35812#issuecomment-3164916546
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control. If you'd like to restart, comment
`assign set of reviewer
tomstepp commented on PR #35812:
URL: https://github.com/apache/beam/pull/35812#issuecomment-3164908903
/gemini review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
tomstepp opened a new pull request, #35812:
URL: https://github.com/apache/beam/pull/35812
Add javadoc comments for public methods related to KafkaIO redistribute.
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test
Abacn commented on code in PR #35621:
URL: https://github.com/apache/beam/pull/35621#discussion_r2260786674
##
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java:
##
@@ -276,8 +276,8 @@ public static void main(
IdGenerator idGenerator = IdGenerators
razvanculea opened a new pull request, #35811:
URL: https://github.com/apache/beam/pull/35811
IObased IOs now support streaming.
Some examples to use TextIO, AvroIO, ParquetIO, TFRecordsIO in streaming
with TestStream or PeriodicImpulse as source.
GitHub Actions Tests Statu
Abacn commented on code in PR #35621:
URL: https://github.com/apache/beam/pull/35621#discussion_r2260718535
##
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java:
##
@@ -276,8 +276,8 @@ public static void main(
IdGenerator idGenerator = IdGenerators
github-actions[bot] commented on issue #30799:
URL: https://github.com/apache/beam/issues/30799#issuecomment-3164757922
Reopening since the workflow is still flaky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
Abacn commented on code in PR #35621:
URL: https://github.com/apache/beam/pull/35621#discussion_r2260705809
##
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java:
##
@@ -276,8 +276,8 @@ public static void main(
IdGenerator idGenerator = IdGenerators
damccorm commented on code in PR #35621:
URL: https://github.com/apache/beam/pull/35621#discussion_r2260722113
##
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java:
##
@@ -276,8 +276,8 @@ public static void main(
IdGenerator idGenerator = IdGenerat
damccorm commented on code in PR #35621:
URL: https://github.com/apache/beam/pull/35621#discussion_r2260715275
##
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java:
##
@@ -276,8 +276,8 @@ public static void main(
IdGenerator idGenerator = IdGenerat
kristynsmith commented on code in PR #35656:
URL: https://github.com/apache/beam/pull/35656#discussion_r2260667875
##
sdks/python/apache_beam/internal/code_object_pickler.py:
##
@@ -95,13 +105,16 @@ def _extend_path(prefix, suffix):
return prefix + '.' + suffix
-def _sear
kristynsmith commented on code in PR #35656:
URL: https://github.com/apache/beam/pull/35656#discussion_r2260667875
##
sdks/python/apache_beam/internal/code_object_pickler.py:
##
@@ -95,13 +105,16 @@ def _extend_path(prefix, suffix):
return prefix + '.' + suffix
-def _sear
kristynsmith commented on code in PR #35656:
URL: https://github.com/apache/beam/pull/35656#discussion_r2260645218
##
sdks/python/apache_beam/internal/code_object_pickler.py:
##
@@ -15,7 +15,445 @@
# limitations under the License.
#
+"""Customizations to how Python code obje
github-actions[bot] commented on PR #35229:
URL: https://github.com/apache/beam/pull/35229#issuecomment-3164626974
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control. If you'd like to restart, comment
`assign set of reviewer
kennknowles commented on PR #35229:
URL: https://github.com/apache/beam/pull/35229#issuecomment-3164622581
R: @ahmedabu98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
damccorm commented on PR #35107:
URL: https://github.com/apache/beam/pull/35107#issuecomment-3164618260
@pabloem could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sjvanrossum commented on PR #35561:
URL: https://github.com/apache/beam/pull/35561#issuecomment-3164599356
Run Java_IOs_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
ksobrenat32 commented on code in PR #35524:
URL: https://github.com/apache/beam/pull/35524#discussion_r2260587662
##
infra/keys/secret_manager.py:
##
@@ -0,0 +1,651 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See th
damccorm commented on code in PR #35774:
URL: https://github.com/apache/beam/pull/35774#discussion_r2260544316
##
sdks/python/apache_beam/yaml/yaml_ml.py:
##
@@ -514,11 +509,36 @@ def ml_transform(
options.YamlOptions.check_enabled(pcoll.pipeline, 'ML')
# TODO(robertwb): P
charlespnh opened a new pull request, #35810:
URL: https://github.com/apache/beam/pull/35810
Part of the larger effort https://github.com/apache/beam/issues/35068 and
https://github.com/apache/beam/issues/35070 to add more examples involving ML
workloads and Iceberg.
damccorm merged PR #35453:
URL: https://github.com/apache/beam/pull/35453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache
github-actions[bot] commented on issue #34206:
URL: https://github.com/apache/beam/issues/34206#issuecomment-3164040955
This issue has been marked as stale due to 150 days of inactivity. It will
be closed in 30 days if no further activity occurs. If you think that’s
incorrect or this issue
shunping commented on issue #35788:
URL: https://github.com/apache/beam/issues/35788#issuecomment-3164077519
Ack. Let me take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
razvanculea commented on issue #25598:
URL: https://github.com/apache/beam/issues/25598#issuecomment-3164011295
pre my IObase work, all IOs derived from IObased and FileBasedSink don't
work in streaming. They do work in batch.
My PR to add streaming support:
PR - [(apache/beam#3513
github-actions[bot] closed issue #33917: [Feature Request]: [Portable
BigQueryIO] support fetching Schema from dynamic destinations when setting
useBeamSchema()
URL: https://github.com/apache/beam/issues/33917
--
This is an automated message from the Apache Git Service.
To respond to the mes
github-actions[bot] closed issue #33864: [Bug]: Managed BQ read transform fails
to attach config row
URL: https://github.com/apache/beam/issues/33864
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
razvanculea commented on issue #32113:
URL: https://github.com/apache/beam/issues/32113#issuecomment-3164000481
@damccorm pre my IObase work, all IOs derived from IObased and
FileBasedSink don't work in streaming (i should have logged an issue). They do
work in batch.
My PR to add s
A1K28 commented on PR #35809:
URL: https://github.com/apache/beam/pull/35809#issuecomment-3164058444
@Amar3tto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
A1K28 opened a new pull request, #35809:
URL: https://github.com/apache/beam/pull/35809
This PR adds vLLM Gemma Benchmarks while utilizing the GPU.
I will add another PR to automatically update the docker image for the GPU
base, which will run once a day.
P.S. I will add succes
razvanculea commented on issue #19636:
URL: https://github.com/apache/beam/issues/19636#issuecomment-3164017411
pre my IObase work, all IOs derived from IObased and FileBasedSink don't
work in streaming. They do work in batch.
My PR to add streaming support:
PR - [(apache/beam#3513
github-actions[bot] commented on issue #30813:
URL: https://github.com/apache/beam/issues/30813#issuecomment-3164043248
Reopening since the workflow is still flaky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
github-actions[bot] commented on issue #33917:
URL: https://github.com/apache/beam/issues/33917#issuecomment-3164041494
This issue has been closed due to lack of activity. If you think that is
incorrect, you can reopen the issue at any time.
--
This is an automated message from the Apache
github-actions[bot] commented on issue #33864:
URL: https://github.com/apache/beam/issues/33864#issuecomment-3164041593
This issue has been closed due to lack of activity. If you think that is
incorrect, you can reopen the issue at any time.
--
This is an automated message from the Apache
github-actions[bot] commented on PR #35229:
URL: https://github.com/apache/beam/pull/35229#issuecomment-3163947390
Reminder, please take a look at this pr: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
github-actions[bot] commented on PR #35739:
URL: https://github.com/apache/beam/pull/35739#issuecomment-3163947274
Reminder, please take a look at this pr: @m-trieu @fozzie15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
arunpandianp commented on PR #35523:
URL: https://github.com/apache/beam/pull/35523#issuecomment-3163787707
just a few minor comments, the logic looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
arunpandianp commented on code in PR #35523:
URL: https://github.com/apache/beam/pull/35523#discussion_r2259798218
##
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/AbstractWindmillStream.java:
##
@@ -214,54 +242,6
gemini-code-assist[bot] commented on PR #35523:
URL: https://github.com/apache/beam/pull/35523#issuecomment-3163387048
## Summary of Changes
This pull request significantly enhances the robustness of Dataflow
streaming by introducing support for dynamic physical stream transit
arunpandianp commented on PR #35523:
URL: https://github.com/apache/beam/pull/35523#issuecomment-3163383844
/gemini summary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
arunpandianp commented on code in PR #35786:
URL: https://github.com/apache/beam/pull/35786#discussion_r2259631842
##
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##
@@ -394,6 +370,163 @@ private St
scwhittle merged PR #35793:
URL: https://github.com/apache/beam/pull/35793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apach
scwhittle commented on PR #35793:
URL: https://github.com/apache/beam/pull/35793#issuecomment-3163234617
remaining failure is unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
scwhittle commented on PR #35523:
URL: https://github.com/apache/beam/pull/35523#issuecomment-3163108326
Thanks! I finished the commitstream tests but see now there are failures in
some of the existing tests and am investigating.
--
This is an automated message from the Apache Git Service
85 matches
Mail list logo
