[GitHub] [beam] aaltay commented on pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

2020-07-07 Thread GitBox
aaltay commented on pull request #11744: URL: https://github.com/apache/beam/pull/11744#issuecomment-655211272 > > Oh I see now. I tried to fix this issue by adding `drop_defaults=true` but we explicitly don't drop the default value for ValueProvider arguments: > > https://github.com/ap

[GitHub] [beam] aaltay commented on pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

2020-07-07 Thread GitBox
aaltay commented on pull request #11744: URL: https://github.com/apache/beam/pull/11744#issuecomment-655209912 > Oh I see now. I tried to fix this issue by adding `drop_defaults=true` but we explicitly don't drop the default value for ValueProvider arguments: > > https://github.com/

[GitHub] [beam] aaltay commented on pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

2020-07-07 Thread GitBox
aaltay commented on pull request #11744: URL: https://github.com/apache/beam/pull/11744#issuecomment-655189985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [beam] aaltay commented on pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

2020-05-20 Thread GitBox
aaltay commented on pull request #11744: URL: https://github.com/apache/beam/pull/11744#issuecomment-631667834 > test_parse_pipeline_options This test is a bit flawed. `expected_options.get_all_options()` could return all registered options. Test is assuming that no other option rela

[GitHub] [beam] aaltay commented on pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

2020-05-20 Thread GitBox
aaltay commented on pull request #11744: URL: https://github.com/apache/beam/pull/11744#issuecomment-631658770 > Somehow this seems to introduce an additional flake in `SdkWorkerMainTest`. I can't replicate it locally... I suspect it only occurs when pipeline options get polluted from othe