[GitHub] [beam] kennknowles commented on pull request #13306: [BEAM-10925] Create interface for SQL Java aggregate function.

2020-11-16 Thread GitBox
kennknowles commented on pull request #13306: URL: https://github.com/apache/beam/pull/13306#issuecomment-728330950 CombineFn is stable, but UDAF is not. One example is that a UDAF has to have a SQL type. Right now this is not represented on the UDAF object but is implied. That might

[GitHub] [beam] kennknowles commented on pull request #13306: [BEAM-10925] Create interface for SQL Java aggregate function.

2020-11-12 Thread GitBox
kennknowles commented on pull request #13306: URL: https://github.com/apache/beam/pull/13306#issuecomment-726224273 Just checking: the interface for a SQL aggregation function is "can give you a CombineFn"? I understand this is the current status of UDAFs. Is that where we want to leave