[GitHub] [beam] daria-malkova commented on a change in pull request #16477: [BEAM-13560][Playground] Split builder into several builders for each step of the pipeline execution

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16477: URL: https://github.com/apache/beam/pull/16477#discussion_r783735862 ## File path: playground/backend/internal/setup_tools/builder/setup_builder.go ## @@ -31,73 +31,134 @@ const ( javaLogConfigFilePlaceholder =

[GitHub] [beam] echauchot commented on pull request #16309: [BEAM-13503] Fixes bug in java ElasticsearchIO BulkIO constructor

2022-01-13 Thread GitBox
echauchot commented on pull request #16309: URL: https://github.com/apache/beam/pull/16309#issuecomment-1011938149 > jcenter.bintray.com @khersey it looks like a temporary web failure at `jcenter.bintray.com` -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [beam] echauchot edited a comment on pull request #16309: [BEAM-13503] Fixes bug in java ElasticsearchIO BulkIO constructor

2022-01-13 Thread GitBox
echauchot edited a comment on pull request #16309: URL: https://github.com/apache/beam/pull/16309#issuecomment-1011938149 > jcenter.bintray.com @khersey it looks like a temporary web failure at `jcenter.bintray.com` I just ran `./gradlew clean test ` locally on your branch on modul

[GitHub] [beam] echauchot edited a comment on pull request #16309: [BEAM-13503] Fixes bug in java ElasticsearchIO BulkIO constructor

2022-01-13 Thread GitBox
echauchot edited a comment on pull request #16309: URL: https://github.com/apache/beam/pull/16309#issuecomment-1011938149 > jcenter.bintray.com @khersey it looks like a temporary web failure at `jcenter.bintray.com` I just ran `./gradlew clean test ` locally on your branch on modul

[GitHub] [beam] robertwb commented on pull request #16465: Stronger typing inference for CoGBK.

2022-01-13 Thread GitBox
robertwb commented on pull request #16465: URL: https://github.com/apache/beam/pull/16465#issuecomment-1011988587 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] daria-malkova commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r783814894 ## File path: playground/backend/internal/preparators/go_preparators.go ## @@ -33,13 +31,44 @@ const ( sep = "." ) +//GoPreparersBuild

[GitHub] [beam] daria-malkova commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r783815086 ## File path: playground/backend/internal/preparators/java_preparators.go ## @@ -41,47 +39,85 @@ const ( publicClassNamePattern=

[GitHub] [beam] daria-malkova commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r783815142 ## File path: playground/backend/internal/preparators/python_preparators.go ## @@ -27,12 +27,30 @@ const ( ) // GetPythonPreparators returns prep

[GitHub] [beam] KhaninArtur commented on a change in pull request #16477: [BEAM-13560][Playground] Split builder into several builders for each step of the pipeline execution

2022-01-13 Thread GitBox
KhaninArtur commented on a change in pull request #16477: URL: https://github.com/apache/beam/pull/16477#discussion_r783816072 ## File path: playground/backend/internal/setup_tools/builder/setup_builder.go ## @@ -31,73 +31,139 @@ const ( javaLogConfigFilePlaceholder = "

[GitHub] [beam] daria-malkova commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r783826381 ## File path: playground/backend/internal/preparators/java_preparators.go ## @@ -41,47 +39,85 @@ const ( publicClassNamePattern=

[GitHub] [beam] daria-malkova commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r783826775 ## File path: playground/backend/internal/preparators/python_preparators.go ## @@ -27,12 +27,30 @@ const ( ) // GetPythonPreparators returns prep

[GitHub] [beam] daria-malkova commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r783827029 ## File path: playground/backend/internal/preparators/java_preparators.go ## @@ -41,47 +39,85 @@ const ( publicClassNamePattern=

[GitHub] [beam] daria-malkova commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r783827119 ## File path: playground/backend/internal/preparators/java_preparators.go ## @@ -41,47 +39,85 @@ const ( publicClassNamePattern=

[GitHub] [beam] codecov[bot] commented on pull request #16465: Stronger typing inference for CoGBK.

2022-01-13 Thread GitBox
codecov[bot] commented on pull request #16465: URL: https://github.com/apache/beam/pull/16465#issuecomment-1012002735 # [Codecov](https://codecov.io/gh/apache/beam/pull/16465?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] KhaninArtur commented on a change in pull request #16499: Output Katas elements into stdout

2022-01-13 Thread GitBox
KhaninArtur commented on a change in pull request #16499: URL: https://github.com/apache/beam/pull/16499#discussion_r783834288 ## File path: learning/katas/java/util/src/org/apache/beam/learning/katas/util/Log.java ## @@ -70,6 +70,7 @@ public void processElement(

[GitHub] [beam] KhaninArtur commented on a change in pull request #16499: Output Katas elements into stdout

2022-01-13 Thread GitBox
KhaninArtur commented on a change in pull request #16499: URL: https://github.com/apache/beam/pull/16499#discussion_r783834288 ## File path: learning/katas/java/util/src/org/apache/beam/learning/katas/util/Log.java ## @@ -70,6 +70,7 @@ public void processElement(

[GitHub] [beam] codecov[bot] edited a comment on pull request #16465: Stronger typing inference for CoGBK.

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16465: URL: https://github.com/apache/beam/pull/16465#issuecomment-1012002735 # [Codecov](https://codecov.io/gh/apache/beam/pull/16465?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] ktttnv opened a new pull request #16501: [DATABEAM-131] Add wrapper class for CDAP plugin

2022-01-13 Thread GitBox
ktttnv opened a new pull request #16501: URL: https://github.com/apache/beam/pull/16501 _Changes:_ - Added wrapper classes for source and sink CDAP plugins - Added builder for plugin wrapper class Thank you for your contribution! Follow this c

[GitHub] [beam] AydarZaynutdinov opened a new pull request #16502: [BEAM-13650][Playground] Add link for examples

2022-01-13 Thread GitBox
AydarZaynutdinov opened a new pull request #16502: URL: https://github.com/apache/beam/pull/16502 [BEAM-13650] Add link for examples. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] AydarZaynutdinov commented on pull request #16502: [BEAM-13650][Playground] Add link for examples

2022-01-13 Thread GitBox
AydarZaynutdinov commented on pull request #16502: URL: https://github.com/apache/beam/pull/16502#issuecomment-1012093789 R: @KhaninArtur @ilya-kozyrev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] ktttnv closed pull request #16501: [DATABEAM-131] Add wrapper class for CDAP plugin

2022-01-13 Thread GitBox
ktttnv closed pull request #16501: URL: https://github.com/apache/beam/pull/16501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [beam] mosche opened a new pull request #16503: [BEAM-13635] Fix usage of SnsIO.write topicArn (AWS Sdk v2)

2022-01-13 Thread GitBox
mosche opened a new pull request #16503: URL: https://github.com/apache/beam/pull/16503 The usage of `SnsIO.write` is rather unintuitive at the moment. `topicArn` is a required configuration and during `expand` the existence of the topic is validated. However, the user also ha

[GitHub] [beam] KhaninArtur commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
KhaninArtur commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r783963670 ## File path: playground/backend/internal/preparers/go_preparators_test.go ## @@ -13,7 +13,7 @@ // See the License for the specific language governing

[GitHub] [beam] KhaninArtur commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-13 Thread GitBox
KhaninArtur commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r783971916 ## File path: playground/backend/configs/DEFAULT_EXAMPLES.json ## @@ -0,0 +1,5 @@ +{ Review comment: I think it's a good place for this file. W

[GitHub] [beam] KhaninArtur commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-13 Thread GitBox
KhaninArtur commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r783975236 ## File path: playground/backend/internal/cloud_bucket/precompiled_objects.go ## @@ -173,6 +175,30 @@ func (cd *CloudStorage) GetPrecompiledObjects(ctx

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-13 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r783976605 ## File path: playground/backend/configs/DEFAULT_EXAMPLES.json ## @@ -0,0 +1,5 @@ +{ Review comment: Now `configs` folder contains files t

[GitHub] [beam] zhoufek commented on pull request #16235: [BEAM-12697] Add basics for SBE schema

2022-01-13 Thread GitBox
zhoufek commented on pull request #16235: URL: https://github.com/apache/beam/pull/16235#issuecomment-1012158952 I'm still waiting for more feedback. I think this PR just got lost amid vacations. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] KhaninArtur commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-13 Thread GitBox
KhaninArtur commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r783979976 ## File path: playground/backend/configs/DEFAULT_EXAMPLES.json ## @@ -0,0 +1,5 @@ +{ Review comment: Hm, on the other hand, we can configure de

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-13 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r783981458 ## File path: playground/backend/configs/DEFAULT_EXAMPLES.json ## @@ -0,0 +1,5 @@ +{ Review comment: Sounds good. -- This is an autom

[GitHub] [beam] KhaninArtur commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-13 Thread GitBox
KhaninArtur commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r783982393 ## File path: playground/backend/configs/DEFAULT_EXAMPLES.json ## @@ -0,0 +1,5 @@ +{ Review comment: @pavel-avilov could you please change the

[GitHub] [beam] KhaninArtur commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-13 Thread GitBox
KhaninArtur commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r783984978 ## File path: playground/backend/cmd/server/server.go ## @@ -109,6 +119,18 @@ func setupCache(ctx context.Context, appEnv environment.ApplicationEnvs)

[GitHub] [beam] scwhittle commented on a change in pull request #16495: [BEAM-13015] Provide caching statistics in the status client.

2022-01-13 Thread GitBox
scwhittle commented on a change in pull request #16495: URL: https://github.com/apache/beam/pull/16495#discussion_r783999225 ## File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/CachesTest.java ## @@ -160,4 +160,20 @@ private void testCache(Cache cache) {

[GitHub] [beam] pcoet opened a new pull request #16504: Redirecting cross-language transforms content

2022-01-13 Thread GitBox
pcoet opened a new pull request #16504: URL: https://github.com/apache/beam/pull/16504 **Please** add a meaningful description for your change here @chamikaramj These changes redirect the "Cross-language transforms" page: * Moved `documentation/patterns/cross-language`

[GitHub] [beam] ElessarST opened a new pull request #16505: [BEAM-13527] [Playground] Pipeline options dialog

2022-01-13 Thread GitBox
ElessarST opened a new pull request #16505: URL: https://github.com/apache/beam/pull/16505 Changed pipeline options text field to pipeline options dialog (https://issues.apache.org/jira/browse/BEAM-13527) https://user-images.githubusercontent.com/6143095/149350542-1d7033fa-50e6-4671-b863

[GitHub] [beam] daria-malkova commented on a change in pull request #16477: [BEAM-13560][Playground] Split builder into several builders for each step of the pipeline execution

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16477: URL: https://github.com/apache/beam/pull/16477#discussion_r784023100 ## File path: playground/backend/internal/setup_tools/builder/setup_builder.go ## @@ -31,73 +31,139 @@ const ( javaLogConfigFilePlaceholder =

[GitHub] [beam] daria-malkova commented on a change in pull request #16477: [BEAM-13560][Playground] Split builder into several builders for each step of the pipeline execution

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16477: URL: https://github.com/apache/beam/pull/16477#discussion_r784023314 ## File path: playground/backend/internal/setup_tools/builder/setup_builder.go ## @@ -31,73 +31,139 @@ const ( javaLogConfigFilePlaceholder =

[GitHub] [beam] daria-malkova commented on a change in pull request #16477: [BEAM-13560][Playground] Split builder into several builders for each step of the pipeline execution

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16477: URL: https://github.com/apache/beam/pull/16477#discussion_r784027376 ## File path: playground/backend/internal/setup_tools/builder/setup_builder.go ## @@ -31,73 +31,139 @@ const ( javaLogConfigFilePlaceholder =

[GitHub] [beam] daria-malkova commented on a change in pull request #16477: [BEAM-13560][Playground] Split builder into several builders for each step of the pipeline execution

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16477: URL: https://github.com/apache/beam/pull/16477#discussion_r784027688 ## File path: playground/backend/internal/setup_tools/builder/setup_builder.go ## @@ -31,73 +31,139 @@ const ( javaLogConfigFilePlaceholder =

[GitHub] [beam] ElessarST commented on pull request #16385: [BEAM-13535] [Playground] add cancel execution button

2022-01-13 Thread GitBox
ElessarST commented on pull request #16385: URL: https://github.com/apache/beam/pull/16385#issuecomment-1012210017 > can you resolve conflicts please @ElessarST ? Sorry, I resolved conflicts, thanks -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] daria-malkova commented on pull request #16477: [BEAM-13560][Playground] Split builder into several builders for each step of the pipeline execution

2022-01-13 Thread GitBox
daria-malkova commented on pull request #16477: URL: https://github.com/apache/beam/pull/16477#issuecomment-1012210927 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] yeandy commented on pull request #16496: [BEAM-13480] Increase pipeline timeout for PubSubIntegrationTest.test_streaming_data_only

2022-01-13 Thread GitBox
yeandy commented on pull request #16496: URL: https://github.com/apache/beam/pull/16496#issuecomment-1012213041 Sounds good, they all passed again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] daria-malkova commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r784038299 ## File path: playground/backend/internal/preparers/go_preparators.go ## @@ -13,33 +13,61 @@ // See the License for the specific language governing

[GitHub] [beam] daria-malkova commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r784039723 ## File path: playground/backend/internal/preparers/java_preparators.go ## @@ -40,47 +38,85 @@ const ( publicClassNamePattern= "p

[GitHub] [beam] daria-malkova commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r784040116 ## File path: playground/backend/internal/preparers/java_preparators_test.go ## @@ -88,25 +88,39 @@ func Test_replace(t *testing.T) { } }

[GitHub] [beam] daria-malkova commented on a change in pull request #16482: [BEAM-13429][Playground] Add builder for preparers

2022-01-13 Thread GitBox
daria-malkova commented on a change in pull request #16482: URL: https://github.com/apache/beam/pull/16482#discussion_r784040622 ## File path: playground/backend/internal/preparers/java_preparators_test.go ## @@ -88,25 +88,39 @@ func Test_replace(t *testing.T) { } }

[GitHub] [beam] yeandy commented on pull request #16497: [BEAM-13218] Increase pipeline timeout for PubSubIntegrationTest.test_streaming_with_attributes

2022-01-13 Thread GitBox
yeandy commented on pull request #16497: URL: https://github.com/apache/beam/pull/16497#issuecomment-1012226104 R: @TheNeuralBit Looks like even with the increased timeout, `test_streaming_with_attributes` is having the original timestamp attributes error that you originally reported.

[GitHub] [beam] KhaninArtur commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-13 Thread GitBox
KhaninArtur commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r784052287 ## File path: playground/backend/cmd/server/controller.go ## @@ -241,20 +241,34 @@ func (controller *playgroundController) Cancel(ctx context.Context,

[GitHub] [beam] AydarZaynutdinov opened a new pull request #16506: [BEAM-13652][Playground] Send examples' links to the frontend

2022-01-13 Thread GitBox
AydarZaynutdinov opened a new pull request #16506: URL: https://github.com/apache/beam/pull/16506 Add the link to the PrecompiledObject Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] AydarZaynutdinov commented on pull request #16506: [BEAM-13652][Playground] Send examples' links to the frontend

2022-01-13 Thread GitBox
AydarZaynutdinov commented on pull request #16506: URL: https://github.com/apache/beam/pull/16506#issuecomment-1012230373 R: @KhaninArtur @ilya-kozyrev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] egalpin commented on pull request #16309: [BEAM-13503] Fixes bug in java ElasticsearchIO BulkIO constructor

2022-01-13 Thread GitBox
egalpin commented on pull request #16309: URL: https://github.com/apache/beam/pull/16309#issuecomment-1012248745 Thanks @khersey for adding the common method for the tests! I admit that the testing setup for Elasticsearch could be improved, but this new method you've add will need to be in

[GitHub] [beam] fernando-wizeline commented on pull request #16436: [BEAM-1330] - DatastoreIO Writes should flush early when duplicate keys arrive

2022-01-13 Thread GitBox
fernando-wizeline commented on pull request #16436: URL: https://github.com/apache/beam/pull/16436#issuecomment-1012271962 > What is the next step on this PR? Hi @aaltay ! I need to add a new test to confirm the changes are good. All the tests in DatastoreV1Test linked to DatastoreWr

[GitHub] [beam] egalpin opened a new pull request #16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api

2022-01-13 Thread GitBox
egalpin opened a new pull request #16507: URL: https://github.com/apache/beam/pull/16507 **Please** add a meaningful description for your change here Fixes BEAM-13137 and possibly BEAM-5172. Elasticsearch read/split/size has often been flaky in unit tests

[GitHub] [beam] egalpin commented on pull request #16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api

2022-01-13 Thread GitBox
egalpin commented on pull request #16507: URL: https://github.com/apache/beam/pull/16507#issuecomment-1012293403 R: @echauchot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] egalpin commented on pull request #16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api

2022-01-13 Thread GitBox
egalpin commented on pull request #16507: URL: https://github.com/apache/beam/pull/16507#issuecomment-1012317109 All previously skipped tests passed: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/20510/testReport/org.apache.beam.sdk.io.elasticsearch/ElasticsearchIOTest/

[GitHub] [beam] aromanenko-dev commented on pull request #16284: [BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types…

2022-01-13 Thread GitBox
aromanenko-dev commented on pull request #16284: URL: https://github.com/apache/beam/pull/16284#issuecomment-1012339944 @mosche Thanks for review! @vitaly-ivanov Could you squash all commits and avoid merge master into the feature branch (please, use rebase instead)? -- This is an aut

[GitHub] [beam] tvalentyn opened a new pull request #16508: [BEAM-13656] Provide an API to check whether a hint is known.

2022-01-13 Thread GitBox
tvalentyn opened a new pull request #16508: URL: https://github.com/apache/beam/pull/16508 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://

[GitHub] [beam] tvalentyn commented on pull request #16508: [BEAM-13656] Provide an API to check whether a hint is known.

2022-01-13 Thread GitBox
tvalentyn commented on pull request #16508: URL: https://github.com/apache/beam/pull/16508#issuecomment-1012366280 R: @ryanthompson591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] ibzib commented on a change in pull request #16380: [BEAM-13577] Beam Select's uniquifyNames function loses nullability of Complex types while inferring schema

2022-01-13 Thread GitBox
ibzib commented on a change in pull request #16380: URL: https://github.com/apache/beam/pull/16380#discussion_r784194971 ## File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamComplexTypeTest.java ## @@ -367,21 +370,21 @@ public void testNu

[GitHub] [beam] ibzib commented on pull request #14974: [BEAM-12464] Change ProtoSchemaTranslator beam schema creation to match the order for protobufs containing Oneof fields

2022-01-13 Thread GitBox
ibzib commented on pull request #14974: URL: https://github.com/apache/beam/pull/14974#issuecomment-1012374679 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] TheNeuralBit commented on pull request #16496: [BEAM-13480] Increase pipeline timeout for PubSubIntegrationTest.test_streaming_data_only

2022-01-13 Thread GitBox
TheNeuralBit commented on pull request #16496: URL: https://github.com/apache/beam/pull/16496#issuecomment-1012380903 Confirmed they look good, thanks again! PostCommit seems to have a new issue: ``` 17:22:14 FAILURE: Build failed with an exception. 17:22:14 17:22:14 * Wh

[GitHub] [beam] TheNeuralBit merged pull request #16496: [BEAM-13480] Increase pipeline timeout for PubSubIntegrationTest.test_streaming_data_only

2022-01-13 Thread GitBox
TheNeuralBit merged pull request #16496: URL: https://github.com/apache/beam/pull/16496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-uns

[GitHub] [beam] codecov[bot] commented on pull request #16508: [BEAM-13656] Provide an API to check whether a hint is known.

2022-01-13 Thread GitBox
codecov[bot] commented on pull request #16508: URL: https://github.com/apache/beam/pull/16508#issuecomment-1012382470 # [Codecov](https://codecov.io/gh/apache/beam/pull/16508?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16508: [BEAM-13656] Provide an API to check whether a hint is known.

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16508: URL: https://github.com/apache/beam/pull/16508#issuecomment-1012382470 # [Codecov](https://codecov.io/gh/apache/beam/pull/16508?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] emilymye opened a new pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
emilymye opened a new pull request #16509: URL: https://github.com/apache/beam/pull/16509 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quick

[GitHub] [beam] robertwb merged pull request #16465: Stronger typing inference for CoGBK.

2022-01-13 Thread GitBox
robertwb merged pull request #16465: URL: https://github.com/apache/beam/pull/16465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] tvalentyn commented on pull request #15449: Fail build pyarrow on m1

2022-01-13 Thread GitBox
tvalentyn commented on pull request #15449: URL: https://github.com/apache/beam/pull/15449#issuecomment-1012396624 Is this reproducible? 1) Do you use a virtual environment 2) Do you have wheel dependency installed? -- This is an automated message from the Apache Git Service. To re

[GitHub] [beam] tvalentyn edited a comment on pull request #15449: Fail build pyarrow on m1

2022-01-13 Thread GitBox
tvalentyn edited a comment on pull request #15449: URL: https://github.com/apache/beam/pull/15449#issuecomment-1012396624 Is this reproducible on latest version of Beam? 1) Do you use a virtual environment? 2) Do you have wheel dependency installed? -- This is an automated message

[GitHub] [beam] kw2542 closed pull request #16510: Update workflow

2022-01-13 Thread GitBox
kw2542 closed pull request #16510: URL: https://github.com/apache/beam/pull/16510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [beam] kw2542 opened a new pull request #16510: Update workflow

2022-01-13 Thread GitBox
kw2542 opened a new pull request #16510: URL: https://github.com/apache/beam/pull/16510 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] codecov[bot] edited a comment on pull request #16508: [BEAM-13656] Provide an API to check whether a hint is known.

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16508: URL: https://github.com/apache/beam/pull/16508#issuecomment-1012382470 # [Codecov](https://codecov.io/gh/apache/beam/pull/16508?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] commented on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
codecov[bot] commented on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012411865 # [Codecov](https://codecov.io/gh/apache/beam/pull/16509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012411865 # [Codecov](https://codecov.io/gh/apache/beam/pull/16509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-13 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r784237568 ## File path: playground/backend/cmd/server/controller.go ## @@ -241,22 +241,28 @@ func (controller *playgroundController) Cancel(ctx context.Con

[GitHub] [beam] emilymye commented on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
emilymye commented on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012416723 As far as I can tell, the following are in the BOM (but were also managed by previous version of BOM so I don't know if we are keeping them separate for other reasons):

[GitHub] [beam] emilymye edited a comment on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
emilymye edited a comment on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012416723 As far as I can tell, the following are in the BOM (but were also managed by previous version of BOM so I don't know if we are keeping them separate for other reasons):

[GitHub] [beam] emilymye edited a comment on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
emilymye edited a comment on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012416723 As far as I can tell, the following are in the BOM (but were also managed by previous version of BOM so I don't know if we are keeping them separate for other reasons):

[GitHub] [beam] codecov[bot] edited a comment on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012411865 # [Codecov](https://codecov.io/gh/apache/beam/pull/16509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012411865 # [Codecov](https://codecov.io/gh/apache/beam/pull/16509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] chamikaramj commented on a change in pull request #16225: [BEAM-13455] Remove duplicated artifacts when using multiple environm…

2022-01-13 Thread GitBox
chamikaramj commented on a change in pull request #16225: URL: https://github.com/apache/beam/pull/16225#discussion_r784244930 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java ## @@ -958,6 +959,11 @@ private De

[GitHub] [beam] ibzib merged pull request #14974: [BEAM-12464] Change ProtoSchemaTranslator beam schema creation to match the order for protobufs containing Oneof fields

2022-01-13 Thread GitBox
ibzib merged pull request #14974: URL: https://github.com/apache/beam/pull/14974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr..

[GitHub] [beam] codecov[bot] edited a comment on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012411865 # [Codecov](https://codecov.io/gh/apache/beam/pull/16509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012411865 # [Codecov](https://codecov.io/gh/apache/beam/pull/16509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012411865 # [Codecov](https://codecov.io/gh/apache/beam/pull/16509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012411865 # [Codecov](https://codecov.io/gh/apache/beam/pull/16509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] suztomo commented on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
suztomo commented on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012455017 Nice. It's a good opportunity to maintain google-cloud-pubsublite version via the BOM. These versions in the BOM are built and tested with the same version of the dependencies.

[GitHub] [beam] robertwb merged pull request #16101: Introduce the notion of a JoinIndex for fewer shuffles.

2022-01-13 Thread GitBox
robertwb merged pull request #16101: URL: https://github.com/apache/beam/pull/16101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] pabloem commented on pull request #16467: [BEAM-12164]: SpannerIO DetectNewPartitions SDF

2022-01-13 Thread GitBox
pabloem commented on pull request #16467: URL: https://github.com/apache/beam/pull/16467#issuecomment-1012456350 this LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] pabloem merged pull request #16467: [BEAM-12164]: SpannerIO DetectNewPartitions SDF

2022-01-13 Thread GitBox
pabloem merged pull request #16467: URL: https://github.com/apache/beam/pull/16467 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] pabloem commented on pull request #16467: [BEAM-12164]: SpannerIO DetectNewPartitions SDF

2022-01-13 Thread GitBox
pabloem commented on pull request #16467: URL: https://github.com/apache/beam/pull/16467#issuecomment-1012456599 thanks @thiagotnunes @hengfengli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] TheNeuralBit commented on pull request #16235: [BEAM-12697] Add basics for SBE schema

2022-01-13 Thread GitBox
TheNeuralBit commented on pull request #16235: URL: https://github.com/apache/beam/pull/16235#issuecomment-1012460166 Hey @zhoufek sorry for the delay. I'm still not entirely clear on why this is necessary, and right now I'm just inclined to hold off until more of the implementation is rea

[GitHub] [beam] codecov[bot] edited a comment on pull request #16508: [BEAM-13656] Provide an API to check whether a hint is known.

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16508: URL: https://github.com/apache/beam/pull/16508#issuecomment-1012382470 # [Codecov](https://codecov.io/gh/apache/beam/pull/16508?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] dannymartinm opened a new pull request #16511: [BEAM 12812] - Run Github Actions on GCP workers in the apache-beam-testing project

2022-01-13 Thread GitBox
dannymartinm opened a new pull request #16511: URL: https://github.com/apache/beam/pull/16511 Updated GitHub Actions workflows to run in self-hosted Ubuntu 20.04 runners. * Docker image created and stored in Google Cloud Artifact Registry (beam-github-actions) * Linux hosts running in

[GitHub] [beam] tvalentyn commented on pull request #13607: [BEAM-11520] Stage extra PyPI dependencies with generated requirements

2022-01-13 Thread GitBox
tvalentyn commented on pull request #13607: URL: https://github.com/apache/beam/pull/13607#issuecomment-1012472909 thanks, updated the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] codecov[bot] edited a comment on pull request #16508: [BEAM-13656] Provide an API to check whether a hint is known.

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16508: URL: https://github.com/apache/beam/pull/16508#issuecomment-1012382470 # [Codecov](https://codecov.io/gh/apache/beam/pull/16508?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16508: [BEAM-13656] Provide an API to check whether a hint is known.

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16508: URL: https://github.com/apache/beam/pull/16508#issuecomment-1012382470 # [Codecov](https://codecov.io/gh/apache/beam/pull/16508?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16508: [BEAM-13656] Provide an API to check whether a hint is known.

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16508: URL: https://github.com/apache/beam/pull/16508#issuecomment-1012382470 # [Codecov](https://codecov.io/gh/apache/beam/pull/16508?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pabloem merged pull request #16385: [BEAM-13535] [Playground] add cancel execution button

2022-01-13 Thread GitBox
pabloem merged pull request #16385: URL: https://github.com/apache/beam/pull/16385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] pabloem commented on pull request #16485: [BEAM-13486] [Playground] For unit tests (java) if one of tests fails the output goes to stdOutput

2022-01-13 Thread GitBox
pabloem commented on pull request #16485: URL: https://github.com/apache/beam/pull/16485#issuecomment-1012523434 LGTM thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] pabloem merged pull request #16485: [BEAM-13486] [Playground] For unit tests (java) if one of tests fails the output goes to stdOutput

2022-01-13 Thread GitBox
pabloem merged pull request #16485: URL: https://github.com/apache/beam/pull/16485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] codecov[bot] edited a comment on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-13 Thread GitBox
codecov[bot] edited a comment on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1012411865 # [Codecov](https://codecov.io/gh/apache/beam/pull/16509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

  1   2   3   >