Weijun-H commented on PR #14411:
URL: https://github.com/apache/datafusion/pull/14411#issuecomment-2660797386
> I ran some tests yesterday and I can confirm the runtime improvements. I
do get some high memory usage however especially with some queries (TPC-H Query
18 I believe) than when us
Kontinuation commented on PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2660794608
> Edge case: let's say input is a deduplicated `StringViewArray` (like a 10k
rows batch with only 100 distinct values, but payload content are stored
without duplication, the ar
2010YOUY01 commented on PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2660783992
> Here is the detailed explanation:
>
> 1. We reserve 2X memory for each batch on insertion, so when
`in_mem_batches` holds 5 batches and consumes 50 MB memory, we have alre
zhuqi-lucas commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957058065
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -641,7 +702,15 @@ pub fn sort_batch(
lexsort_to_indices(&sort_columns, fetch)?
};
-let
zhuqi-lucas commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957057990
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -302,31 +299,16 @@ impl ExternalSorter {
}
self.reserve_memory_for_merge()?;
-
zhuqi-lucas commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957056599
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -641,7 +702,15 @@ pub fn sort_batch(
lexsort_to_indices(&sort_columns, fetch)?
};
-let
Kontinuation commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957056835
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -641,7 +702,15 @@ pub fn sort_batch(
lexsort_to_indices(&sort_columns, fetch)?
};
-le
Kontinuation commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957056835
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -641,7 +702,15 @@ pub fn sort_batch(
lexsort_to_indices(&sort_columns, fetch)?
};
-le
Kontinuation commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957056835
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -641,7 +702,15 @@ pub fn sort_batch(
lexsort_to_indices(&sort_columns, fetch)?
};
-le
zhuqi-lucas commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957054182
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -641,7 +702,15 @@ pub fn sort_batch(
lexsort_to_indices(&sort_columns, fetch)?
};
-let
zhuqi-lucas commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957055119
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -408,50 +395,100 @@ impl ExternalSorter {
debug!("Spilling sort data of ExternalSorter to disk
zhuqi-lucas commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957054182
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -641,7 +702,15 @@ pub fn sort_batch(
lexsort_to_indices(&sort_columns, fetch)?
};
-let
Kontinuation commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957054215
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -302,31 +299,16 @@ impl ExternalSorter {
}
self.reserve_memory_for_merge()?;
-
dentiny opened a new issue, #14678:
URL: https://github.com/apache/datafusion/issues/14678
### Is your feature request related to a problem or challenge?
When I was building datafusion for the first time (with `cargo test`), I met
an error:
```
error: failed to run custom build
zhuqi-lucas commented on PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2660771854
> > Thank you @kazuyukitanimura for the PR, i applied the PR try to fix the
testing, but the above testing is still failed for me, i am not sure if i am
missing something.
>
Weijun-H commented on code in PR #14411:
URL: https://github.com/apache/datafusion/pull/14411#discussion_r1957051847
##
datafusion/physical-plan/src/repartition/on_demand_repartition.rs:
##
@@ -0,0 +1,1589 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
Weijun-H commented on code in PR #14411:
URL: https://github.com/apache/datafusion/pull/14411#discussion_r1957051847
##
datafusion/physical-plan/src/repartition/on_demand_repartition.rs:
##
@@ -0,0 +1,1589 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
zhuqi-lucas commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957051337
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -302,31 +299,16 @@ impl ExternalSorter {
}
self.reserve_memory_for_merge()?;
-
zhuqi-lucas commented on code in PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#discussion_r1957051337
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -302,31 +299,16 @@ impl ExternalSorter {
}
self.reserve_memory_for_merge()?;
-
zhuqi-lucas commented on PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2660767316
> > Thank you @kazuyukitanimura for the PR, i applied the PR try to fix the
testing, but the above testing is still failed for me, i am not sure if i am
missing something.
>
wiedld commented on code in PR #14637:
URL: https://github.com/apache/datafusion/pull/14637#discussion_r1957023902
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -126,29 +126,65 @@ fn update_sort_ctx_children(
/// [`CoalescePartitionsExec`] descendant(s) for
wiedld commented on code in PR #14673:
URL: https://github.com/apache/datafusion/pull/14673#discussion_r1957046184
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -84,42 +84,56 @@ impl EnforceSorting {
}
}
-/// This object is used within the [`EnforceS
wiedld commented on code in PR #14673:
URL: https://github.com/apache/datafusion/pull/14673#discussion_r1957046184
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -84,42 +84,56 @@ impl EnforceSorting {
}
}
-/// This object is used within the [`EnforceS
wiedld commented on code in PR #14673:
URL: https://github.com/apache/datafusion/pull/14673#discussion_r1957033990
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -151,10 +165,51 @@ fn update_coalesce_ctx_children(
};
}
-/// The boolean flag `repartiti
wiedld commented on code in PR #14673:
URL: https://github.com/apache/datafusion/pull/14673#discussion_r1957033990
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -151,10 +165,51 @@ fn update_coalesce_ctx_children(
};
}
-/// The boolean flag `repartiti
Kontinuation commented on PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2660748423
> Thank you @kazuyukitanimura for the PR, i applied the PR try to fix the
testing, but the above testing is still failed for me, i am not sure if i am
missing something.
Dandandan commented on code in PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#discussion_r1957035222
##
datafusion/functions/src/string/uuid.rs:
##
@@ -87,7 +88,13 @@ impl ScalarUDFImpl for UuidFunc {
if !args.is_empty() {
return internal_e
wiedld commented on code in PR #14673:
URL: https://github.com/apache/datafusion/pull/14673#discussion_r1957033990
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -151,10 +165,51 @@ fn update_coalesce_ctx_children(
};
}
-/// The boolean flag `repartiti
wiedld commented on code in PR #14637:
URL: https://github.com/apache/datafusion/pull/14637#discussion_r1957023902
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -126,29 +126,65 @@ fn update_sort_ctx_children(
/// [`CoalescePartitionsExec`] descendant(s) for
wiedld commented on code in PR #14637:
URL: https://github.com/apache/datafusion/pull/14637#discussion_r1957023902
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -126,29 +126,65 @@ fn update_sort_ctx_children(
/// [`CoalescePartitionsExec`] descendant(s) for
wiedld commented on code in PR #14637:
URL: https://github.com/apache/datafusion/pull/14637#discussion_r1957033043
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -138,27 +138,25 @@ fn is_coalesce_to_remove(
node: &Arc,
parent: &Arc,
) -> bool {
-
wiedld commented on code in PR #14637:
URL: https://github.com/apache/datafusion/pull/14637#discussion_r1957032310
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -138,27 +138,25 @@ fn is_coalesce_to_remove(
node: &Arc,
parent: &Arc,
) -> bool {
-
wiedld commented on code in PR #14637:
URL: https://github.com/apache/datafusion/pull/14637#discussion_r1957024693
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -298,20 +355,11 @@ pub fn parallelize_sorts(
vec![requirements],
),
wiedld commented on code in PR #14637:
URL: https://github.com/apache/datafusion/pull/14637#discussion_r1957023902
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -126,29 +126,65 @@ fn update_sort_ctx_children(
/// [`CoalescePartitionsExec`] descendant(s) for
zhuqi-lucas commented on PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2660707498
```rust
use arrow::array::{RecordBatch, StringBuilder};
use arrow_schema::{DataType, Field, Schema};
use datafusion::execution::disk_manager::DiskManagerConfig;
use dat
irenjj opened a new pull request, #14677:
URL: https://github.com/apache/datafusion/pull/14677
## Which issue does this PR close?
- Partof #9371
## Rationale for this change
## What changes are included in this PR?
## Are these changes teste
andygrove commented on PR #1405:
URL:
https://github.com/apache/datafusion-comet/pull/1405#issuecomment-2660658972
> > What about `.github/actions/setup-spark-builder/action.yaml`?
>
> There is no need to override the default value since it gets replace
dynamically, but I filed an is
parthchandra commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1956991849
##
native/core/src/execution/planner.rs:
##
@@ -1155,12 +1154,9 @@ impl PhysicalPlanner {
))
});
-
shehabgamin commented on PR #14440:
URL: https://github.com/apache/datafusion/pull/14440#issuecomment-2660643722
@jayzhan211 I will re-review by tomorrow EOD, exciting progress!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
codecov-commenter commented on PR #1405:
URL:
https://github.com/apache/datafusion-comet/pull/1405#issuecomment-2660637358
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1405?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
github-actions[bot] closed pull request #1581: Reorganize the Parser module
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
github-actions[bot] closed pull request #13699: PoC Adaptive round robin
repartitioning
URL: https://github.com/apache/datafusion/pull/13699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
github-actions[bot] commented on PR #13420:
URL: https://github.com/apache/datafusion/pull/13420#issuecomment-2660627372
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
andygrove commented on PR #1405:
URL:
https://github.com/apache/datafusion-comet/pull/1405#issuecomment-2660616259
> What about `.github/actions/setup-spark-builder/action.yaml`?
There is no need to override the default value since it gets replace
dynamically, but I filed an issue to
andygrove opened a new issue, #1406:
URL: https://github.com/apache/datafusion-comet/issues/1406
### What is the problem the feature request solves?
We hard-code the current snapshot version in some GitHub actions. We should
get the version number from the pom.xml instead to remove th
andygrove commented on PR #1405:
URL:
https://github.com/apache/datafusion-comet/pull/1405#issuecomment-2660614850
> The title says `[branch-0.6]` but this PR is against `main`?
Thanks. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message,
kazuyukitanimura commented on PR #1405:
URL:
https://github.com/apache/datafusion-comet/pull/1405#issuecomment-2660613861
The title says `[branch-0.6]` but this PR is against `main`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
andygrove commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1956971872
##
dev/diffs/3.4.3.diff:
##
@@ -7,7 +7,7 @@ index d3544881af1..26ab186c65d 100644
2.5.1
2.0.8
+3.4
-+0.5.0-SNAPSHOT
Review Comment:
andygrove opened a new pull request, #1405:
URL: https://github.com/apache/datafusion-comet/pull/1405
## Which issue does this PR close?
Fix incorrect Comet version in Spark diffs.
## Rationale for this change
Fixing this just in case anyone wants to run S
kazuyukitanimura commented on PR #14644:
URL: https://github.com/apache/datafusion/pull/14644#issuecomment-2660597523
Not directly related to the point of this PR but regarding
`
I had a hard time making DataFusion Comet work on cloud instances with 4GB
memory per CPU core, partially b
kazuyukitanimura commented on issue #1389:
URL:
https://github.com/apache/datafusion-comet/issues/1389#issuecomment-2660587673
Thanks @viirya
@EmilyMatt Did you mean that we should be able to run Comet aggregation even
Comet shuffle is disabled by
> I believe I've seen a few
irenjj commented on issue #14438:
URL: https://github.com/apache/datafusion/issues/14438#issuecomment-2660573715
> Hey [@irenjj](https://github.com/irenjj) how is it going with this ticket
:) Can I help with anything?
Hi, @eliaperantoni, Sorry for not updating my status for a long tim
kazuyukitanimura commented on PR #1359:
URL:
https://github.com/apache/datafusion-comet/pull/1359#issuecomment-2660574425
oops, @comphead would you mind merging the latest main into this PR branch
in order to resolve the conflict?
--
This is an automated message from the Apache Git Servi
kazuyukitanimura merged PR #1387:
URL: https://github.com/apache/datafusion-comet/pull/1387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
viirya commented on issue #1389:
URL:
https://github.com/apache/datafusion-comet/issues/1389#issuecomment-2660573325
Because this?
```
// When Comet shuffle is disabled, we don't want to transform the
HashAggregate
// to CometHashAggregate. Otherwise, we probably get partial Co
kazuyukitanimura commented on PR #1150:
URL:
https://github.com/apache/datafusion-comet/pull/1150#issuecomment-2660569970
Merged thanks @mbutrovich @parthchandra @comphead @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kazuyukitanimura merged PR #1150:
URL: https://github.com/apache/datafusion-comet/pull/1150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsub
kazuyukitanimura commented on issue #1389:
URL:
https://github.com/apache/datafusion-comet/issues/1389#issuecomment-2660567872
cc @viirya
I forgot why we did this in #991
https://github.com/apache/datafusion-comet/blob/f099e6e40aa18441c7882e5bffd9d6dfb10c6c19/spark/src/main/scala/or
kazuyukitanimura commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1956946498
##
dev/diffs/3.4.3.diff:
##
@@ -7,7 +7,7 @@ index d3544881af1..26ab186c65d 100644
2.5.1
2.0.8
+3.4
-+0.5.0-SNAPSHOT
Review Comme
comphead commented on PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#issuecomment-2660554270
@simonvandel I'd like to ask you to create a slt test for UUID(), I know it
is non guaranteed output, but we can check the v4 validity format I suppose.
--
This is an automated me
comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1956937048
##
native/core/src/execution/planner.rs:
##
@@ -1155,12 +1154,9 @@ impl PhysicalPlanner {
))
});
-let
kazuyukitanimura commented on PR #1390:
URL:
https://github.com/apache/datafusion-comet/pull/1390#issuecomment-2660546336
#1389 mentioned
https://github.com/apache/datafusion-comet/blob/f099e6e40aa18441c7882e5bffd9d6dfb10c6c19/spark/src/main/scala/org/apache/comet/CometSparkSessionExtens
parthchandra commented on PR #1150:
URL:
https://github.com/apache/datafusion-comet/pull/1150#issuecomment-2660530828
> > @mbutrovich Do you plan to overwrite
spark/benchmarks/CometReadBenchmark-jdk11-results.txt ?
>
> > Thanks for running this benchmark @mbutrovich. Slowness in nati
parthchandra commented on code in PR #1398:
URL: https://github.com/apache/datafusion-comet/pull/1398#discussion_r1956903894
##
spark/src/main/scala/org/apache/comet/DataTypeSupport.scala:
##
@@ -37,7 +37,7 @@ trait DataTypeSupport {
private def isGloballySupported(dt: Data
andygrove merged PR #1398:
URL: https://github.com/apache/datafusion-comet/pull/1398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
parthchandra commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1956879942
##
native/core/src/execution/planner.rs:
##
@@ -1155,12 +1154,9 @@ impl PhysicalPlanner {
))
});
-
comphead commented on code in PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#discussion_r1956877727
##
datafusion/functions/src/string/uuid.rs:
##
@@ -87,7 +88,13 @@ impl ScalarUDFImpl for UuidFunc {
if !args.is_empty() {
return internal_er
simonvandel commented on PR #14675:
URL: https://github.com/apache/datafusion/pull/14675#issuecomment-2660484055
Oops, need to generate valid uuidv4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
comphead opened a new pull request, #14676:
URL: https://github.com/apache/datafusion/pull/14676
## Which issue does this PR close?
Related to #14389
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are th
kazuyukitanimura commented on code in PR #1390:
URL: https://github.com/apache/datafusion-comet/pull/1390#discussion_r1956865360
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -216,6 +216,17 @@ object CometConf extends ShimCometConf {
val COMET_EXEC_INITCAP_
parthchandra commented on PR #1387:
URL:
https://github.com/apache/datafusion-comet/pull/1387#issuecomment-2660476596
@kazuyukitanimura please go ahead and merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kazuyukitanimura commented on code in PR #1390:
URL: https://github.com/apache/datafusion-comet/pull/1390#discussion_r1956799716
##
common/src/main/scala/org/apache/comet/CometConf.scala:
##
@@ -216,6 +216,17 @@ object CometConf extends ShimCometConf {
val COMET_EXEC_INITCAP_
simonvandel opened a new pull request, #14675:
URL: https://github.com/apache/datafusion/pull/14675
## Which issue does this PR close?
N/A
## Rationale for this change
It seems to be faster to generate random u128's in bulk, and then converting
them to Uuids.
comphead commented on issue #14580:
URL: https://github.com/apache/datafusion/issues/14580#issuecomment-2660433774
I'll try to chase
https://github.com/apache/datafusion/issues/13816
https://github.com/apache/datafusion/issues/14389
--
This is an automated message from the Apache Git
codecov-commenter commented on PR #1404:
URL:
https://github.com/apache/datafusion-comet/pull/1404#issuecomment-2660420263
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1404?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
alamb commented on code in PR #14673:
URL: https://github.com/apache/datafusion/pull/14673#discussion_r1956781210
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -151,10 +165,51 @@ fn update_coalesce_ctx_children(
};
}
-/// The boolean flag `repartitio
alamb commented on code in PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#discussion_r1956785686
##
datafusion/physical-optimizer/src/enforce_sorting/replace_with_order_preserving_variants.rs:
##
@@ -45,7 +45,7 @@ use itertools::izip;
pub type OrderPreservation
alamb commented on PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#issuecomment-2660389460
FYI @ozankabak and @berkaysynnada
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
andygrove closed pull request #1261: feat: Add support for distinct aggregates
URL: https://github.com/apache/datafusion-comet/pull/1261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
comphead commented on code in PR #1359:
URL: https://github.com/apache/datafusion-comet/pull/1359#discussion_r1956765242
##
native/core/Cargo.toml:
##
@@ -77,6 +77,7 @@ datafusion-comet-proto = { workspace = true }
object_store = { workspace = true }
url = { workspace = true }
andygrove commented on code in PR #1398:
URL: https://github.com/apache/datafusion-comet/pull/1398#discussion_r1956762065
##
spark/src/main/scala/org/apache/comet/DataTypeSupport.scala:
##
@@ -37,7 +37,7 @@ trait DataTypeSupport {
private def isGloballySupported(dt: DataTyp
andygrove commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1956760901
##
dev/diffs/3.4.3.diff:
##
@@ -7,7 +7,7 @@ index d3544881af1..26ab186c65d 100644
2.5.1
2.0.8
+3.4
-+0.5.0-SNAPSHOT
Review Comment:
andygrove commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1956760033
##
dev/diffs/3.4.3.diff:
##
@@ -7,7 +7,7 @@ index d3544881af1..26ab186c65d 100644
2.5.1
2.0.8
+3.4
-+0.5.0-SNAPSHOT
Review Comment:
andygrove commented on code in PR #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404#discussion_r1956753958
##
dev/diffs/3.4.3.diff:
##
@@ -7,7 +7,7 @@ index d3544881af1..26ab186c65d 100644
2.5.1
2.0.8
+3.4
-+0.5.0-SNAPSHOT
Review Comment:
andygrove opened a new pull request, #1404:
URL: https://github.com/apache/datafusion-comet/pull/1404
## Which issue does this PR close?
Closes #.
## Rationale for this change
## What changes are included in this PR?
## How are these changes
andygrove merged PR #1402:
URL: https://github.com/apache/datafusion-comet/pull/1402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
mbutrovich commented on PR #1150:
URL:
https://github.com/apache/datafusion-comet/pull/1150#issuecomment-2660305494
> Sorry, one more question @mbutrovich do we need to add the
DataFusion/IcebergCompat scans to `readerBenchmark` as well?
That benchmark is more of a microbenchmark tha
findepi opened a new pull request, #14674:
URL: https://github.com/apache/datafusion/pull/14674
GitHub runs include this warning
The Ubuntu-20.04 brownout takes place from 2025-02-01.
For more details, see
https://github.com/actions/runner-images/issues/11101
Let's t
wiedld commented on code in PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#discussion_r1956722551
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -119,7 +119,7 @@ fn update_sort_ctx_children(
}
node.data = data;
-node.update_pl
findepi commented on PR #14668:
URL: https://github.com/apache/datafusion/pull/14668#issuecomment-2660287208
i now also have support for
various numeric
```rust
#[excalibur_function]
fn add(a: i32, b: u32) -> i64 {
a as i64 + b as i64
}
```
nullable fu
wiedld commented on code in PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#discussion_r1956722551
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -119,7 +119,7 @@ fn update_sort_ctx_children(
}
node.data = data;
-node.update_pl
wiedld opened a new pull request, #14673:
URL: https://github.com/apache/datafusion/pull/14673
## Which issue does this PR close?
Helps with the docs effort https://github.com/apache/datafusion/issues/7013.
## Rationale for this change
Noticed while reviewing https://gith
wiedld commented on code in PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#discussion_r1956722551
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -119,7 +119,7 @@ fn update_sort_ctx_children(
}
node.data = data;
-node.update_pl
wiedld commented on code in PR #14650:
URL: https://github.com/apache/datafusion/pull/14650#discussion_r1956722551
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -119,7 +119,7 @@ fn update_sort_ctx_children(
}
node.data = data;
-node.update_pl
wiedld commented on code in PR #14673:
URL: https://github.com/apache/datafusion/pull/14673#discussion_r1956718287
##
datafusion/physical-optimizer/src/enforce_sorting/mod.rs:
##
@@ -84,42 +84,56 @@ impl EnforceSorting {
}
}
-/// This object is used within the [`EnforceS
friendlymatthew opened a new pull request, #14672:
URL: https://github.com/apache/datafusion/pull/14672
Closes #14613
`array_prepend` would error when attempting to concatenate certain `List`
data types due to an incorrect offset type assumption. The error occurs because
the impleme
kazuyukitanimura commented on code in PR #1398:
URL: https://github.com/apache/datafusion-comet/pull/1398#discussion_r1956696728
##
spark/src/main/scala/org/apache/comet/DataTypeSupport.scala:
##
@@ -37,7 +37,7 @@ trait DataTypeSupport {
private def isGloballySupported(dt:
Omega359 commented on issue #14661:
URL: https://github.com/apache/datafusion/issues/14661#issuecomment-2660211300
https://github.com/apache/datafusion/issues/8282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
kazuyukitanimura commented on PR #1387:
URL:
https://github.com/apache/datafusion-comet/pull/1387#issuecomment-2660195143
@parthchandra any other comments? otherwise I can merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
milenkovicm commented on PR #14631:
URL: https://github.com/apache/datafusion/pull/14631#issuecomment-2660174463
@alamb this PR looks fine I verified it with
`datafusion.execution.parquet.pushdown_filters=true` but still same problem
like https://github.com/apache/datafusion/pull/14631#iss
1 - 100 of 219 matches
Mail list logo
