kazuyukitanimura commented on code in PR #1398:
URL: https://github.com/apache/datafusion-comet/pull/1398#discussion_r1956696728
##########
spark/src/main/scala/org/apache/comet/DataTypeSupport.scala:
##########
@@ -37,7 +37,7 @@ trait DataTypeSupport {
private def isGloballySupported(dt: DataType): Boolean = dt match {
case ByteType | ShortType
- if CometSparkSessionExtensions.isComplexTypeReaderEnabled(SQLConf.get)
&&
+ if CometSparkSessionExtensions.usingDataFusionParquetExec(SQLConf.get)
&&
Review Comment:
I wonder if there ways to disable specific for unit rather than disabling
for all bytes and shorts, but should be in a separate PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
