crystalxyz commented on issue #17087:
URL: https://github.com/apache/datafusion/issues/17087#issuecomment-3235551112
Hi @timsaucer, I'm returning to the community and refreshing my memory on
FFI! I've just implemented a quick fix for this issue, and please let me know
if this is what you ha
ding-young commented on code in PR #17315:
URL: https://github.com/apache/datafusion/pull/17315#discussion_r2308923216
##
datafusion/physical-plan/src/spill/spill_manager.rs:
##
@@ -194,7 +195,84 @@ impl GetSlicedSize for RecordBatch {
for array in self.columns() {
timsaucer merged PR #1213:
URL: https://github.com/apache/datafusion-python/pull/1213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
ding-young commented on issue #17334:
URL: https://github.com/apache/datafusion/issues/17334#issuecomment-3235438790
> I think some specific timing can cause the non-spillable operators to OOM,
however if spillable operators can spill earlier, the execution should be
possible to finish. ([@
timsaucer merged PR #1211:
URL: https://github.com/apache/datafusion-python/pull/1211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
comphead commented on issue #2256:
URL:
https://github.com/apache/datafusion-comet/issues/2256#issuecomment-3235337339
This happens because of
```
if (struct.names.length != struct.names.distinct.length) {
withInfo(expr, "CreateNamedStruct with duplicate field nam
adamreeve commented on code in PR #17342:
URL: https://github.com/apache/datafusion/pull/17342#discussion_r2308836875
##
datafusion/datasource-parquet/src/opener.rs:
##
@@ -152,16 +152,18 @@ impl FileOpener for ParquetOpener {
let mut predicate_file_schema = Arc::clone(
adamreeve opened a new issue, #17352:
URL: https://github.com/apache/datafusion/issues/17352
https://github.com/apache/datafusion/blob/d19bf524e384bc24e509c70f1806b6f330829529/datafusion/datasource-parquet/src/opener.rs#L158-L162
This was fixed in https://github.com/apache/arrow-rs/pu
Jefffrey commented on code in PR #17013:
URL: https://github.com/apache/datafusion/pull/17013#discussion_r2308807125
##
datafusion/spark/src/function/bitwise/bit_shift.rs:
##
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
xanderbailey commented on PR #17299:
URL: https://github.com/apache/datafusion/pull/17299#issuecomment-3235211365
Anything else needed from me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
parthchandra commented on code in PR #2044:
URL: https://github.com/apache/datafusion-comet/pull/2044#discussion_r2308725990
##
native/spark-expr/src/conversion_funcs/cast.rs:
##
@@ -866,6 +867,40 @@ pub fn spark_cast(
}
}
+// copied from datafusion common scalar/mod.rs
mbutrovich commented on PR #2258:
URL:
https://github.com/apache/datafusion-comet/pull/2258#issuecomment-3234923462
The next challenge to figure out is adding some flexibility for
dictionary-encoded columns. The current approach with one schema is too rigid.
--
This is an automated messa
andygrove commented on PR #2251:
URL:
https://github.com/apache/datafusion-comet/pull/2251#issuecomment-3234967366
> lgtm. I only wonder if this will end up making a bunch of S3 calls every
time ScanRule is called (but perhaps for the time being this is ok until we
address this better).
samueleresca commented on issue #17269:
URL: https://github.com/apache/datafusion/issues/17269#issuecomment-3234944839
This issue is also affecting other aggregates (e.g. `sum()`). I think the
root cause is the parsing between `ScalarValue` to `ArrayRef` happening at the
finalisation of the
andygrove opened a new issue, #2260:
URL: https://github.com/apache/datafusion-comet/issues/2260
### What is the problem the feature request solves?
_No response_
### Describe the potential solution
_No response_
### Additional context
_No response_
--
Th
adriangb commented on code in PR #17351:
URL: https://github.com/apache/datafusion/pull/17351#discussion_r2308522201
##
datafusion/physical-expr-common/src/physical_expr.rs:
##
@@ -377,6 +377,40 @@ pub trait PhysicalExpr: Any + Send + Sync + Display +
Debug + DynEq + DynHash {
adriangb opened a new pull request, #17351:
URL: https://github.com/apache/datafusion/pull/17351
Closes https://github.com/apache/datafusion/issues/17318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
milenkovicm opened a new pull request, #1302:
URL: https://github.com/apache/datafusion-ballista/pull/1302
# Which issue does this PR close?
Closes #.
# Rationale for this change
with datafusion 48 method which is to be used for Exec statistic information
changed. Shuff
crystalxyz opened a new pull request, #17350:
URL: https://github.com/apache/datafusion/pull/17350
## Which issue does this PR close?
- Closes #17087 .
## Rationale for this change
## What changes are included in this PR?
## Are these change
etolbakov commented on issue #17198:
URL: https://github.com/apache/datafusion/issues/17198#issuecomment-3234710847
@findepi I believe this could be closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
avantgardnerio commented on code in PR #17347:
URL: https://github.com/apache/datafusion/pull/17347#discussion_r2308362009
##
datafusion/physical-optimizer/src/limit_pushdown_past_window.rs:
##
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+//
BlakeOrth commented on PR #17266:
URL: https://github.com/apache/datafusion/pull/17266#issuecomment-3234598245
@alamb I've made some changes that I think get the functional side of the
code where it needs to be and pushed those for review. This is still lacking
tests and docs, but I thought
davisp opened a new issue, #17349:
URL: https://github.com/apache/datafusion/issues/17349
### Describe the bug
I got nerd sniped by a question in the DataFusion Discord channel into
seeing if I couldn't implement something similar to [BigQuery's gap_fill
function](https://cloud.googl
BlakeOrth commented on code in PR #17266:
URL: https://github.com/apache/datafusion/pull/17266#discussion_r2308256808
##
datafusion-cli/src/object_storage.rs:
##
@@ -563,6 +563,592 @@ pub(crate) async fn get_object_store(
Ok(store)
}
+pub mod instrumented {
Review Comme
BlakeOrth commented on code in PR #17266:
URL: https://github.com/apache/datafusion/pull/17266#discussion_r2308250575
##
datafusion-cli/src/print_options.rs:
##
@@ -73,6 +77,8 @@ pub struct PrintOptions {
pub quiet: bool,
pub maxrows: MaxRows,
pub color: bool,
+
andygrove opened a new pull request, #2257:
URL: https://github.com/apache/datafusion-comet/pull/2257
## Which issue does this PR close?
Part of https://github.com/apache/datafusion-comet/issues/2019
## Rationale for this change
Continued refactoring as pa
16pierre commented on issue #17334:
URL: https://github.com/apache/datafusion/issues/17334#issuecomment-3234493420
> I think some specific timing can cause the non-spillable operators to OOM,
however if spillable operators can spill earlier, the execution should be
possible to finish
andygrove commented on PR #2251:
URL:
https://github.com/apache/datafusion-comet/pull/2251#issuecomment-3233741851
@Kontinuation fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
kazantsev-maksim opened a new pull request, #2259:
URL: https://github.com/apache/datafusion-comet/pull/2259
## Which issue does this PR close?
Part of https://github.com/apache/datafusion-comet/issues/2019
## Rationale for this change
Part of https://github.com/apache/da
avantgardnerio opened a new pull request, #17347:
URL: https://github.com/apache/datafusion/pull/17347
## Which issue does this PR close?
- Closes #17346.
## Rationale for this change
We would like plans with window functions to go faster.
## What changes are inclu
avantgardnerio commented on code in PR #17347:
URL: https://github.com/apache/datafusion/pull/17347#discussion_r2308160226
##
datafusion/common/src/config.rs:
##
@@ -727,6 +727,10 @@ config_namespace! {
/// during aggregations, if possible
pub enable_topk_aggre
mbutrovich closed issue #2245: Add type parameter to
`CometAggregateExpressionSerde`
URL: https://github.com/apache/datafusion-comet/issues/2245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
mbutrovich merged PR #2249:
URL: https://github.com/apache/datafusion-comet/pull/2249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
mbutrovich closed issue #2198: decryption not supported when using `auto` scan
mode to read from Parquet
URL: https://github.com/apache/datafusion-comet/issues/2198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mbutrovich merged PR #2250:
URL: https://github.com/apache/datafusion-comet/pull/2250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
Dandandan commented on code in PR #17347:
URL: https://github.com/apache/datafusion/pull/17347#discussion_r2308149858
##
datafusion/physical-optimizer/src/limit_pushdown_past_window.rs:
##
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
Dandandan commented on code in PR #17347:
URL: https://github.com/apache/datafusion/pull/17347#discussion_r2308149858
##
datafusion/physical-optimizer/src/limit_pushdown_past_window.rs:
##
@@ -0,0 +1,145 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
Dandandan commented on code in PR #17347:
URL: https://github.com/apache/datafusion/pull/17347#discussion_r2308131304
##
datafusion/common/src/config.rs:
##
@@ -727,6 +727,10 @@ config_namespace! {
/// during aggregations, if possible
pub enable_topk_aggregatio
Dandandan commented on code in PR #17347:
URL: https://github.com/apache/datafusion/pull/17347#discussion_r2308131304
##
datafusion/common/src/config.rs:
##
@@ -727,6 +727,10 @@ config_namespace! {
/// during aggregations, if possible
pub enable_topk_aggregatio
rishvin commented on PR #2221:
URL:
https://github.com/apache/datafusion-comet/pull/2221#issuecomment-3234381573
> Thanks @rishvin I feel like this PR would be hard to review, would be that
possible to break it down to smaller parts? One function a time?
Thanks @comphead for the feed
andygrove commented on code in PR #2251:
URL: https://github.com/apache/datafusion-comet/pull/2251#discussion_r2308038000
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -288,8 +292,25 @@ case class CometScanRule(session: SparkSession) extends
Rule[Spa
andygrove commented on code in PR #2251:
URL: https://github.com/apache/datafusion-comet/pull/2251#discussion_r2308038000
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -288,8 +292,25 @@ case class CometScanRule(session: SparkSession) extends
Rule[Spa
mbutrovich commented on PR #2258:
URL:
https://github.com/apache/datafusion-comet/pull/2258#issuecomment-3234211470
I'll try to investigate how TPC-H Correctness suite ended up with `Error
from DataFusion: Empty iterator passed to ScalarValue::iter_to_array.`
It might be trying to go dow
codecov-commenter commented on PR #2258:
URL:
https://github.com/apache/datafusion-comet/pull/2258#issuecomment-3234191347
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2258?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
mbutrovich commented on PR #2258:
URL:
https://github.com/apache/datafusion-comet/pull/2258#issuecomment-3234182214
cc @Kontinuation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
andygrove commented on PR #2249:
URL:
https://github.com/apache/datafusion-comet/pull/2249#issuecomment-3234171837
@peter-toth fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
andygrove merged PR #1299:
URL: https://github.com/apache/datafusion-ballista/pull/1299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
mbutrovich opened a new pull request, #2258:
URL: https://github.com/apache/datafusion-comet/pull/2258
## Which issue does this PR close?
Closes #1906.
## Rationale for this change
#1862 tried to implement RangePartitioning with native shuffle. The
implem
adriangb commented on PR #17273:
URL: https://github.com/apache/datafusion/pull/17273#issuecomment-3234115401
I've made an epic to track this work:
https://github.com/apache/datafusion/issues/17348
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
adriangb opened a new issue, #17348:
URL: https://github.com/apache/datafusion/issues/17348
**Background**
We already have an excellent blog post that I think does a great
introduction to the importance of optimizing sort order information in queries:
https://datafusion.apache.org/bl
andygrove commented on code in PR #2250:
URL: https://github.com/apache/datafusion-comet/pull/2250#discussion_r2307885326
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -131,11 +131,19 @@ case class CometScanRule(session: SparkSession) extends
Rule[Sp
comphead commented on PR #2046:
URL:
https://github.com/apache/datafusion-comet/pull/2046#issuecomment-3234065474
Thanks @kination and @andygrove for the proto we prob should be take one
step at a time.
Lets try move all datatype related structures into the `types.proto` and
make the co
avantgardnerio opened a new issue, #17346:
URL: https://github.com/apache/datafusion/issues/17346
### Is your feature request related to a problem or challenge?
Window functions are cardinality preserving, they just might need to see
more data than the limits applied after them, so we
comphead merged PR #2253:
URL: https://github.com/apache/datafusion-comet/pull/2253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
comphead closed issue #2175: `cast StructType to StringType` test fails if
default scan is `auto`
URL: https://github.com/apache/datafusion-comet/issues/2175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
comphead commented on code in PR #2251:
URL: https://github.com/apache/datafusion-comet/pull/2251#discussion_r2307830288
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -288,8 +292,25 @@ case class CometScanRule(session: SparkSession) extends
Rule[Spar
comphead commented on code in PR #2251:
URL: https://github.com/apache/datafusion-comet/pull/2251#discussion_r2307826742
##
native/core/src/parquet/mod.rs:
##
@@ -686,9 +715,9 @@ pub unsafe extern "system" fn
Java_org_apache_comet_parquet_Native_initRecordBat
) -> jlong {
chenkovsky commented on code in PR #17013:
URL: https://github.com/apache/datafusion/pull/17013#discussion_r2307499989
##
datafusion/spark/src/function/bitwise/bit_shift.rs:
##
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
comphead commented on code in PR #2250:
URL: https://github.com/apache/datafusion-comet/pull/2250#discussion_r2307746115
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -131,11 +131,19 @@ case class CometScanRule(session: SparkSession) extends
Rule[Spa
codecov-commenter commented on PR #2257:
URL:
https://github.com/apache/datafusion-comet/pull/2257#issuecomment-3233973612
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/2257?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove commented on code in PR #2250:
URL: https://github.com/apache/datafusion-comet/pull/2250#discussion_r2307754474
##
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##
@@ -131,11 +131,19 @@ case class CometScanRule(session: SparkSession) extends
Rule[Sp
bombsimon opened a new pull request, #2017:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2017
Followup on #2016, I didn't update all the types. `DIMENSIONS` also support
wildcard, from [the
docs](https://docs.snowflake.com/en/sql-reference/constructs/semantic_view)
> T
akupchinskiy commented on issue #2255:
URL:
https://github.com/apache/datafusion-comet/issues/2255#issuecomment-3233941579
I can work on that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
andygrove commented on PR #2046:
URL:
https://github.com/apache/datafusion-comet/pull/2046#issuecomment-3233855052
> Sorry I couldn't reproduce PR build failure in local(macOS). Could
somebody give me some tip to check these?
@kination I pulled these changes locally and ran `make cle
andygrove closed pull request #2026: chore: Refactor GetArrayItem, ElementAt,
GetArrayStructFields out of QueryPlanSerde
URL: https://github.com/apache/datafusion-comet/pull/2026
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
andygrove commented on PR #2026:
URL:
https://github.com/apache/datafusion-comet/pull/2026#issuecomment-3233843793
I'll go ahead and close this. I started
https://github.com/apache/datafusion-comet/pull/2257 to refactor these
expressions.
--
This is an automated message from the Apache
comphead merged PR #2254:
URL: https://github.com/apache/datafusion-comet/pull/2254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
16pierre commented on issue #17334:
URL: https://github.com/apache/datafusion/issues/17334#issuecomment-3233816123
Thanks a lot for the quick feedback !
I'm a bit stretch on dev bandwidth as we're still in early phases of our
Datafusion production integration, but will try my best to
davidlghellin commented on code in PR #17331:
URL: https://github.com/apache/datafusion/pull/17331#discussion_r2307652098
##
datafusion/spark/src/function/math/width_bucket.rs:
##
@@ -0,0 +1,506 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
timsaucer opened a new pull request, #1215:
URL: https://github.com/apache/datafusion-python/pull/1215
# Which issue does this PR close?
This is a user request but no issue was opened.
# Rationale for this change
With this you can do slicing of arrays via expression. For
friendlymatthew commented on PR #17242:
URL: https://github.com/apache/datafusion/pull/17242#issuecomment-3233675439
> It would be better to have a high-level diagram to describe the current
relationship.
Fwiw, this change involves removing the `FileScanConfig` node and moving it
in
friendlymatthew commented on PR #17242:
URL: https://github.com/apache/datafusion/pull/17242#issuecomment-3233489562
> It would be better to have a high-level diagram to describe the current
relationship.
Hi, sure happy to do that. Do you have a link to that diagram? I'd like to
make
chenkovsky commented on code in PR #17013:
URL: https://github.com/apache/datafusion/pull/17013#discussion_r2307499989
##
datafusion/spark/src/function/bitwise/bit_shift.rs:
##
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
andygrove closed issue #1214: Ballista client keep blocking when
prepare_task_definition or prepare_multi_task_definition fail
URL: https://github.com/apache/datafusion-ballista/issues/1214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
andygrove merged PR #1297:
URL: https://github.com/apache/datafusion-ballista/pull/1297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
andygrove merged PR #1298:
URL: https://github.com/apache/datafusion-ballista/pull/1298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
adriangb merged PR #17323:
URL: https://github.com/apache/datafusion/pull/17323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
adriangb commented on PR #17323:
URL: https://github.com/apache/datafusion/pull/17323#issuecomment-3233367866
I think we should apply this first, especially since we can pretty easily
put it out as a hot fix, there are no or very minimal breaking changes in this
PR versus the other one is g
xudong963 commented on PR #17242:
URL: https://github.com/apache/datafusion/pull/17242#issuecomment-3233360860
It would be better to have a high-level diagram to describe the current
relationship. Before the PR, it looks like
https://github.com/user-attachments/assets/1b77f071-145a-49eb-9
2010YOUY01 commented on issue #17334:
URL: https://github.com/apache/datafusion/issues/17334#issuecomment-326093
The current `FairSpillPool` implementation seems problematic
See its behavior:
https://github.com/apache/datafusion/blob/5021b397b1e63277b217dd3f8111b64b3458d484/datafusion
Jefffrey commented on code in PR #17013:
URL: https://github.com/apache/datafusion/pull/17013#discussion_r2307154278
##
datafusion/spark/src/function/bitwise/bit_shift.rs:
##
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
mbutrovich merged PR #2252:
URL: https://github.com/apache/datafusion-comet/pull/2252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
Jefffrey commented on PR #16092:
URL: https://github.com/apache/datafusion/pull/16092#issuecomment-3232117851
@dependabot recreate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
Jefffrey merged PR #17343:
URL: https://github.com/apache/datafusion/pull/17343
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
iffyio commented on code in PR #2013:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2013#discussion_r2306975457
##
src/ast/mod.rs:
##
@@ -8796,16 +8831,46 @@ pub enum CopyLegacyOption {
Delimiter(char),
/// EMPTYASNULL
EmptyAsNull,
+/// ENCRYPTE
Jefffrey merged PR #17345:
URL: https://github.com/apache/datafusion/pull/17345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
Jefffrey merged PR #17344:
URL: https://github.com/apache/datafusion/pull/17344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
iffyio merged PR #2016:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
dependabot[bot] opened a new pull request, #17343:
URL: https://github.com/apache/datafusion/pull/17343
Bumps [libmimalloc-sys](https://github.com/purpleprotocol/mimalloc_rust)
from 0.1.43 to 0.1.44.
Release notes
Sourced from https://github.com/purpleprotocol/mimalloc_rust/release
rluvaton opened a new pull request, #17344:
URL: https://github.com/apache/datafusion/pull/17344
## Which issue does this PR close?
None
## Rationale for this change
the copy is very cheap and maybe optimized away but nonetheless
## What changes are included in thi
dependabot[bot] opened a new pull request, #17345:
URL: https://github.com/apache/datafusion/pull/17345
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.2.2 to
5.0.0.
Release notes
Sourced from https://github.com/actions/checkout/releases";>actions/checkout's
r
2010YOUY01 commented on code in PR #17319:
URL: https://github.com/apache/datafusion/pull/17319#discussion_r2306871250
##
datafusion/optimizer/src/extract_equijoin_predicate.rs:
##
@@ -112,22 +151,82 @@ impl OptimizerRule for ExtractEquijoinPredicate {
}
}
+/// Splits an
2010YOUY01 commented on code in PR #17315:
URL: https://github.com/apache/datafusion/pull/17315#discussion_r2306863053
##
datafusion/physical-plan/src/spill/spill_manager.rs:
##
@@ -194,7 +195,84 @@ impl GetSlicedSize for RecordBatch {
for array in self.columns() {
crepererum commented on code in PR #17332:
URL: https://github.com/apache/datafusion/pull/17332#discussion_r2306804318
##
.github/workflows/rust.yml:
##
@@ -579,7 +579,7 @@ jobs:
with:
rust-version: stable
- name: Run datafusion-common tests
-r
crepererum commented on PR #17332:
URL: https://github.com/apache/datafusion/pull/17332#issuecomment-3232662859
I've adjusted the description because I think that also closes #17258
:partying_face:
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
chenkovsky commented on code in PR #17013:
URL: https://github.com/apache/datafusion/pull/17013#discussion_r2306633810
##
datafusion/spark/src/function/bitwise/bit_shift.rs:
##
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
shehabgamin commented on issue #16799:
URL: https://github.com/apache/datafusion/issues/16799#issuecomment-3232376292
The DataFusion 50 upgrade may be challenging for many people. The Sail
update currently involves more than 100 file changes, and I am still not
finished.
https://github.c
Jefffrey commented on code in PR #17013:
URL: https://github.com/apache/datafusion/pull/17013#discussion_r2306554329
##
datafusion/spark/src/function/bitwise/bit_shift.rs:
##
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
chenkovsky commented on code in PR #17013:
URL: https://github.com/apache/datafusion/pull/17013#discussion_r2306428541
##
datafusion/spark/src/function/bitwise/bit_shift.rs:
##
@@ -0,0 +1,678 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribut
Jefffrey commented on PR #16092:
URL: https://github.com/apache/datafusion/pull/16092#issuecomment-3232297447
fyi @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
1 - 100 of 101 matches
Mail list logo
