Re: [PR] Minor: Move group accumulator for aggregate function to physical-expr-common, and add ahash physical-expr-common [datafusion]

2024-05-22 Thread via GitHub
alamb commented on PR #10574: URL: https://github.com/apache/datafusion/pull/10574#issuecomment-2125721583 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Minor: Move group accumulator for aggregate function to physical-expr-common, and add ahash physical-expr-common [datafusion]

2024-05-21 Thread via GitHub
jayzhan211 merged PR #10574: URL: https://github.com/apache/datafusion/pull/10574 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@dat

Re: [PR] Minor: Move group accumulator for aggregate function to physical-expr-common, and add ahash physical-expr-common [datafusion]

2024-05-21 Thread via GitHub
jayzhan211 commented on PR #10574: URL: https://github.com/apache/datafusion/pull/10574#issuecomment-2123785496 Thanks @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Minor: Move group accumulator for aggregate function to physical-expr-common, and add ahash physical-expr-common [datafusion]

2024-05-21 Thread via GitHub
alamb commented on code in PR #10574: URL: https://github.com/apache/datafusion/pull/10574#discussion_r1608876810 ## datafusion/physical-expr-common/src/aggregate/groups_accumulator/mod.rs: ## @@ -0,0 +1,20 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[PR] Minor: Move group accumulator for aggregate function to physical-expr-common, and add ahash physical-expr-common [datafusion]

2024-05-18 Thread via GitHub
jayzhan211 opened a new pull request, #10574: URL: https://github.com/apache/datafusion/pull/10574 ## Which issue does this PR close? Closes #. ## Rationale for this change 1. add ahash for common, used for distinct count accumulator #10484 2. move other g