jayzhan211 commented on code in PR #12617:
URL: https://github.com/apache/datafusion/pull/12617#discussion_r1776419786
##
datafusion/physical-plan/src/aggregates/group_values/column_wise.rs:
##
@@ -36,7 +36,7 @@ use datafusion_physical_expr::binary_map::OutputType;
use hashbr
jayzhan211 commented on code in PR #12617:
URL: https://github.com/apache/datafusion/pull/12617#discussion_r1776419786
##
datafusion/physical-plan/src/aggregates/group_values/column_wise.rs:
##
@@ -36,7 +36,7 @@ use datafusion_physical_expr::binary_map::OutputType;
use hashbr
jayzhan211 commented on code in PR #12617:
URL: https://github.com/apache/datafusion/pull/12617#discussion_r1776115903
##
datafusion/physical-plan/src/aggregates/group_values/column_wise.rs:
##
@@ -36,7 +36,7 @@ use datafusion_physical_expr::binary_map::OutputType;
use hashbr
comphead commented on code in PR #12617:
URL: https://github.com/apache/datafusion/pull/12617#discussion_r1775797249
##
datafusion/physical-plan/src/aggregates/group_values/group_value_row.rs:
##
@@ -60,11 +61,13 @@ pub trait ArrayRowEq: Send + Sync {
fn take_n(&mut self, n
comphead commented on code in PR #12617:
URL: https://github.com/apache/datafusion/pull/12617#discussion_r1775793749
##
datafusion/physical-plan/src/aggregates/group_values/group_value_row.rs:
##
@@ -60,11 +61,13 @@ pub trait ArrayRowEq: Send + Sync {
fn take_n(&mut self, n
comphead commented on code in PR #12617:
URL: https://github.com/apache/datafusion/pull/12617#discussion_r1775792354
##
datafusion/physical-plan/src/aggregates/group_values/column_wise.rs:
##
@@ -36,7 +36,7 @@ use datafusion_physical_expr::binary_map::OutputType;
use hashbrow
alamb opened a new pull request, #12617:
URL: https://github.com/apache/datafusion/pull/12617
## Which issue does this PR close?
N/A
## Rationale for this change
As part of reviewing the PR for
https://github.com/apache/datafusion/pull/12269 from @jayzhan211 I found some
