Re: [PR] feat: Add a test for supported types of SortMergeJoin in DataFusion [datafusion-comet]

2024-05-02 Thread via GitHub
planga82 commented on code in PR #365: URL: https://github.com/apache/datafusion-comet/pull/365#discussion_r1588316130 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -383,6 +383,13 @@ object CometConf { .booleanConf .createWithDefault(false) + val

Re: [PR] feat: Add a test for supported types of SortMergeJoin in DataFusion [datafusion-comet]

2024-05-02 Thread via GitHub
planga82 closed pull request #365: feat: Add a test for supported types of SortMergeJoin in DataFusion URL: https://github.com/apache/datafusion-comet/pull/365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] feat: Add a test for supported types of SortMergeJoin in DataFusion [datafusion-comet]

2024-05-02 Thread via GitHub
planga82 commented on code in PR #365: URL: https://github.com/apache/datafusion-comet/pull/365#discussion_r1588295377 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -383,6 +383,13 @@ object CometConf { .booleanConf .createWithDefault(false) + val

Re: [PR] feat: Add a test for supported types of SortMergeJoin in DataFusion [datafusion-comet]

2024-05-02 Thread via GitHub
comphead commented on code in PR #365: URL: https://github.com/apache/datafusion-comet/pull/365#discussion_r1587866196 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -383,6 +383,13 @@ object CometConf { .booleanConf .createWithDefault(false) + val

Re: [PR] feat: Add a test for supported types of SortMergeJoin in DataFusion [datafusion-comet]

2024-05-01 Thread via GitHub
planga82 commented on code in PR #365: URL: https://github.com/apache/datafusion-comet/pull/365#discussion_r1586685070 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -383,6 +383,13 @@ object CometConf { .booleanConf .createWithDefault(false) + val

Re: [PR] feat: Add a test for supported types of SortMergeJoin in DataFusion [datafusion-comet]

2024-05-01 Thread via GitHub
comphead commented on code in PR #365: URL: https://github.com/apache/datafusion-comet/pull/365#discussion_r1586622441 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -383,6 +383,13 @@ object CometConf { .booleanConf .createWithDefault(false) + val

[PR] feat: Add a test for supported types of SortMergeJoin in DataFusion [datafusion-comet]

2024-05-01 Thread via GitHub
planga82 opened a new pull request, #365: URL: https://github.com/apache/datafusion-comet/pull/365 ## Which issue does this PR close? Closes #357 . ## Rationale for this change The goal of these tests is that if Datafusion supports more data types, we