parthchandra commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1586606093
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +233,202 @@ impl Cast {
}
}
+/// Equivalent to
andygrove merged PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
viirya commented on PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#issuecomment-2087972895
Looks good to me. Thanks @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1585729713
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +230,193 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1585533880
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +230,193 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1584909396
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +230,193 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583892096
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +230,193 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583889160
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +230,193 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583889008
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +230,193 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583885384
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -64,6 +68,24 @@ pub struct Cast {
pub timezone: String,
}
+macro_rules! cast_utf8_to_int {
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583883651
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +230,193 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583752306
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +230,193 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583738069
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +230,193 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583736840
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +230,193 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
comphead commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583677411
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +230,193 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
comphead commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583667605
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,76 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
comphead commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583667605
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,76 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
comphead commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1583665422
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -64,6 +68,24 @@ pub struct Cast {
pub timezone: String,
}
+macro_rules! cast_utf8_to_int {
andygrove commented on PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#issuecomment-2082911871
> Thanks for your effort @andygrove, the new code is well crafted.
Thank you for the thorough review @advancedxy!
--
This is an automated message from the Apache Git
andygrove commented on PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#issuecomment-2082781370
@viirya @sunchao @parthchandra @comphead I did quite a bit of refactoring
and performance tuning over the weekend. Please take another look when you can.
--
This is an
advancedxy commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1582496611
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -66,20 +71,65 @@ class CometCastSuite extends CometTestBase with
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581891542
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,72 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581876400
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +226,311 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581876329
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,72 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581876228
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,72 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581875517
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +226,311 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581872458
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,72 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581871855
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,72 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581836049
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +226,311 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581741614
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,72 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581740802
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,72 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581740802
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,72 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581740471
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -66,20 +71,65 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581740415
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -66,20 +71,65 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581740218
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -66,20 +71,65 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
vaibhawvipul opened a new pull request, #335:
URL: https://github.com/apache/datafusion-comet/pull/335
## Which issue does this PR close?
Closes #328 .
## Rationale for this change
Improve compatibility with Apache Spark
## What changes are
parthchandra commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581637504
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +226,311 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581165723
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +226,311 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581140743
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +126,78 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1581001480
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +226,311 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
advancedxy commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1580453298
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +226,311 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
andygrove commented on PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#issuecomment-2077582671
@parthchandra @advancedxy @viirya I have improved the tests and fixed some
more issues. Please take a look when you get a chance.
--
This is an automated message from the
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1579680869
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -222,3 +581,34 @@ impl PhysicalExpr for Cast {
self.hash( s);
}
}
+
+#[cfg(test)]
sunchao commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1579646263
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +126,78 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1579561300
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -142,6 +226,281 @@ impl Cast {
}
}
+fn cast_string_to_i8(str: , eval_mode: EvalMode) ->
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1579562716
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -222,3 +581,34 @@ impl PhysicalExpr for Cast {
self.hash( s);
}
}
+
+#[cfg(test)]
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1579561967
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,72 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
advancedxy commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1578925501
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +125,72 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576969288
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +126,78 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576944454
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -64,6 +68,25 @@ pub struct Cast {
pub timezone: String,
}
+macro_rules!
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576919256
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -64,6 +68,25 @@ pub struct Cast {
pub timezone: String,
}
+macro_rules!
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576894523
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +126,78 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576894815
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +126,78 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
viirya commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576888006
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +126,78 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
comphead commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576844996
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -64,6 +68,25 @@ pub struct Cast {
pub timezone: String,
}
+macro_rules!
comphead commented on PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#issuecomment-2073364294
> > Thanks @andygrove btw I'm wondering if this PR should cover scope with
formatting
https://spark.apache.org/docs/latest/sql-ref-number-pattern.html#the-to_number-function
>
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576823136
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -66,19 +66,22 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper
andygrove commented on PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#issuecomment-2073322973
> Thanks @andygrove btw I'm wondering if this PR should cover scope with
formatting
https://spark.apache.org/docs/latest/sql-ref-number-pattern.html#the-to_number-function
parthchandra commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576817617
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -66,19 +66,22 @@ class CometCastSuite extends CometTestBase with
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576814855
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -64,6 +68,25 @@ pub struct Cast {
pub timezone: String,
}
+macro_rules!
parthchandra commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576810386
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +126,78 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
comphead commented on PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#issuecomment-2073292355
Thanks @andygrove btw I'm wondering if this PR should cover scope with
formatting
https://spark.apache.org/docs/latest/sql-ref-number-pattern.html#the-to_number-function
--
comphead commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576797068
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +126,78 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
comphead commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576796459
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +126,78 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
comphead commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576795634
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -64,6 +68,25 @@ pub struct Cast {
pub timezone: String,
}
+macro_rules!
comphead commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576794138
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -64,6 +68,25 @@ pub struct Cast {
pub timezone: String,
}
+macro_rules!
andygrove commented on code in PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1576792898
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -103,10 +126,78 @@ impl Cast {
(DataType::LargeUtf8, DataType::Boolean) => {
andygrove commented on PR #307:
URL: https://github.com/apache/datafusion-comet/pull/307#issuecomment-207292
I am now working on refactoring to reduce code duplication by leveraging
macros/generics.
--
This is an automated message from the Apache Git Service.
To respond to the
68 matches
Mail list logo
