andygrove commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2092998859
I filed https://github.com/apache/datafusion-comet/issues/376 for the follow
on work
--
This is an automated message from the Apache Git Service.
To respond to the message,
parthchandra commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2091930125
As a follow up, I would also suggest adding/verifying support for any
timezone. (See this test for instance:
andygrove merged PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vaibhawvipul commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2090694817
> This is looking great @vaibhawvipul. I think this is close to being ready
to merge and then have some follow on issues for remaining items.
>
> I think the one thing
andygrove commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2089227013
This is looking great @vaibhawvipul. I think this is close to being ready to
merge and then have some follow on issues for remaining items.
I think the one thing I would
andygrove commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1586766148
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -510,9 +558,246 @@ impl PhysicalExpr for Cast {
}
}
+fn timestamp_parser(value: ,
andygrove commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1586743530
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -86,6 +89,24 @@ macro_rules! cast_utf8_to_int {
}};
}
+macro_rules! cast_utf8_to_timestamp
andygrove commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1586652474
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -528,14 +528,29 @@ class CometCastSuite extends CometTestBase with
vaibhawvipul commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1586473860
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -109,10 +109,12 @@ class CometCastSuite extends CometTestBase with
vaibhawvipul commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1585961551
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -109,10 +109,12 @@ class CometCastSuite extends CometTestBase with
vaibhawvipul commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1585961551
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -109,10 +109,12 @@ class CometCastSuite extends CometTestBase with
vaibhawvipul commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1585625453
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -109,10 +109,12 @@ class CometCastSuite extends CometTestBase with
andygrove commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1585277456
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -109,10 +109,12 @@ class CometCastSuite extends CometTestBase with
andygrove commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1585259550
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -109,10 +109,12 @@ class CometCastSuite extends CometTestBase with
andygrove commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1585257279
##
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##
@@ -109,10 +109,12 @@ class CometCastSuite extends CometTestBase with
andygrove commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2085638441
Thanks @vaibhawvipul this is looking great. I will review today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
andygrove commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2085631496
> seems like, test is failing in ANSI mode, debugging that.
There is an improved version of the ANSI testing in
https://github.com/apache/datafusion-comet/pull/351
--
vaibhawvipul commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2084536168
@andygrove
I have enabled a "string to timestamp" cast test case that passes. We are
supporting all the timestamps mentioned in the issue.
[
vaibhawvipul commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2084348903
seems like, test is failing in ANSI mode, debugging that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
vaibhawvipul commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2083478311
Thanks @andygrove , setting timestamp as UTC worked!
Any idea about this error?
```
test("cast string to timestamp") {
withSQLConf(
andygrove commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2082886164
> Update -
>
> Working on this bug, there is 8 hours difference in comet vs spark cast.
If anyone has any pointer, please let me know.
>
>
vaibhawvipul commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2081885869
Update -
Working on this bug, there is 8 hours difference in comet vs spark cast. If
anyone has any pointer, please let me know.
andygrove commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1581837448
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -222,3 +263,139 @@ impl PhysicalExpr for Cast {
self.hash( s);
}
}
+
+fn
andygrove commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1581835065
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -222,3 +263,139 @@ impl PhysicalExpr for Cast {
self.hash( s);
}
}
+
+fn
andygrove commented on code in PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1581834740
##
core/src/execution/datafusion/expressions/cast.rs:
##
@@ -222,3 +263,139 @@ impl PhysicalExpr for Cast {
self.hash( s);
}
}
+
+fn
andygrove commented on PR #335:
URL: https://github.com/apache/datafusion-comet/pull/335#issuecomment-2080715428
@vaibhawvipul You can run `make format` to fix the linting issues that are
causing some CI tests to fail
--
This is an automated message from the Apache Git Service.
To
26 matches
Mail list logo
