Re: [Github-comments] [geany/geany-plugins] workbench: pass error=NULL to "g_key_file_get_string_list()" for key "Bookmarks" (#716)

2018-03-01 Thread LarsGit223
I know, thanks. But I rate this and the other little PR as a bug. And I really like to have it as a labeled issue so I can find things easier in the future. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

Re: [Github-comments] [geany/geany-plugins] workbench: pass error=NULL to "g_key_file_get_string_list()" for key "Bookmarks" (#716)

2018-03-01 Thread Matthew Brush
You don't have to create an issue for each PR if you don't want to. It's nice to let people know you're working on something or to discuss, but for small stuff like this which is uncontroversial and/or you have already fixed, you could just submit the PR by itself. Either way is fine. -- You

Re: [Github-comments] [geany/geany] Perhaps change fold/unfold to collapse/expand (#1793)

2018-03-01 Thread elextr
Well, its a similar concept from differing domains, code editing, and tree viewing (commonly filesystems). IME the former uses "fold/unfold" for the hiding of contiguous blocks of code whilst the latter uses "expand/collapse" for an information hierarchy. Certainly the underlying widgets do

Re: [Github-comments] [geany/geany] Placements of OK, Cancel, etc. buttons (#1794)

2018-03-01 Thread Colomban Wendling
The expected order on Windows and other platforms is different. GTK ha[d/s] a function for providing an alternate order which I believe is used on Windows:

Re: [Github-comments] [geany/geany] Perhaps change fold/unfold to collapse/expand (#1793)

2018-03-01 Thread Colomban Wendling
Interesting point. Here, "fold" refers to hiding some part of the document, while "collapse" refers to a tree list view. Not sure if we should keep the distinction, or unify the similar concepts. -- You are receiving this because you are subscribed to this thread. Reply to this email

Re: [Github-comments] [geany/geany] Geany on Opensuse Tumbleweed (Gnome) suffers from typing lag (#1787)

2018-03-01 Thread Colomban Wendling
for checking CPU usage, what about having both windows on the screen at the same time, and having Geany's on the front? using the system monitor, `top` or whatnot, should be doable on most if not all but the tiniest screens. -- You are receiving this because you are subscribed to this thread.

Re: [Github-comments] [geany/geany] Perhaps missing space (#1789)

2018-03-01 Thread Colomban Wendling
I don't think it really matters, but I would go with single space in anything I want "formal". I usually put two spaces (like I just did writing this comment, actually), just out of habit, likely in an attempt to make sentences easier to discriminate in a fixed-width font email world, but

Re: [Github-comments] [geany/geany] Placements of OK, Cancel, etc. buttons (#1794)

2018-03-01 Thread elextr
There is an option somewhere to use windows native dialogs, unfortunately I am not on windows so I don't see it and can't tell you where. Not sure if it applies to all dialogs, if the order is different on native dialogs, and it certainly won't apply to plugins dialogs. Geany is developed

Re: [Github-comments] [geany/geany] Geany on Opensuse Tumbleweed (Gnome) suffers from typing lag (#1787)

2018-03-01 Thread elextr
> It only happens when Geany is the top layered window, so far. So the lag > might be related to windowing or the GNOME Desktop. We have basically eliminated anything that has caused that sort of lag on other systems, so yeah it comes down to your system. Unless it happens to another

[Github-comments] [geany/geany-plugins] workbench: pass error=NULL to "g_key_file_get_string_list()" for key "Bookmarks" (#716)

2018-03-01 Thread LarsGit223
The key "Bookmarks" can be missing and that is not an error. So pass "NULL" for parameter "error" on calling ```g_key_file_get_string_list()```. This prevents multiple error messages from being written to one ```GErrror``` and so causing a GLib warning in the debug messages. Fixes #714. You can

[Github-comments] [geany/geany-plugins] workbench: fixed tag-manager warning. Fixes #713. (#715)

2018-03-01 Thread LarsGit223
Prevent debug messages by checking if the file path is a regular file or not. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/715 -- Commit Summary -- * workbench: fixed tag-manager warning. Fixes #713. -- File Changes -- M

[Github-comments] [geany/geany-plugins] workbench: GLib WARNING: GError set over the top of a previous GError or uninitialized memory. (#714)

2018-03-01 Thread LarsGit223
The workbench plugin causes a needless GLib warning on opening a workbench file: ```GLib WARNING: GError set over the top of a previous GError or uninitialized memory.``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany-plugins] workbench: Tagmanager WARNING "..." Not a regular file (#713)

2018-03-01 Thread LarsGit223
The workbench plugin causes needless debug messages by passing directory file paths to the tag manager. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/713

Re: [Github-comments] [geany/geany] Geany on Opensuse Tumbleweed (Gnome) suffers from typing lag (#1787)

2018-03-01 Thread bentref
@codebrainz I did open geany with a -c option, temporarily resetting preferences, but this did not fix the lag issue. I'm using emacs until I can fix it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] Placements of OK, Cancel, etc. buttons (#1794)

2018-03-01 Thread scootergrisen
I think the placements of the buttons like OK, Apply, Cancel is not using the same style as other software on Windows 7. Like in Geany the buttons might be "Cancel OK" from left to right but i think other software is using "OK Cancel". And when you try to close an unsaved document its "Cancel

Re: [Github-comments] [geany/geany] Perhaps change fold/unfold to collapse/expand (#1793)

2018-03-01 Thread scootergrisen
![1](https://user-images.githubusercontent.com/1836590/36844819-7e43423c-1d54-11e8-9172-3e8adc4dc37c.jpg) ![2](https://user-images.githubusercontent.com/1836590/36844820-7e70d166-1d54-11e8-983d-6665ed2bbadf.jpg) -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [Github-comments] [geany/geany] Perhaps change fold/unfold to collapse/expand (#1793)

2018-03-01 Thread elextr
Please show where these strings are from, without any context its impossible to say. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1793#issuecomment-369574392

Re: [Github-comments] [geany/geany] Perhaps missing space (#1789)

2018-03-01 Thread elextr
English as she are wrote around the world. In some parts of the world its common to separate sentences by two spaces, in other places its not. I don't think Geany has a proclamation on this, probably just make them all the same where it matters, and as Github neatly demonstrates, it doesn't

[Github-comments] [geany/geany] Perhaps change fold/unfold to collapse/expand (#1793)

2018-03-01 Thread scootergrisen
We have strings like: ``` _Fold All _Unfold All _Expand All _Collapse All Fold/unfold all children of a fold point Fold or unfold all children of a fold point. By pressing the Shift key while clicking on a fold symbol the contrary behavior is used. ``` Perhaps they should all use

Re: [Github-comments] [geany/geany] The word extension is used differently (#1792)

2018-03-01 Thread elextr
Hi and welcome to inconsistency corner :grin:. This is a problem that infests many places of both operating systems and languages and libraries, what to call stuff relating to files, common options seem to be: * `path` or `file path` or `filename`, the location of a file eg

Re: [Github-comments] [geany/geany] Perhaps missing space (#1789)

2018-03-01 Thread scootergrisen
Here is one with double space. `Perform regular expression matching on the whole buffer at once rather than line by line, allowing matches to span multiple lines. In this mode, newline characters are part of the input and can be captured as normal characters by the pattern.` -- You are

[Github-comments] [geany/geany] The word extension is used differently (#1792)

2018-03-01 Thread scootergrisen
The word "extension" seems to be used differently maybe make it the same: "filename extension", "filetype extension", "file extension". ``` Explicitly defines a filetype for the file, if it would not be detected by filename extension. Note if you choose multiple files, they will all be opened

Re: [Github-comments] [geany/geany] Print white text on white background when "invert syntax highlighting colors" is ticked (#1791)

2018-03-01 Thread elextr
Duplicate of #1551 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1791#issuecomment-369540044

Re: [Github-comments] [geany/geany] Print white text on white background when "invert syntax highlighting colors" is ticked (#1791)

2018-03-01 Thread elextr
Closed #1791. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/1791#event-1498630236

[Github-comments] [geany/geany] Print white text on white background when "invert syntax highlighting colors" is ticked (#1791)

2018-03-01 Thread 3togo
If "invert syntax highlighting colors" is ticked, (Pref->Editor->Display), the print out will print white text on white backgroud. ![screenshot from 2018-03-01 17-50-18](https://user-images.githubusercontent.com/731338/36838206-872c616a-1d79-11e8-8c85-d6e6ac2670b4.png) ![screenshot from