[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread elextr via Github-comments
> The n_same variable in the parser is named confusingly because it's always > the number of = +1 and this 1 is then subtracted No its named right, its the count of the number of characters the same, it needs one subtracted because C is 0 based indexing, but having 0 characters the same is hard

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread Jiří Techet via Github-comments
> No its named right, its the count of the number of characters the same, it > needs one subtracted because C is 0 based indexing, but having 0 characters > the same is hard to detect as markup :-) Yep, I got this one wrong. > Although > [this](https://github.com/geany/geany/blob/ae1f499e3b2fa

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread elextr via Github-comments
> while the current ctags parser supports level 5 sections (i.e. 6 =), see except that as the OP said, it doesn't, or it does and Geany doesn't, but anyway level 5 doesn't show in the symbols. Does it matter that the enum [here](https://github.com/geany/geany/blob/ae1f499e3b2fa108d749942008431e

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread elextr via Github-comments
Or is [this](https://github.com/geany/geany/blob/ae1f499e3b2fa108d749942008431ec1aaf0294b/src/tagmanager/tm_parser.c#L840) the culprit in T-T-T-(takes brave pills)-Tagmanager ;-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3411#issuecomment-144358

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread Jiří Techet via Github-comments
Yeah, we also don't have the kind mapped here (`tm_tag_undef_t` means unmapped): https://github.com/geany/geany/blob/ae1f499e3b2fa108d749942008431ec1aaf0294b/src/tagmanager/tm_parser.c#L837 I'll prepare a patch. -- Reply to this email directly or view it on GitHub: https://github.com/geany/gean

[Github-comments] [geany/geany] Map asciidoc level 5 section so it can be shown in the sidebar (PR #3412)

2023-02-24 Thread Jiří Techet via Github-comments
Fixes #3411. Probably trivial enough so if there are no objections, I'll merge it in about a week. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3412 -- Commit Summary -- * Map asciidoc level 5 section so it can be shown in the sidebar

[Github-comments] Re: [geany/geany] Map asciidoc level 5 section so it can be shown in the sidebar (PR #3412)

2023-02-24 Thread elextr via Github-comments
LGBI -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3412#issuecomment-1443650916 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Asciidoc symbols panel cannot display Level 5 Section Title (Issue #3411)

2023-02-24 Thread Jiří Techet via Github-comments
> Does it matter that the enum > [here](https://github.com/geany/geany/blob/ae1f499e3b2fa108d749942008431ec1aaf0294b/ctags/parsers/asciidoc.c#L43) > does not go to level 5? This is probably "correct" but extremely ugly. Those `K_CHAPTER` up to `K_LEVEL4SECTION` aren't used anywhere in the code,

[Github-comments] Re: [geany/geany] Map asciidoc level 5 section so it can be shown in the sidebar (PR #3412)

2023-02-24 Thread Colomban Wendling via Github-comments
Not tested but looks good to me 👍 Kudos for the new source layout btw, lakes for a very clean patch 😊 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3412#issuecomment-1444113199 You are receiving this because you are subscribed to this thread. Message I

[Github-comments] [geany/geany] Improve code commenting-out global config files (PR #3413)

2023-02-24 Thread Jiří Techet via Github-comments
Right now, when a config file from Tools->Configuration Files is edited for the first time, the global config file is taken and all lines in it are commented-out. When modified, such a file is copied into the user's config directory. The logic behind this is that the user typically wants to modi

[Github-comments] Re: [geany/geany] Improve code commenting-out global config files (PR #3413)

2023-02-24 Thread elextr via Github-comments
Just a comment, the original concept was that it used the toggle comment marker so blocks of settings could just be toggled. But `Edit->Format->Toggle line Commentation` is pretty well hidden and obscure so that only experienced users know about it and they already have their configs fettled

[Github-comments] Re: [geany/geany] Improve code commenting-out global config files (PR #3413)

2023-02-24 Thread Jiří Techet via Github-comments
> Just a comment [Edit: pun intended :-)], the original concept was that it > used the toggle comment marker so blocks of settings could just be toggled. I could do it too with this patch too - right now the patch only inserts `#` but it could also be `#~ `. Maybe it's a good idea also because i

[Github-comments] Re: [geany/geany] Improve code commenting-out global config files (PR #3413)

2023-02-24 Thread elextr via Github-comments
> Maybe it's a good idea also because it makes it more obvious which line was > commented out. Well with the current patch there are three types of lines, headings which are uncommented, comments which are "# " commented and settings that are "#" no space are commented[^1]. Probably not to ne