[Github-comments] Re: [geany/geany] Improve code commenting-out global config files (PR #3413)

2023-02-26 Thread Jiří Techet via Github-comments
I wouldn't make the setting variable comments too similar to the actual comments - they then become hard to distinguish, see: ```ini # set to false if a comment character/string should start at column 0 of a line, true uses any # indentation of the line, e.g. setting to true causes the following

[Github-comments] Re: [geany/geany] Improve code commenting-out global config files (PR #3413)

2023-02-26 Thread elextr via Github-comments
``` ## set to false if a comment character/string should start at column 0 of a line, true uses any ## indentation of the line, e.g. setting to true causes the following on pressing CTRL+d # #command_example(); ## setting to false would generate this ## command_example(); ## This setti

[Github-comments] [geany/geany] Save As saves CLI opened file instead of new document (Issue #3414)

2023-02-26 Thread Nick Treleaven via Github-comments
Happens when Save As is used on the only empty new document, and a command line file replaces that document while the dialog is still open. _Originally posted by @ntrel in https://github.com/geany/geany/issues/3388#issuecomment-1420621069_ -- Reply to this email directly or view it on GitHub:

[Github-comments] [geany/geany] Fix Save As saves CLI opened file instead of new document (PR #3415)

2023-02-26 Thread Nick Treleaven via Github-comments
Fixes #3414. You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3415 -- Commit Summary -- * Fix Save As saves CLI opened file instead of new document -- File Changes -- M src/document.c (4) -- Patch Links -- https://github.com/geany/ge

[Github-comments] Re: [geany/geany] Open CLI docs only once main window is active again (PR #3395)

2023-02-26 Thread Nick Treleaven via Github-comments
> this affects virtually all CLI openings, as the main window is unlikely to be > focused when that happens. Maybe that could be worked around by checking if the main window has focus, not sure. > can't we "just" fix the offending case(s) not to be buggy in that regard? > (using the document I

[Github-comments] Re: [geany/geany] Fix Save As saves CLI opened file instead of new document (PR #3415)

2023-02-26 Thread Nick Treleaven via Github-comments
@ntrel commented on this pull request. > @@ -628,7 +628,9 @@ static GeanyDocument *document_create(const gchar > *utf8_filename) { doc = document_get_current(); /* remove the empty document first */ - if (doc != NULL && doc->file_name == NUL

[Github-comments] Re: [geany/geany] Improve code commenting-out global config files (PR #3413)

2023-02-26 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. 94c3e110e1a9b5da60faaa81be42759d95365886 fixup! Improve code commenting-out global config files -- View it on GitHub: https://github.com/geany/geany/pull/3413/files/766f756495e0704e7656773bdbf29f096ef45d16..94c3e110e1a9b5da60faaa81be42759d95365886 You are receiving thi

[Github-comments] Re: [geany/geany] Improve code commenting-out global config files (PR #3413)

2023-02-26 Thread Jiří Techet via Github-comments
> Looks good to me, and its simple, just add # to every line except headings. And also except empty lines. > I would not worry about the indented example, after adding a #, it is no > longer an accurate example whichever way its done. I actually don't think this is even a valid conf file syntax

[Github-comments] Re: [geany/geany] Improve code commenting-out global config files (PR #3413)

2023-02-26 Thread Jiří Techet via Github-comments
I just had a look at a few filetype's configurations and it's really a mixed bag of styles. I think it would make most sense to document all the config options in `filetypes.common` _only_ and language-specific config files would contain only those values they override to some other value than

[Github-comments] [geany/geany] TypeScript Parser: Does Not Always Display Complete List of Methods (Issue #3416)

2023-02-26 Thread Jordan Irwin via Github-comments
I have built Geany from commit 4508f77a1150b37d5e16c3e7fc9c7223bc591e88. I am very happy to have a list of members & methods in the symbols pane. And I appreciate the work going into Geany. I have come across a bug in my build's TypeScript parser (ctags?). The parsing sometimes is incomplete. T

[Github-comments] Re: [geany/geany] TypeScript Parser: Does Not Always Display Complete List of Methods (Issue #3416)

2023-02-26 Thread elextr via Github-comments
@techee (sorry to ping you again, but you are __the__ expert in tags and parsers and symbols etc) There is a ctags typescript parser being built into Geany. But the Typescript filetype is a custom filetype that references a [typescript](https://github.com/geany/geany/blob/2509e21526d36034f5251