[Github-comments] Re: [geany/geany-plugins] Small update of the French translation (PR #1287)

2023-10-18 Thread Frank Lanitz via Github-comments
Merged #1287 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1287#event-10705656742 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] lineoperations: Fix translation of some strings (PR #1286)

2023-10-18 Thread Frank Lanitz via Github-comments
Merged #1286 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1286#event-10705606213 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add R execution command (PR #3607)

2023-10-18 Thread hieeupomalrf via Github-comments
@hieeupomalrf pushed 1 commit. 6104d0007a6df4ed3f601e55080475d3066a add R execution command -- View it on GitHub: https://github.com/geany/geany/pull/3607/files/480e17ae6aa08b23b034ab4e9255259c4669c0f7..6104d0007a6df4ed3f601e55080475d3066a You are receiving this because you are subscrib

[Github-comments] Re: [geany/geany-plugins] lineoperations: Fix translation of some strings (PR #1286)

2023-10-18 Thread Sylvan Mostert via Github-comments
@smostertdev approved this pull request. 👍 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1286#pullrequestreview-1686433659 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] lineoperations: Fix translation of some strings (PR #1286)

2023-10-18 Thread Colomban Wendling via Github-comments
@frlan Ideally this could make it to 2.0 as it would extend translation and is fairly trivial, but if it doesn't because it's way too late for this nothing new breaks. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1286#issuecomment-1769587343

[Github-comments] [geany/geany-plugins] Small update of the French translation (PR #1287)

2023-10-18 Thread Colomban Wendling via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1287 -- Commit Summary -- * Small update of the French translation -- File Changes -- M po/fr.po (232) -- Patch Links -- https://github.com/geany/geany-plugins/pull/1287.patch

[Github-comments] [geany/geany-plugins] lineoperations: Fix translation of some strings (PR #1286)

2023-10-18 Thread Colomban Wendling via Github-comments
@smostertdev @frlan This makes translations actually work in several places (prefs dialog, keybindings list, Nth line dialog) You can view, comment on, or merge this pull request online at: https://github.com/geany/geany-plugins/pull/1286 -- Commit Summary -- * lineoperations: Fix translati

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-18 Thread elextr via Github-comments
@poluyan just to remind you, "Monospace" is not a font, it is an alias for one. Use `fc-match monospace` to find out which one so you can avoid it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3610#issuecomment-1769561652 You are receiving this bec

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-18 Thread elextr via Github-comments
Closed #3610 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3610#event-10700778434 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-18 Thread elextr via Github-comments
> Let's just cross fingers and hope Debian does something about it, and nobody > else is shipping a broken Adwaita icon theme… or that none of our user > actually use the broken ones. No chance unless Murphy goes on holidays :smiling_imp: -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-18 Thread Sergey Poluyan via Github-comments
@eht16 Thank you, I have checked, this is exactly the place where font starts to be blurry. I tried SciTE with `scite "-font.base=font:Monospace Regular,size:12"` and compared Geany, SciTE, Gedit. ![geany22](https://github.com/geany/geany/assets/4203047/1619e246-41f9-4fbc-a403-5642f50d8442) Just

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-18 Thread elextr via Github-comments
Thanks Neil, that could explain the difference between GTK2 (Scintilla 3.5) Geany and GTK3 current git (Scintilla 5.3.7) Geany. As I said above, the images posted by the OP show the current aliasing to be more correct than the GTK2 version which never seems to alias both sides of the verticals.

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#pullrequestreview-1686329485 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/edit_change_history.png: @eht16 I took the liberty to push to this PR with the fix above. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1364648967 You are receiving this because you

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 37647e32ca6861f7d06000d8acf8f8f8e079a405 Distribute new documentation image -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/d2186cccddf8a885eae0ccb7c894564f1ac669a0..37647e32ca6861f7d06000d8acf8f8f8e079a405 You are receiving this because you are subscr

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n requested changes on this pull request. New image is missing from the build system. Otherwise I didn't check all PR and issue references, but looks good! :+1: On doc/images/edit_change_history.png: This is not installed! ```diff diff --git a/doc/Makefile.am b/doc/Makefile.am index ea0e0f6

[Github-comments] Re: [geany/geany] Add templates to Config Files menu (PR #3396)

2023-10-18 Thread Colomban Wendling via Github-comments
Postponing as it's a bit late now. Should probably be merged soon after release though. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3396#issuecomment-1769503371 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
I'm gonna postpone that as discussed in #3614, although it might come back to bite us. Or we mention it somewhere in the announcement email? @eht16 :laughing: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3613#issuecomment-1769501953 You are receiv

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-18 Thread Colomban Wendling via Github-comments
Agreed, it grew way too out of hand to be merged less than 24 hours before the deadline. And I agree with @elextr that it likely requires more testing than just hoping every other distro is shipping a well-behaving theme (better behaving than Debian's Adwaita 43) by default, although @techee has

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-18 Thread elextr via Github-comments
> on all thinkable distributions No, just Ubuntu, Mint, Arch probably. The point is that the change is relying on icon themes, and distros are the thing that provides them, and possibly differing sets on each desktop, as far as we can tell all but Debian Adwaita provide sensible `gtk-clear` ic

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-18 Thread Neil Hodgson via Github-comments
Possibly https://sourceforge.net/p/scintilla/code/ci/c692633b18bff53ea43e0f0a81cf56b6ebc83836/ which was to fix https://sourceforge.net/p/scintilla/bugs/2310/. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3610#issuecomment-1769477898 You are receiv

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Thomas Martitz via Github-comments
LGTM -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-176945 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-18 Thread Jiří Techet via Github-comments
> This needs to be tested on a wide range of distros, not just Debian, and not > just Gnome, Cinnamon, XFCE, etc and Windows. I don't think it needs to be tested on all thinkable distributions (just tried briefly on macOS and it seems to work), it should work the same way everywhere. On the oth

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > +* Update Python filetype config (PR#3039). +* Add AutoIt filetype (Skif-off, PR#1752). +* Add GDScript filetype (David Yang, PR#3012). +* Remove Ferite filetype (PR#3075). +* Enable local variables and improve autocompletion for C/C++

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 pushed 6 commits. 641a09159a047d5df5adaf4b7675aa242e72a101 Add NEWS for Geany 2.0 dbf3c8e0141da0e14a619787c2d14a2aa47130c7 Add documentation for new Scintilla feature "Change history" 35a208aa24e78887109fa3d1993548492abc516d Update documentation screenshots c1be9eca9f12c38d12762c6472ad0

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > +* Update Python filetype config (PR#3039). +* Add AutoIt filetype (Skif-off, PR#1752). +* Add GDScript filetype (David Yang, PR#3012). +* Remove Ferite filetype (PR#3075). +* Enable local variables and improve autocompletion for C/C++

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread elextr via Github-comments
@elextr commented on this pull request. > +.. image:: ./images/edit_change_history.png + +The image shows the default visuals: + +* inserted characters appear with coloured underlines +* points where characters were deleted are shown with small triangles +* the margin shows a block indicating th

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread elextr via Github-comments
I just did a quick rescan, raised one question, not critical just ignore if stupid :-) LGTM -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1769368276 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread elextr via Github-comments
@elextr commented on this pull request. > +* Update Python filetype config (PR#3039). +* Add AutoIt filetype (Skif-off, PR#1752). +* Add GDScript filetype (David Yang, PR#3012). +* Remove Ferite filetype (PR#3075). +* Enable local variables and improve autocompletion for C/C+

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > +.. image:: ./images/edit_change_history.png + +The image shows the default visuals: + +* inserted characters appear with coloured underlines +* points where characters were deleted are shown with small triangles +* the margin shows a block indicating the

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 85febd1e301506e8a22cedcc4eb177dd919719c5 Document Change History is disabled by default -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/e35069844226d60456eb397e6095116b099eb74a..85febd1e301506e8a22cedcc4eb177dd919719c5 You are receiving this because

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
@elextr @kugel- @b4n could you have a look on the yet open discussions and either resolve or comment on them? We are slightly running out of time. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1769341258 You are receiving this because

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
> @eht16 looks like there has been a rebase mishap, and you grabbed some > unrelated things in there 😕 Oops, thanks for notifying. Should be fixed. I started a first round of squashing the incremental changes and then came #3611 :). > You can add #3611 now ;) Done. -- Reply to this email dir

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread elextr via Github-comments
GP is less concerning, plugins can be disabled, code in Geany can't. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#issuecomment-1769334983 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread elextr via Github-comments
@elextr commented on this pull request. > +.. image:: ./images/edit_change_history.png + +The image shows the default visuals: + +* inserted characters appear with coloured underlines +* points where characters were deleted are shown with small triangles +* the margin shows a block indicating th

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. On doc/images/main_window.png: No, it just that the user reading the documentation would need a resolution big enough to match the screenshot dimensions or the user needs to scroll. But probably no big deal nowadays. -- Reply to this email directly or

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@elextr regarding the CI it was merely a squash (no diff from the base verified) + a rebase… and yes, I let my build and meson finish :P And it's all green now, ain't it :] (though, I start to think it's becoming late indeed… I'll only plan to make one more PR for 2.0 GP :]) -- Reply to this

[Github-comments] Re: [geany/geany-plugins] projectorganizer: ignored directory patterns are not applied to project root paths (Issue #1283)

2023-10-18 Thread elextr via Github-comments
> creating the Geany project one directory above so foo becomes a single > directory of the project and can get ignored as a whole. Which is why I showed it as `project_dir/remote` where remote is the mount and the ignored pattern. -- Reply to this email directly or view it on GitHub: https://

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 pushed 4 commits. b73b29b90cc1e1526ea77096d59953610777d2d6 Add NEWS for Geany 2.0 6a61051feccacb0698308d256d29f787bff4705c Add documentation for new Scintilla feature "Change history" f90c81347d9542c85bc6aeddbabc6becc7b4311c Update documentation screenshots e35069844226d60456eb397e60951

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
@techee Ah yeah those names are common indeed. And cool, if they are required by GTK itself, it's indeed very likely to be present, or at least work fine if not (e.g. falling back on the non-symbolic version) :+1: -- Reply to this email directly or view it on GitHub: https://github.com/geany/

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Enrico Tröger via Github-comments
What bad things should happen? @b4n committed (this is without any irony!). -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#issuecomment-1769324008 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@eht16 looks like there has been a rebase mishap, and you grabbed some unrelated things in there :confused: -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1769322566 You are receiving this because you are subscribed to this thread. M

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread elextr via Github-comments
FFS STOP THE LAST MINUTE MERGING!! The CI ddin't even finish here. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#issuecomment-1769320995 You are receiving this because you are subscribed to this thread. Mes

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
You can add #3611 now ;) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#issuecomment-1769320562 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Restoring the session does not restore the current file or files order when tabs_order_beside is enabled (Issue #3609)

2023-10-18 Thread Colomban Wendling via Github-comments
Closed #3609 as completed via 4246298dd8b3c70528cdad0554000f5d54f39765. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3609#event-10699097436 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
Merged #3611 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#event-10699097461 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Release 2.0 documentation (PR #1285)

2023-10-18 Thread Frank Lanitz via Github-comments
LGTM -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1285#issuecomment-1769317238 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-18 Thread elextr via Github-comments
Heh, overlapping comments Great minds think alike :-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3610#issuecomment-1769315999 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
(I just squashed the commits and rebased on master, will now merge) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#issuecomment-1769315976 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Jiří Techet via Github-comments
At least GTK seems to have a test for these icon names so I think their presence is kind of required: https://gitlab.gnome.org/GNOME/gtk/-/blob/main/testsuite/gtk/check-icon-names.c -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3613#issuecomment-17

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-18 Thread elextr via Github-comments
Try the merges that change Scintilla versions first. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3610#issuecomment-1769315440 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-18 Thread Enrico Tröger via Github-comments
I didn't understand the issue completely yet but anyway maybe it's worth to try SciTE (https://archlinux.org/packages/extra/x86_64/scite/) to check whether it has the same problem. If so, it is very likely related to Scintilla. If not, it may or may not be related to Scintilla. @poluyan when yo

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 4246298dd8b3c70528cdad0554000f5d54f39765 Fix startup files order when placing tabs next to the current one -- View it on GitHub: https://github.com/geany/geany/pull/3611/files/0e0b33b5b8f2e858c06ea91128331f7d2252c15b..4246298dd8b3c70528cdad0554000f5d54f39765 You are recei

[Github-comments] Re: [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-18 Thread elextr via Github-comments
This needs to be tested on a wide range of distros, not just Debian, and not just Gnome, Cinnamon, XFCE, etc and Windows. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3614#issuecomment-1769312752 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
See #3614 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3613#issuecomment-1769309119 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] [geany/geany] Icon names, and symbolic. Makes Adwaita 43 happy. (PR #3614)

2023-10-18 Thread Colomban Wendling via Github-comments
See #3613. Some of the changes here make sense, some don't really but are still needed not to look terrible with Adwaita 43. See each commit for details. @techee @eht16 that's kind of how it looks to dodge the Adwaita 43 issues I could see. You can view, comment on, or merge this pull request o

[Github-comments] Re: [geany/geany] font hintstyle/antialias in editor differ from settings font (Issue #3610)

2023-10-18 Thread Sergey Poluyan via Github-comments
Thanks everyone for the detailed answers! I just tested geany 1.38 (2022-05-01) from the official arch repo. The font there looks "sharp" as I wanted. It uses GTK+ v3.24.38, the same one I used building latest commit version from source. I tested geany with gtk2 too, font is sharp. I have to do

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
@techee symbolic icons has nothing to do with using icon names rather than stock items, apart that stock items don't use symbolic icons. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3613#issuecomment-1769305818 You are receiving this because you are

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Jiří Techet via Github-comments
> Might there be any risk that other themes may not work well with the changed > icon references? I guess this is hard to answer; the icon loading mechanism > are big mystique to me and so I'm just wondering how much we could break with > this change. Just speculating but `gtk_image_new_from_st

[Github-comments] Re: [geany/geany-plugins] Release 2.0 documentation (PR #1285)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > +Addons: +* Bookmarks: Prevent duplicating bookmarks when editing line (PR #1040) +* Delay updating of tasks list until document has been colorised + (Issue #1254, PR #1257) + +GeanyLua: +* Update documentation for "geany.keygrab"

[Github-comments] Re: [geany/geany-plugins] Release 2.0 documentation (PR #1285)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 0167607f2f7124dd285cf088ad0f6e0182b2c4b2 fixup! Add NEWS for Geany-Plugins 2.0 -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1285/files/436e514c1139b6738f617b8441f990c39ed7aa12..0167607f2f7124dd285cf088ad0f6e0182b2c4b2 You are receiving this because y

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE; +

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#pullrequestreview-1686111258 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
> Might there be any risk that other themes may not work well with the changed > icon references? I guess this is hard to answer; the icon loading mechanism > are big mystique to me and so I'm just wondering how much we could break with > this change. Well, I'm not 100% sure, but I think yes, t

[Github-comments] Re: [geany/geany-plugins] Release 2.0 documentation (PR #1285)

2023-10-18 Thread Frank Lanitz via Github-comments
@frlan commented on this pull request. > +Addons: +* Bookmarks: Prevent duplicating bookmarks when editing line (PR #1040) +* Delay updating of tasks list until document has been colorised + (Issue #1254, PR #1257) + +GeanyLua: +* Update documentation for "geany.keygrab"

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Jiří Techet via Github-comments
@techee commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE;

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Enrico Tröger via Github-comments
Great, that you have it reported on Debian. And good to know that newer versions of the theme do not expose this bug. Debian users could probably even install the Sid package (judged from the direct dependencies which should be possible). Back to Geany: I fully agree with what @techee said. It's

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE; +

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Thomas Martitz via Github-comments
@kugel- commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE;

[Github-comments] Re: [geany/geany-plugins] Release 2.0 documentation (PR #1285)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 pushed 2 commits. 1e9296bee0715464482b0784e0e68cd2f8fc768f Updated translations 436e514c1139b6738f617b8441f990c39ed7aa12 Merge pull request #1 from frlan/release_2_0_documentation -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1285/files/addfc9ae82601bc2922339e468cd6

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE; +

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n pushed 1 commit. 0e0b33b5b8f2e858c06ea91128331f7d2252c15b fixup! Fix startup files order when placing tabs next to the current one -- View it on GitHub: https://github.com/geany/geany/pull/3611/files/7ff00f56af24fe1ea9013c9d3b64e14d6dce5f76..0e0b33b5b8f2e858c06ea91128331f7d2252c15b You ar

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Enrico Tröger via Github-comments
> An aside: @eht16 congrats the Windows CI is working again. Interesting to see > the relative speeds, meson/ninja vs Autotools/gmake vs Autotools in a > container. Comparing Meson vs Autotools was already possible before. The Windows CI builds should be excluded from such comparisons because t

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Jiří Techet via Github-comments
> You guys like to have me updating screenshots I guess... Nah, it could have totally stayed the way it was. > The screenshot for the prefs dialog with the changed default for the tab > label length is updated for 1000 chars, pixels, apples, Euros 😄. We are aiming for 1000 screenshot updates in

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
You guys like to have me updating screenshots I guess... The screenshot for the prefs dialog with the changed default for the tab label length is updated for 1000 chars, pixels, apples, Euros :smile:. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Thomas Martitz via Github-comments
> And having added the feature back then, I can tell you I didn't plan for this > :) Alright, I am convinced it's a bug now :-) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#issuecomment-1769240269 You are receiving this because you are subscri

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 8ac78832fb7e758784ed65dc50eb7ad766ba9eaf Update doc/geany.txt -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/143f8e399684624dbf3b5f0147209ce9f1bd628d..8ac78832fb7e758784ed65dc50eb7ad766ba9eaf You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Thomas Martitz via Github-comments
@kugel- commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE;

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@kugel- > It's not even clear to me if this is even a bug (as in "not working as > intended"). I surely never used that pref. Well, to me it's definitely a bug as the session is *not* restored as it was saved. Both documents order and current document are lost (well, current document is OK if

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Enrico Tröger via Github-comments
> It's not even clear to me if this is even a bug (as in "not working as > intended"). I surely never used that pref. I hardly can imagine this could be intended behaviour. After start, the previous code opened the tabs in some random (maybe not really random but in some for the user undetermin

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE; +

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Enrico Tröger via Github-comments
> although any sane person would have enabled the problematic option 😁 @b4n Hah, it seems you have proven me as crazy again, my config says `tab_order_beside=false` :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#issuecomment-1769221517 You are

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Thomas Martitz via Github-comments
@kugel- commented on this pull request. > /* necessary to set it to TRUE for project session support */ main_status.opening_session_files++; - i = file_prefs.tab_order_ltr ? 0 : (session_files->len - 1); - while (TRUE) + file_prefs.tab_order_beside = FALSE;

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Thomas Martitz via Github-comments
Actually if it's like this in 1.38 already (and possibly earlier) I see no compelling reason to rush this into 2.0, considering that tomorrow is release. It's not even clear to me if this is even a bug (as on "not working as intended"). I surely never used that pref. -- Reply to this email dir

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 approved this pull request. Tested and works cleanly. I'm all in for merge. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#pullrequestreview-1685997547 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Enrico Tröger via Github-comments
@eht16 pushed 1 commit. 143f8e399684624dbf3b5f0147209ce9f1bd628d Update screenshots -- View it on GitHub: https://github.com/geany/geany/pull/3593/files/50f76291b2e9b3ff55fe655109d532ed221f46a1..143f8e399684624dbf3b5f0147209ce9f1bd628d You are receiving this because you are subscribed to this t

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
> otherwise we might get flooded with bug reports regarding this problem and we > might have to make a new release because of it anyway. Yeah that's kind of my point, whomever fault it is, some of it will land on us. And it still might, as if you install Geany from Debian under GNOME in Bookwo

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Jiří Techet via Github-comments
Regardless of whether it is an Adwaita icon theme bug (I just tried with other icon themes and apart from the Adwaita one, all work well), I think if the patch is as simple as you propose (possibly covering more instances), we should do it - otherwise we might get flooded with bug reports regard

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Jiří Techet via Github-comments
@techee approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3611#pullrequestreview-1685192114 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Jiří Techet via Github-comments
> Looks good to me based on the code itself and I think it could go to 2.0. I > just haven't tested it yet (which I'm going to do now). I just tested it and, yes, it is fixed, and, yes, the re-arrangement is really annoying without this patch so I think it should go to 2.0. (Somehow, I didn't h

[Github-comments] Re: [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
Subset of a possible fix: ```diff diff --git a/src/build.c b/src/build.c index 56ec9d613..3d94a683f 100644 --- a/src/build.c +++ b/src/build.c @@ -1898,7 +1898,7 @@ static RowWidgets *build_add_dialog_row(GeanyDocument *doc, GtkTable *table, gui GTK_FILL | GTK_EXPAND, entry

[Github-comments] [geany/geany] Adwaita icon theme makes Geany look ugly (on Debian Bookworm?) (Issue #3613)

2023-10-18 Thread Colomban Wendling via Github-comments
Following up https://github.com/geany/geany/pull/3593#issuecomment-1757592993, should we do something about it on our end? Basically the solution is to use `edit-clear-symbolic` icon-name instead of `GTK_STOCK_CLEAR`, which is for most of it easy, for some a bit more involved. * is it our prob

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Jiří Techet via Github-comments
> @eht16 @techee @elextr I added that to %2.0, but if it's not new since 1.38 > and you don't feel it's simple enough, we can postpone. It's actually not a > problem with the default settings, so it's less bad -- although any sane > person would have enabled the problematic option 😁 Looks good

[Github-comments] Re: [geany/geany-plugins] projectorganizer: ignored directory patterns are not applied to project root paths (Issue #1283)

2023-10-18 Thread Jiří Techet via Github-comments
> But using patterns allows the plugin to autoselect which projects to disable > since it can distinguish between project1_dir/remote (which is the slow > remote mount) and project2_dir/local (which is fast local storage). But I think the problem (if I understand it correctly) is, that when you

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Jiří Techet via Github-comments
Merged #3612 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3612#event-10692845087 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Jiří Techet via Github-comments
> BTW, what's the unit of the setting? pixels, chars, apples? The tooltip of the entry says "Characters to be visible on the tab label of the file". While it's a bit inaccurate wrt international text as @b4n noted, it's probably fine for "normal" projects and files. -- Reply to this email dire

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. On doc/images/main_window.png: @eht16 yeah… is it a problem in the generated file? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3593#discussion_r1363823645 You are receiving this because you are subscribed to th

[Github-comments] Re: [geany/geany] Release 2.0 documentation (PR #3593)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > +Screenshots in the document are the default GTK Adwaita theme, +but Geany will adapt to the desktop GTK theme that is set. ```suggestion Screenshots in this document are taken with the default GTK Adwaita theme, but Geany will adapt to the

[Github-comments] Re: [geany/geany] Fix startup files order when placing tabs next to the current one (PR #3611)

2023-10-18 Thread Colomban Wendling via Github-comments
@eht16 @techee @elextr I added that to %2.0, but if it's not new since 1.38 and you don't feel it's simple enough, we can postpone. It's actually not a problem with the default settings, so it's less bad -- although any sane person would have enabled the problematic option :grin: -- Reply to

[Github-comments] Re: [geany/geany] Change default tab_label_length from 99999 to 1000 (PR #3612)

2023-10-18 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3612#pullrequestreview-1684973051 You are receiving this because you are subscribed to this thread. Message ID:

  1   2   >