[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-19 Thread elextr via Github-comments
The dropdown to the right of the big green button has a squash and merge option. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3169#issuecomment-2008340400 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Update HACKING with find_shebang() and editor_set_indentation_guides() (PR #3795)

2024-03-19 Thread elextr via Github-comments
LGTM -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3795#issuecomment-2008339163 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] RFE: please add support for Perl6 (Raku) (Issue #3054)

2024-03-19 Thread ToddAndMargo via Github-comments
Hi Rdipardo, What is the release number that this first appears in? (If I can give Fedora the release number, they will spin a new RPM for me.) Thank yoU! -T -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3054#issuecomment-2008307240 You are

[Github-comments] [geany/geany] Update HACKING with find_shebang() and editor_set_indentation_guides() (PR #3795)

2024-03-19 Thread Jiří Techet via Github-comments
Inspired by https://github.com/geany/geany/pull/3169 which was missing the update of find_shebang(), we should mention this in HACKING. I also noticed we kind of neglected updating editor_set_indentation_guides() - not sure if its very important but at least worth mentioning in HACKING. You

[Github-comments] Re: [geany/geany] Add Ocaml ctags parser (PR #3163)

2024-03-19 Thread Jiří Techet via Github-comments
@eht16 @b4n What do you think about including the ocaml ctags parser? It's not strictly necessary but since it's in ctags and "for free", I'd say why not. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3163#issuecomment-2008215856 You are receiving

[Github-comments] Re: [geany/geany] Add Ocaml ctags parser (PR #3163)

2024-03-19 Thread Jiří Techet via Github-comments
@techee pushed 1 commit. c509b9000633acd9c9af93f15a84a3f4e6dd5ad3 Add Ocaml ctags parser -- View it on GitHub: https://github.com/geany/geany/pull/3163/files/d25365aed87acd92065a02962142d848cd301bbf..c509b9000633acd9c9af93f15a84a3f4e6dd5ad3 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-19 Thread Jiří Techet via Github-comments
Meh, I forgot how github handles fixup commits and kind of assumed they get auto-squashed when merging a PR (which didn't happen). So there's a slight mess as the fixup commits were preserved. Sorry for that. -- Reply to this email directly or view it on GitHub:

[Github-comments] Re: [geany/geany] Raku comment #`{comment} not recognized properly (Issue #3053)

2024-03-19 Thread Jiří Techet via Github-comments
Closed #3053 as completed via #3169. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3053#event-12176146469 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Raku Syntax Highlighting (#2456)

2024-03-19 Thread Jiří Techet via Github-comments
Closed #2456 as completed via #3169. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/2456#event-12176146516 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-19 Thread Jiří Techet via Github-comments
Merged #3169 into master. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3169#event-12176146188 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] RFE: please add support for Perl6 (Raku) (Issue #3054)

2024-03-19 Thread Jiří Techet via Github-comments
Closed #3054 as completed via #3169. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3054#event-12176146420 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-19 Thread Enrico Tröger via Github-comments
>Surely he means Racket, its [lisp](https://xkcd.com/297/) (well >Scheme, but similar) and it has its own portable native GUI library >built in, no more GTK on windows issues .. hmm I just might convince >myself at this rate :-) Raku, R, Racket, Rust, Ruby, I'll leave the important questions to

[Github-comments] Re: [geany/geany] Initial support for Scintilla sub-styles (PR #3794)

2024-03-19 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > + /* FIXME: this is sub-stylable, but we can't > figure out the base +* style without the Scintilla instance -- and we can't simply +* assume that if the style ID

[Github-comments] Re: [geany/geany] Initial support for Scintilla sub-styles (PR #3794)

2024-03-19 Thread elextr via Github-comments
@elextr commented on this pull request. > + /* FIXME: this is sub-stylable, but we can't > figure out the base +* style without the Scintilla instance -- and we can't simply +* assume that if the style

[Github-comments] Re: [geany/geany] Initial support for Scintilla sub-styles (PR #3794)

2024-03-19 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > g_string_append_c(stats_str, ' '); - g_string_append_printf(stats_str, "%d", - sci_get_style_at(doc->editor->sci, pos)); +

[Github-comments] Re: [geany/geany] Initial support for Scintilla sub-styles (PR #3794)

2024-03-19 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > + /* FIXME: this is sub-stylable, but we can't > figure out the base +* style without the Scintilla instance -- and we can't simply +* assume that if the style ID

[Github-comments] Re: [geany/geany] Initial support for Scintilla sub-styles (PR #3794)

2024-03-19 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > @@ -877,6 +939,21 @@ static void styleset_from_mapping(ScintillaObject *sci, > guint ft_id, guint lexer if (styles[i].fill_eol) SSM(sci, SCI_STYLESETEOLFILLED, styles[i].style, TRUE);

[Github-comments] [geany/geany] Initial support for Scintilla sub-styles (PR #3794)

2024-03-19 Thread Colomban Wendling via Github-comments
This is a first attempt with little testing, but it seems to work pretty OK. However, please review all levels, from design to implementation. To summarize, what this does is look for `stylename.N` for styles that are known to be sub-stylable[^1], as well as the corresponding

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-19 Thread elextr via Github-comments
> > Maybe I'll change my mind in two weeks, what about Reany? > Sounds like Geany written in R, doesn't it? :) Surely he means Racket, its [lisp](https://xkcd.com/297/) (well Scheme, but similar) and it has its own portable native GUI library built in, no more GTK on windows issues .. hmm I

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-19 Thread Colomban Wendling via Github-comments
> Maybe I'll change my mind in two weeks, what about Reany? Sounds like Geany written in R, doesn't it? :) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3169#issuecomment-2006337810 You are receiving this because you are subscribed to this thread.

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-19 Thread Colomban Wendling via Github-comments
@b4n approved this pull request. I still have no clue about Raku, but LGTM and works as far as super-basic testing goes. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3169#pullrequestreview-1945531024 You are receiving this because you are

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-19 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > +functions=ACCEPTS AT-KEY EVALFILE EXISTS-KEY Filetests IO STORE abs accept > acos acosec acosech acosh acotan acotanh alarm and antipairs asec asech asin > asinh atan atan2 atanh base bind binmode bless break caller ceiling chars > chdir chmod chomp

[Github-comments] Re: [geany/geany] Add Raku (Perl 6) filetype support (lexer and ctags parser) (PR #3169)

2024-03-19 Thread Colomban Wendling via Github-comments
@b4n commented on this pull request. > + { 2, "types_basic", FALSE }, + { 3, "types_composite", FALSE }, + { 4, "types_domain",FALSE }, + { 5, "types_exceptions",FALSE }, You convinced me that we can at least wait for