@elextr commented on this pull request.
> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+#ifndef GEANY_PLUGIN_EXTENSION_H
+#define GEANY_PLUGIN_EXTENSION_H 1
+
+#include "document.h"
+
+/* Temporary define so the plugin can check whether it's compiled against
+ * Ge
Keep the string, its for _human_ consumption and use, and a pointer isn't.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#issuecomment-2161737994
You are receiving this because you are subscribed to this thread.
Message ID:
@techee commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
> or just use get_current_word_or_sel()?
But it's static inside
@elextr commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
Just a note, nothing should depend on Geany thinking there is a
@techee commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
Just tested and yes, I get identical numbers from
```C
int start
> @techee yeah, the only thing is whether to pass GeanyPlugin* to the register
> function, the rest looks good to me.
Since we'll be flooded by plugins wanting to implement this API, some of them
using Peasy, some implementing several extensions just for fun, we'll need to
distinguish all these
@b4n commented on this pull request.
>
if (plugin_extension_goto_provided(doc, NULL))
return plugin_extension_goto_perform(doc, pos, definition);
+ editor_find_current_word(doc->editor, pos,
+ editor_info.current_word, GEANY_MAX_WORD_LENGTH, NULL);
@techee yeah, the only thing is whether to pass `GeanyPlugin*` to the register
function, the rest looks good to me.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#issuecomment-2161709815
You are receiving this because you are subscribed to this thr
@techee pushed 1 commit.
b7c6b84ee0d77af826994bce8c59073d1f363dd8 Add missing check
--
View it on GitHub:
https://github.com/geany/geany/pull/3849/files/d34a0a36e761cb2844ae50ffaceaee18fee0d348..b7c6b84ee0d77af826994bce8c59073d1f363dd8
You are receiving this because you are subscribed to this t
@techee commented on this pull request.
>
if (plugin_extension_goto_provided(doc, NULL))
return plugin_extension_goto_perform(doc, pos, definition);
+ editor_find_current_word(doc->editor, pos,
+ editor_info.current_word, GEANY_MAX_WORD_LENGTH, NUL
@b4n commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
…or just use `get_current_word_or_sel()`? Not tested, but the clic
@b4n commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
Ah, right, it calls `get_current_word_or_sel()`, and is indeed diff
@b4n commented on this pull request.
>
if (plugin_extension_goto_provided(doc, NULL))
return plugin_extension_goto_perform(doc, pos, definition);
+ editor_find_current_word(doc->editor, pos,
+ editor_info.current_word, GEANY_MAX_WORD_LENGTH, NULL);
(getting a build could be nice, but apparently GA has had some issues…)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2161693458
You are receiving this because you are subscribed to this thread.
Message ID:
@techee merging as is is fine here I think, the history could be cleaned but
it's not bad either. So I'd rather not worry about squashing smartly, which
might prove harder than necessary.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecommen
@b4n approved this pull request.
LGBI with a little squashing
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany-plugins/pull/1358#pullrequestreview-2111542923
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n I believe I addressed all your comments - if I forgot about something,
please let me know.
Can I start working on the documentation or is there still a risk the API will
turn into something completely different? :-)
--
Reply to this email directly or view it on GitHub:
https://github.com/
@techee pushed 2 commits.
0f1bf7cedd3b13cb964539e78c196020b26ed0ad Move
plugin_extension_calltips_provided() check inside on_editor_notify()
d34a0a36e761cb2844ae50ffaceaee18fee0d348 Make plugin_extension_goto_provided()
free to decide whether to perform goto
--
View it on GitHub:
https://git
@techee commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
I'd just point out that this eliminates `get_current_word_or_sel
@techee pushed 1 commit.
5f18bbfd7f755918dcfa0cd15ee6f9cbe2a4bcb3 Remove unnecessary _provided() calls
--
View it on GitHub:
https://github.com/geany/geany/pull/3849/files/80fbed1671c5901059c34acce9e93245333933dd..5f18bbfd7f755918dcfa0cd15ee6f9cbe2a4bcb3
You are receiving this because you are s
@eht16 commented on this pull request.
> -#if ! GTK_CHECK_VERSION(2, 10, 0)
gtk_widget_hide(check_systray);
-#endif
This is so me...you are completely right.
Thanks for spotting, fixed.
Funny thing, this attempt to hide the option didn't work at all because in
Geany itself we call `gt
@eht16 pushed 1 commit.
678c81edbf221adedb2917e327062365b178d33a fixup: remove left-over systray call
--
View it on GitHub:
https://github.com/geany/geany-plugins/pull/1358/files/695748bccca5f8ad2a5ed6a21970b60439935b0e..678c81edbf221adedb2917e327062365b178d33a
You are receiving this because yo
@techee commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
> there's still the question of whether this should really be gu
> LGTM
OK to merge as it is or do some squashing?
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2161581125
You are receiving this because you are subscribed to this thread.
Message ID:
>> In theory this should be all it's needed but something else may appear
>> during implementation. How does it sound?
> Good if it's not too hard to implement the details like activating a row,
> navigating them an whatnot, but I guess we don't have much custom stuff apart
> knowing where to g
> I thought of it, but I don't know… on one hand it indeed allows accessing a
> lot more stuff if need be, and we could even make sure the extension got
> unregistered on plugin unload (so a plugin forgetting to unregister wouldn't
> crash, although I wouldn't love authors to disregard deregistr
@b4n approved this pull request.
LGTM
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#pullrequestreview-2111404817
You are receiving this because you are subscribed to this thread.
Message ID:
@b4n pushed 1 commit.
3106a938506c3b73e775d055025fb774aa828b80 Do not create empty file filters
--
View it on GitHub:
https://github.com/geany/geany/pull/3861/files/f1a2870609d855c4ba3acbfc341bb314cc96b687..3106a938506c3b73e775d055025fb774aa828b80
You are receiving this because you are subscrib
@techee commented on this pull request.
> + if (plugin_extension_calltips_provided(editor->document, NULL))
+ plugin_extension_calltips_show(editor->document, FALSE);
+
+ if (plugin_extension_autocomplete_provided(editor->document, NULL))
+ plugin_extension_
> Still thinking a bit about the symbol tree - it would be nice not to have a
> separate tab that users have to switch to. What about:
>
> * allowing the plugin to access the GtkTreeView of the symbol tree so it can
> put whatever it wants there
Could the extension be called once (per document,
> Now thinking, instead of `name`, shouldn't rather `GeanyPlugin *` be passed
> as an argument of `register()`? The function can read from it whatever it
> wants.
I thought of it, but I don't know… on one hand it indeed allows accessing a lot
more stuff if need be, and we could even make sure t
@b4n commented on this pull request.
> {
+ GeanyDocument *doc = document_get_current();
+
+ if (plugin_extension_goto_provided(doc, NULL))
+ return plugin_extension_goto_perform(doc, pos, definition);
there's still the question of whether this should really be guarded
@b4n commented on this pull request.
> + if (plugin_extension_calltips_provided(editor->document, NULL))
+ plugin_extension_calltips_show(editor->document, FALSE);
+
+ if (plugin_extension_autocomplete_provided(editor->document, NULL))
+ plugin_extension_aut
@b4n commented on this pull request.
> + if (plugin_extension_calltips_provided(doc, NULL))
+ return;
+
Yes
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#discussion_r1635385969
You are receiving this because you are subscribed
Now thinking, instead of `name`, shouldn't rather `GeanyPlugin *` be passed as
an argument of `register()`? The function can read from it whatever it wants.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3849#issuecomment-2161132509
You are receiving th
I just noticed some more dead code inside `win32.c` that was used by the native
implementation so I removed it.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3861#issuecomment-2160488828
You are receiving this because you are subscribed to this thread.
@techee pushed 1 commit.
f1a2870609d855c4ba3acbfc341bb314cc96b687 Remove some more win32 code that was
previously used by native dialogs
--
View it on GitHub:
https://github.com/geany/geany/pull/3861/files/7a259e8ed7e76f3861d192afa083dae78de44e7b..f1a2870609d855c4ba3acbfc341bb314cc96b687
You a
I won't be able to check on a real linux/windows machine until the end of the
week, I'll see then.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3902#issuecomment-2160205451
You are receiving this because you are subscribed to this thread.
Message ID:
Maybe its something about how graphics on native and the VM maps to the Macos
graphics, both have to end up calling the same library that maps them into the
Macos display, otherwise the machine display could get all messed up if
"foreign" graphics were just allowed total control of the hardware.
> Having human readable names for extensions is useful in many ways, even just
> having something to debug print, so @b4n is right, adding a name now is a
> good idea and we can then use it lots of ways.
OK, done.
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/g
@techee pushed 1 commit.
80fbed1671c5901059c34acce9e93245333933dd Add plugin name argument to
plugin_extension_register()
--
View it on GitHub:
https://github.com/geany/geany/pull/3849/files/947ea7b377fa76a9118972ccf7ac74f09e9cfecb..80fbed1671c5901059c34acce9e93245333933dd
You are receiving th
> PS I wouldn't say you are crazy, but your system might be ;-)
Well, if it happened just on one, it could be. But this happens both with the
macOS binary and on Linux VM (on the same macOS but it's a different GTK
backend). Basically the CPU oscillates somewhere between 0.3%-1.0% in `top`
afte
> Just to verify, I assume where you say "multiple carets" you also mean
> multiple selection?
Yes, it's the same thing. You either Modifier+click to add a new caret or
Modifier+drag (or Modifier+double-click on an identifier) to make a new
selection
--
Reply to this email directly or view it
> Actually, given GNOME uses Super, Alt might be a better default.
Cinnamon uses Alt, so Super is better (ie no right answer)
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3899#issuecomment-2160094566
You are receiving this because you are subscribed t
@b4n I wasn't mentioning it remember :grin:, so didn't go into details ... but
I said it better in the second post, press keybinding (as you do now) then
select action for it, so anything GTK can understand (and will get through the
barrier of the WM ;-) can be assigned to any action. And the H
I don't have a whole lot to add to the discussion just yet (but allowing e.g.
RMB or even MMB is a neat idea to double or triple the
options at hand), but:
> Reasonal defaults would be
>
> […]
> * Linux: Super for multiple carets, Ctrl+Shift for rectangular selection
Actually, given GN
Hmmm, sorry about the multiple post, for some reason the first didn't show up
until I posted the second
--
Reply to this email directly or view it on GitHub:
https://github.com/geany/geany/pull/3899#issuecomment-2160044700
You are receiving this because you are subscribed to this thread.
Messag
If you map action to selectable click modifier you need to check if that it
isn't assigned elsewhere since each modifier can only trigger one action and
popup a "its already assigned, do you want me to unassign it" dialog like the
Geany keybinding does because its backwards too. (Inverting it wo
Well, its not much difference between the UIs for something this small,
although I think mapping fixed click modifier to selectable action is the way
round it should work (and the whole Geany keybinding UI should be changed to
fixed key combo selectable action, but I won't mention it to avoid @b
49 matches
Mail list logo
