[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-05-30 Thread Andy Alt via Github-comments
> Yes, I'll do that soon. @eht16 I tried and tested but the AS doesn't highlight. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3757#issuecomment-2141289564 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-05-30 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. e366b21fcc5eea51cc36ac151af2363dcedec8ac Add Dockerfile filedef -- View it on GitHub: https://github.com/geany/geany/pull/3757/files/63474cc70c093122c09c2c1706d63065d4f1305a..e366b21fcc5eea51cc36ac151af2363dcedec8ac You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-05-29 Thread Andy Alt via Github-comments
Yes, I'll do that soon. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3757#issuecomment-2136861333 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

2024-05-10 Thread Andy Alt via Github-comments
@eht16 @b4n This is squashed and ready to go. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3759#issuecomment-2104724781 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-05-10 Thread Andy Alt via Github-comments
> Do we need to adjust anything for the Meson build system? No, this is in data/meson.build: `install_subdir('filedefs', install_dir: cdata.get('GEANY_DATA_DIR'), exclude_files: 'filetypes.python.in')` I think this is done now. -- Reply to this email directly or view it on GitHub: https:/

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-05-10 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 63474cc70c093122c09c2c1706d63065d4f1305a Add Dockerfile filedef -- View it on GitHub: https://github.com/geany/geany/pull/3757/files/f684daf36e9b31a91fdd115b4026f8de35412188..63474cc70c093122c09c2c1706d63065d4f1305a You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-05-10 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. f684daf36e9b31a91fdd115b4026f8de35412188 Update data/filedefs/filetypes.Dockerfile.conf -- View it on GitHub: https://github.com/geany/geany/pull/3757/files/b21ed0baba253cb40c6a2e239c1812c833c16a66..f684daf36e9b31a91fdd115b4026f8de35412188 You are receiving this beca

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-03-17 Thread Andy Alt via Github-comments
No worries @eht16 , I know mistakes happen to humans. Cheers! -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3769#issuecomment-2002704998 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-03-10 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > @@ -15,7 +15,7 @@ on: # cancel already running builds of the same branch or pull request concurrency: - group: ci-${{ github.head_ref }} || concat(${{ github.ref }} + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.s

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-03-10 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. a8bb8700e1d55e63c71fa2850d9862d211178677 Change concurrency rules -- View it on GitHub: https://github.com/geany/geany/pull/3769/files/e5a73c9e3608ca7185c508fe8f0d1199a4a89078..a8bb8700e1d55e63c71fa2850d9862d211178677 You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-03-10 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > @@ -8,6 +8,13 @@ on: push: branches: - master +- '**' I totally see your point. I've reverted all changes to build.yml. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3769#discussion_r151

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-03-10 Thread Andy Alt via Github-comments
> > Adding ` workflow_dispatch:` might be a good idea to manually re-run the > > workflow. > > I would still recommend this simple change. > > And it seems the configuration still has syntax errors: > https://github.com/geany/geany/actions/runs/8135027731/workflow That seems outdated. I added

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-03-10 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. e5a73c9e3608ca7185c508fe8f0d1199a4a89078 Add CodeQL Analysis workflow -- View it on GitHub: https://github.com/geany/geany/pull/3769/files/629514d67d1ae515686473f36f9c16725cf771e2..e5a73c9e3608ca7185c508fe8f0d1199a4a89078 You are receiving this because you are subscri

[Github-comments] Re: [geany/geany] [Feature request] Zig Language Support (Issue #3724)

2024-03-10 Thread Andy Alt via Github-comments
@Ndashka-Dev Here is a filetypes def I've started (It only partially works) ``` # For complete documentation of this file, please see Geany's main documentation [styling=C] [keywords] # all items must be in one line primary=alignof as async await break const continue defer else enum errno export

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-03-03 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > @@ -8,6 +8,13 @@ on: push: branches: - master +- '**' So it won't run when other yml files are changed. Trivial in this case, but I figured you might want to add more path filters in the future: https://docs.github.com/en/actions/

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-03-03 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 629514d67d1ae515686473f36f9c16725cf771e2 Add CodeQL Analysis workflow -- View it on GitHub: https://github.com/geany/geany/pull/3769/files/d0ff4df5d1558ba4901c1dc53f864d25da96a1bf..629514d67d1ae515686473f36f9c16725cf771e2 You are receiving this because you are subscri

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-03-03 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. d0ff4df5d1558ba4901c1dc53f864d25da96a1bf Add CodeQL Analysis workflow -- View it on GitHub: https://github.com/geany/geany/pull/3769/files/2c58e9dcc9f9fc5250e57b1eb53d66a9cd393448..d0ff4df5d1558ba4901c1dc53f864d25da96a1bf You are receiving this because you are subscri

[Github-comments] Re: [geany/geany] Return NULL from document_get_current() if document is 'untitled' (PR #3770)

2024-02-20 Thread Andy Alt via Github-comments
@elextr explained this to me in detail at https://github.com/andy5995/pinner/commit/8151d8b0b16e4ff3e674d2ad7aaaf97c3b4179f6#commitcomment-138855981 I consider the matter resolved. :) Thank you @elextr -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/37

[Github-comments] Re: [geany/geany] Return NULL from document_get_current() if document is 'untitled' (PR #3770)

2024-02-20 Thread Andy Alt via Github-comments
There was a little more conversation about this in https://github.com/andy5995/pinner/commit/8151d8b0b16e4ff3e674d2ad7aaaf97c3b4179f6#commitcomment-138854459 I wanted to mention that if you think is_valid should be 0 when file_name == NULL, I'd redo this PR so that happens on https://github.com

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-20 Thread Andy Alt via Github-comments
> Yes, that was what I was asking, describing a feature as "I want it to work > like Vscode" is unhelpful if the reader doesn't use Vscode or that feature of > Vscode, whereas "I want it to do xyz when I click blah because I have found > it useful in Vscode" is of course fine. Sounds like we're

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-19 Thread Andy Alt via Github-comments
I forgot to mention, based on your feedback @elextr , I expanded the [README.md](https://github.com/andy5995/pinner/blob/trunk/README.md) with hopefully a better explanation of the goal of the plugin, and added a link to a demo video. -- Reply to this email directly or view it on GitHub: https

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-19 Thread Andy Alt via Github-comments
>write the documentation explaining what this plugin is supposed to do, sounds >like it does something different to what @eht16 understood "pin" to mean, and >I have always been confused about what it was meant to do. I'm happy to elaborate an idea or re-frame a goal if I haven't made myself cl

[Github-comments] [geany/geany] Return NULL from document_get_current() if document is 'untitled' (PR #3770)

2024-02-18 Thread Andy Alt via Github-comments
I ran into a little problem when testing my pinner plugin. When using document_get_current(), the 'file_name' member was NULL even if the value returned by document_get_current() was not NULL and 'is_valid' was 1. You can view, comment on, or merge this pull request online at: https://github.

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-02-18 Thread Andy Alt via Github-comments
> Sounds good. > > * For the next time, a description to describe what is the PR about and > more importantly why, is generally a good idea. Understood! > > * We could add `*.py` to the patterns and `python` to the matrix to also > cover the Python helper scripts in the repository. D

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-02-18 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 2c58e9dcc9f9fc5250e57b1eb53d66a9cd393448 strip comments, add workflow_patch trigger, enable python -- View it on GitHub: https://github.com/geany/geany/pull/3769/files/14ef5fe702b42309fcd9e0fd1088b28e871cb6c5..2c58e9dcc9f9fc5250e57b1eb53d66a9cd393448 You are receivin

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-18 Thread Andy Alt via Github-comments
I moved this to https://github.com/andy5995/pinner -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#issuecomment-1951367227 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-18 Thread Andy Alt via Github-comments
Closed #1308. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#event-11840560015 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-02-17 Thread Andy Alt via Github-comments
@rdipardo Thank you for the explanation. @elextr I sent you an invite to be a collaborator. Another thing CodeQL does is when a workflow is in place, it gives alerts for any problematic code that may be introduced in a pull request. -- Reply to this email directly or view it on GitHub: https:/

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-17 Thread Andy Alt via Github-comments
"Unpin Document" available by right-clicking ![image](https://github.com/geany/geany-plugins/assets/16764864/3172aa37-1828-4bfb-af66-0dc7d666b6b8) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#issuecomment-1950262978 You are receiving thi

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-17 Thread Andy Alt via Github-comments
@andy5995 pushed 2 commits. b3c3b671e74e406d95374ea0fbdd301430b1783c Add "unpin document" to right-click menu b58b98b4c8948e2d9d7081ddbcdfc0cae6a7a5b1 Add "Unpin" item to right-click popup menu -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/cd1f6876eb21e9943b097

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-17 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. cd1f6876eb21e9943b097f58d584aa9101cacb34 Implment keybindings and add README.md -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/7aa35e595b1cb1cfe69f291e6597eccc78a23fbb..cd1f6876eb21e9943b097f58d584aa9101cacb34 You are receiving this becau

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-02-17 Thread Andy Alt via Github-comments
I enabled the default scan from my repository settings. The only problems it found were related to Scintilla https://github.com/andy5995/geany/security/code-scanning -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3769#issuecomment-1950228067 You are re

[Github-comments] Re: [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-02-17 Thread Andy Alt via Github-comments
It doesn't run. The message is ``` github/codeql-action/init@v3, github/codeql-action/autobuild@v3, and github/codeql-action/analyze@v3 are not allowed to be used in geany/geany. Actions in this workflow must be: within a repository owned by geany or matching the following: actions/cache@v2, ac

[Github-comments] [geany/geany] Add CodeQL Analysis workflow (PR #3769)

2024-02-17 Thread Andy Alt via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3769 -- Commit Summary -- * Add CodeQL Analysis workflow -- File Changes -- A .github/workflows/codeql.yml (103) -- Patch Links -- https://github.com/geany/geany/pull/3769.patch https

[Github-comments] Re: [geany/geany-plugins] CI: Download, compile and use latest cppcheck version (PR #1310)

2024-02-17 Thread Andy Alt via Github-comments
Have you ever considered adding a [CodeQL check](https://github.com/github/codeql-action) here or on Geany itself? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1310#issuecomment-1950199930 You are receiving this because you are subscribed to t

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-17 Thread Andy Alt via Github-comments
Longer filenames are now handled better, and they're left-justified with a 10 pixel margin on both sides. ![image](https://github.com/geany/geany-plugins/assets/16764864/636cab6c-05d5-499b-915e-d3cf7b347215) @luigifab -- Reply to this email directly or view it on GitHub: https://github.com/ge

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-17 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 7aa35e595b1cb1cfe69f291e6597eccc78a23fbb Acommodate for long filenames by using an ellipse -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/e0d734c2d260f6d5634df335dff103be40afb2b0..7aa35e595b1cb1cfe69f291e6597eccc78a23fbb You are receivin

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-16 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. e0d734c2d260f6d5634df335dff103be40afb2b0 Don't use 'with_mnemonic' (fix missing underscores) -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/259571ebebba229bffdaea28aa09e07549cf72c5..e0d734c2d260f6d5634df335dff103be40afb2b0 You are receiv

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-16 Thread Andy Alt via Github-comments
![image](https://github.com/geany/geany-plugins/assets/16764864/5e46462a-ff14-4d2c-9d3e-4bb466616e8a) ![image](https://github.com/geany/geany-plugins/assets/16764864/8c8cce8a-6a4b-464a-8927-2c074c49ffb3) ![image](https://github.com/geany/geany-plugins/assets/16764864/54c46d41-29de-40e4-9eaf-7a29

[Github-comments] Re: [geany/geany-plugins] Pinned Tab (#839)

2024-02-16 Thread Andy Alt via Github-comments
@luigifab I'm working on a "Pinner" plugin in https://github.com/geany/geany-plugins/pull/1308 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/issues/839#issuecomment-1948522025 You are receiving this because you are subscribed to this thread. Messag

[Github-comments] Re: [geany/geany-plugins] Commander like file search on keyboard shortcut find file in projects (#953)

2024-02-16 Thread Andy Alt via Github-comments
This is different from the file search already available? https://github.com/geany/geany/discussions/3748 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/953#issuecomment-1948519400 You are receiving this because you are subscribed to this thread

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-16 Thread Andy Alt via Github-comments
Ready for review and testing -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#issuecomment-1948486163 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-16 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 259571ebebba229bffdaea28aa09e07549cf72c5 remove sanitize flag -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/a0f4bc8e37569afea0390306f79793099fc674a4..259571ebebba229bffdaea28aa09e07549cf72c5 You are receiving this because you are subscri

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-16 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > + +static gboolean pin_init(GeanyPlugin *plugin, gpointer pdata) +{ + GtkWidget *main_menu_item; + + struct pindata *container = init_pindata(); + container->plugin = plugin; + + // Create a new menu item and show it + mai

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-16 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 0c0a34fe8e14049b0210cf95a4bf7460dcfd610e Add credit for ChatGPT [skip ci] -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/295737b2721da29ee3f6586bba6a47216876a486..0c0a34fe8e14049b0210cf95a4bf7460dcfd610e You are receiving this because you

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-16 Thread Andy Alt via Github-comments
@andy5995 pushed 2 commits. 87b8b4e27b856d27296727c84bacb62c0c1ebf5b Add right-click menu/option to clear pinned list 295737b2721da29ee3f6586bba6a47216876a486 Conditionally add sanitize flag -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/5391654fb522550bfab02bbeb

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-16 Thread Andy Alt via Github-comments
@andy5995 pushed 3 commits. a1fe9573bb09b841a96e01354b65a71a10c31a20 fix double-free error when freeing list cf40001168fa9e3b9bae629edf72d6af9af04027 fix 'stack-use-after-return` in pin_cleanup 5391654fb522550bfab02bbebcfb7c6b3b01254f implement unpin, use hashtable instead of GSList -- Vie

[Github-comments] Re: [geany/geany-plugins] Feature remote debugger (PR #1162)

2024-02-15 Thread Andy Alt via Github-comments
> So anybody (other than @pascal-fb-martin :-) who is interested in this needs > to code review and test. @pascal-fb-martin I could test this but I think you'll need to rebase first. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1162#issuecom

[Github-comments] Re: [geany/geany-plugins] Make numbered bookmarks work with numlock on (#1093)

2024-02-15 Thread Andy Alt via Github-comments
I just tried this plugin and I have the same problem. I found the open issue. When I disable numlock the numbered bookmarks work. I have a Logitech K120 USB wired keyboard. Thank you for working on this @Davidy22 . Does this patch need further testing before it's merged? -- Reply to this emai

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-15 Thread Andy Alt via Github-comments
At this point, clicking on a document in the "Pinned" tab, will open (switch to) it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#issuecomment-1946417676 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-15 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. b8d66c4101dfb12d366beb30b4d1ebb2b551d0a5 Don't auto-switch to the "Pinned" tab -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/6a96d0c7f3932fd68bf281ff8b895126e66df719..b8d66c4101dfb12d366beb30b4d1ebb2b551d0a5 You are receiving this becaus

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-15 Thread Andy Alt via Github-comments
@andy5995 pushed 2 commits. 093184d081fdce62111d39cddc69fda07eb74088 Add UNpin function 6a96d0c7f3932fd68bf281ff8b895126e66df719 Make documents clickable and open them -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/9ff65479c9e788045fdf4dc7fde471be404253a3..6a96d0c

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-15 Thread Andy Alt via Github-comments
> I just found some old code and it seems I started with a similar approach > some time ago: https://gist.github.com/eht16/15afd001f238f77f100a43e4129b8d20 > Use what is helpful but with care 😄. I don't remember much its state except > that it was working to some extend but quite buggy and proba

[Github-comments] Re: [geany/geany] How to switch to a file that's already open in a Geany Project (Discussion #3748)

2024-02-15 Thread Andy Alt via Github-comments
@elextr I started working on it in https://github.com/geany/geany-plugins/pull/1308 AFAIK Geany won't override anything the plugin does. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3748#discussioncomment-8480283 You are receiving this because

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-15 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 9ff65479c9e788045fdf4dc7fde471be404253a3 Add UNpin function -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/afeeb5952c1f9a56aa15117c723ecebfe2c20ba1..9ff65479c9e788045fdf4dc7fde471be404253a3 You are receiving this because you are subscribe

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. afeeb5952c1f9a56aa15117c723ecebfe2c20ba1 Remove header, make all functions static -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/c1899e4369a9f5aea2266439e4355231640957b8..afeeb5952c1f9a56aa15117c723ecebfe2c20ba1 You are receiving this be

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
> One thing I'm not sure of yet is how to pass the the list to the cleanup > function so I can free it. I made the list global. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#issuecomment-1944274058 You are receiving this because you are

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. c1899e4369a9f5aea2266439e4355231640957b8 Make list global -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/73322e4a185e3e50bbd546e1bccbabc5080824e9..c1899e4369a9f5aea2266439e4355231640957b8 You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 73322e4a185e3e50bbd546e1bccbabc5080824e9 add header to Makefile.am -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/18b58b305ff01e989ca5322dbe12323fc44a7289..73322e4a185e3e50bbd546e1bccbabc5080824e9 You are receiving this because you are su

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > + +static gboolean pin_init(GeanyPlugin *plugin, gpointer pdata) +{ + GtkWidget *main_menu_item; + + struct pindata *container = init_pindata(); + container->plugin = plugin; + + // Create a new menu item and show it + mai

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 18b58b305ff01e989ca5322dbe12323fc44a7289 Add non-working popup menu and func to clear list -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/4bb86a95810c5da704794d924e11cfae11a44fef..18b58b305ff01e989ca5322dbe12323fc44a7289 You are receivin

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
Duplicate checking works now. Any feedback on how I'm implementing this so far? One thing I'm not sure of yet is how to pass the the list to the cleanup function so I can free it. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#issuecomment

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > + * + * + */ + +#include +#include + +static GtkWidget *pinned_view_vbox; +static gint page_number = 0; + +struct pindata { + GeanyPlugin *plugin; +GSList *list; +}; + +static struct pindata *init_pindata(void) Ok to use a function

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
@andy5995 pushed 4 commits. 50209670e24d25b8188f4d2aad5336749d72a7d0 Add Pinner plugin 5def3d767465a138aee70a8ce81787b8e83da130 Check for duplicates 3a293072756b34cee614c80ac329fd1e0bf2f3df check if doc eq NULL 4bb86a95810c5da704794d924e11cfae11a44fef use g_strdup instead of strlcpy, point be

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. c8dbb27032f54b13503594bbc4da240eca827e7c Check for duplicates -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/565320a5358b49939288035ad6566f05683f85e9..c8dbb27032f54b13503594bbc4da240eca827e7c You are receiving this because you are subscri

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > @@ -0,0 +1,25 @@ +include $(top_srcdir)/build/vars.build.mk + +plugin = pinner + +geanyplugins_LTLIBRARIES = pinner.la + +pinner_la_SOURCES = \ + pinner.c + +pinner_la_CPPFLAGS = $(AM_CPPFLAGS) \ +-

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
What I have so far works as expected. ![image](https://github.com/geany/geany-plugins/assets/16764864/08fb092b-8375-4231-ba4a-691b2f766b5d) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1308#issuecomment-1943634516 You are receiving this becau

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > + GeanyDocument *doc = document_get_current(); + + if (doc != NULL && pin_list == NULL) + { + GtkWidget *label = gtk_label_new_with_mnemonic(doc->file_name); + gtk_widget_show(label); + gtk_box_

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-14 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 565320a5358b49939288035ad6566f05683f85e9 Add Pinner plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/8431a100f118aacf438af159a4b822469534077f..565320a5358b49939288035ad6566f05683f85e9 You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-13 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 8431a100f118aacf438af159a4b822469534077f Add Pinner plugin -- View it on GitHub: https://github.com/geany/geany-plugins/pull/1308/files/3d954c351a0489fd7e45e82e168ba677e9b11d97..8431a100f118aacf438af159a4b822469534077f You are receiving this because you are subscribed

[Github-comments] Re: [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-13 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > + GeanyDocument *doc = document_get_current(); + + if (doc != NULL && pin_list == NULL) + { + GtkWidget *label = gtk_label_new_with_mnemonic(doc->file_name); + gtk_widget_show(label); + gtk_box_

[Github-comments] [geany/geany-plugins] Add Pinner plugin (PR #1308)

2024-02-13 Thread Andy Alt via Github-comments
>From what I can tell, as I'm just learning the Geany API and gtk3, I would >now need to 1. Create a linked list using GSList() to store each item that's pinned 2. Before pinning, check to see if document is already in the list 3. Other stuff after that. I'm a bit lost on how to pass some values

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-02-13 Thread Andy Alt via Github-comments
> @dolik-rce thanks, if only we got more reviews by third parties things would > proceed faster. I don't know how many people consult the wiki to find out > configurations etc. Given the number of projects where the _only_ docs are > the wiki I would have thought many dedicated open sourcers wou

[Github-comments] Re: [geany/geany] Add dependabot.yml (PR #3758)

2024-02-12 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. a5d9d5c351faf7350807094377f3d20e3014a7cd Add dependabot.yml -- View it on GitHub: https://github.com/geany/geany/pull/3758/files/65d60cf5dc62a0148b35e8afe01c71fd411c2815..a5d9d5c351faf7350807094377f3d20e3014a7cd You are receiving this because you are subscribed to thi

[Github-comments] Re: [geany/geany] Add dependabot.yml (PR #3758)

2024-02-12 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > @@ -0,0 +1,6 @@ +version: 2 +updates: Certainly! Done. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3758#discussion_r1486713585 You are receiving this because you are subscribed to this thread. Message I

[Github-comments] Re: [geany/geany] Add dependabot.yml (PR #3758)

2024-02-12 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 65d60cf5dc62a0148b35e8afe01c71fd411c2815 Add dependabot.yml -- View it on GitHub: https://github.com/geany/geany/pull/3758/files/588f70da75d7457c77bcc8b3e625220b79a06873..65d60cf5dc62a0148b35e8afe01c71fd411c2815 You are receiving this because you are subscribed to thi

[Github-comments] Re: [geany/geany] Add dependabot.yml (PR #3758)

2024-02-11 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 588f70da75d7457c77bcc8b3e625220b79a06873 Add dependabot.yml -- View it on GitHub: https://github.com/geany/geany/pull/3758/files/7fdf4ddb67766a6bedd1484fcc5193614acf8c6c..588f70da75d7457c77bcc8b3e625220b79a06873 You are receiving this because you are subscribed to thi

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-02-11 Thread Andy Alt via Github-comments
> See also the already filetype configuration for Docker and Docker-Compose > files in the wiki: https://wiki.geany.org/config/docker-compose. You don't want it included with the Geany distribution then? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/

[Github-comments] Re: [geany/geany] Add dependabot.yml (PR #3758)

2024-02-11 Thread Andy Alt via Github-comments
K, I removed the docker section. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3758#issuecomment-1937795058 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add dependabot.yml (PR #3758)

2024-02-09 Thread Andy Alt via Github-comments
> > when never major versions are released > > Are you saying Geany will never get another major version 😉 > Hehe, looks like I did bad typing again. ;) An example is [here where it was merged into the curl project](https://github.com/curl/curl/commit/bf7cd837a68452bef11d9b1a783f43d4128c4ad4)

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-02-09 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. 93f5698e7e559c19b02e9b7c8851441341eade37 Add Dockerfile filedef -- View it on GitHub: https://github.com/geany/geany/pull/3757/files/9d7ede11029ae7168538e2e70329db98a0cf689f..93f5698e7e559c19b02e9b7c8851441341eade37 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] Add dependabot.yml (PR #3758)

2024-02-09 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. fe457f3b2f72556b01a15e2b5006d8dbd4d79001 Add dependabot.yml -- View it on GitHub: https://github.com/geany/geany/pull/3758/files/4f4dfc2d829c04d537cf9d5e5ec9468dbf54608c..fe457f3b2f72556b01a15e2b5006d8dbd4d79001 You are receiving this because you are subscribed to thi

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

2024-02-09 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. aab90a0d052ced3c6e2775688c2dcaaa153ffd83 Start off with strings -- View it on GitHub: https://github.com/geany/geany/pull/3759/files/ad3e7753f9de9956e706aed00b784ee58e6bdff5..aab90a0d052ced3c6e2775688c2dcaaa153ffd83 You are receiving this because you are subscribed to

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

2024-02-09 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > runner = find_program('ctags/runner.sh') foreach t : ctags_tests - test('@0@'.format(t), runner, + test(join_paths(fs.parent(t), fs.name(t)), runner, @eli-schwartz Isn't there a proper way to convert a file object to a string in <=0.53?

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

2024-02-09 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > runner = find_program('ctags/runner.sh') foreach t : ctags_tests - test('@0@'.format(t), runner, + test(join_paths(fs.parent(t), fs.name(t)), runner, One other potentially noteworthy feature of 0.59 is that when using 'ninja uninstall`,

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

2024-02-09 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > runner = find_program('ctags/runner.sh') foreach t : ctags_tests - test('@0@'.format(t), runner, + test(join_paths(fs.parent(t), fs.name(t)), runner, The required meson version is 0.53 and this feature is not available until 0.59 Looks

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

2024-02-09 Thread Andy Alt via Github-comments
@andy5995 pushed 1 commit. ad3e7753f9de9956e706aed00b784ee58e6bdff5 Fix deprecation warning about str.format() during meson setup -- View it on GitHub: https://github.com/geany/geany/pull/3759/files/bfce17935451f8e2d95b0e8c02839351c4214375..ad3e7753f9de9956e706aed00b784ee58e6bdff5 You are rece

[Github-comments] Re: [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

2024-02-09 Thread Andy Alt via Github-comments
@andy5995 commented on this pull request. > @@ -355,7 +355,7 @@ ctags_tests = files([ runner = find_program('ctags/runner.sh') foreach t : ctags_tests - test('@0@'.format(t), runner, + test('@0@'.format(f[0][0]), runner, Oops, that's not right. Let me have a closer look at how t

[Github-comments] [geany/geany] Fix deprecation warning about str.format() during meson setup (PR #3759)

2024-02-09 Thread Andy Alt via Github-comments
Each object in the list is a file object, not a string: `ctags_tests = files([...` hence the message: "tests/meson.build:359: DEPRECATION: Project uses feature that was always broken, and is now deprecated since '1.3.0': str.format: Value other than strings, integers, bools, options, dictionari

[Github-comments] [geany/geany] Add dependabot.yml (PR #3758)

2024-02-09 Thread Andy Alt via Github-comments
This will cause dependabot to open PRs to bump any actions, such as "checkout" when never major versions are released. https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file You can view, comment on, or merge this pull requ

[Github-comments] Re: [geany/www.geany.org] home.html: Fix type and grammer (PR #49)

2024-02-09 Thread Andy Alt via Github-comments
Closed #49. -- Reply to this email directly or view it on GitHub: https://github.com/geany/www.geany.org/pull/49#event-11757693524 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany] Add Dockerfile filedef (PR #3757)

2024-02-09 Thread Andy Alt via Github-comments
https://github.com/dockersamples/genai-chatbot/blob/master/docker-bot/Dockerfile ![image](https://github.com/geany/geany/assets/16764864/bc0a2cb9-974d-4fee-b7e2-ad7bb8b22786) -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/pull/3757#issuecomment-1935857945 Y

[Github-comments] Re: [geany/geany] filetypes.Dockerfile.conf (Issue #3752)

2024-02-09 Thread Andy Alt via Github-comments
> Any other docker users want to comment (for example the one using docker to > build Geany for Windows [end subtle]). PR https://github.com/geany/geany/pull/3757 opened. @rcjsuen @alexr00 -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/issues/3752#issue

[Github-comments] [geany/geany] Add Dockerfile filedef (PR #3757)

2024-02-09 Thread Andy Alt via Github-comments
Per @elextr will require further discussion. Closes https://github.com/geany/geany/issues/3752 but You can view, comment on, or merge this pull request online at: https://github.com/geany/geany/pull/3757 -- Commit Summary -- * Add Dockerfile filedef -- File Changes -- A data/filedefs/

[Github-comments] [geany/www.geany.org] home.html: Fix type and grammer (PR #49)

2024-02-09 Thread Andy Alt via Github-comments
You can view, comment on, or merge this pull request online at: https://github.com/geany/www.geany.org/pull/49 -- Commit Summary -- * home.html: Fix type and grammer -- File Changes -- M geany/templates/home.html (2) -- Patch Links -- https://github.com/geany/www.geany.org/pull/49.p

[Github-comments] Re: [geany/geany] filetypes.Dockerfile.conf (Issue #3752)

2024-02-06 Thread Andy Alt via Github-comments
Thanks. I consulted [phind](https://www.phind.com/search?cache=m3jm69uiaqguzjakctnepwd9) to get it to work. You want a PR? ``` [styling=C] [keywords] primary= ADD ARG CMD COPY ENTRYPOINT ENV EXPOSE FROM HEALTHCHECK LABEL MAINTAINER ONBUILD RUN SHELL STOPSIGNAL USER VOLUME WORKDIR [lexer_proper

[Github-comments] Re: [geany/geany] filetypes.Dockerfile (Issue #3752)

2024-02-05 Thread Andy Alt via Github-comments
The format of the filenames... I've renamed it to `filetypes.Dockerfile.conf` and now it shows up under Document->filetype->Misc but there's no syntax highlighting when I'm viewing a Dockerfile. ``` [styling] # Default styles default=default comment=comment string=string number=number operator=o

[Github-comments] [geany/geany] filetypes.Dockerfile (Issue #3752)

2024-02-05 Thread Andy Alt via Github-comments
I'm trying to add a `Dockerfile` filetype (primarily so I can use Format->comment_lines in Geany). When I select Document->filetype, the Dockerfile type doesn't magically appear. Anyone around to give me clues? My custom filetype_extensions.conf ``` # Filetype extension configuration file for

[Github-comments] Re: [geany/geany] How to switch to a file that's already open in a Geany Project (Discussion #3748)

2024-02-05 Thread Andy Alt via Github-comments
> AFAIK all notebook tab manipulation is inside Geany. Does that mean a plugin involving tabs can't be done? -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany/discussions/3748#discussioncomment-8370072 You are receiving this because you are subscribed to this

[Github-comments] Re: [geany/geany] How to switch to a file that's already open in a Geany Project (Discussion #3748)

2024-02-05 Thread Andy Alt via Github-comments
@elextr So I can search through them if I need to work on patch that only involves 3 or 4 files. And because I usually have all the files associated with a project open. I don't create Geany project files for each patch. Is there a more efficient way for me to use Geany? -- Reply to this email

  1   2   3   4   >